External - Code Metrics - Inspection of "Merge pull request #22 from nextcloud/cleanup" - nextcloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0f1d39...28c19e )

by Joas

created 2017-04-12 08:51 UTC

External A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

81.25%

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	3
dl	0
loc	52
ccs	26
cts	32
cp	0.8125
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	prepareChunk()	4	1
C	initScanner()	24	8
A	shutdownScanner()	11	1

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;

class External extends \OCA\Files_Antivirus\Scanner {
	
	// Daemon/socket mode
	private $useSocket;
	
	public function __construct(AppConfig $config){
		$this->appConfig = $config;
		$this->useSocket = $this->appConfig->getAvMode() === 'socket';
	}
	
	public function initScanner(){
		parent::initScanner();
		
		if ($this->useSocket){
			$avSocket = $this->appConfig->getAvSocket();
			$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
			}
		} else {
			$avHost = $this->appConfig->getAvHost();
			$avPort = $this->appConfig->getAvPort();
			if (!($avHost && $avPort)) {
				throw new \RuntimeException('The clamav port and host are not configured.');
			}
			$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('The clamav module is not configured for daemon mode.');
			}
		}

		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}
	
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$response = fgets($this->getWriteHandle());
		\OC::$server->getLogger()->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		
		$this->status->parseResponse($response);
	}
	
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		use OCA\Files_Antivirus\AppConfig;
13
14		class External extends \OCA\Files_Antivirus\Scanner {
15
16		// Daemon/socket mode
17		private $useSocket;
18
19	2	public function __construct(AppConfig $config){
20	2	$this->appConfig = $config;
21	2	$this->useSocket = $this->appConfig->getAvMode() === 'socket';
22	2	}
23
24	2	public function initScanner(){
25	2	parent::initScanner();
26
27	2	if ($this->useSocket){
28		$avSocket = $this->appConfig->getAvSocket();
29		$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
30		if (!$this->getWriteHandle()) {
31		throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
32		}
33		} else {
34	2	$avHost = $this->appConfig->getAvHost();
35	2	$avPort = $this->appConfig->getAvPort();
36	2	if (!($avHost && $avPort)) {
37		throw new \RuntimeException('The clamav port and host are not configured.');
38		}
39	2	$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
40	2	if (!$this->getWriteHandle()) {
41		throw new \RuntimeException('The clamav module is not configured for daemon mode.');
42		}
43		}
44
45		// request scan from the daemon
46	2	@fwrite($this->getWriteHandle(), "nINSTREAM\n");
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
47	2	}
48
49	2	protected function shutdownScanner(){
50	2	@fwrite($this->getWriteHandle(), pack('N', 0));
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
51	2	$response = fgets($this->getWriteHandle());
52	2	\OC::$server->getLogger()->debug(
53	2	'Response :: ' . $response,
54	2	['app' => 'files_antivirus']
55		);
56	2	@fclose($this->getWriteHandle());
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
57
58	2	$this->status->parseResponse($response);
59	2	}
60
61	2	protected function prepareChunk($data){
62	2	$chunkLength = pack('N', strlen($data));
63	2	return $chunkLength . $data;
64		}
65		}
66

nextcloud / files_antivirus

Push — master ( 0f1d39...28c19e )

External A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like