Local::__construct() - Code Metrics - Inspection of "Use proper Backgroundjob DI" - nextcloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Roeland

created 2018-03-03 21:13 UTC

Local::__construct() A

↳ Parent: Local

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
rs	9.4285
cc	2
eloc	5
nc	2
nop	1
crap	2.0185

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCA\Files_Antivirus\Scanner;

class Local extends Scanner{
	
	/**
	 * @var string
	 */
	protected $avPath;
	
	/**
	 * STDIN and STDOUT descriptors
	 * @var array of resources
	 */
	private $pipes = [];
	
	/**
	 * Process handle
	 * @var resource
	 */
	private $process;
	
	public function __construct(AppConfig $config){
		$this->appConfig = $config;
		// get the path to the executable
		$this->avPath = escapeshellcmd($this->appConfig->getAvPath());

		// check that the executable is available
		if (!file_exists($this->avPath)) {
			throw new \RuntimeException('The antivirus executable could not be found at ' . $this->avPath);
		}
	}
	
	public function initScanner(){
		parent::initScanner();
		
		// using 2>&1 to grab the full command-line output.
		$cmd = $this->avPath . " " . $this->appConfig->getCmdline() ." - 2>&1";
		$descriptorSpec = array(
			0 => ["pipe","r"], // STDIN
			1 => ["pipe","w"]  // STDOUT
		);
		
		$this->process = proc_open($cmd, $descriptorSpec, $this->pipes);
		if (!is_resource($this->process)) {
			throw new \RuntimeException('Error starting process');
		}
		$this->writeHandle = $this->pipes[0];
	}
	
	protected function shutdownScanner(){
		@fclose($this->pipes[0]);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$output = stream_get_contents($this->pipes[1]);
		@fclose($this->pipes[1]);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		
		$result = proc_close($this->process);
		\OC::$server->getLogger()->debug(
			'Exit code :: ' . $result . ' Response :: ' . $output,
			['app' => 'files_antivirus']
		);
		$this->status->parseResponse($output, $result);
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		use OCA\Files_Antivirus\AppConfig;
13		use OCA\Files_Antivirus\Scanner;
14
15		class Local extends Scanner{
16
17		/**
18		* @var string
19		*/
20		protected $avPath;
21
22		/**
23		* STDIN and STDOUT descriptors
24		* @var array of resources
25		*/
26		private $pipes = [];
27
28		/**
29		* Process handle
30		* @var resource
31		*/
32		private $process;
33
34	2	public function __construct(AppConfig $config){
35	2	$this->appConfig = $config;
36		// get the path to the executable
37	2	$this->avPath = escapeshellcmd($this->appConfig->getAvPath());
38
39		// check that the executable is available
40	2	if (!file_exists($this->avPath)) {
41		throw new \RuntimeException('The antivirus executable could not be found at ' . $this->avPath);
42		}
43	2	}
44
45	2	public function initScanner(){
46	2	parent::initScanner();
47
48		// using 2>&1 to grab the full command-line output.
49	2	$cmd = $this->avPath . " " . $this->appConfig->getCmdline() ." - 2>&1";
50		$descriptorSpec = array(
51	2	0 => ["pipe","r"], // STDIN
52		1 => ["pipe","w"] // STDOUT
53		);
54
55	2	$this->process = proc_open($cmd, $descriptorSpec, $this->pipes);
56	2	if (!is_resource($this->process)) {
57		throw new \RuntimeException('Error starting process');
58		}
59	2	$this->writeHandle = $this->pipes[0];
60	2	}
61
62	2	protected function shutdownScanner(){
63	2	@fclose($this->pipes[0]);
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
64	2	$output = stream_get_contents($this->pipes[1]);
65	2	@fclose($this->pipes[1]);
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
66
67	2	$result = proc_close($this->process);
68	2	\OC::$server->getLogger()->debug(
69	2	'Exit code :: ' . $result . ' Response :: ' . $output,
70	2	['app' => 'files_antivirus']
71		);
72	2	$this->status->parseResponse($output, $result);
73	2	}
74		}
75

nextcloud / files_antivirus

Pull Request — master (#50)

Local::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like