BackgroundScanner::run() - Code Metrics - Inspection of "Merge pull request #145 from nextcloud/enh/always_..." - nextcloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c9e51e...cc5120 )

by Roeland

created 2020-05-18 10:47 UTC

BackgroundScanner::run() F

↳ Parent: BackgroundScanner

Complexity

Conditions	26
Paths	2969

Size

Total Lines

141

Duplication

Lines	102
Ratio	72.34 %

Code Coverage

Tests	0
CRAP Score	702

Importance

Changes

Metric	Value
dl	102
loc	141
ccs	0
cts	107
cp	0
rs	0
c	0
b	0
f	0
cc	26
nc	2969
nop	1
crap	702

How to fix Long Method Complexity

<?php
declare(strict_types=1);
/**
 * Copyright (c) 2012 Bart Visscher <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus\BackgroundJob;

use OC\BackgroundJob\TimedJob;
use OCA\Files_Antivirus\AppConfig;
use OCA\Files_Antivirus\ItemFactory;
use OCA\Files_Antivirus\Scanner\ScannerFactory;
use OCP\DB\QueryBuilder\IQueryBuilder;
use OCP\Files\File;
use OCP\Files\IMimeTypeLoader;
use OCP\IDBConnection;
use OCP\Files\IRootFolder;
use OCP\ILogger;
use OCP\IUser;
use OCP\IUserManager;

class BackgroundScanner extends TimedJob {
	/** @var IRootFolder */
	protected $rootFolder;

	/** @var ScannerFactory */
	private $scannerFactory;

	/** @var  AppConfig  */
	private $appConfig;

	/** @var ILogger */
	protected $logger;

	/** @var IUserManager */
	protected $userManager;

	/** @var IDBConnection */
	protected $db;

	/** @var IMimeTypeLoader */
	protected $mimeTypeLoader;

	/** @var ItemFactory */
	protected $itemFactory;
	/** @var bool */
	private $isCLI;

	public function __construct(ScannerFactory $scannerFactory,
								AppConfig $appConfig,
								IRootFolder $rootFolder,
								ILogger $logger,
								IUserManager $userManager,
								IDBConnection $db,
								IMimeTypeLoader $mimeTypeLoader,
								ItemFactory $itemFactory,
								bool $isCLI
	){
		$this->rootFolder = $rootFolder;
		$this->scannerFactory = $scannerFactory;
		$this->appConfig = $appConfig;
		$this->logger = $logger;
		$this->userManager = $userManager;
		$this->db = $db;
		$this->mimeTypeLoader = $mimeTypeLoader;
		$this->itemFactory = $itemFactory;
		$this->isCLI = $isCLI;

		// Run once per 15 minutes
		$this->setInterval(60 * 15);
	}

	/**
	 * Background scanner main job
	 */
	public function run($args): void {
		// locate files that are not checked yet
		try {
			$result = $this->getUnscannedFiles();
		} catch(\Exception $e) {
			$this->logger->logException($e);
			return;
		}

		$this->logger->debug('Start background scan');
		$batchSize = $this->getBatchSize();

		// Run for unscanned files
		$cnt = 0;
		while (($row = $result->fetch()) && $cnt < $batchSize) {

			try {
				$fileId = $row['fileid'];
				$users = $this->getUserWithAccessToStorage((int)$row['storage']);

				foreach ($users as $user) {
					/** @var IUser $owner */
					$owner = $this->userManager->get($user['user_id']);
					if (!$owner instanceof IUser){
if ($x instanceof DoesNotExist) {
    // Do something.
}
						continue;
					}

					$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
					$files = $userFolder->getById($fileId);

					if ($files === []) {
						continue;
					}

					$file = array_pop($files);
					if ($file instanceof File) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
						$this->scanOneFile($file);
					} else {
						$this->logger->error('Tried to scan non file');
					}

					// increased only for successfully scanned files
					$cnt++;
					break;
				}
			} catch (\Exception $e) {
				$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
			}
		}

		if ($cnt === $batchSize) {
			// we are done
			return;
		}

		// Run for updated files
		try {
			$result = $this->getToRescanFiles();
		} catch(\Exception $e) {
			$this->logger->logException($e);
			return;
		}

		while (($row = $result->fetch()) && $cnt < $batchSize) {

			try {
				$fileId = $row['fileid'];
				$users = $this->getUserWithAccessToStorage((int)$row['storage']);

				foreach ($users as $user) {
					/** @var IUser $owner */
					$owner = $this->userManager->get($user['user_id']);
					if (!$owner instanceof IUser){
if ($x instanceof DoesNotExist) {
    // Do something.
}
						continue;
					}

					$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
					$files = $userFolder->getById($fileId);

					if ($files === []) {
						continue;
					}

					$file = array_pop($files);
					if ($file instanceof File) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
						$this->scanOneFile($file);
					} else {
						$this->logger->error('Tried to scan non file');
					}

					// increased only for successfully scanned files
					$cnt++;
					break;
				}
			} catch (\Exception $e) {
				$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
			}
		}


		// Run for files that have been scanned in the past. Just start to rescan them as the virus definitaions might have been updated
		try {
			$result = $this->getOutdatedFiles();
		} catch(\Exception $e) {
			$this->logger->logException($e);
			return;
		}

		while (($row = $result->fetch()) && $cnt < $batchSize) {

			try {
				$fileId = $row['fileid'];
				$users = $this->getUserWithAccessToStorage((int)$row['storage']);

				foreach ($users as $user) {
					/** @var IUser $owner */
					$owner = $this->userManager->get($user['user_id']);
					if (!$owner instanceof IUser){
if ($x instanceof DoesNotExist) {
    // Do something.
}
						continue;
					}

					$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
					$files = $userFolder->getById($fileId);

					if ($files === []) {
						continue;
					}

					$file = array_pop($files);
					if ($file instanceof File) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
						$this->scanOneFile($file);
					} else {
						$this->logger->error('Tried to scan non file');
					}

					// increased only for successfully scanned files
					$cnt++;
					break;
				}
			} catch (\Exception $e) {
				$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
			}
		}
	}

	protected function getBatchSize(): int {
		$batchSize = 10;
		if ($this->isCLI) {
			$batchSize = 100;
		}

		$this->logger->debug('Batch size is: ' . $batchSize);

		return $batchSize;
	}

	protected function getSizeLimitExpression(IQueryBuilder $qb)  {
		$sizeLimit = (int)$this->appConfig->getAvMaxFileSize();
		if ( $sizeLimit === -1 ){
			$sizeLimitExpr = $qb->expr()->neq('fc.size', $qb->expr()->literal('0'));
		} else {
			$sizeLimitExpr = $qb->expr()->andX(
				$qb->expr()->neq('fc.size', $qb->expr()->literal('0')),
				$qb->expr()->lt('fc.size', $qb->createNamedParameter($sizeLimit))
			);
		}

		return $sizeLimitExpr;
	}

	protected function getUserWithAccessToStorage(int $storageId): array {
		$qb = $this->db->getQueryBuilder();

		$qb->select('user_id')
			->from('mounts')
			->where($qb->expr()->eq('storage_id', $qb->createNamedParameter($storageId)));

		$cursor = $qb->execute();
		$data = $cursor->fetchAll();
		$cursor->closeCursor();
		return $data;
	}

	protected function getUnscannedFiles() {
		$dirMimeTypeId = $this->mimeTypeLoader->getId('httpd/unix-directory');

		$qb1 = $this->db->getQueryBuilder();
		$qb1->select('fileid')
			->from('files_antivirus');

		$qb2 = $this->db->getQueryBuilder();
		$qb2->select('fileid', 'storage')
			->from('filecache', 'fc')
			->where($qb2->expr()->notIn('fileid', $qb2->createFunction($qb1->getSQL())))
			->andWhere($qb2->expr()->neq('mimetype', $qb2->expr()->literal($dirMimeTypeId)))
			->andWhere($qb2->expr()->like('path', $qb2->expr()->literal('files/%')))
			->andWhere($this->getSizeLimitExpression($qb2))
			->setMaxResults($this->getBatchSize() * 10);

		return $qb2->execute();
	}

	protected function getToRescanFiles() {
		$qb = $this->db->getQueryBuilder();
		$qb->select('fc.fileid', 'fc.storage')
			->from('filecache', 'fc')
			->join('fc', 'files_antivirus', 'fa', $qb->expr()->eq('fc.fileid', 'fa.fileid'))
			->andWhere($qb->expr()->lt('fa.check_time', 'fc.mtime'))
			->andWhere($this->getSizeLimitExpression($qb))
			->setMaxResults($this->getBatchSize() * 10);

		return $qb->execute();
	}

	protected function getOutdatedFiles() {
		$dirMimeTypeId = $this->mimeTypeLoader->getId('httpd/unix-directory');

		// We do not want to keep scanning the same files. So only scan them once per 28 days at most.
		$yesterday = time() - (28 * 24 * 60 * 60);

		$qb1 = $this->db->getQueryBuilder();
		$qb2 = $this->db->getQueryBuilder();

		$qb1->select('fileid')
			->from('files_antivirus')
			->andWhere($qb2->expr()->lt('check_time', $qb2->createNamedParameter($yesterday)))
			->orderBy('check_time', 'ASC');

		$qb2->select('fileid', 'storage')
			->from('filecache', 'fc')
			->where($qb2->expr()->in('fileid', $qb2->createFunction($qb1->getSQL())))
			->andWhere($qb2->expr()->neq('mimetype', $qb2->expr()->literal($dirMimeTypeId)))
			->andWhere($qb2->expr()->like('path', $qb2->expr()->literal('files/%')))
			->andWhere($this->getSizeLimitExpression($qb2))
			->setMaxResults($this->getBatchSize() * 10);

		$x = $qb2->getSQL();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		return $qb2->execute();
	}

	protected function scanOneFile(File $file): void {
		$this->logger->debug('Scanning file with fileid: ' . $file->getId());

		$item = $this->itemFactory->newItem($file, true);
		$scanner = $this->scannerFactory->getScanner();
		$status = $scanner->scan($item);
		$status->dispatch($item);
	}
}


Push — master ( c9e51e...cc5120 )

BackgroundScanner::run() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1		<?php
2		declare(strict_types=1);
3		/**
4		* Copyright (c) 2012 Bart Visscher <[email protected]>
5		* This file is licensed under the Affero General Public License version 3 or
6		* later.
7		* See the COPYING-README file.
8		*/
9
10		namespace OCA\Files_Antivirus\BackgroundJob;
11
12		use OC\BackgroundJob\TimedJob;
13		use OCA\Files_Antivirus\AppConfig;
14		use OCA\Files_Antivirus\ItemFactory;
15		use OCA\Files_Antivirus\Scanner\ScannerFactory;
16		use OCP\DB\QueryBuilder\IQueryBuilder;
17		use OCP\Files\File;
18		use OCP\Files\IMimeTypeLoader;
19		use OCP\IDBConnection;
20		use OCP\Files\IRootFolder;
21		use OCP\ILogger;
22		use OCP\IUser;
23		use OCP\IUserManager;
24
25		class BackgroundScanner extends TimedJob {
26		/** @var IRootFolder */
27		protected $rootFolder;
28
29		/** @var ScannerFactory */
30		private $scannerFactory;
31
32		/** @var AppConfig */
33		private $appConfig;
34
35		/** @var ILogger */
36		protected $logger;
37
38		/** @var IUserManager */
39		protected $userManager;
40
41		/** @var IDBConnection */
42		protected $db;
43
44		/** @var IMimeTypeLoader */
45		protected $mimeTypeLoader;
46
47		/** @var ItemFactory */
48		protected $itemFactory;
49		/** @var bool */
50		private $isCLI;
51
52		public function __construct(ScannerFactory $scannerFactory,
53		AppConfig $appConfig,
54		IRootFolder $rootFolder,
55		ILogger $logger,
56		IUserManager $userManager,
57		IDBConnection $db,
58		IMimeTypeLoader $mimeTypeLoader,
59		ItemFactory $itemFactory,
60		bool $isCLI
61		){
62		$this->rootFolder = $rootFolder;
63		$this->scannerFactory = $scannerFactory;
64		$this->appConfig = $appConfig;
65		$this->logger = $logger;
66		$this->userManager = $userManager;
67		$this->db = $db;
68		$this->mimeTypeLoader = $mimeTypeLoader;
69		$this->itemFactory = $itemFactory;
70		$this->isCLI = $isCLI;
71
72		// Run once per 15 minutes
73		$this->setInterval(60 * 15);
74		}
75
76		/**
77		* Background scanner main job
78		*/
79		public function run($args): void {
80		// locate files that are not checked yet
81		try {
82		$result = $this->getUnscannedFiles();
83		} catch(\Exception $e) {
84		$this->logger->logException($e);
85		return;
86		}
87
88		$this->logger->debug('Start background scan');
89		$batchSize = $this->getBatchSize();
90
91		// Run for unscanned files
92		$cnt = 0;
93	View Code Duplication	while (($row = $result->fetch()) && $cnt < $batchSize) {
		0 ignored issues – show Duplication introduced 2019-04-16 10:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		try {
95		$fileId = $row['fileid'];
96		$users = $this->getUserWithAccessToStorage((int)$row['storage']);
97
98		foreach ($users as $user) {
99		/** @var IUser $owner */
100		$owner = $this->userManager->get($user['user_id']);
101		if (!$owner instanceof IUser){
		0 ignored issues – show Bug introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report The class `OCP\IUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
102		continue;
103		}
104
105		$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
106		$files = $userFolder->getById($fileId);
107
108		if ($files === []) {
109		continue;
110		}
111
112		$file = array_pop($files);
113		if ($file instanceof File) {
		0 ignored issues – show Bug introduced 2019-04-16 10:19 UTC by Report Bug Copy Issue Report The class `OCP\Files\File` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
114		$this->scanOneFile($file);
115		} else {
116		$this->logger->error('Tried to scan non file');
117		}
118
119		// increased only for successfully scanned files
120		$cnt++;
121		break;
122		}
123		} catch (\Exception $e) {
124		$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
125		}
126		}
127
128		if ($cnt === $batchSize) {
129		// we are done
130		return;
131		}
132
133		// Run for updated files
134		try {
135		$result = $this->getToRescanFiles();
136		} catch(\Exception $e) {
137		$this->logger->logException($e);
138		return;
139		}
140
141	View Code Duplication	while (($row = $result->fetch()) && $cnt < $batchSize) {
		0 ignored issues – show Duplication introduced 2019-04-16 10:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142		try {
143		$fileId = $row['fileid'];
144		$users = $this->getUserWithAccessToStorage((int)$row['storage']);
145
146		foreach ($users as $user) {
147		/** @var IUser $owner */
148		$owner = $this->userManager->get($user['user_id']);
149		if (!$owner instanceof IUser){
		0 ignored issues – show Bug introduced 2019-04-16 10:19 UTC by Report Bug Copy Issue Report The class `OCP\IUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
150		continue;
151		}
152
153		$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
154		$files = $userFolder->getById($fileId);
155
156		if ($files === []) {
157		continue;
158		}
159
160		$file = array_pop($files);
161		if ($file instanceof File) {
		0 ignored issues – show Bug introduced 2019-04-16 10:19 UTC by Report Bug Copy Issue Report The class `OCP\Files\File` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
162		$this->scanOneFile($file);
163		} else {
164		$this->logger->error('Tried to scan non file');
165		}
166
167		// increased only for successfully scanned files
168		$cnt++;
169		break;
170		}
171		} catch (\Exception $e) {
172		$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
173		}
174		}
175
176
177		// Run for files that have been scanned in the past. Just start to rescan them as the virus definitaions might have been updated
178		try {
179		$result = $this->getOutdatedFiles();
180		} catch(\Exception $e) {
181		$this->logger->logException($e);
182		return;
183		}
184
185	View Code Duplication	while (($row = $result->fetch()) && $cnt < $batchSize) {
		0 ignored issues – show Duplication introduced 2020-03-18 19:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
186		try {
187		$fileId = $row['fileid'];
188		$users = $this->getUserWithAccessToStorage((int)$row['storage']);
189
190		foreach ($users as $user) {
191		/** @var IUser $owner */
192		$owner = $this->userManager->get($user['user_id']);
193		if (!$owner instanceof IUser){
		0 ignored issues – show Bug introduced 2020-03-18 19:03 UTC by Report Bug Copy Issue Report The class `OCP\IUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
194		continue;
195		}
196
197		$userFolder = $this->rootFolder->getUserFolder($owner->getUID());
198		$files = $userFolder->getById($fileId);
199
200		if ($files === []) {
201		continue;
202		}
203
204		$file = array_pop($files);
205		if ($file instanceof File) {
		0 ignored issues – show Bug introduced 2020-03-18 19:03 UTC by Report Bug Copy Issue Report The class `OCP\Files\File` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
206		$this->scanOneFile($file);
207		} else {
208		$this->logger->error('Tried to scan non file');
209		}
210
211		// increased only for successfully scanned files
212		$cnt++;
213		break;
214		}
215		} catch (\Exception $e) {
216		$this->logger->error( __METHOD__ . ', exception: ' . $e->getMessage(), ['app' => 'files_antivirus']);
217		}
218		}
219		}
220
221		protected function getBatchSize(): int {
222		$batchSize = 10;
223		if ($this->isCLI) {
224		$batchSize = 100;
225		}
226
227		$this->logger->debug('Batch size is: ' . $batchSize);
228
229		return $batchSize;
230		}
231
232		protected function getSizeLimitExpression(IQueryBuilder $qb) {
233		$sizeLimit = (int)$this->appConfig->getAvMaxFileSize();
234		if ( $sizeLimit === -1 ){
235		$sizeLimitExpr = $qb->expr()->neq('fc.size', $qb->expr()->literal('0'));
236		} else {
237		$sizeLimitExpr = $qb->expr()->andX(
238		$qb->expr()->neq('fc.size', $qb->expr()->literal('0')),
239		$qb->expr()->lt('fc.size', $qb->createNamedParameter($sizeLimit))
240		);
241		}
242
243		return $sizeLimitExpr;
244		}
245
246		protected function getUserWithAccessToStorage(int $storageId): array {
247		$qb = $this->db->getQueryBuilder();
248
249		$qb->select('user_id')
250		->from('mounts')
251		->where($qb->expr()->eq('storage_id', $qb->createNamedParameter($storageId)));
252
253		$cursor = $qb->execute();
254		$data = $cursor->fetchAll();
255		$cursor->closeCursor();
256		return $data;
257		}
258
259		protected function getUnscannedFiles() {
260		$dirMimeTypeId = $this->mimeTypeLoader->getId('httpd/unix-directory');
261
262		$qb1 = $this->db->getQueryBuilder();
263		$qb1->select('fileid')
264		->from('files_antivirus');
265
266		$qb2 = $this->db->getQueryBuilder();
267		$qb2->select('fileid', 'storage')
268		->from('filecache', 'fc')
269		->where($qb2->expr()->notIn('fileid', $qb2->createFunction($qb1->getSQL())))
270		->andWhere($qb2->expr()->neq('mimetype', $qb2->expr()->literal($dirMimeTypeId)))
271		->andWhere($qb2->expr()->like('path', $qb2->expr()->literal('files/%')))
272		->andWhere($this->getSizeLimitExpression($qb2))
273		->setMaxResults($this->getBatchSize() * 10);
274
275		return $qb2->execute();
276		}
277
278		protected function getToRescanFiles() {
279		$qb = $this->db->getQueryBuilder();
280		$qb->select('fc.fileid', 'fc.storage')
281		->from('filecache', 'fc')
282		->join('fc', 'files_antivirus', 'fa', $qb->expr()->eq('fc.fileid', 'fa.fileid'))
283		->andWhere($qb->expr()->lt('fa.check_time', 'fc.mtime'))
284		->andWhere($this->getSizeLimitExpression($qb))
285		->setMaxResults($this->getBatchSize() * 10);
286
287		return $qb->execute();
288		}
289
290		protected function getOutdatedFiles() {
291		$dirMimeTypeId = $this->mimeTypeLoader->getId('httpd/unix-directory');
292
293		// We do not want to keep scanning the same files. So only scan them once per 28 days at most.
294		$yesterday = time() - (28 * 24 * 60 * 60);
295
296		$qb1 = $this->db->getQueryBuilder();
297		$qb2 = $this->db->getQueryBuilder();
298
299		$qb1->select('fileid')
300		->from('files_antivirus')
301		->andWhere($qb2->expr()->lt('check_time', $qb2->createNamedParameter($yesterday)))
302		->orderBy('check_time', 'ASC');
303
304		$qb2->select('fileid', 'storage')
305		->from('filecache', 'fc')
306		->where($qb2->expr()->in('fileid', $qb2->createFunction($qb1->getSQL())))
307		->andWhere($qb2->expr()->neq('mimetype', $qb2->expr()->literal($dirMimeTypeId)))
308		->andWhere($qb2->expr()->like('path', $qb2->expr()->literal('files/%')))
309		->andWhere($this->getSizeLimitExpression($qb2))
310		->setMaxResults($this->getBatchSize() * 10);
311
312		$x = $qb2->getSQL();
		0 ignored issues – show Unused Code introduced 2020-05-14 12:59 UTC by Report Bug Copy Issue Report `$x` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
313
314		return $qb2->execute();
315		}
316
317		protected function scanOneFile(File $file): void {
318		$this->logger->debug('Scanning file with fileid: ' . $file->getId());
319
320		$item = $this->itemFactory->newItem($file, true);
321		$scanner = $this->scannerFactory->getScanner();
322		$status = $scanner->scan($item);
323		$status->dispatch($item);
324		}
325		}
326

nextcloud / files_antivirus

Push — master ( c9e51e...cc5120 )

BackgroundScanner::run() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like