Issues in ExceptionMiddleware.php (master) - Issues in master - nextcloud/deck - Measure and Improve Code Quality continuously with Scrutinizer

Issues (221)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Middleware/ExceptionMiddleware.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2016 Julius Härtl <[email protected]>
 *
 * @author Julius Härtl <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Deck\Middleware;

use OCA\Deck\Controller\PageController;
use OCA\Deck\StatusException;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Middleware;
use OCP\AppFramework\Http\JSONResponse;
use OCP\ILogger;
use OCP\Util;
use OCP\IConfig;


class ExceptionMiddleware extends Middleware {

	/** @var ILogger */
	private $logger;
	/** @var IConfig */
	private $config;

	/**
	 * SharingMiddleware constructor.
	 *
	 * @param ILogger $logger
	 * @param IConfig $config
	 */
	public function __construct(ILogger $logger, IConfig $config) {
		$this->logger = $logger;
		$this->config = $config;
	}

	/**
	 * Return JSON error response if the user has no sufficient permission
	 *
	 * @param \OCP\AppFramework\Controller $controller
	 * @param string $methodName
	 * @param \Exception $exception
	 * @return JSONResponse
	 * @throws \Exception
	 */
	public function afterException($controller, $methodName, \Exception $exception) {
		if ($exception instanceof StatusException) {
			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {

				$this->logger->logException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			}
			return new JSONResponse([
				'status' => $exception->getStatus(),
				'message' => $exception->getMessage()
			], $exception->getStatus());
		}

		if (strpos(get_class($controller), 'OCA\\Deck\\Controller\\') === 0) {
			$response = [
				'status' => 500,
				'message' => $exception->getMessage()
			];
			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {

				$this->logger->logException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			}
			if ($this->config->getSystemValue('debug', true) === true) {
				$response['exception'] = (array) $exception;
			}
			return new JSONResponse($response, 500);
		}

		// uncatched DoesNotExistExceptions will be thrown when the main entity is not found
		// we return a 403 so we don't leak information over existing entries
		// TODO: At some point those should properly be catched in the service classes
		if ($exception instanceof DoesNotExistException) {
			return new JSONResponse([
				'status' => 403,
				'message' => 'Permission denied'
			], 403);
		}

		throw $exception;
	}

}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016 Julius Härtl <[email protected]>
4			*
5			* @author Julius Härtl <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Deck\Middleware;
25
26			use OCA\Deck\Controller\PageController;
27			use OCA\Deck\StatusException;
28			use OCP\AppFramework\Db\DoesNotExistException;
29			use OCP\AppFramework\Middleware;
30			use OCP\AppFramework\Http\JSONResponse;
31			use OCP\ILogger;
32			use OCP\Util;
33			use OCP\IConfig;
34
35
36			class ExceptionMiddleware extends Middleware {
37
38			/** @var ILogger */
39			private $logger;
40			/** @var IConfig */
41			private $config;
42
43			/**
44			* SharingMiddleware constructor.
45			*
46			* @param ILogger $logger
47			* @param IConfig $config
48			*/
49			public function __construct(ILogger $logger, IConfig $config) {
50			$this->logger = $logger;
51			$this->config = $config;
52			}
53
54			/**
55			* Return JSON error response if the user has no sufficient permission
56			*
57			* @param \OCP\AppFramework\Controller $controller
58			* @param string $methodName
59			* @param \Exception $exception
60			* @return JSONResponse
61			* @throws \Exception
62			*/
63			public function afterException($controller, $methodName, \Exception $exception) {
64			if ($exception instanceof StatusException) {
65			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
			0 ignored issues – show Deprecated Code introduced 2018-09-24 01:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `OCP\Util::WARN` has been deprecated with message: 14.0.0 use \OCP\ILogger::WARN This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history... Deprecated Code introduced 2018-09-24 01:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `OCP\Util::DEBUG` has been deprecated with message: 14.0.0 use \OCP\ILogger::DEBUG This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history...
66			$this->logger->logException($exception);
			0 ignored issues – show Documentation introduced 2018-09-24 01:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$exception` is of type `object<OCA\Deck\StatusException>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			}
68			return new JSONResponse([
69			'status' => $exception->getStatus(),
70			'message' => $exception->getMessage()
71			], $exception->getStatus());
72			}
73
74			if (strpos(get_class($controller), 'OCA\\Deck\\Controller\\') === 0) {
75			$response = [
76			'status' => 500,
77			'message' => $exception->getMessage()
78			];
79			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
			0 ignored issues – show Deprecated Code introduced 2019-03-05 18:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `OCP\Util::WARN` has been deprecated with message: 14.0.0 use \OCP\ILogger::WARN This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history... Deprecated Code introduced 2019-03-05 18:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `OCP\Util::DEBUG` has been deprecated with message: 14.0.0 use \OCP\ILogger::DEBUG This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history...
80			$this->logger->logException($exception);
			0 ignored issues – show Documentation introduced 2019-03-05 18:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$exception` is of type `object<Exception>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			}
82			if ($this->config->getSystemValue('debug', true) === true) {
83			$response['exception'] = (array) $exception;
84			}
85			return new JSONResponse($response, 500);
86			}
87
88			// uncatched DoesNotExistExceptions will be thrown when the main entity is not found
89			// we return a 403 so we don't leak information over existing entries
90			// TODO: At some point those should properly be catched in the service classes
91			if ($exception instanceof DoesNotExistException) {
92			return new JSONResponse([
93			'status' => 403,
94			'message' => 'Permission denied'
95			], 403);
96			}
97
98			throw $exception;
99			}
100
101			}
102

nextcloud / deck

Issues (221)

Security Analysis no request data

lib/Middleware/ExceptionMiddleware.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like