Issues in ConfigController.php (master) - Issues in master - nextcloud/deck - Measure and Improve Code Quality continuously with Scrutinizer

Issues (221)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Controller/ConfigController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2018 Julius Härtl <[email protected]>
 *
 * @author Julius Härtl <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Deck\Controller;

use OCA\Deck\Service\DefaultBoardService;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Http\NotFoundResponse;
use OCP\IConfig;
use OCP\IGroup;
use OCP\IGroupManager;
use OCP\IRequest;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Controller;
use OCP\IL10N;

class ConfigController extends Controller {

	private $config;
	private $userId;
	private $groupManager;

	public function __construct(
		$AppName,
		IRequest $request,
		IConfig $config,
		IGroupManager $groupManager,
		$userId
		) {
		parent::__construct($AppName, $request);

		$this->userId = $userId;
		$this->groupManager = $groupManager;
		$this->config = $config;
	}

	/**
	 * @NoCSRFRequired
	 */
	public function get() {
		$data = [
			'groupLimit' => $this->getGroupLimit(),
		];
		return new DataResponse($data);
	}

	/**
	 * @NoCSRFRequired
	 */
	public function setValue($key, $value) {
		switch ($key) {
			case 'groupLimit':
				$result = $this->setGroupLimit($value);
				break;
		}
		if ($result === null) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			return new NotFoundResponse();
		}
		return new DataResponse($result);
	}

	private function setGroupLimit($value) {
		$groups = [];
		foreach ($value as $group) {
			$groups[] = $group['id'];
		}
		$data = implode(',', $groups);
		$this->config->setAppValue($this->appName, 'groupLimit', $data);
		return $groups;
	}

	private function getGroupLimitList() {

		$value = $this->config->getAppValue($this->appName, 'groupLimit', '');
		$groups = explode(',', $value);
		if ($value === '') {
			return [];
		}
		return $groups;
	}

	private function getGroupLimit() {
		$groups = $this->getGroupLimitList();
		$groups = array_map(function($groupId) {
			/** @var IGroup $groups */
			$group = $this->groupManager->get($groupId);
			if ($group === null) {
				return null;
			}
			return [
				'id' => $group->getGID(),
				'displayname' => $group->getDisplayName(),
			];
		}, $groups);
		return array_filter($groups);
	}

}


1		<?php
2		/**
3		* @copyright Copyright (c) 2018 Julius Härtl <[email protected]>
4		*
5		* @author Julius Härtl <[email protected]>
6		*
7		* @license GNU AGPL version 3 or any later version
8		*
9		* This program is free software: you can redistribute it and/or modify
10		* it under the terms of the GNU Affero General Public License as
11		* published by the Free Software Foundation, either version 3 of the
12		* License, or (at your option) any later version.
13		*
14		* This program is distributed in the hope that it will be useful,
15		* but WITHOUT ANY WARRANTY; without even the implied warranty of
16		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17		* GNU Affero General Public License for more details.
18		*
19		* You should have received a copy of the GNU Affero General Public License
20		* along with this program. If not, see <http://www.gnu.org/licenses/>.
21		*
22		*/
23
24		namespace OCA\Deck\Controller;
25
26		use OCA\Deck\Service\DefaultBoardService;
27		use OCP\AppFramework\Http\DataResponse;
28		use OCP\AppFramework\Http\NotFoundResponse;
29		use OCP\IConfig;
30		use OCP\IGroup;
31		use OCP\IGroupManager;
32		use OCP\IRequest;
33		use OCP\AppFramework\Http\TemplateResponse;
34		use OCP\AppFramework\Controller;
35		use OCP\IL10N;
36
37		class ConfigController extends Controller {
38
39		private $config;
40		private $userId;
41		private $groupManager;
42
43		public function __construct(
44		$AppName,
45		IRequest $request,
46		IConfig $config,
47		IGroupManager $groupManager,
48		$userId
49		) {
50		parent::__construct($AppName, $request);
51
52		$this->userId = $userId;
53		$this->groupManager = $groupManager;
54		$this->config = $config;
55		}
56
57		/**
58		* @NoCSRFRequired
59		*/
60		public function get() {
61		$data = [
62		'groupLimit' => $this->getGroupLimit(),
63		];
64		return new DataResponse($data);
65		}
66
67		/**
68		* @NoCSRFRequired
69		*/
70		public function setValue($key, $value) {
71		switch ($key) {
72		case 'groupLimit':
73		$result = $this->setGroupLimit($value);
74		break;
75		}
76		if ($result === null) {
		0 ignored issues – show Bug introduced 2018-12-04 08:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
77		return new NotFoundResponse();
78		}
79		return new DataResponse($result);
80		}
81
82		private function setGroupLimit($value) {
83		$groups = [];
84		foreach ($value as $group) {
85		$groups[] = $group['id'];
86		}
87		$data = implode(',', $groups);
88		$this->config->setAppValue($this->appName, 'groupLimit', $data);
89		return $groups;
90		}
91
92	View Code Duplication	private function getGroupLimitList() {
		0 ignored issues – show Duplication introduced 2018-12-04 08:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		$value = $this->config->getAppValue($this->appName, 'groupLimit', '');
94		$groups = explode(',', $value);
95		if ($value === '') {
96		return [];
97		}
98		return $groups;
99		}
100
101		private function getGroupLimit() {
102		$groups = $this->getGroupLimitList();
103		$groups = array_map(function($groupId) {
104		/** @var IGroup $groups */
105		$group = $this->groupManager->get($groupId);
106		if ($group === null) {
107		return null;
108		}
109		return [
110		'id' => $group->getGID(),
111		'displayname' => $group->getDisplayName(),
112		];
113		}, $groups);
114		return array_filter($groups);
115		}
116
117		}
118

nextcloud / deck

Issues (221)

Security Analysis no request data

lib/Controller/ConfigController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like