nextcloud / deck

lib/Db/LabelMapper.php

Doc Comments +6 added lines

@@ -66,6 +66,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param integer $labelId
+	 */
 	public function deleteLabelAssignments($labelId) {
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE label_id = ?';
 		$stmt = $this->db->prepare($sql);
@@ -73,6 +76,9 @@ 
 		$stmt->execute();
 	}
 
+	/**
+	 * @param integer $cardId
+	 */
 	public function deleteLabelAssignmentsForCard($cardId) {
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE card_id = ?';
 		$stmt = $this->db->prepare($sql);

lib/Activity/ActivityManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	}
 
 	/**
-	 * @param $subjectIdentifier
+	 * @param string $subjectIdentifier
 	 * @param array $subjectParams
 	 * @param bool $ownActivity
 	 * @return string

Spacing +8 added lines, -8 removed lines

@@ -133,7 +133,7 @@ 
 		$subject = '';
 		switch ($subjectIdentifier) {
 			case self::SUBJECT_BOARD_CREATE:
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
 				break;
 			case self::SUBJECT_BOARD_DELETE:
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -302,10 +302,10 @@ 
 		try {
 			$object = $this->findObjectForEntity($objectType, $entity);
 		} catch (DoesNotExistException $e) {
-			\OC::$server->getLogger()->error('Could not create activity entry for ' . $subject . '. Entity not found.', (array)$entity);
+			\OC::$server->getLogger()->error('Could not create activity entry for ' . $subject . '. Entity not found.', (array) $entity);
 			return null;
 		} catch (MultipleObjectsReturnedException $e) {
-			\OC::$server->getLogger()->error('Could not create activity entry for ' . $subject . '. Entity not found.', (array)$entity);
+			\OC::$server->getLogger()->error('Could not create activity entry for ' . $subject . '. Entity not found.', (array) $entity);
 			return null;
 		}
 
@@ -375,7 +375,7 @@ 
 				break;
 		}
 
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
 			$card = $subjectParams['card'];
 			if ($card->getLastEditor() === $this->userId) {
 				return null;
@@ -394,7 +394,7 @@ 
 		$event->setApp('deck')
 			->setType($eventType)
 			->setAuthor($author === null ? $this->userId : $author)
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
 			->setTimestamp(time());
 
@@ -455,7 +455,7 @@ 
 					$objectId = $entity->getObjectId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->cardMapper->find($objectId);
 		}
@@ -470,11 +470,11 @@ 
 					$objectId = $entity->getBoardId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->boardMapper->find($objectId);
 		}
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 	}
 
 	private function findDetailsForStack($stackId) {

lib/Service/CardService.php

Spacing +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
 		$card->setLabels($this->labelMapper->findAssignedLabelsForCard($cardId));
 		$card->setAttachmentCount($this->attachmentService->count($cardId));
 		$user = $this->userManager->get($this->currentUser);
-		$lastRead = $this->commentsManager->getReadMark('deckCard', (string)$card->getId(), $user);
-		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string)$card->getId(), $lastRead);
+		$lastRead = $this->commentsManager->getReadMark('deckCard', (string) $card->getId(), $user);
+		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string) $card->getId(), $lastRead);
 		$card->setCommentsUnread($count);
 	}
 

Doc Comments +2 added lines, -2 removed lines

@@ -147,7 +147,7 @@ 
 	/**
 	 * @param $title
 	 * @param $stackId
-	 * @param $type
+	 * @param string $type
 	 * @param integer $order
 	 * @param $description
 	 * @param $owner
@@ -576,7 +576,7 @@ 
 	/**
 	 * @param $cardId
 	 * @param $userId
-	 * @return bool|null|\OCP\AppFramework\Db\Entity
+	 * @return AssignedUsers|null
 	 * @throws BadRequestException
 	 * @throws \OCA\Deck\NoPermissionException
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException

lib/Db/ChangeHelper.php

Unused Use Statements -4 removed lines

@@ -23,13 +23,9 @@
 
 namespace OCA\Deck\Db;
 
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\ICache;
 use OCP\ICacheFactory;
 use OCP\IDBConnection;
 use OCP\IRequest;
-use OCP\IUserManager;
-use OCP\IGroupManager;
 
 class ChangeHelper {
 

Spacing +3 added lines, -3 removed lines

@@ -61,7 +61,7 @@ 
 	public function cardChanged($cardId, $updateCard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$cardId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $cardId, $etag);
 		if ($updateCard) {
 			$sql = 'UPDATE `*PREFIX*deck_cards` SET `last_modified` = ?, `last_editor` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $this->userId, $cardId]);
@@ -78,7 +78,7 @@ 
 	public function stackChanged($stackId, $updateBoard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$stackId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $stackId, $etag);
 		if ($updateBoard) {
 			$sql = 'UPDATE `*PREFIX*deck_stacks` SET `last_modified` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $stackId]);
@@ -94,7 +94,7 @@ 
 	}
 
 	public function getEtag($type, $id) {
-		$entry = $this->cache->get($type . '-' .$id);
+		$entry = $this->cache->get($type . '-' . $id);
 		if ($entry === 'null') {
 			return '';
 		}

lib/Controller/AttachmentApiController.php

Indentation +34 added lines, -34 removed lines

@@ -31,76 +31,76 @@
 
 class AttachmentApiController extends ApiController {
 
-    private $attachmentService;
+	private $attachmentService;
 
-    public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
-        parent::__construct($appName, $request);
-        $this->attachmentService = $attachmentService;
-    }
+	public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
+		parent::__construct($appName, $request);
+		$this->attachmentService = $attachmentService;
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function getAll() {
-        $attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function getAll() {
+		$attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function display() {
-        $attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+	public function display() {
+		$attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
 		return $attachment;
-    }
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function create($type, $data) {
-        $attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function create($type, $data) {
+		$attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function update($data) {
-        $attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function update($data) {
+		$attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function delete() {
-        $attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function delete() {
+		$attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function restore() {
-        $attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function restore() {
+		$attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 }
\ No newline at end of file

lib/Controller/ConfigController.php

Unused Use Statements -3 removed lines

@@ -23,16 +23,13 @@
 
 namespace OCA\Deck\Controller;
 
-use OCA\Deck\Service\DefaultBoardService;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\IConfig;
 use OCP\IGroup;
 use OCP\IGroupManager;
 use OCP\IRequest;
-use OCP\AppFramework\Http\TemplateResponse;
 use OCP\AppFramework\Controller;
-use OCP\IL10N;
 
 class ConfigController extends Controller {
 

lib/Controller/PageController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	public function index() {
 		$params = [
 			'user' => $this->userId,
-			'maxUploadSize' => (int)\OCP\Util::uploadLimit(),
+			'maxUploadSize' => (int) \OCP\Util::uploadLimit(),
 			'canCreate' => $this->permissionService->canCreate()
 		];
 

lib/Activity/DeckProvider.php

Doc Comments +14 added lines

@@ -189,6 +189,9 @@ 
 		return $event;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForBoard($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -200,6 +203,10 @@ 
 		}
 		return $params;
 	}
+
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForStack($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -211,6 +218,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForAttachment($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -285,6 +295,7 @@ 
 	 *
 	 * @param $subjectParams
 	 * @param $params
+	 * @param IEvent $event
 	 * @return mixed
 	 */
 	private function parseParamForChanges($subjectParams, $params, $event) {
@@ -312,6 +323,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $endpoint
+	 */
 	public function deckUrl($endpoint) {
 		return $this->urlGenerator->linkToRouteAbsolute('deck.page.index') . '#!' . $endpoint;
 	}

Spacing +2 added lines, -2 removed lines

@@ -281,9 +281,9 @@
 		if (array_key_exists('comment', $subjectParams)) {
 			/** @var IComment $comment */
 			try {
-				$comment = $this->commentsManager->get((int)$subjectParams['comment']);
+				$comment = $this->commentsManager->get((int) $subjectParams['comment']);
 				$event->setParsedMessage($comment->getMessage());
-				$params['comment'] =[
+				$params['comment'] = [
 					'type' => 'highlight',
 					'id' => $subjectParams['comment'],
 					'name' => $comment->getMessage()

lib/Cron/CardDescriptionActivity.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 	private $cardMapper;
 
 	public function __construct(ActivityManager $activityManager, CardMapper $cardMapper) {
-		$this->activityManager  = $activityManager;
+		$this->activityManager = $activityManager;
 		$this->cardMapper = $cardMapper;
 	}