nextcloud / deck

lib/Db/AclMapper.php

Doc Comments +3 added lines

@@ -48,6 +48,9 @@
 		return $entity->getBoardId();
 	}
 
+	/**
+	 * @param string $participant
+	 */
 	public function findByParticipant($type, $participant) {
 		$sql = 'SELECT * from *PREFIX*deck_board_acl WHERE type = ? AND participant = ?';
 		return $this->findEntities($sql, [$type, $participant]);

lib/Service/StackService.php

Unused Use Statements -1 removed lines

@@ -34,7 +34,6 @@
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 use OCA\Deck\BadRequestException;
-use OCP\Comments\ICommentsManager;
 
 
 class StackService {

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 	private function enrichStackWithCards($stack, $since = -1) {
 		$cards = $this->cardMapper->findAll($stack->getId(), null, null, $since);
 
-		if(\count($cards) === 0) {
+		if (\count($cards) === 0) {
 			return;
 		}
 
@@ -216,7 +216,7 @@ 
 	 */
 	public function delete($id) {
 
-		if ( is_numeric($id) === false ) {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('stack id must be a number');
 		}
 

lib/AppInfo/Application.php

Spacing +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
 	}
 
 	protected function registerCommentsEventHandler() {
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
 			return $this->getContainer()->query(CommentEventHandler::class);
 		});
 	}

lib/Activity/ActivityManager.php

Spacing +6 added lines, -6 removed lines

@@ -133,7 +133,7 @@ 
 		$subject = '';
 		switch ($subjectIdentifier) {
 			case self::SUBJECT_BOARD_CREATE:
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
 				break;
 			case self::SUBJECT_BOARD_DELETE:
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -368,7 +368,7 @@ 
 				break;
 		}
 
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
 			$subjectParams['diff'] = true;
 		}
 		if ($subject === self::SUBJECT_CARD_UPDATE_STACKID) {
@@ -379,7 +379,7 @@ 
 		$event->setApp('deck')
 			->setType('deck')
 			->setAuthor($this->userId)
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
 			->setTimestamp(time());
 
@@ -440,7 +440,7 @@ 
 					$objectId = $entity->getObjectId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->cardMapper->find($objectId);
 		}
@@ -455,11 +455,11 @@ 
 					$objectId = $entity->getBoardId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->boardMapper->find($objectId);
 		}
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 	}
 
 	private function findDetailsForStack($stackId) {

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	}
 
 	/**
-	 * @param $subjectIdentifier
+	 * @param string $subjectIdentifier
 	 * @param array $subjectParams
 	 * @param bool $ownActivity
 	 * @return string

lib/Activity/CommentEventHandler.php

Spacing +3 added lines, -3 removed lines

@@ -43,12 +43,12 @@ 
 	 * @param CommentsEvent $event
 	 */
 	public function handle(CommentsEvent $event) {
-		if($event->getComment()->getObjectType() !== 'deckCard') {
+		if ($event->getComment()->getObjectType() !== 'deckCard') {
 			return;
 		}
 
 		$eventType = $event->getEvent();
-		if( $eventType === CommentsEvent::EVENT_ADD
+		if ($eventType === CommentsEvent::EVENT_ADD
 		) {
 			$this->notificationHandler($event);
 			$this->activityHandler($event);
@@ -60,7 +60,7 @@ 
 			CommentsEvent::EVENT_UPDATE,
 			CommentsEvent::EVENT_DELETE,
 		];
-		if(in_array($eventType, $applicableEvents)) {
+		if (in_array($eventType, $applicableEvents)) {
 			$this->notificationHandler($event);
 			return;
 		}

lib/Service/CardService.php

Spacing +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
 		$card->setLabels($this->labelMapper->findAssignedLabelsForCard($cardId));
 		$card->setAttachmentCount($this->attachmentService->count($cardId));
 		$user = $this->userManager->get($this->currentUser);
-		$lastRead = $this->commentsManager->getReadMark('deckCard', (string)$card->getId(), $user);
-		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string)$card->getId(), $lastRead);
+		$lastRead = $this->commentsManager->getReadMark('deckCard', (string) $card->getId(), $user);
+		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string) $card->getId(), $lastRead);
 		$card->setCommentsUnread($count);
 	}
 

lib/Service/BoardService.php

Doc Comments +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
 	}
 
 	/**
-	 * @return array
+	 * @return integer
 	 */
 	private function getBoardPrerequisites() {
 		$groups = $this->groupManager->getUserGroupIds(

Spacing +6 added lines, -6 removed lines

@@ -91,7 +91,7 @@ 
 	public function findAll($since = -1) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
 		$complete = array_merge($userBoards, $groupBoards);
 		$result = [];
 		foreach ($complete as &$item) {
@@ -125,7 +125,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -174,7 +174,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -208,7 +208,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -339,7 +339,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -373,7 +373,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 

lib/Db/ChangeHelper.php

Unused Use Statements -4 removed lines

@@ -23,13 +23,9 @@
 
 namespace OCA\Deck\Db;
 
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\ICache;
 use OCP\ICacheFactory;
 use OCP\IDBConnection;
 use OCP\IRequest;
-use OCP\IUserManager;
-use OCP\IGroupManager;
 
 class ChangeHelper {
 

Spacing +3 added lines, -3 removed lines

@@ -59,7 +59,7 @@ 
 	public function cardChanged($cardId, $updateCard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$cardId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $cardId, $etag);
 		if ($updateCard) {
 			$sql = 'UPDATE `*PREFIX*deck_cards` SET `last_modified` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $cardId]);
@@ -76,7 +76,7 @@ 
 	public function stackChanged($stackId, $updateBoard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$stackId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $stackId, $etag);
 		if ($updateBoard) {
 			$sql = 'UPDATE `*PREFIX*deck_stacks` SET `last_modified` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $stackId]);
@@ -92,7 +92,7 @@ 
 	}
 
 	public function getEtag($type, $id) {
-		$entry = $this->cache->get($type . '-' .$id);
+		$entry = $this->cache->get($type . '-' . $id);
 		if ($entry === 'null') {
 			return '';
 		}

lib/Controller/AttachmentApiController.php

Indentation +34 added lines, -34 removed lines

@@ -31,76 +31,76 @@
 
 class AttachmentApiController extends ApiController {
 
-    private $attachmentService;
+	private $attachmentService;
 
-    public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
-        parent::__construct($appName, $request);
-        $this->attachmentService = $attachmentService;
-    }
+	public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
+		parent::__construct($appName, $request);
+		$this->attachmentService = $attachmentService;
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function getAll() {
-        $attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function getAll() {
+		$attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function display() {
-        $attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+	public function display() {
+		$attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
 		return $attachment;
-    }
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function create($type, $data) {
-        $attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function create($type, $data) {
+		$attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function update($data) {
-        $attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function update($data) {
+		$attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function delete() {
-        $attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function delete() {
+		$attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function restore() {
-        $attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function restore() {
+		$attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 }
\ No newline at end of file