nextcloud / deck

lib/Controller/BoardApiController.php

Unused Use Statements -2 removed lines

@@ -26,10 +26,8 @@
 
 use OCA\Deck\StatusException;
 use OCP\AppFramework\ApiController;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\IRequest;
-
 use OCA\Deck\Service\BoardService;
 use Sabre\HTTP\Util;
 

lib/Notification/NotificationHelper.php

Doc Comments +6 added lines

@@ -95,6 +95,9 @@ 
 		$this->cardMapper->markNotified($card);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function markDuedateAsRead($card) {
 		$notification = $this->notificationManager->createNotification();
 		$notification
@@ -104,6 +107,9 @@ 
 		$this->notificationManager->markProcessed($notification);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function sendCardAssigned($card, $userId) {
 		$boardId = $this->cardMapper->findBoardId($card->getId());
 		$board = $this->getBoard($boardId);

lib/Provider/DeckProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 	 * DeckProvider constructor.
 	 *
 	 * @param IL10N $l10n
-	 * @param IUrlGenerator $urlGenerator
+	 * @param IURLGenerator $urlGenerator
 	 * @param FullTextSearchService $fullTextSearchService
 	 */
 	public function __construct(

Spacing +1 added lines, -1 removed lines

@@ -240,7 +240,7 @@
 		foreach ($searchResult->getDocuments() as $document) {
 			try {
 				$board =
-					$this->fullTextSearchService->getBoardFromCardId((int)$document->getId());
+					$this->fullTextSearchService->getBoardFromCardId((int) $document->getId());
 				$path = '#!/board/' . $board->getId() . '//card/' . $document->getId();
 				$document->setLink($this->urlGenerator->linkToRoute('deck.page.index') . $path);
 			} catch (DoesNotExistException $e) {

Unused Use Statements -1 removed lines

@@ -44,7 +44,6 @@
 use OCP\FullTextSearch\Model\ISearchResult;
 use OCP\FullTextSearch\Model\ISearchTemplate;
 use OCP\IL10N;
-use OCP\IURLGenerator;
 
 
 /**

lib/Service/LabelService.php

Spacing +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
 
 		$boardLabels = $this->labelMapper->findAll($boardId);
 		if (\is_array($boardLabels)) {
-			foreach($boardLabels as $boardLabel) {
+			foreach ($boardLabels as $boardLabel) {
 				if ($boardLabel->getTitle() === $title) {
 					throw new BadRequestException('title must be unique');
 					break;
@@ -168,7 +168,7 @@ 
 
 		$boardLabels = $this->labelMapper->findAll($label->getBoardId());
 		if (\is_array($boardLabels)) {
-			foreach($boardLabels as $boardLabel) {
+			foreach ($boardLabels as $boardLabel) {
 				if ($boardLabel->getId() === $label->getId()) {
 					continue;
 				}

lib/Collaboration/Resources/ResourceProvider.php

Doc Comments -1 removed lines

@@ -55,7 +55,6 @@
 	/**
 	 * Get the type of a resource
 	 *
-	 * @param IResource $resource
 	 * @return string
 	 * @since 15.0.0
 	 */

Unused Use Statements -2 removed lines

@@ -25,7 +25,6 @@ 
 
 
 use OCA\Deck\Db\Acl;
-use OCA\Deck\Db\Board;
 use OCA\Deck\Db\BoardMapper;
 use OCA\Deck\Service\PermissionService;
 use OCP\AppFramework\Db\DoesNotExistException;
@@ -34,7 +33,6 @@ 
 use OCP\Collaboration\Resources\IManager;
 use OCP\Collaboration\Resources\IProvider;
 use OCP\Collaboration\Resources\IResource;
-use OCP\Collaboration\Resources\ResourceException;
 use OCP\IUser;
 
 class ResourceProvider implements IProvider {

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 		} catch (QueryException $e) {
 		}
 		if ($boardId !== null) {
-			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string)$boardId, null);
+			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string) $boardId, null);
 			$resourceManager->invalidateAccessCacheForResource($resource);
 		} else {
 			$resourceManager->invalidateAccessCacheForProvider($this);

lib/Db/Acl.php

Doc Comments +3 added lines

@@ -53,6 +53,9 @@
 		$this->addResolvable('participant');
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getPermission($permission) {
 		switch ($permission) {
 			case self::PERMISSION_READ:

lib/Service/PermissionService.php

Doc Comments +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
 
 	/**
 	 * @param $boardId
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function userIsBoardOwner($boardId, $userId = null) {
 		if ($userId === null) {

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Db\Entity;
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
-use OCP\AppFramework\QueryException;
 use OCP\IConfig;
 use OCP\IGroupManager;
 use OCP\ILogger;

lib/Middleware/ExceptionMiddleware.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 namespace OCA\Deck\Middleware;
 
-use OCA\Deck\Controller\PageController;
 use OCA\Deck\StatusException;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Middleware;

lib/Service/BoardService.php

Spacing +10 added lines, -10 removed lines

@@ -104,8 +104,8 @@ 
 	public function findAll($since = -1, $details = null) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
-		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null,  $since);
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
+		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since);
 		$complete = array_merge($userBoards, $groupBoards, $circleBoards);
 		$result = [];
 		/** @var Board $item */
@@ -145,7 +145,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -193,7 +193,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -227,7 +227,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -382,7 +382,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -422,7 +422,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 
@@ -608,7 +608,7 @@ 
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($stacks) === 0) {
+		if (\count($stacks) === 0) {
 			return;
 		}
 
@@ -618,7 +618,7 @@ 
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($labels) === 0) {
+		if (\count($labels) === 0) {
 			return;
 		}
 
@@ -627,7 +627,7 @@ 
 
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
-		if(\count($boardUsers) === 0) {
+		if (\count($boardUsers) === 0) {
 			return;
 		}
 		$board->setUsers(array_values($boardUsers));

Doc Comments +10 added lines, -1 removed lines

@@ -180,7 +180,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return integer
 	 */
 	private function getBoardPrerequisites() {
 		$groups = $this->groupManager->getUserGroupIds(
@@ -658,6 +658,9 @@ 
 		return $newBoard;
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
@@ -668,6 +671,9 @@ 
 		$board->setStacks($stacks);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
@@ -678,6 +684,9 @@ 
 		$board->setLabels($labels);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
 		if(\count($boardUsers) === 0) {