Completed
Pull Request — master (#653)
by rakekniven
23:11
created
lib/Db/DeckMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
 		return $this->findEntity($sql, [$id]);
46 46
 	}
47 47
 
48
+	/**
49
+	 * @param string $sql
50
+	 */
48 51
 	protected function execute($sql, array $params = [], $limit = null, $offset = null) {
49 52
 		return parent::execute($sql, $params, $limit, $offset);
50 53
 	}
Please login to merge, or discard this patch.
lib/Db/LabelMapper.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
 		return $result;
67 67
 	}
68 68
 
69
+	/**
70
+	 * @param integer $labelId
71
+	 */
69 72
 	public function deleteLabelAssignments($labelId) {
70 73
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE label_id = ?';
71 74
 		$stmt = $this->db->prepare($sql);
@@ -73,6 +76,9 @@  discard block
 block discarded – undo
73 76
 		$stmt->execute();
74 77
 	}
75 78
 
79
+	/**
80
+	 * @param integer $cardId
81
+	 */
76 82
 	public function deleteLabelAssignmentsForCard($cardId) {
77 83
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE card_id = ?';
78 84
 		$stmt = $this->db->prepare($sql);
Please login to merge, or discard this patch.
lib/Middleware/SharingMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OCA\Deck\Middleware;
25 25
 
26 26
 use OCA\Deck\StatusException;
27
-use OCA\Deck\BadRequestException;
28 27
 use OCP\AppFramework\Db\DoesNotExistException;
29 28
 use OCP\AppFramework\Middleware;
30 29
 use OCP\AppFramework\Http\JSONResponse;
Please login to merge, or discard this patch.
lib/Db/AclMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@
 block discarded – undo
48 48
 		return $entity->getBoardId();
49 49
 	}
50 50
 
51
+	/**
52
+	 * @param string $participant
53
+	 */
51 54
 	public function findByParticipant($type, $participant) {
52 55
 		$sql = 'SELECT * from *PREFIX*deck_board_acl WHERE type = ? AND participant = ?';
53 56
 		return $this->findEntities($sql, [$type, $participant]);
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
 	}
143 143
 
144 144
 	protected function registerCommentsEventHandler() {
145
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
145
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
146 146
 			return $this->getContainer()->query(CommentEventHandler::class);
147 147
 		});
148 148
 	}
Please login to merge, or discard this patch.
lib/Activity/ActivityManager.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$subject = '';
134 134
 		switch ($subjectIdentifier) {
135 135
 			case self::SUBJECT_BOARD_CREATE:
136
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
136
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
137 137
 				break;
138 138
 			case self::SUBJECT_BOARD_DELETE:
139 139
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 				break;
369 369
 		}
370 370
 
371
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
371
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
372 372
 			$subjectParams['diff'] = true;
373 373
 		}
374 374
 		if ($subject === self::SUBJECT_CARD_UPDATE_STACKID) {
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 		$event->setApp('deck')
380 380
 			->setType('deck')
381 381
 			->setAuthor($this->userId)
382
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
382
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
383 383
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
384 384
 			->setTimestamp(time());
385 385
 
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
 					$objectId = $entity->getObjectId();
441 441
 					break;
442 442
 				default:
443
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
443
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
444 444
 			}
445 445
 			return $this->cardMapper->find($objectId);
446 446
 		}
@@ -455,11 +455,11 @@  discard block
 block discarded – undo
455 455
 					$objectId = $entity->getBoardId();
456 456
 					break;
457 457
 				default:
458
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
458
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
459 459
 			}
460 460
 			return $this->boardMapper->find($objectId);
461 461
 		}
462
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
462
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
463 463
 	}
464 464
 
465 465
 	private function findDetailsForStack($stackId) {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	}
125 125
 
126 126
 	/**
127
-	 * @param $subjectIdentifier
127
+	 * @param string $subjectIdentifier
128 128
 	 * @param array $subjectParams
129 129
 	 * @param bool $ownActivity
130 130
 	 * @return string
Please login to merge, or discard this patch.
lib/Activity/CommentEventHandler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
 	 * @param CommentsEvent $event
44 44
 	 */
45 45
 	public function handle(CommentsEvent $event) {
46
-		if($event->getComment()->getObjectType() !== 'deckCard') {
46
+		if ($event->getComment()->getObjectType() !== 'deckCard') {
47 47
 			return;
48 48
 		}
49 49
 
50 50
 		$eventType = $event->getEvent();
51
-		if( $eventType === CommentsEvent::EVENT_ADD
51
+		if ($eventType === CommentsEvent::EVENT_ADD
52 52
 		) {
53 53
 			$this->notificationHandler($event);
54 54
 			$this->activityHandler($event);
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 			CommentsEvent::EVENT_UPDATE,
61 61
 			CommentsEvent::EVENT_DELETE,
62 62
 		];
63
-		if(in_array($eventType, $applicableEvents)) {
63
+		if (in_array($eventType, $applicableEvents)) {
64 64
 			$this->notificationHandler($event);
65 65
 			return;
66 66
 		}
Please login to merge, or discard this patch.
lib/Service/CardService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -91,8 +91,8 @@
 block discarded – undo
91 91
 		$card->setLabels($this->labelMapper->findAssignedLabelsForCard($cardId));
92 92
 		$card->setAttachmentCount($this->attachmentService->count($cardId));
93 93
 		$user = $this->userManager->get($this->currentUser);
94
-		$lastRead = $this->commentsManager->getReadMark('deckCard', (string)$card->getId(), $user);
95
-		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string)$card->getId(), $lastRead);
94
+		$lastRead = $this->commentsManager->getReadMark('deckCard', (string) $card->getId(), $user);
95
+		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string) $card->getId(), $lastRead);
96 96
 		$card->setCommentsUnread($count);
97 97
 	}
98 98
 
Please login to merge, or discard this patch.