nextcloud / deck

lib/Notification/NotificationHelper.php

Doc Comments +3 added lines

@@ -94,6 +94,9 @@
 		$this->cardMapper->markNotified($card);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function sendCardAssigned($card, $userId) {
 		$boardId = $this->cardMapper->findBoardId($card->getId());
 		$board = $this->getBoard($boardId);

lib/Controller/AttachmentApiController.php

Indentation +35 added lines, -35 removed lines

@@ -31,76 +31,76 @@
 
 class AttachmentApiController extends ApiController {
 
-    private $attachmentService;
+	private $attachmentService;
 
-    public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
-        parent::__construct($appName, $request);
-        $this->attachmentService = $attachmentService;
-    }
+	public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
+		parent::__construct($appName, $request);
+		$this->attachmentService = $attachmentService;
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function getAll() {
-        $attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function getAll() {
+		$attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function display() {
-        $attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function display() {
+		$attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function create($type, $data) {
-        $attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function create($type, $data) {
+		$attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function update($data) {
-        $attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function update($data) {
+		$attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function delete() {
-        $attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function delete() {
+		$attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function restore() {
-        $attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function restore() {
+		$attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 }
\ No newline at end of file

appinfo/routes.php

Spacing +1 added lines, -1 removed lines

@@ -112,6 +112,6 @@
 		['name' => 'attachment_api#delete', 'url' => '/api/v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}', 'verb' => 'DELETE'],
 		['name' => 'attachment_api#restore', 'url' => '/api/v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}/restore', 'verb' => 'PUT'],
 
-		['name' => 'board_api#preflighted_cors', 'url' => '/api/v1.0/{path}','verb' => 'OPTIONS', 'requirements' => ['path' => '.+']],
+		['name' => 'board_api#preflighted_cors', 'url' => '/api/v1.0/{path}', 'verb' => 'OPTIONS', 'requirements' => ['path' => '.+']],
 	]
 ];

lib/Service/DefaultBoardService.php

Indentation +7 added lines, -7 removed lines

@@ -40,7 +40,7 @@ 
 	private $config;
 	private $l10n;
 
-    public function __construct(
+	public function __construct(
 			IL10N $l10n,
 			BoardMapper $boardMapper,
 			BoardService $boardService,
@@ -55,7 +55,7 @@ 
 		$this->config = $config;
 		$this->boardMapper = $boardMapper;
 		$this->l10n = $l10n;
-    }
+	}
 
 	/**
 	 * @param $userId
@@ -73,7 +73,7 @@ 
 		}
 
 		return false;
-    }
+	}
 
 	/**
 	 * @param $title
@@ -100,9 +100,9 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-        $defaultBoard = $this->boardService->create($title, $userId, $color);
-        $defaultStacks = [];
-        $defaultCards = [];
+		$defaultBoard = $this->boardService->create($title, $userId, $color);
+		$defaultStacks = [];
+		$defaultCards = [];
 
 		$boardId = $defaultBoard->getId();		
 
@@ -115,5 +115,5 @@ 
 		$defaultCards[] = $this->cardService->create($this->l10n->t('Example Task 1'), $defaultStacks[2]->getId(), 'text', 0, $userId);
 
 		return $defaultBoard;
-    }
+	}
 }
\ No newline at end of file

lib/Controller/BoardApiController.php

Unused Use Statements -2 removed lines

@@ -25,10 +25,8 @@
 namespace OCA\Deck\Controller;
 
 use OCP\AppFramework\ApiController;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\IRequest;
-
 use OCA\Deck\Service\BoardService;
 
 /**

lib/Db/BoardMapper.php

Doc Comments +3 added lines

@@ -173,6 +173,9 @@
 		return ($board->getOwner() === $userId);
 	}
 
+	/**
+	 * @param string $id
+	 */
 	public function findBoardId($id) {
 		return $id;
 	}

lib/Service/BoardService.php

Spacing +5 added lines, -5 removed lines

@@ -121,7 +121,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -170,7 +170,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -204,7 +204,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -335,7 +335,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -369,7 +369,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 

appinfo/app.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
  *
  */
 
-if ((@include_once __DIR__ . '/../vendor/autoload.php')===false) {
+if ((@include_once __DIR__ . '/../vendor/autoload.php') === false) {
 	throw new Exception('Cannot include autoload. Did you run install dependencies using composer?');
 }
 

lib/Service/StackService.php

Spacing +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
 	private function enrichStackWithCards($stack) {
 		$cards = $this->cardMapper->findAll($stack->getId());
 
-		if(is_null($cards)) {
+		if (is_null($cards)) {
 			return;
 		}
 
@@ -215,7 +215,7 @@ 
 	 */
 	public function delete($id) {
 
-		if ( is_numeric($id) === false ) {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('stack id must be a number');
 		}
 

Unused Use Statements -1 removed lines

@@ -34,7 +34,6 @@
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 use OCA\Deck\BadRequestException;
-use OCP\Comments\ICommentsManager;
 
 
 class StackService {