nextcloud / deck

lib/Service/PermissionService.php

Doc Comments +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
 
 	/**
 	 * @param $boardId
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function userIsBoardOwner($boardId, $userId = null) {
 		if ($userId === null) {

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Db\Entity;
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
-use OCP\AppFramework\QueryException;
 use OCP\IConfig;
 use OCP\IGroupManager;
 use OCP\ILogger;

lib/Middleware/ExceptionMiddleware.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 namespace OCA\Deck\Middleware;
 
-use OCA\Deck\Controller\PageController;
 use OCA\Deck\StatusException;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Middleware;

lib/AppInfo/Application.php

Spacing +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
 	 * @throws \OCP\AppFramework\QueryException
 	 */
 	protected function registerCommentsEventHandler() {
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
 			return $this->getContainer()->query(CommentEventHandler::class);
 		});
 	}
@@ -175,7 +175,7 @@ 
 		/** @var IManager $resourceManager */
 		$resourceManager = $this->getContainer()->query(IManager::class);
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProvider::class);
-		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function () {
+		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function() {
 			\OCP\Util::addScript('deck', 'build/collections');
 		});
 	}

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OCA\Deck\Notification\Notifier;
 use OCA\Deck\Service\FullTextSearchService;
 use OCP\AppFramework\App;
-use OCA\Deck\Middleware\SharingMiddleware;
 use OCP\Collaboration\Resources\IManager;
 use OCP\Comments\CommentsEntityEvent;
 use OCP\IGroup;

lib/Service/BoardService.php

Spacing +10 added lines, -10 removed lines

@@ -97,8 +97,8 @@ 
 	public function findAll($since = 0, $details = null) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
-		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null,  $since);
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
+		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since);
 		$complete = array_merge($userBoards, $groupBoards, $circleBoards);
 		$result = [];
 		/** @var Board $item */
@@ -138,7 +138,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -186,7 +186,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -220,7 +220,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -358,7 +358,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -392,7 +392,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 
@@ -554,7 +554,7 @@ 
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($stacks) === 0) {
+		if (\count($stacks) === 0) {
 			return;
 		}
 
@@ -564,7 +564,7 @@ 
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($labels) === 0) {
+		if (\count($labels) === 0) {
 			return;
 		}
 
@@ -573,7 +573,7 @@ 
 
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
-		if(\count($boardUsers) === 0) {
+		if (\count($boardUsers) === 0) {
 			return;
 		}
 		$board->setUsers(array_values($boardUsers));

Doc Comments +10 added lines, -1 removed lines

@@ -170,7 +170,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return integer
 	 */
 	private function getBoardPrerequisites() {
 		$groups = $this->groupManager->getUserGroupIds(
@@ -605,6 +605,9 @@ 
 		return $delete;
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
@@ -615,6 +618,9 @@ 
 		$board->setStacks($stacks);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
@@ -625,6 +631,9 @@ 
 		$board->setLabels($labels);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
 		if(\count($boardUsers) === 0) {