Passed
Pull Request — master (#1483)
by Julius
03:07
created
lib/Db/AssignedUsersMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 	 * Check if user exists before assigning it to a card
64 64
 	 *
65 65
 	 * @param Entity $entity
66
-	 * @return null|Entity
66
+	 * @return AssignedUsers|null
67 67
 	 */
68 68
 	public function insert(Entity $entity) {
69 69
 		$user = $this->userManager->get($entity->getParticipant());
Please login to merge, or discard this patch.
lib/Service/AttachmentService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
 	 * @param $cardId
164 164
 	 * @param $attachmentId
165 165
 	 * @param $request
166
-	 * @return mixed
166
+	 * @return \OCP\AppFramework\Db\Entity
167 167
 	 * @throws \OCA\Deck\NoPermissionException
168 168
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException
169 169
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
Please login to merge, or discard this patch.
lib/Service/FileService.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -23,15 +23,11 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Deck\Service;
25 25
 
26
-use OC\Security\CSP\ContentSecurityPolicyManager;
27 26
 use OCA\Deck\Db\Attachment;
28 27
 use OCA\Deck\StatusException;
29 28
 use OCP\AppFramework\Http\ContentSecurityPolicy;
30
-use OCP\AppFramework\Http\EmptyContentSecurityPolicy;
31 29
 use OCP\AppFramework\Http\FileDisplayResponse;
32 30
 use OCP\AppFramework\Http\StreamResponse;
33
-use OCP\Files\Cache\IScanner;
34
-use OCP\Files\Folder;
35 31
 use OCP\Files\IAppData;
36 32
 use OCP\Files\IRootFolder;
37 33
 use OCP\Files\NotFoundException;
Please login to merge, or discard this patch.
lib/Db/CardMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -136,6 +136,9 @@
 block discarded – undo
136 136
 		return parent::delete($entity);
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param integer $stackId
141
+	 */
139 142
 	public function deleteByStack($stackId) {
140 143
 		$cards = $this->findAllByStack($stackId);
141 144
 		foreach ($cards as $card) {
Please login to merge, or discard this patch.
lib/Controller/CardApiController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
  namespace OCA\Deck\Controller;
25 25
 
26 26
  use OCP\AppFramework\ApiController;
27
- use OCP\AppFramework\Http;
28 27
  use OCP\AppFramework\Http\DataResponse;
29 28
  use OCP\IRequest;
30 29
  use OCA\Deck\Service\CardService;
Please login to merge, or discard this patch.
lib/Db/DeckMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
 		return $this->findEntity($sql, [$id]);
46 46
 	}
47 47
 
48
+	/**
49
+	 * @param string $sql
50
+	 */
48 51
 	protected function execute($sql, array $params = [], $limit = null, $offset = null) {
49 52
 		return parent::execute($sql, $params, $limit, $offset);
50 53
 	}
Please login to merge, or discard this patch.
lib/Db/LabelMapper.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
 		return $result;
67 67
 	}
68 68
 
69
+	/**
70
+	 * @param integer $labelId
71
+	 */
69 72
 	public function deleteLabelAssignments($labelId) {
70 73
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE label_id = ?';
71 74
 		$stmt = $this->db->prepare($sql);
@@ -73,6 +76,9 @@  discard block
 block discarded – undo
73 76
 		$stmt->execute();
74 77
 	}
75 78
 
79
+	/**
80
+	 * @param integer $cardId
81
+	 */
76 82
 	public function deleteLabelAssignmentsForCard($cardId) {
77 83
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE card_id = ?';
78 84
 		$stmt = $this->db->prepare($sql);
Please login to merge, or discard this patch.
lib/Activity/ActivityManager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	}
125 125
 
126 126
 	/**
127
-	 * @param $subjectIdentifier
127
+	 * @param string $subjectIdentifier
128 128
 	 * @param array $subjectParams
129 129
 	 * @param bool $ownActivity
130 130
 	 * @return string
Please login to merge, or discard this patch.
lib/Db/ChangeHelper.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -23,13 +23,9 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Deck\Db;
25 25
 
26
-use OCP\AppFramework\Db\DoesNotExistException;
27
-use OCP\ICache;
28 26
 use OCP\ICacheFactory;
29 27
 use OCP\IDBConnection;
30 28
 use OCP\IRequest;
31
-use OCP\IUserManager;
32
-use OCP\IGroupManager;
33 29
 
34 30
 class ChangeHelper {
35 31
 
Please login to merge, or discard this patch.