nextcloud / deck

lib/Db/ChangeHelper.php

Unused Use Statements -4 removed lines

@@ -23,13 +23,9 @@
 
 namespace OCA\Deck\Db;
 
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\ICache;
 use OCP\ICacheFactory;
 use OCP\IDBConnection;
 use OCP\IRequest;
-use OCP\IUserManager;
-use OCP\IGroupManager;
 
 class ChangeHelper {
 

Spacing +3 added lines, -3 removed lines

@@ -61,7 +61,7 @@ 
 	public function cardChanged($cardId, $updateCard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$cardId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $cardId, $etag);
 		if ($updateCard) {
 			$sql = 'UPDATE `*PREFIX*deck_cards` SET `last_modified` = ?, `last_editor` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $this->userId, $cardId]);
@@ -78,7 +78,7 @@ 
 	public function stackChanged($stackId, $updateBoard = true) {
 		$time = time();
 		$etag = md5($time . microtime());
-		$this->cache->set(self::TYPE_CARD . '-' .$stackId, $etag);
+		$this->cache->set(self::TYPE_CARD . '-' . $stackId, $etag);
 		if ($updateBoard) {
 			$sql = 'UPDATE `*PREFIX*deck_stacks` SET `last_modified` = ? WHERE `id` = ?';
 			$this->db->executeUpdate($sql, [time(), $stackId]);
@@ -94,7 +94,7 @@ 
 	}
 
 	public function getEtag($type, $id) {
-		$entry = $this->cache->get($type . '-' .$id);
+		$entry = $this->cache->get($type . '-' . $id);
 		if ($entry === 'null') {
 			return '';
 		}

lib/Controller/AttachmentApiController.php

Indentation +34 added lines, -34 removed lines

@@ -31,76 +31,76 @@
 
 class AttachmentApiController extends ApiController {
 
-    private $attachmentService;
+	private $attachmentService;
 
-    public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
-        parent::__construct($appName, $request);
-        $this->attachmentService = $attachmentService;
-    }
+	public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
+		parent::__construct($appName, $request);
+		$this->attachmentService = $attachmentService;
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function getAll() {
-        $attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function getAll() {
+		$attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function display() {
-        $attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+	public function display() {
+		$attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
 		return $attachment;
-    }
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function create($type, $data) {
-        $attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function create($type, $data) {
+		$attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function update($data) {
-        $attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function update($data) {
+		$attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function delete() {
-        $attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function delete() {
+		$attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function restore() {
-        $attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function restore() {
+		$attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 }
\ No newline at end of file

lib/Controller/ConfigController.php

Unused Use Statements -3 removed lines

@@ -23,16 +23,13 @@
 
 namespace OCA\Deck\Controller;
 
-use OCA\Deck\Service\DefaultBoardService;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\IConfig;
 use OCP\IGroup;
 use OCP\IGroupManager;
 use OCP\IRequest;
-use OCP\AppFramework\Http\TemplateResponse;
 use OCP\AppFramework\Controller;
-use OCP\IL10N;
 
 class ConfigController extends Controller {
 

lib/Controller/PageController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	public function index() {
 		$params = [
 			'user' => $this->userId,
-			'maxUploadSize' => (int)\OCP\Util::uploadLimit(),
+			'maxUploadSize' => (int) \OCP\Util::uploadLimit(),
 			'canCreate' => $this->permissionService->canCreate()
 		];
 

lib/Activity/DeckProvider.php

Doc Comments +14 added lines

@@ -189,6 +189,9 @@ 
 		return $event;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForBoard($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -200,6 +203,10 @@ 
 		}
 		return $params;
 	}
+
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForStack($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -211,6 +218,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForAttachment($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -285,6 +295,7 @@ 
 	 *
 	 * @param $subjectParams
 	 * @param $params
+	 * @param IEvent $event
 	 * @return mixed
 	 */
 	private function parseParamForChanges($subjectParams, $params, $event) {
@@ -312,6 +323,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $endpoint
+	 */
 	public function deckUrl($endpoint) {
 		return $this->urlGenerator->linkToRouteAbsolute('deck.page.index') . '#!' . $endpoint;
 	}

Spacing +2 added lines, -2 removed lines

@@ -281,11 +281,11 @@
 		if (array_key_exists('comment', $subjectParams)) {
 			/** @var IComment $comment */
 			try {
-				$comment = $this->commentsManager->get((int)$subjectParams['comment']);
+				$comment = $this->commentsManager->get((int) $subjectParams['comment']);
 				$event->setParsedMessage($comment->getMessage());
 			} catch (NotFoundException $e) {
 			}
-			$params['comment'] =[
+			$params['comment'] = [
 				'type' => 'highlight',
 				'id' => $subjectParams['comment'],
 				'name' => $comment->getMessage()

lib/Cron/CardDescriptionActivity.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 	private $cardMapper;
 
 	public function __construct(ActivityManager $activityManager, CardMapper $cardMapper) {
-		$this->activityManager  = $activityManager;
+		$this->activityManager = $activityManager;
 		$this->cardMapper = $cardMapper;
 	}
 

lib/Activity/CommentEventHandler.php

Spacing +3 added lines, -3 removed lines

@@ -50,12 +50,12 @@ 
 	 * @param CommentsEvent $event
 	 */
 	public function handle(CommentsEvent $event) {
-		if($event->getComment()->getObjectType() !== 'deckCard') {
+		if ($event->getComment()->getObjectType() !== 'deckCard') {
 			return;
 		}
 
 		$eventType = $event->getEvent();
-		if( $eventType === CommentsEvent::EVENT_ADD
+		if ($eventType === CommentsEvent::EVENT_ADD
 		) {
 			$this->notificationHandler($event);
 			$this->activityHandler($event);
@@ -65,7 +65,7 @@ 
 		$applicableEvents = [
 			CommentsEvent::EVENT_UPDATE
 		];
-		if(in_array($eventType, $applicableEvents)) {
+		if (in_array($eventType, $applicableEvents)) {
 			$this->notificationHandler($event);
 			return;
 		}

lib/Controller/BoardApiController.php

Unused Use Statements -2 removed lines

@@ -26,10 +26,8 @@
 
 use OCA\Deck\StatusException;
 use OCP\AppFramework\ApiController;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\IRequest;
-
 use OCA\Deck\Service\BoardService;
 use Sabre\HTTP\Util;
 

lib/Notification/NotificationHelper.php

Doc Comments +6 added lines

@@ -95,6 +95,9 @@ 
 		$this->cardMapper->markNotified($card);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function markDuedateAsRead($card) {
 		$notification = $this->notificationManager->createNotification();
 		$notification
@@ -104,6 +107,9 @@ 
 		$this->notificationManager->markProcessed($notification);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function sendCardAssigned($card, $userId) {
 		$boardId = $this->cardMapper->findBoardId($card->getId());
 		$board = $this->getBoard($boardId);