Passed
Pull Request — master (#885)
by Maxence
03:47 queued 01:01
created
lib/Service/DefaultBoardService.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	private $config;
41 41
 	private $l10n;
42 42
 
43
-    public function __construct(
43
+	public function __construct(
44 44
 			IL10N $l10n,
45 45
 			BoardMapper $boardMapper,
46 46
 			BoardService $boardService,
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 		$this->config = $config;
56 56
 		$this->boardMapper = $boardMapper;
57 57
 		$this->l10n = $l10n;
58
-    }
58
+	}
59 59
 
60 60
 	/**
61 61
 	 * @param $userId
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 		}
74 74
 
75 75
 		return false;
76
-    }
76
+	}
77 77
 
78 78
 	/**
79 79
 	 * @param $title
@@ -100,9 +100,9 @@  discard block
 block discarded – undo
100 100
 			throw new BadRequestException('color must be provided');
101 101
 		}
102 102
 
103
-        $defaultBoard = $this->boardService->create($title, $userId, $color);
104
-        $defaultStacks = [];
105
-        $defaultCards = [];
103
+		$defaultBoard = $this->boardService->create($title, $userId, $color);
104
+		$defaultStacks = [];
105
+		$defaultCards = [];
106 106
 
107 107
 		$boardId = $defaultBoard->getId();		
108 108
 
@@ -115,5 +115,5 @@  discard block
 block discarded – undo
115 115
 		$defaultCards[] = $this->cardService->create($this->l10n->t('Example Task 1'), $defaultStacks[2]->getId(), 'text', 0, $userId);
116 116
 
117 117
 		return $defaultBoard;
118
-    }
118
+	}
119 119
 }
120 120
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/BoardMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -173,6 +173,9 @@
 block discarded – undo
173 173
 		return ($board->getOwner() === $userId);
174 174
 	}
175 175
 
176
+	/**
177
+	 * @param string $id
178
+	 */
176 179
 	public function findBoardId($id) {
177 180
 		return $id;
178 181
 	}
Please login to merge, or discard this patch.
appinfo/app.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
  *
22 22
  */
23 23
 
24
-if ((@include_once __DIR__ . '/../vendor/autoload.php')===false) {
24
+if ((@include_once __DIR__ . '/../vendor/autoload.php') === false) {
25 25
 	throw new Exception('Cannot include autoload. Did you run install dependencies using composer?');
26 26
 }
27 27
 
Please login to merge, or discard this patch.
lib/Db/DeckMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
 		return $this->findEntity($sql, [$id]);
46 46
 	}
47 47
 
48
+	/**
49
+	 * @param string $sql
50
+	 */
48 51
 	protected function execute($sql, array $params = [], $limit = null, $offset = null) {
49 52
 		return parent::execute($sql, $params, $limit, $offset);
50 53
 	}
Please login to merge, or discard this patch.
lib/Db/LabelMapper.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
 		return $result;
67 67
 	}
68 68
 
69
+	/**
70
+	 * @param integer $labelId
71
+	 */
69 72
 	public function deleteLabelAssignments($labelId) {
70 73
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE label_id = ?';
71 74
 		$stmt = $this->db->prepare($sql);
@@ -73,6 +76,9 @@  discard block
 block discarded – undo
73 76
 		$stmt->execute();
74 77
 	}
75 78
 
79
+	/**
80
+	 * @param integer $cardId
81
+	 */
76 82
 	public function deleteLabelAssignmentsForCard($cardId) {
77 83
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE card_id = ?';
78 84
 		$stmt = $this->db->prepare($sql);
Please login to merge, or discard this patch.
lib/Middleware/SharingMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OCA\Deck\Middleware;
25 25
 
26 26
 use OCA\Deck\StatusException;
27
-use OCA\Deck\BadRequestException;
28 27
 use OCP\AppFramework\Db\DoesNotExistException;
29 28
 use OCP\AppFramework\Middleware;
30 29
 use OCP\AppFramework\Http\JSONResponse;
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
 	}
143 143
 
144 144
 	protected function registerCommentsEventHandler() {
145
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
145
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
146 146
 			return $this->getContainer()->query(CommentEventHandler::class);
147 147
 		});
148 148
 	}
Please login to merge, or discard this patch.
lib/Activity/ActivityManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	}
125 125
 
126 126
 	/**
127
-	 * @param $subjectIdentifier
127
+	 * @param string $subjectIdentifier
128 128
 	 * @param array $subjectParams
129 129
 	 * @param bool $ownActivity
130 130
 	 * @return string
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$subject = '';
134 134
 		switch ($subjectIdentifier) {
135 135
 			case self::SUBJECT_BOARD_CREATE:
136
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
136
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
137 137
 				break;
138 138
 			case self::SUBJECT_BOARD_DELETE:
139 139
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 				break;
374 374
 		}
375 375
 
376
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
376
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
377 377
 			$card = $subjectParams['card'];
378 378
 			if ($card->getLastEditor() === $this->userId) {
379 379
 				return null;
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 		$event->setApp('deck')
393 393
 			->setType($eventType)
394 394
 			->setAuthor($author === null ? $this->userId : $author)
395
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
395
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
396 396
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
397 397
 			->setTimestamp(time());
398 398
 
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 					$objectId = $entity->getObjectId();
454 454
 					break;
455 455
 				default:
456
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
456
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
457 457
 			}
458 458
 			return $this->cardMapper->find($objectId);
459 459
 		}
@@ -468,11 +468,11 @@  discard block
 block discarded – undo
468 468
 					$objectId = $entity->getBoardId();
469 469
 					break;
470 470
 				default:
471
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
471
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
472 472
 			}
473 473
 			return $this->boardMapper->find($objectId);
474 474
 		}
475
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
475
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
476 476
 	}
477 477
 
478 478
 	private function findDetailsForStack($stackId) {
Please login to merge, or discard this patch.
lib/Service/CardService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -91,8 +91,8 @@
 block discarded – undo
91 91
 		$card->setLabels($this->labelMapper->findAssignedLabelsForCard($cardId));
92 92
 		$card->setAttachmentCount($this->attachmentService->count($cardId));
93 93
 		$user = $this->userManager->get($this->currentUser);
94
-		$lastRead = $this->commentsManager->getReadMark('deckCard', (string)$card->getId(), $user);
95
-		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string)$card->getId(), $lastRead);
94
+		$lastRead = $this->commentsManager->getReadMark('deckCard', (string) $card->getId(), $user);
95
+		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string) $card->getId(), $lastRead);
96 96
 		$card->setCommentsUnread($count);
97 97
 	}
98 98
 
Please login to merge, or discard this patch.