Passed
Pull Request — master (#885)
by Maxence
03:47 queued 01:01
created
lib/Db/ChangeHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 	public function cardChanged($cardId, $updateCard = true) {
62 62
 		$time = time();
63 63
 		$etag = md5($time . microtime());
64
-		$this->cache->set(self::TYPE_CARD . '-' .$cardId, $etag);
64
+		$this->cache->set(self::TYPE_CARD . '-' . $cardId, $etag);
65 65
 		if ($updateCard) {
66 66
 			$sql = 'UPDATE `*PREFIX*deck_cards` SET `last_modified` = ?, `last_editor` = ? WHERE `id` = ?';
67 67
 			$this->db->executeUpdate($sql, [time(), $this->userId, $cardId]);
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	public function stackChanged($stackId, $updateBoard = true) {
79 79
 		$time = time();
80 80
 		$etag = md5($time . microtime());
81
-		$this->cache->set(self::TYPE_CARD . '-' .$stackId, $etag);
81
+		$this->cache->set(self::TYPE_CARD . '-' . $stackId, $etag);
82 82
 		if ($updateBoard) {
83 83
 			$sql = 'UPDATE `*PREFIX*deck_stacks` SET `last_modified` = ? WHERE `id` = ?';
84 84
 			$this->db->executeUpdate($sql, [time(), $stackId]);
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	}
95 95
 
96 96
 	public function getEtag($type, $id) {
97
-		$entry = $this->cache->get($type . '-' .$id);
97
+		$entry = $this->cache->get($type . '-' . $id);
98 98
 		if ($entry === 'null') {
99 99
 			return '';
100 100
 		}
Please login to merge, or discard this patch.
lib/Cron/CardDescriptionActivity.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	private $cardMapper;
44 44
 
45 45
 	public function __construct(ActivityManager $activityManager, CardMapper $cardMapper) {
46
-		$this->activityManager  = $activityManager;
46
+		$this->activityManager = $activityManager;
47 47
 		$this->cardMapper = $cardMapper;
48 48
 	}
49 49
 
Please login to merge, or discard this patch.
lib/Activity/ActivityManager.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$subject = '';
134 134
 		switch ($subjectIdentifier) {
135 135
 			case self::SUBJECT_BOARD_CREATE:
136
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
136
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
137 137
 				break;
138 138
 			case self::SUBJECT_BOARD_DELETE:
139 139
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 				break;
374 374
 		}
375 375
 
376
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
376
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
377 377
 			$card = $subjectParams['card'];
378 378
 			if ($card->getLastEditor() === $this->userId) {
379 379
 				return null;
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 		$event->setApp('deck')
393 393
 			->setType($eventType)
394 394
 			->setAuthor($author === null ? $this->userId : $author)
395
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
395
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
396 396
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
397 397
 			->setTimestamp(time());
398 398
 
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 					$objectId = $entity->getObjectId();
454 454
 					break;
455 455
 				default:
456
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
456
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
457 457
 			}
458 458
 			return $this->cardMapper->find($objectId);
459 459
 		}
@@ -468,11 +468,11 @@  discard block
 block discarded – undo
468 468
 					$objectId = $entity->getBoardId();
469 469
 					break;
470 470
 				default:
471
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
471
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
472 472
 			}
473 473
 			return $this->boardMapper->find($objectId);
474 474
 		}
475
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
475
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
476 476
 	}
477 477
 
478 478
 	private function findDetailsForStack($stackId) {
Please login to merge, or discard this patch.
lib/Activity/CommentEventHandler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
50 50
 	 * @param CommentsEvent $event
51 51
 	 */
52 52
 	public function handle(CommentsEvent $event) {
53
-		if($event->getComment()->getObjectType() !== 'deckCard') {
53
+		if ($event->getComment()->getObjectType() !== 'deckCard') {
54 54
 			return;
55 55
 		}
56 56
 
57 57
 		$eventType = $event->getEvent();
58
-		if( $eventType === CommentsEvent::EVENT_ADD
58
+		if ($eventType === CommentsEvent::EVENT_ADD
59 59
 		) {
60 60
 			$this->notificationHandler($event);
61 61
 			$this->activityHandler($event);
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 		$applicableEvents = [
66 66
 			CommentsEvent::EVENT_UPDATE
67 67
 		];
68
-		if(in_array($eventType, $applicableEvents)) {
68
+		if (in_array($eventType, $applicableEvents)) {
69 69
 			$this->notificationHandler($event);
70 70
 			return;
71 71
 		}
Please login to merge, or discard this patch.
lib/Activity/DeckProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -281,11 +281,11 @@
 block discarded – undo
281 281
 		if (array_key_exists('comment', $subjectParams)) {
282 282
 			/** @var IComment $comment */
283 283
 			try {
284
-				$comment = $this->commentsManager->get((int)$subjectParams['comment']);
284
+				$comment = $this->commentsManager->get((int) $subjectParams['comment']);
285 285
 				$event->setParsedMessage($comment->getMessage());
286 286
 			} catch (NotFoundException $e) {
287 287
 			}
288
-			$params['comment'] =[
288
+			$params['comment'] = [
289 289
 				'type' => 'highlight',
290 290
 				'id' => $subjectParams['comment'],
291 291
 				'name' => $comment->getMessage()
Please login to merge, or discard this patch.
lib/Provider/DeckProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -240,7 +240,7 @@
 block discarded – undo
240 240
 		foreach ($searchResult->getDocuments() as $document) {
241 241
 			try {
242 242
 				$board =
243
-					$this->fullTextSearchService->getBoardFromCardId((int)$document->getId());
243
+					$this->fullTextSearchService->getBoardFromCardId((int) $document->getId());
244 244
 				$path = '#!/board/' . $board->getId() . '//card/' . $document->getId();
245 245
 				$document->setLink($this->urlGenerator->linkToRoute('deck.page.index') . $path);
246 246
 			} catch (DoesNotExistException $e) {
Please login to merge, or discard this patch.
lib/Service/FullTextSearchService.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 		$userId = $e->getArgument('userId');
97 97
 
98 98
 		$this->fullTextSearchManager->createIndex(
99
-			DeckProvider::DECK_PROVIDER_ID, (string)$cardId, $userId, IIndex::INDEX_FULL
99
+			DeckProvider::DECK_PROVIDER_ID, (string) $cardId, $userId, IIndex::INDEX_FULL
100 100
 		);
101 101
 	}
102 102
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$cardId = $e->getArgument('id');
109 109
 
110 110
 		$this->fullTextSearchManager->updateIndexStatus(
111
-			DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_CONTENT
111
+			DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_CONTENT
112 112
 		);
113 113
 	}
114 114
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 		$cardId = $e->getArgument('id');
121 121
 
122 122
 		$this->fullTextSearchManager->updateIndexStatus(
123
-			DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_REMOVE
123
+			DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_REMOVE
124 124
 		);
125 125
 	}
126 126
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 	 * @return IIndexDocument
150 150
 	 */
151 151
 	public function generateIndexDocumentFromCard(Card $card): IIndexDocument {
152
-		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string)$card->getId());
152
+		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string) $card->getId());
153 153
 
154 154
 		return $document;
155 155
 	}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 */
164 164
 	public function fillIndexDocument(IIndexDocument $document) {
165 165
 		/** @var Card $card */
166
-		$card = $this->cardMapper->find((int)$document->getId());
166
+		$card = $this->cardMapper->find((int) $document->getId());
167 167
 
168 168
 		$document->setTitle($card->getTitle());
169 169
 		$document->setContent($card->getDescription());
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	 * @throws MultipleObjectsReturnedException
231 231
 	 */
232 232
 	public function getBoardFromCardId(int $cardId): Board {
233
-		$boardId = (int)$this->cardMapper->findBoardId($cardId);
233
+		$boardId = (int) $this->cardMapper->findBoardId($cardId);
234 234
 		/** @var Board $board */
235 235
 		$board = $this->boardMapper->find($boardId);
236 236
 
Please login to merge, or discard this patch.