Passed
Pull Request — master (#333)
by Morris
02:14
created
lib/Service/StackService.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@
 block discarded – undo
85 85
 		return $stacks;
86 86
 	}
87 87
 
88
+	/**
89
+	 * @param integer $order
90
+	 */
88 91
 	public function create($title, $boardId, $order) {
89 92
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
90 93
 		if($this->boardService->isArchived(null, $boardId)) {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,10 +26,7 @@
 block discarded – undo
26 26
 use OCA\Deck\Db\Acl;
27 27
 use OCA\Deck\Db\CardMapper;
28 28
 use OCA\Deck\Db\LabelMapper;
29
-
30
-
31 29
 use OCA\Deck\Db\Stack;
32
-
33 30
 use OCA\Deck\Db\StackMapper;
34 31
 use OCA\Deck\StatusException;
35 32
 
Please login to merge, or discard this patch.
lib/Service/PermissionService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@
 block discarded – undo
183 183
 	 * Find a list of all users (including the ones from groups)
184 184
 	 * Required to allow assigning them to cards
185 185
 	 *
186
-	 * @param $boardId
186
+	 * @param integer|null $boardId
187 187
 	 * @return array
188 188
 	 */
189 189
 	public function findUsers($boardId) {
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 use OCP\AppFramework\App;
30 30
 use OCA\Deck\Middleware\SharingMiddleware;
31 31
 use OCP\IGroup;
32
-
33 32
 use OCP\IUser;
34 33
 use OCP\IUserManager;
35 34
 use OCP\IURLGenerator;
Please login to merge, or discard this patch.
lib/Db/CardMapper.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
 	/**
94 94
 	 * @param $id
95
-	 * @return RelationalEntity if not found
95
+	 * @return Entity if not found
96 96
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
97 97
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException
98 98
 	 */
@@ -136,6 +136,9 @@  discard block
 block discarded – undo
136 136
 		return parent::delete($entity);
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param integer $stackId
141
+	 */
139 142
 	public function deleteByStack($stackId) {
140 143
 		$cards = $this->findAllByStack($stackId);
141 144
 		foreach ($cards as $card) {
Please login to merge, or discard this patch.
lib/Db/RelationalEntity.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 	/**
34 34
 	 * Mark a property as relation so it will not get updated using Mapper::update
35
-	 * @param $property string Name of the property
35
+	 * @param string $property string Name of the property
36 36
 	 */
37 37
 	public function addRelation($property) {
38 38
 		if (!in_array($property, $this->_relations, true)) {
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
 	/**
44 44
 	 * Mark a property as resolvable via resolveRelation()
45
-	 * @param $property string Name of the property
45
+	 * @param string $property string Name of the property
46 46
 	 */
47 47
 	public function addResolvable($property) {
48 48
 		$this->_resolvedProperties[$property] = null;
Please login to merge, or discard this patch.
lib/Notification/NotificationHelper.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * Send notifications that a board was shared with a user/group
99 99
 	 *
100 100
 	 * @param $boardId
101
-	 * @param $acl
101
+	 * @param Acl $acl
102 102
 	 * @throws \InvalidArgumentException
103 103
 	 */
104 104
 	public function sendBoardShared($boardId, $acl) {
@@ -128,6 +128,9 @@  discard block
 block discarded – undo
128 128
 		return $this->boards[$boardId];
129 129
 	}
130 130
 
131
+	/**
132
+	 * @param Board $board
133
+	 */
131 134
 	private function generateBoardShared($board, $userId) {
132 135
 		$notification = $this->notificationManager->createNotification();
133 136
 		$notification
Please login to merge, or discard this patch.
lib/Service/CardService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@
 block discarded – undo
49 49
 		return $this->cardMapper->find($cardId);
50 50
 	}
51 51
 
52
+	/**
53
+	 * @param integer $order
54
+	 */
52 55
 	public function create($title, $stackId, $type, $order, $owner) {
53 56
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
54 57
 		if($this->boardService->isArchived($this->stackMapper, $stackId)) {
Please login to merge, or discard this patch.