nextcloud / deck

lib/Service/PermissionService.php

Doc Comments +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
 	 * Find a list of all users (including the ones from groups)
 	 * Required to allow assigning them to cards
 	 *
-	 * @param $boardId
+	 * @param integer|null $boardId
 	 * @return array
 	 */
 	public function findUsers($boardId) {

Spacing +5 added lines, -5 removed lines

@@ -188,8 +188,8 @@ 
 	 */
 	public function findUsers($boardId) {
 		// cache users of a board so we don't query them for every cards
-		if (array_key_exists((string)$boardId, $this->users)) {
-			return $this->users[(string)$boardId];
+		if (array_key_exists((string) $boardId, $this->users)) {
+			return $this->users[(string) $boardId];
 		}
 		try {
 			$board = $this->boardMapper->find($boardId);
@@ -206,14 +206,14 @@ 
 				$user = $this->userManager->get($acl->getParticipant());
 				$users[$user->getUID()] = new User($user);
 			}
-			if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 				$group = $this->groupManager->get($acl->getParticipant());
 				foreach ($group->getUsers() as $user) {
 					$users[$user->getUID()] = new User($user);
 				}
 			}
 		}
-		$this->users[(string)$boardId] = $users;
-		return $this->users[(string)$boardId];
+		$this->users[(string) $boardId] = $users;
+		return $this->users[(string) $boardId];
 	}
 }
\ No newline at end of file

lib/Db/RelationalEntity.php

Doc Comments +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
 	/**
 	 * Mark a property as relation so it will not get updated using Mapper::update
-	 * @param $property string Name of the property
+	 * @param string $property string Name of the property
 	 */
 	public function addRelation($property) {
 		if (!in_array($property, $this->_relations, true)) {
@@ -42,7 +42,7 @@ 
 
 	/**
 	 * Mark a property as resolvable via resolveRelation()
-	 * @param $property string Name of the property
+	 * @param string $property string Name of the property
 	 */
 	public function addResolvable($property) {
 		$this->_resolvedProperties[$property] = null;

Spacing +10 added lines, -10 removed lines

@@ -77,7 +77,7 @@ 
 			}
 		}
 		foreach ($this->_resolvedProperties as $property => $value) {
-			if($value !== null) {
+			if ($value !== null) {
 				$json[$property] = $value;
 			}
 		}
@@ -107,29 +107,29 @@ 
 	 */
 	public function resolveRelation($property, $resolver) {
 		$result = null;
-		if($property !== null && $this->$property !== null) {
+		if ($property !== null && $this->$property !== null) {
 			$result = $resolver($this->$property);
 		}
 
-		if($result instanceof RelationalObject || $result === null) {
+		if ($result instanceof RelationalObject || $result === null) {
 			$this->_resolvedProperties[$property] = $result;
 		} else {
 			throw new \Exception('resolver must return an instance of RelationalObject');
 		}
 	}
 
-	public function __call($methodName, $args){
-		$attr = lcfirst( substr($methodName, 7) );
-		if(array_key_exists($attr, $this->_resolvedProperties) && strpos($methodName, 'resolve') === 0) {
-			if($this->_resolvedProperties[$attr] !== null) {
+	public function __call($methodName, $args) {
+		$attr = lcfirst(substr($methodName, 7));
+		if (array_key_exists($attr, $this->_resolvedProperties) && strpos($methodName, 'resolve') === 0) {
+			if ($this->_resolvedProperties[$attr] !== null) {
 				return $this->_resolvedProperties[$attr];
 			}
 			return $this->getter($attr);
 		}
 
-		$attr = lcfirst( substr($methodName, 3) );
-		if(array_key_exists($attr, $this->_resolvedProperties) && strpos($methodName, 'set') === 0) {
-			if(!is_scalar($args[0])) {
+		$attr = lcfirst(substr($methodName, 3));
+		if (array_key_exists($attr, $this->_resolvedProperties) && strpos($methodName, 'set') === 0) {
+			if (!is_scalar($args[0])) {
 				$args[0] = $args[0]['primaryKey'];
 			}
 			parent::setter($attr, $args);

lib/Notification/NotificationHelper.php

Doc Comments +4 added lines, -1 removed lines

@@ -98,7 +98,7 @@ 
 	 * Send notifications that a board was shared with a user/group
 	 *
 	 * @param $boardId
-	 * @param $acl
+	 * @param Acl $acl
 	 * @throws \InvalidArgumentException
 	 */
 	public function sendBoardShared($boardId, $acl) {
@@ -128,6 +128,9 @@ 
 		return $this->boards[$boardId];
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function generateBoardShared($board, $userId) {
 		$notification = $this->notificationManager->createNotification();
 		$notification

lib/Db/RelationalObject.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 	 * @throws \Exception
 	 */
 	public function getObjectSerialization() {
-		if($this->object instanceof \JsonSerializable) {
+		if ($this->object instanceof \JsonSerializable) {
 			$this->object->jsonSerialize();
 		} else {
 			throw new \Exception('jsonSerialize is not implemented on ' . get_class($this));

lib/Db/Card.php

Spacing +6 added lines, -6 removed lines

@@ -64,7 +64,7 @@ 
 	}
 
 	public function getDuedate($isoFormat = false) {
-		if($this->duedate === null) {
+		if ($this->duedate === null) {
 			return null;
 		}
 		$dt = new DateTime($this->duedate);
@@ -80,16 +80,16 @@ 
 		$due = strtotime($this->duedate);
 
 		$today = new DateTime();
-		$today->setTime( 0, 0);
+		$today->setTime(0, 0);
 
 		$match_date = new DateTime($this->duedate);
 
-		$match_date->setTime( 0, 0);
+		$match_date->setTime(0, 0);
 
-		$diff = $today->diff( $match_date );
-		$diffDays = (integer)$diff->format('%R%a'); // Extract days count in interval
+		$diff = $today->diff($match_date);
+		$diffDays = (integer) $diff->format('%R%a'); // Extract days count in interval
 
-		if($due !== false) {
+		if ($due !== false) {
 			if ($diffDays === 1) {
 				$json['overdue'] = self::DUEDATE_NEXT;
 			}

lib/Db/BoardMapper.php

Spacing +8 added lines, -8 removed lines

@@ -140,7 +140,7 @@ 
 
 	public function findToDelete() {
 		// add buffer of 5 min
-		$timeLimit = time()-(60*5);
+		$timeLimit = time() - (60 * 5);
 		$sql = 'SELECT id, title, owner, color, archived, deleted_at FROM `*PREFIX*deck_boards` ' .
 			'WHERE `deleted_at` > 0 AND `deleted_at` < ?';
 		return $this->findEntities($sql, [$timeLimit]);
@@ -177,21 +177,21 @@ 
 		return $id;
 	}
 
-	public function mapAcl(Acl &$acl) {
+	public function mapAcl(Acl & $acl) {
 		$userManager = $this->userManager;
 		$groupManager = $this->groupManager;
 		$acl->resolveRelation('participant', function($participant) use (&$acl, &$userManager, &$groupManager) {
-			if($acl->getType() === Acl::PERMISSION_TYPE_USER) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 				$user = $userManager->get($participant);
-				if($user !== null) {
+				if ($user !== null) {
 					return new User($user);
 				}
 				\OC::$server->getLogger()->debug('User ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
 				return null;
 			}
-			if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 				$group = $groupManager->get($participant);
-				if($group !== null) {
+				if ($group !== null) {
 					return new Group($group);
 				}
 				\OC::$server->getLogger()->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
@@ -204,11 +204,11 @@ 
 	/**
 	 * @param Board $board
 	 */
-	public function mapOwner(Board &$board) {
+	public function mapOwner(Board & $board) {
 		$userManager = $this->userManager;
 		$board->resolveRelation('owner', function($owner) use (&$userManager) {
 			$user = $userManager->get($owner);
-			if($user !== null) {
+			if ($user !== null) {
 				return new User($user);
 			}
 			return null;