nextcloud / deck

lib/Middleware/SharingMiddleware.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 */
 	public function afterException($controller, $methodName, \Exception $exception) {
 		if ($exception instanceof StatusException) {
-			if($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
+			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
 				$this->logger->logException($exception);
 			}
 			return new JSONResponse([

lib/Service/BoardService.php

Spacing +4 added lines, -4 removed lines

@@ -53,10 +53,10 @@ 
 		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups']);
 		$complete = array_merge($userBoards, $groupBoards);
 		$result = [];
-		foreach($complete as &$item) {
-			if(!array_key_exists($item->getId(), $result)) {
+		foreach ($complete as &$item) {
+			if (!array_key_exists($item->getId(), $result)) {
 				$this->boardMapper->mapOwner($item);
-				if($item->getAcl() !== null) {
+				if ($item->getAcl() !== null) {
 					foreach ($item->getAcl() as &$acl) {
 						$this->boardMapper->mapAcl($acl);
 					}
@@ -73,7 +73,7 @@ 
 		$board = $this->boardMapper->find($boardId, true, true);
 		$this->boardMapper->mapOwner($board);
 		foreach ($board->getAcl() as &$acl) {
-			if($acl !== null) {
+			if ($acl !== null) {
 				$this->boardMapper->mapAcl($acl);
 			}
 		}

lib/Migration/UnknownUsers.php

Spacing +4 added lines, -4 removed lines

@@ -64,15 +64,15 @@
 			$acls = $this->aclMapper->findAll($board->getId());
 			/** @var Acl $acl */
 			foreach ($acls as $acl) {
-				if($acl->getType() === Acl::PERMISSION_TYPE_USER) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 					$user = $this->userManager->get($acl->getParticipant());
-					if($user === null) {
+					if ($user === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}
-				if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 					$group = $this->groupManager->get($acl->getParticipant());
-					if($group === null) {
+					if ($group === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}

lib/Db/CardMapper.php

Spacing +2 added lines, -2 removed lines

@@ -129,11 +129,11 @@
 		return $row['id'];
 	}
 
-	public function mapOwner(Card &$card) {
+	public function mapOwner(Card & $card) {
 		$userManager = $this->userManager;
 		$card->resolveRelation('owner', function($owner) use (&$userManager) {
 			$user = $userManager->get($owner);
-			if($user !== null) {
+			if ($user !== null) {
 				return new User($user);
 			}
 			return null;

Doc Comments +4 added lines, -1 removed lines

@@ -92,7 +92,7 @@ 
 
 	/**
 	 * @param $id
-	 * @return RelationalEntity if not found
+	 * @return Entity if not found
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException
 	 */
@@ -136,6 +136,9 @@ 
 		return parent::delete($entity);
 	}
 
+	/**
+	 * @param integer $stackId
+	 */
 	public function deleteByStack($stackId) {
 		$cards = $this->findAllByStack($stackId);
 		foreach ($cards as $card) {

lib/Service/StackService.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
 
 	public function create($title, $boardId, $order) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = new Stack();
@@ -102,7 +102,7 @@ 
 
 	public function update($id, $title, $boardId, $order) {
 		$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->stackMapper, $id)) {
+		if ($this->boardService->isArchived($this->stackMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = $this->stackMapper->find($id);

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
 		return $stacks;
 	}
 
+	/**
+	 * @param integer $order
+	 */
 	public function create($title, $boardId, $order) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
 		if($this->boardService->isArchived(null, $boardId)) {

Unused Use Statements -3 removed lines

@@ -26,10 +26,7 @@
 use OCA\Deck\Db\Acl;
 use OCA\Deck\Db\CardMapper;
 use OCA\Deck\Db\LabelMapper;
-
-
 use OCA\Deck\Db\Stack;
-
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 

lib/Service/LabelService.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 
 	public function create($title, $color, $boardId) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = new Label();
@@ -63,7 +63,7 @@ 
 
 	public function delete($id) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		return $this->labelMapper->delete($this->find($id));
@@ -71,7 +71,7 @@ 
 
 	public function update($id, $title, $color) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = $this->find($id);

lib/Service/CardService.php

Spacing +9 added lines, -9 removed lines

@@ -52,7 +52,7 @@ 
 
 	public function create($title, $stackId, $type, $order, $owner) {
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->stackMapper, $stackId)) {
+		if ($this->boardService->isArchived($this->stackMapper, $stackId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = new Card();
@@ -67,7 +67,7 @@ 
 
 	public function delete($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		return $this->cardMapper->delete($this->cardMapper->find($id));
@@ -75,7 +75,7 @@ 
 
 	public function update($id, $title, $stackId, $type, $order, $description, $owner, $duedate) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -94,7 +94,7 @@ 
 
 	public function rename($id, $title) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -107,7 +107,7 @@ 
 
 	public function reorder($id, $stackId, $order) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$cards = $this->cardMapper->findAll($stackId);
@@ -138,7 +138,7 @@ 
 
 	public function archive($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -148,7 +148,7 @@ 
 
 	public function unarchive($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -158,7 +158,7 @@ 
 
 	public function assignLabel($cardId, $labelId) {
 		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $cardId)) {
+		if ($this->boardService->isArchived($this->cardMapper, $cardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($cardId);
@@ -170,7 +170,7 @@ 
 
 	public function removeLabel($cardId, $labelId) {
 		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $cardId)) {
+		if ($this->boardService->isArchived($this->cardMapper, $cardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($cardId);

Doc Comments +3 added lines

@@ -49,6 +49,9 @@
 		return $this->cardMapper->find($cardId);
 	}
 
+	/**
+	 * @param integer $order
+	 */
 	public function create($title, $stackId, $type, $order, $owner) {
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
 		if($this->boardService->isArchived($this->stackMapper, $stackId)) {

templates/main.php

Spacing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
 Util::addScript('deck', 'vendor/markdown-it-link-target/dist/markdown-it-link-target.min');
 Util::addScript('deck', 'vendor/jquery-timepicker/jquery.ui.timepicker');
 
-if(!\OC::$server->getConfig()->getSystemValue('debug', false)) {
+if (!\OC::$server->getConfig()->getSystemValue('debug', false)) {
 	Util::addScript('deck', 'public/app');
 } else {
 	// Load seperate JS files when debug mode is enabled
@@ -49,9 +49,9 @@ 
 		'filters' => ['boardFilterAcl', 'cardFilter', 'cardSearchFilter', 'iconWhiteFilter', 'lightenColorFilter', 'orderObjectBy', 'dateFilters', 'textColorFilter'],
 		'service' => ['ApiService', 'BoardService', 'CardService', 'LabelService', 'StackService', 'StatusService'],
 	];
-	foreach($js as $folder=>$files) {
+	foreach ($js as $folder=>$files) {
 		foreach ($files as $file) {
-			Util::addScript('deck', $folder.'/'.$file);
+			Util::addScript('deck', $folder . '/' . $file);
 		}
 	}
 }

lib/AppInfo/Application.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 		$self = &$this;
 		$notificationManager->registerNotifier(function() use (&$self) {
 			return $self->getContainer()->query(Notifier::class);
-		}, function () {
+		}, function() {
 			return ['id' => 'deck', 'name' => 'Deck'];
 		});
 

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use OCP\AppFramework\App;
 use OCA\Deck\Middleware\SharingMiddleware;
 use OCP\IGroup;
-
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IURLGenerator;