nextcloud / deck

lib/Service/BoardService.php

Spacing +10 added lines, -10 removed lines

@@ -104,8 +104,8 @@ 
 	public function findAll($since = -1, $details = null) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
-		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null,  $since);
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
+		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since);
 		$complete = array_merge($userBoards, $groupBoards, $circleBoards);
 		$result = [];
 		/** @var Board $item */
@@ -145,7 +145,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -193,7 +193,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -227,7 +227,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -382,7 +382,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -422,7 +422,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 
@@ -608,7 +608,7 @@ 
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($stacks) === 0) {
+		if (\count($stacks) === 0) {
 			return;
 		}
 
@@ -618,7 +618,7 @@ 
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($labels) === 0) {
+		if (\count($labels) === 0) {
 			return;
 		}
 
@@ -627,7 +627,7 @@ 
 
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
-		if(\count($boardUsers) === 0) {
+		if (\count($boardUsers) === 0) {
 			return;
 		}
 		$board->setUsers(array_values($boardUsers));

Doc Comments +10 added lines, -1 removed lines

@@ -180,7 +180,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return integer
 	 */
 	private function getBoardPrerequisites() {
 		$groups = $this->groupManager->getUserGroupIds(
@@ -658,6 +658,9 @@ 
 		return $newBoard;
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
@@ -668,6 +671,9 @@ 
 		$board->setStacks($stacks);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithLabels($board, $since = -1) {
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
 
@@ -678,6 +684,9 @@ 
 		$board->setLabels($labels);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithUsers($board, $since = -1) {
 		$boardUsers = $this->permissionService->findUsers($board->getId());
 		if(\count($boardUsers) === 0) {

lib/Db/BoardMapper.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\Deck\Db;
 
 use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\AppFramework\QueryException;
 use OCP\IDBConnection;
 use OCP\ILogger;
 use OCP\IUserManager;

Doc Comments +7 added lines, -1 removed lines

@@ -111,7 +111,7 @@ 
 	/**
 	 * Find all boards for a given user
 	 *
-	 * @param $userId
+	 * @param string $userId
 	 * @param $groups
 	 * @param null $limit
 	 * @param null $offset
@@ -139,6 +139,9 @@ 
 		return $entries;
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function findAllByCircles($userId, $limit = null, $offset = null) {
 		if (!$this->circlesEnabled) {
 			return [];
@@ -208,6 +211,9 @@ 
 		return ($board->getOwner() === $userId);
 	}
 
+	/**
+	 * @param integer $id
+	 */
 	public function findBoardId($id) {
 		return $id;
 	}

lib/Service/FullTextSearchService.php

Spacing +8 added lines, -8 removed lines

@@ -98,7 +98,7 @@ 
 
 		try {
 			$this->fullTextSearchManager->createIndex(
-				DeckProvider::DECK_PROVIDER_ID, (string)$cardId, $userId, IIndex::INDEX_FULL
+				DeckProvider::DECK_PROVIDER_ID, (string) $cardId, $userId, IIndex::INDEX_FULL
 			);
 		} catch (FullTextSearchAppNotAvailableException $e) {
 		}
@@ -113,7 +113,7 @@ 
 
 		try {
 			$this->fullTextSearchManager->updateIndexStatus(
-			DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_CONTENT
+			DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_CONTENT
 		);
 		} catch (FullTextSearchAppNotAvailableException $e) {
 		}
@@ -128,7 +128,7 @@ 
 
 		try {
 			$this->fullTextSearchManager->updateIndexStatus(
-				DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_REMOVE
+				DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_REMOVE
 			);
 		} catch (FullTextSearchAppNotAvailableException $e) {
 		}
@@ -139,7 +139,7 @@ 
 	 * @param GenericEvent $e
 	 */
 	public function onBoardShares(GenericEvent $e) {
-		$boardId = (int)$e->getArgument('boardId');
+		$boardId = (int) $e->getArgument('boardId');
 
 		$cards = array_map(
 			function(Card $item) {
@@ -162,7 +162,7 @@ 
 	 * @return IIndexDocument
 	 */
 	public function generateIndexDocumentFromCard(Card $card): IIndexDocument {
-		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string)$card->getId());
+		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string) $card->getId());
 
 		return $document;
 	}
@@ -176,11 +176,11 @@ 
 	 */
 	public function fillIndexDocument(IIndexDocument $document) {
 		/** @var Card $card */
-		$card = $this->cardMapper->find((int)$document->getId());
+		$card = $this->cardMapper->find((int) $document->getId());
 
 		$document->setTitle(($card->getTitle() === null) ? '' : $card->getTitle());
 		$document->setContent(($card->getDescription() === null) ? '' : $card->getDescription());
-		$document->setAccess($this->generateDocumentAccessFromCardId((int)$card->getId()));
+		$document->setAccess($this->generateDocumentAccessFromCardId((int) $card->getId()));
 	}
 
 
@@ -241,7 +241,7 @@ 
 	 * @throws MultipleObjectsReturnedException
 	 */
 	public function getBoardFromCardId(int $cardId): Board {
-		$boardId = (int)$this->cardMapper->findBoardId($cardId);
+		$boardId = (int) $this->cardMapper->findBoardId($cardId);
 		/** @var Board $board */
 		$board = $this->boardMapper->find($boardId);
 

lib/Collaboration/Resources/ResourceProviderCard.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 	}
 
 	/**
-	 * @param $cardId
+	 * @param string $cardId
 	 * @return Board
 	 * @throws DoesNotExistException
 	 * @throws MultipleObjectsReturnedException

Spacing +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
 		} catch (QueryException $e) {
 		}
 		if ($cardId !== null) {
-			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string)$cardId, null);
+			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string) $cardId, null);
 			$resourceManager->invalidateAccessCacheForResource($resource);
 		} else {
 			$resourceManager->invalidateAccessCacheForProvider($this);

lib/Service/StackService.php

Doc Comments +2 added lines, -2 removed lines

@@ -326,8 +326,8 @@
 	}
 
 	/**
-	 * @param $id
-	 * @param $order
+	 * @param integer $id
+	 * @param integer $order
 	 *
 	 * @return array
 	 * @throws \OCA\Deck\NoPermissionException

lib/AppInfo/Application.php

Spacing +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
 	 * @throws \OCP\AppFramework\QueryException
 	 */
 	protected function registerCommentsEventHandler() {
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
 			return $this->getContainer()->query(CommentEventHandler::class);
 		});
 	}
@@ -196,7 +196,7 @@ 
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProvider::class);
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProviderCard::class);
 
-		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function () {
+		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function() {
 			\OCP\Util::addScript('deck', 'collections');
 		});
 	}

lib/Controller/CardController.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 	 * @return array
 	 */
 	public function reorder($cardId, $stackId, $order) {
-		return $this->cardService->reorder((int)$cardId, (int)$stackId, (int)$order);
+		return $this->cardService->reorder((int) $cardId, (int) $stackId, (int) $order);
 	}
 
 	/**

lib/Controller/StackController.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 	 * @return array
 	 */
 	public function reorder($stackId, $order) {
-		return $this->stackService->reorder((int)$stackId, (int)$order);
+		return $this->stackService->reorder((int) $stackId, (int) $order);
 	}
 
 	/**