Passed
Push — master ( db5915...22087f )
by Julius
02:53
created
lib/Middleware/ExceptionMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Deck\Middleware;
25 25
 
26
-use OCA\Deck\Controller\PageController;
27 26
 use OCA\Deck\StatusException;
28 27
 use OCP\AppFramework\Db\DoesNotExistException;
29 28
 use OCP\AppFramework\Middleware;
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	 * @throws \OCP\AppFramework\QueryException
156 156
 	 */
157 157
 	protected function registerCommentsEventHandler() {
158
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
158
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
159 159
 			return $this->getContainer()->query(CommentEventHandler::class);
160 160
 		});
161 161
 	}
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 		/** @var IManager $resourceManager */
176 176
 		$resourceManager = $this->getContainer()->query(IManager::class);
177 177
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProvider::class);
178
-		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function () {
178
+		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function() {
179 179
 			\OCP\Util::addScript('deck', 'build/collections');
180 180
 		});
181 181
 	}
Please login to merge, or discard this patch.
lib/Service/BoardService.php 2 patches
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	}
171 171
 
172 172
 	/**
173
-	 * @return array
173
+	 * @return integer
174 174
 	 */
175 175
 	private function getBoardPrerequisites() {
176 176
 		$groups = $this->groupManager->getUserGroupIds(
@@ -605,6 +605,9 @@  discard block
 block discarded – undo
605 605
 		return $delete;
606 606
 	}
607 607
 
608
+	/**
609
+	 * @param Board $board
610
+	 */
608 611
 	private function enrichWithStacks($board, $since = -1) {
609 612
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
610 613
 
@@ -615,6 +618,9 @@  discard block
 block discarded – undo
615 618
 		$board->setStacks($stacks);
616 619
 	}
617 620
 
621
+	/**
622
+	 * @param Board $board
623
+	 */
618 624
 	private function enrichWithLabels($board, $since = -1) {
619 625
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
620 626
 
@@ -625,6 +631,9 @@  discard block
 block discarded – undo
625 631
 		$board->setLabels($labels);
626 632
 	}
627 633
 
634
+	/**
635
+	 * @param Board $board
636
+	 */
628 637
 	private function enrichWithUsers($board, $since = -1) {
629 638
 		$boardUsers = $this->permissionService->findUsers($board->getId());
630 639
 		if(\count($boardUsers) === 0) {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
104 104
 	public function findAll($since = -1, $details = null) {
105 105
 		$userInfo = $this->getBoardPrerequisites();
106 106
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
107
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
108
-		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null,  $since);
107
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
108
+		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since);
109 109
 		$complete = array_merge($userBoards, $groupBoards, $circleBoards);
110 110
 		$result = [];
111 111
 		/** @var Board $item */
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	 */
146 146
 	public function find($boardId) {
147 147
 
148
-		if ( is_numeric($boardId) === false ) {
148
+		if (is_numeric($boardId) === false) {
149 149
 			throw new BadRequestException('board id must be a number');
150 150
 		}
151 151
 
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 	 */
194 194
 	public function isArchived($mapper, $id) {
195 195
 
196
-		if (is_numeric($id) === false)  {
196
+		if (is_numeric($id) === false) {
197 197
 			throw new BadRequestException('id must be a number');
198 198
 		}
199 199
 
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 			throw new BadRequestException('mapper must be provided');
228 228
 		}
229 229
 
230
-		if (is_numeric($id) === false)  {
230
+		if (is_numeric($id) === false) {
231 231
 			throw new BadRequestException('id must be a number');
232 232
 		}
233 233
 
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
 	 * @throws BadRequestException
383 383
 	 */
384 384
 	public function deleteForce($id) {
385
-		if (is_numeric($id) === false)  {
385
+		if (is_numeric($id) === false) {
386 386
 			throw new BadRequestException('id must be a number');
387 387
 		}
388 388
 
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
 			throw new BadRequestException('color must be provided');
423 423
 		}
424 424
 
425
-		if ( is_bool($archived) === false ) {
425
+		if (is_bool($archived) === false) {
426 426
 			throw new BadRequestException('archived must be a boolean');
427 427
 		}
428 428
 
@@ -608,7 +608,7 @@  discard block
 block discarded – undo
608 608
 	private function enrichWithStacks($board, $since = -1) {
609 609
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
610 610
 
611
-		if(\count($stacks) === 0) {
611
+		if (\count($stacks) === 0) {
612 612
 			return;
613 613
 		}
614 614
 
@@ -618,7 +618,7 @@  discard block
 block discarded – undo
618 618
 	private function enrichWithLabels($board, $since = -1) {
619 619
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
620 620
 
621
-		if(\count($labels) === 0) {
621
+		if (\count($labels) === 0) {
622 622
 			return;
623 623
 		}
624 624
 
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
 
628 628
 	private function enrichWithUsers($board, $since = -1) {
629 629
 		$boardUsers = $this->permissionService->findUsers($board->getId());
630
-		if(\count($boardUsers) === 0) {
630
+		if (\count($boardUsers) === 0) {
631 631
 			return;
632 632
 		}
633 633
 		$board->setUsers(array_values($boardUsers));
Please login to merge, or discard this patch.
lib/Service/FullTextSearchService.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 
99 99
 		try {
100 100
 			$this->fullTextSearchManager->createIndex(
101
-				DeckProvider::DECK_PROVIDER_ID, (string)$cardId, $userId, IIndex::INDEX_FULL
101
+				DeckProvider::DECK_PROVIDER_ID, (string) $cardId, $userId, IIndex::INDEX_FULL
102 102
 			);
103 103
 		} catch (FullTextSearchAppNotAvailableException $e) {
104 104
 		}
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
 		try {
115 115
 			$this->fullTextSearchManager->updateIndexStatus(
116
-			DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_CONTENT
116
+			DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_CONTENT
117 117
 		);
118 118
 		} catch (FullTextSearchAppNotAvailableException $e) {
119 119
 		}
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 		try {
130 130
 			$this->fullTextSearchManager->updateIndexStatus(
131
-				DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_REMOVE
131
+				DeckProvider::DECK_PROVIDER_ID, (string) $cardId, IIndex::INDEX_REMOVE
132 132
 			);
133 133
 		} catch (FullTextSearchAppNotAvailableException $e) {
134 134
 		}
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	 * @param GenericEvent $e
140 140
 	 */
141 141
 	public function onBoardShares(GenericEvent $e) {
142
-		$boardId = (int)$e->getArgument('boardId');
142
+		$boardId = (int) $e->getArgument('boardId');
143 143
 
144 144
 		$cards = array_map(
145 145
 			function(Card $item) {
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 	 * @return IIndexDocument
163 163
 	 */
164 164
 	public function generateIndexDocumentFromCard(Card $card): IIndexDocument {
165
-		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string)$card->getId());
165
+		$document = new IndexDocument(DeckProvider::DECK_PROVIDER_ID, (string) $card->getId());
166 166
 
167 167
 		return $document;
168 168
 	}
@@ -176,11 +176,11 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function fillIndexDocument(IIndexDocument $document) {
178 178
 		/** @var Card $card */
179
-		$card = $this->cardMapper->find((int)$document->getId());
179
+		$card = $this->cardMapper->find((int) $document->getId());
180 180
 
181 181
 		$document->setTitle(($card->getTitle() === null) ? '' : $card->getTitle());
182 182
 		$document->setContent(($card->getDescription() === null) ? '' : $card->getDescription());
183
-		$document->setAccess($this->generateDocumentAccessFromCardId((int)$card->getId()));
183
+		$document->setAccess($this->generateDocumentAccessFromCardId((int) $card->getId()));
184 184
 	}
185 185
 
186 186
 
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	 * @throws MultipleObjectsReturnedException
242 242
 	 */
243 243
 	public function getBoardFromCardId(int $cardId): Board {
244
-		$boardId = (int)$this->cardMapper->findBoardId($cardId);
244
+		$boardId = (int) $this->cardMapper->findBoardId($cardId);
245 245
 		/** @var Board $board */
246 246
 		$board = $this->boardMapper->find($boardId);
247 247
 
Please login to merge, or discard this patch.