nextcloud / deck

lib/Controller/CardApiController.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
  namespace OCA\Deck\Controller;
 
  use OCP\AppFramework\ApiController;
- use OCP\AppFramework\Http;
  use OCP\AppFramework\Http\DataResponse;
  use OCP\IRequest;
  use OCA\Deck\Service\CardService;

Indentation +4 added lines, -4 removed lines

@@ -31,10 +31,10 @@
  use OCA\Deck\Service\CardService;
 
  /**
- * Class BoardApiController
- *
- * @package OCA\Deck\Controller
- */
+  * Class BoardApiController
+  *
+  * @package OCA\Deck\Controller
+  */
 class CardApiController extends ApiController {
 	private $cardService;
 	private $userId;

Spacing +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
 	 * Assign a user to a card
 	 */
 	public function assignUser($userId) {
-		$card = $this->cardService->assignUser($this->request->getParam('cardId'), $userId);;
+		$card = $this->cardService->assignUser($this->request->getParam('cardId'), $userId); ;
 		return new DataResponse($card, HTTP::STATUS_OK);
 	}
 

lib/Db/BoardMapper.php

Doc Comments +3 added lines

@@ -173,6 +173,9 @@
 		return ($board->getOwner() === $userId);
 	}
 
+	/**
+	 * @param string $id
+	 */
 	public function findBoardId($id) {
 		return $id;
 	}

appinfo/app.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
  *
  */
 
-if ((@include_once __DIR__ . '/../vendor/autoload.php')===false) {
+if ((@include_once __DIR__ . '/../vendor/autoload.php') === false) {
 	throw new Exception('Cannot include autoload. Did you run install dependencies using composer?');
 }
 

lib/Db/DeckMapper.php

Doc Comments +3 added lines

@@ -45,6 +45,9 @@
 		return $this->findEntity($sql, [$id]);
 	}
 
+	/**
+	 * @param string $sql
+	 */
 	protected function execute($sql, array $params = [], $limit = null, $offset = null) {
 		return parent::execute($sql, $params, $limit, $offset);
 	}

lib/Db/LabelMapper.php

Doc Comments +6 added lines

@@ -66,6 +66,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param integer $labelId
+	 */
 	public function deleteLabelAssignments($labelId) {
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE label_id = ?';
 		$stmt = $this->db->prepare($sql);
@@ -73,6 +76,9 @@ 
 		$stmt->execute();
 	}
 
+	/**
+	 * @param integer $cardId
+	 */
 	public function deleteLabelAssignmentsForCard($cardId) {
 		$sql = 'DELETE FROM `*PREFIX*deck_assigned_labels` WHERE card_id = ?';
 		$stmt = $this->db->prepare($sql);

lib/Service/StackService.php

Unused Use Statements -1 removed lines

@@ -34,7 +34,6 @@
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 use OCA\Deck\BadRequestException;
-use OCP\Comments\ICommentsManager;
 
 
 class StackService {

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 	private function enrichStackWithCards($stack, $since = -1) {
 		$cards = $this->cardMapper->findAll($stack->getId(), null, null, $since);
 
-		if(\count($cards) === 0) {
+		if (\count($cards) === 0) {
 			return;
 		}
 
@@ -216,7 +216,7 @@ 
 	 */
 	public function delete($id) {
 
-		if ( is_numeric($id) === false ) {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('stack id must be a number');
 		}
 

lib/AppInfo/Application.php

Spacing +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
 	}
 
 	protected function registerCommentsEventHandler() {
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
 			return $this->getContainer()->query(CommentEventHandler::class);
 		});
 	}

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 use OCA\Deck\Middleware\ExceptionMiddleware;
 use OCA\Deck\Notification\Notifier;
 use OCP\AppFramework\App;
-use OCA\Deck\Middleware\SharingMiddleware;
 use OCP\Comments\CommentsEntityEvent;
 use OCP\IGroup;
 use OCP\IUser;

lib/Activity/ActivityManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	}
 
 	/**
-	 * @param $subjectIdentifier
+	 * @param string $subjectIdentifier
 	 * @param array $subjectParams
 	 * @param bool $ownActivity
 	 * @return string

Spacing +6 added lines, -6 removed lines

@@ -133,7 +133,7 @@ 
 		$subject = '';
 		switch ($subjectIdentifier) {
 			case self::SUBJECT_BOARD_CREATE:
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
 				break;
 			case self::SUBJECT_BOARD_DELETE:
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -373,7 +373,7 @@ 
 				break;
 		}
 
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
 			$card = $subjectParams['card'];
 			if ($card->getLastEditor() === $this->userId) {
 				return null;
@@ -392,7 +392,7 @@ 
 		$event->setApp('deck')
 			->setType($eventType)
 			->setAuthor($author === null ? $this->userId : $author)
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
 			->setTimestamp(time());
 
@@ -453,7 +453,7 @@ 
 					$objectId = $entity->getObjectId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->cardMapper->find($objectId);
 		}
@@ -468,11 +468,11 @@ 
 					$objectId = $entity->getBoardId();
 					break;
 				default:
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 			}
 			return $this->boardMapper->find($objectId);
 		}
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
 	}
 
 	private function findDetailsForStack($stackId) {

lib/Service/CardService.php

Spacing +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
 		$card->setLabels($this->labelMapper->findAssignedLabelsForCard($cardId));
 		$card->setAttachmentCount($this->attachmentService->count($cardId));
 		$user = $this->userManager->get($this->currentUser);
-		$lastRead = $this->commentsManager->getReadMark('deckCard', (string)$card->getId(), $user);
-		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string)$card->getId(), $lastRead);
+		$lastRead = $this->commentsManager->getReadMark('deckCard', (string) $card->getId(), $user);
+		$count = $this->commentsManager->getNumberOfCommentsForObject('deckCard', (string) $card->getId(), $lastRead);
 		$card->setCommentsUnread($count);
 	}