nextcloud / deck

lib/Controller/PageController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	public function index() {
 		$params = [
 			'user' => $this->userId,
-			'maxUploadSize' => (int)\OCP\Util::uploadLimit(),
+			'maxUploadSize' => (int) \OCP\Util::uploadLimit(),
 			'canCreate' => $this->permissionService->canCreate()
 		];
 

lib/Activity/DeckProvider.php

Doc Comments +14 added lines

@@ -189,6 +189,9 @@ 
 		return $event;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForBoard($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -200,6 +203,10 @@ 
 		}
 		return $params;
 	}
+
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForStack($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -211,6 +218,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $paramName
+	 */
 	private function parseParamForAttachment($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
@@ -285,6 +295,7 @@ 
 	 *
 	 * @param $subjectParams
 	 * @param $params
+	 * @param IEvent $event
 	 * @return mixed
 	 */
 	private function parseParamForChanges($subjectParams, $params, $event) {
@@ -312,6 +323,9 @@ 
 		return $params;
 	}
 
+	/**
+	 * @param string $endpoint
+	 */
 	public function deckUrl($endpoint) {
 		return $this->urlGenerator->linkToRouteAbsolute('deck.page.index') . '#!' . $endpoint;
 	}

Spacing +2 added lines, -2 removed lines

@@ -281,11 +281,11 @@
 		if (array_key_exists('comment', $subjectParams)) {
 			/** @var IComment $comment */
 			try {
-				$comment = $this->commentsManager->get((int)$subjectParams['comment']);
+				$comment = $this->commentsManager->get((int) $subjectParams['comment']);
 				$event->setParsedMessage($comment->getMessage());
 			} catch (NotFoundException $e) {
 			}
-			$params['comment'] =[
+			$params['comment'] = [
 				'type' => 'highlight',
 				'id' => $subjectParams['comment'],
 				'name' => $comment->getMessage()

lib/Cron/CardDescriptionActivity.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 	private $cardMapper;
 
 	public function __construct(ActivityManager $activityManager, CardMapper $cardMapper) {
-		$this->activityManager  = $activityManager;
+		$this->activityManager = $activityManager;
 		$this->cardMapper = $cardMapper;
 	}
 

lib/Activity/CommentEventHandler.php

Spacing +3 added lines, -3 removed lines

@@ -50,12 +50,12 @@ 
 	 * @param CommentsEvent $event
 	 */
 	public function handle(CommentsEvent $event) {
-		if($event->getComment()->getObjectType() !== 'deckCard') {
+		if ($event->getComment()->getObjectType() !== 'deckCard') {
 			return;
 		}
 
 		$eventType = $event->getEvent();
-		if( $eventType === CommentsEvent::EVENT_ADD
+		if ($eventType === CommentsEvent::EVENT_ADD
 		) {
 			$this->notificationHandler($event);
 			$this->activityHandler($event);
@@ -65,7 +65,7 @@ 
 		$applicableEvents = [
 			CommentsEvent::EVENT_UPDATE
 		];
-		if(in_array($eventType, $applicableEvents)) {
+		if (in_array($eventType, $applicableEvents)) {
 			$this->notificationHandler($event);
 			return;
 		}

lib/Controller/BoardApiController.php

Unused Use Statements -2 removed lines

@@ -26,10 +26,8 @@
 
 use OCA\Deck\StatusException;
 use OCP\AppFramework\ApiController;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\IRequest;
-
 use OCA\Deck\Service\BoardService;
 use Sabre\HTTP\Util;
 

lib/Notification/NotificationHelper.php

Doc Comments +6 added lines

@@ -95,6 +95,9 @@ 
 		$this->cardMapper->markNotified($card);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function markDuedateAsRead($card) {
 		$notification = $this->notificationManager->createNotification();
 		$notification
@@ -104,6 +107,9 @@ 
 		$this->notificationManager->markProcessed($notification);
 	}
 
+	/**
+	 * @param \OCA\Deck\Db\Card $card
+	 */
 	public function sendCardAssigned($card, $userId) {
 		$boardId = $this->cardMapper->findBoardId($card->getId());
 		$board = $this->getBoard($boardId);

lib/Service/LabelService.php

Spacing +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
 
 		$boardLabels = $this->labelMapper->findAll($boardId);
 		if (\is_array($boardLabels)) {
-			foreach($boardLabels as $boardLabel) {
+			foreach ($boardLabels as $boardLabel) {
 				if ($boardLabel->getTitle() === $title) {
 					throw new BadRequestException('title must be unique');
 					break;
@@ -168,7 +168,7 @@ 
 
 		$boardLabels = $this->labelMapper->findAll($label->getBoardId());
 		if (\is_array($boardLabels)) {
-			foreach($boardLabels as $boardLabel) {
+			foreach ($boardLabels as $boardLabel) {
 				if ($boardLabel->getId() === $label->getId()) {
 					continue;
 				}

lib/Service/BoardService.php

Doc Comments +4 added lines, -1 removed lines

@@ -158,7 +158,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return integer
 	 */
 	private function getBoardPrerequisites() {
 		$groups = $this->groupManager->getUserGroupIds(
@@ -532,6 +532,9 @@ 
 		return $this->aclMapper->delete($acl);
 	}
 
+	/**
+	 * @param Board $board
+	 */
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 

Spacing +8 added lines, -8 removed lines

@@ -96,8 +96,8 @@ 
 	public function findAll($since = 0) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
-		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);
-		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null,  $since);
+		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'], null, null, $since);
+		$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since);
 		$complete = array_merge($userBoards, $groupBoards, $circleBoards);
 		$result = [];
 		/** @var Board $item */
@@ -133,7 +133,7 @@ 
 	 */
 	public function find($boardId) {
 
-		if ( is_numeric($boardId) === false ) {
+		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('board id must be a number');
 		}
 
@@ -182,7 +182,7 @@ 
 	 */
 	public function isArchived($mapper, $id) {
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -216,7 +216,7 @@ 
 			throw new BadRequestException('mapper must be provided');
 		}
 
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -354,7 +354,7 @@ 
 	 * @throws BadRequestException
 	 */
 	public function deleteForce($id) {
-		if (is_numeric($id) === false)  {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('id must be a number');
 		}
 
@@ -388,7 +388,7 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-		if ( is_bool($archived) === false ) {
+		if (is_bool($archived) === false) {
 			throw new BadRequestException('archived must be a boolean');
 		}
 
@@ -536,7 +536,7 @@ 
 	private function enrichWithStacks($board, $since = -1) {
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
 
-		if(\count($stacks) === 0) {
+		if (\count($stacks) === 0) {
 			return;
 		}
 

lib/Collaboration/Resources/ResourceProvider.php

Doc Comments -1 removed lines

@@ -55,7 +55,6 @@
 	/**
 	 * Get the type of a resource
 	 *
-	 * @param IResource $resource
 	 * @return string
 	 * @since 15.0.0
 	 */

Unused Use Statements -2 removed lines

@@ -25,7 +25,6 @@ 
 
 
 use OCA\Deck\Db\Acl;
-use OCA\Deck\Db\Board;
 use OCA\Deck\Db\BoardMapper;
 use OCA\Deck\Service\PermissionService;
 use OCP\AppFramework\Db\DoesNotExistException;
@@ -34,7 +33,6 @@ 
 use OCP\Collaboration\Resources\IManager;
 use OCP\Collaboration\Resources\IProvider;
 use OCP\Collaboration\Resources\IResource;
-use OCP\Collaboration\Resources\ResourceException;
 use OCP\IUser;
 
 class ResourceProvider implements IProvider {

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 		} catch (QueryException $e) {
 		}
 		if ($boardId !== null) {
-			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string)$boardId, null);
+			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string) $boardId, null);
 			$resourceManager->invalidateAccessCacheForResource($resource);
 		} else {
 			$resourceManager->invalidateAccessCacheForProvider($this);