Inspection of "Pico CMS for Nextcloud v1.0.0 (WIP)" - nextcloud/cms_pico - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#77)

by Daniel

created 2019-08-04 19:57 UTC

Status

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -29,8 +29,7 @@
 block discarded – undo
 use OCP\Files\InvalidPathException;
 use OCP\Files\NotPermittedException;
 
-interface NodeInterface
-{
+interface NodeInterface {
 	/**
 	 * @param string $name
 	 *

Please login to merge, or discard this patch.

lib/Files/AbstractNode.php 2 patches

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -115,7 +115,7 @@  discard block
 block discarded – undo
 	 */
 	public function isReadable(): bool
 	{
-		return ($this->getPermissions() & Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
+		return ($this->getPermissions()&Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
 	}
 
 	/**
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
 	 */
 	public function isUpdateable(): bool
 	{
-		return ($this->getPermissions() & Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
+		return ($this->getPermissions()&Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
 	}
 
 	/**
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	 */
 	public function isDeletable(): bool
 	{
-		return ($this->getPermissions() & Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
+		return ($this->getPermissions()&Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
 	}
 
 	/**
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
 	 */
 	protected function assertValidFileName(string $name)
 	{
-		if (in_array($name, [ '', '.', '..' ], true)) {
+		if (in_array($name, ['', '.', '..'], true)) {
 			throw new InvalidPathException();
 		}
 		if ((strpos($name, '/') !== false) || (strpos($name, '\\') !== false)) {

Please login to merge, or discard this patch.

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -27,8 +27,7 @@
 block discarded – undo
 use OCP\Constants;
 use OCP\Files\InvalidPathException;
 
-abstract class AbstractNode implements NodeInterface
-{
+abstract class AbstractNode implements NodeInterface {
 	/**
 	 * {@inheritDoc}
 	 */

Please login to merge, or discard this patch.

lib/Files/AbstractStorageNode.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -29,8 +29,7 @@
 block discarded – undo
 use OCP\Files\InvalidPathException;
 use OCP\Files\Node as OCNode;
 
-abstract class AbstractStorageNode extends AbstractNode implements NodeInterface
-{
+abstract class AbstractStorageNode extends AbstractNode implements NodeInterface {
 	/** @var OCNode */
 	protected $node;
 

Please login to merge, or discard this patch.

lib/Service/ThemesService.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,8 +30,7 @@
 block discarded – undo
 use OCA\CMSPico\Files\FolderInterface;
 use OCP\Files\NotFoundException;
 
-class ThemesService
-{
+class ThemesService {
 	/** @var ConfigService */
 	private $configService;
 

Please login to merge, or discard this patch.

lib/Service/PluginsService.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,8 +31,7 @@
 block discarded – undo
 use OCP\Files\InvalidPathException;
 use OCP\Files\NotFoundException;
 
-class PluginsService
-{
+class PluginsService {
 	/** @var ConfigService */
 	private $configService;
 

Please login to merge, or discard this patch.

appinfo/routes.php 1 patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -32,20 +32,20 @@  discard block
 block discarded – undo
 			'name' => 'Pico#getAsset',
 			'url' => '/pico/{site}/assets/{asset}',
 			'verb' => 'GET',
-			'requirements' => [ 'asset' => '.+' ]
+			'requirements' => ['asset' => '.+']
 		],
 		[
 			'name' => 'Pico#getAsset',
 			'postfix' => 'ETag',
 			'url' => '/pico/{site}/assets_{assetsETag}/{asset}',
 			'verb' => 'GET',
-			'requirements' => [ 'asset' => '.+' ]
+			'requirements' => ['asset' => '.+']
 		],
 		[
 			'name' => 'Pico#getPage',
 			'url' => '/pico/{site}/{page}',
 			'verb' => 'GET',
-			'requirements' => [ 'page' => '.+' ]
+			'requirements' => ['page' => '.+']
 		],
 
 		[
@@ -53,51 +53,51 @@  discard block
 block discarded – undo
 			'postfix' => 'Proxy',
 			'url' => '/pico_proxy/{site}/',
 			'verb' => 'GET',
-			'defaults' => [ 'proxyRequest' => true ]
+			'defaults' => ['proxyRequest' => true]
 		],
 		[
 			'name' => 'Pico#getAsset',
 			'postfix' => 'Proxy',
 			'url' => '/pico_proxy/{site}/assets/{asset}',
 			'verb' => 'GET',
-			'requirements' => [ 'asset' => '.+' ]
+			'requirements' => ['asset' => '.+']
 		],
 		[
 			'name' => 'Pico#getAsset',
 			'postfix' => 'ProxyETag',
 			'url' => '/pico_proxy/{site}/assets_{assetsETag}/{asset}',
 			'verb' => 'GET',
-			'requirements' => [ 'asset' => '.+' ]
+			'requirements' => ['asset' => '.+']
 		],
 		[
 			'name' => 'Pico#getPage',
 			'postfix' => 'Proxy',
 			'url' => '/pico_proxy/{site}/{page}',
 			'verb' => 'GET',
-			'defaults' => [ 'proxyRequest' => true ],
-			'requirements' => [ 'page' => '.+' ]
+			'defaults' => ['proxyRequest' => true],
+			'requirements' => ['page' => '.+']
 		],
 
-		[ 'name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET' ],
-		[ 'name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE' ],
+		['name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET'],
+		['name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST'],
+		['name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST'],
+		['name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE'],
 
-		[ 'name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET' ],
-		[ 'name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE' ],
+		['name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET'],
+		['name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST'],
+		['name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE'],
 
-		[ 'name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET' ],
-		[ 'name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE' ],
+		['name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET'],
+		['name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST'],
+		['name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST'],
+		['name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE'],
 
-		[ 'name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET' ],
-		[ 'name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST' ],
-		[ 'name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE' ],
+		['name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET'],
+		['name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST'],
+		['name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST'],
+		['name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE'],
 
-		[ 'name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST' ],
+		['name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST'],
 	]
 ];
 

Please login to merge, or discard this patch.

		@@ -115,7 +115,7 @@ discard block
		block discarded – undo
115	115	*/
116	116	public function isReadable(): bool
117	117	{
118		- return ($this->getPermissions() & Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
	118	+ return ($this->getPermissions()&Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
119	119	}
120	120
121	121	/**
		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	*/
124	124	public function isUpdateable(): bool
125	125	{
126		- return ($this->getPermissions() & Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
	126	+ return ($this->getPermissions()&Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
127	127	}
128	128
129	129	/**
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	*/
132	132	public function isDeletable(): bool
133	133	{
134		- return ($this->getPermissions() & Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
	134	+ return ($this->getPermissions()&Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
135	135	}
136	136
137	137	/**
		@@ -141,7 +141,7 @@ discard block
		block discarded – undo
141	141	*/
142	142	protected function assertValidFileName(string $name)
143	143	{
144		- if (in_array($name, [ '', '.', '..' ], true)) {
	144	+ if (in_array($name, ['', '.', '..'], true)) {
145	145	throw new InvalidPathException();
146	146	}
147	147	if ((strpos($name, '/') !== false) \|\| (strpos($name, '\\') !== false)) {

		@@ -32,20 +32,20 @@ discard block
		block discarded – undo
32	32	'name' => 'Pico#getAsset',
33	33	'url' => '/pico/{site}/assets/{asset}',
34	34	'verb' => 'GET',
35		- 'requirements' => [ 'asset' => '.+' ]
	35	+ 'requirements' => ['asset' => '.+']
36	36	],
37	37	[
38	38	'name' => 'Pico#getAsset',
39	39	'postfix' => 'ETag',
40	40	'url' => '/pico/{site}/assets_{assetsETag}/{asset}',
41	41	'verb' => 'GET',
42		- 'requirements' => [ 'asset' => '.+' ]
	42	+ 'requirements' => ['asset' => '.+']
43	43	],
44	44	[
45	45	'name' => 'Pico#getPage',
46	46	'url' => '/pico/{site}/{page}',
47	47	'verb' => 'GET',
48		- 'requirements' => [ 'page' => '.+' ]
	48	+ 'requirements' => ['page' => '.+']
49	49	],
50	50
51	51	[
		@@ -53,51 +53,51 @@ discard block
		block discarded – undo
53	53	'postfix' => 'Proxy',
54	54	'url' => '/pico_proxy/{site}/',
55	55	'verb' => 'GET',
56		- 'defaults' => [ 'proxyRequest' => true ]
	56	+ 'defaults' => ['proxyRequest' => true]
57	57	],
58	58	[
59	59	'name' => 'Pico#getAsset',
60	60	'postfix' => 'Proxy',
61	61	'url' => '/pico_proxy/{site}/assets/{asset}',
62	62	'verb' => 'GET',
63		- 'requirements' => [ 'asset' => '.+' ]
	63	+ 'requirements' => ['asset' => '.+']
64	64	],
65	65	[
66	66	'name' => 'Pico#getAsset',
67	67	'postfix' => 'ProxyETag',
68	68	'url' => '/pico_proxy/{site}/assets_{assetsETag}/{asset}',
69	69	'verb' => 'GET',
70		- 'requirements' => [ 'asset' => '.+' ]
	70	+ 'requirements' => ['asset' => '.+']
71	71	],
72	72	[
73	73	'name' => 'Pico#getPage',
74	74	'postfix' => 'Proxy',
75	75	'url' => '/pico_proxy/{site}/{page}',
76	76	'verb' => 'GET',
77		- 'defaults' => [ 'proxyRequest' => true ],
78		- 'requirements' => [ 'page' => '.+' ]
	77	+ 'defaults' => ['proxyRequest' => true],
	78	+ 'requirements' => ['page' => '.+']
79	79	],
80	80
81		- [ 'name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET' ],
82		- [ 'name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST' ],
83		- [ 'name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST' ],
84		- [ 'name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE' ],
	81	+ ['name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET'],
	82	+ ['name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST'],
	83	+ ['name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST'],
	84	+ ['name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE'],
85	85
86		- [ 'name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET' ],
87		- [ 'name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST' ],
88		- [ 'name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE' ],
	86	+ ['name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET'],
	87	+ ['name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST'],
	88	+ ['name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE'],
89	89
90		- [ 'name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET' ],
91		- [ 'name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST' ],
92		- [ 'name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST' ],
93		- [ 'name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE' ],
	90	+ ['name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET'],
	91	+ ['name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST'],
	92	+ ['name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST'],
	93	+ ['name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE'],
94	94
95		- [ 'name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET' ],
96		- [ 'name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST' ],
97		- [ 'name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST' ],
98		- [ 'name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE' ],
	95	+ ['name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET'],
	96	+ ['name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST'],
	97	+ ['name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST'],
	98	+ ['name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE'],
99	99
100		- [ 'name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST' ],
	100	+ ['name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST'],
101	101	]
102	102	];
103	103

		@@ -29,8 +29,7 @@
		block discarded – undo
29	29	use OCP\Files\InvalidPathException;
30	30	use OCP\Files\NotPermittedException;
31	31
32		-interface NodeInterface
33		-{
	32	+interface NodeInterface {
34	33	/**
35	34	* @param string $name
36	35	*

		@@ -27,8 +27,7 @@
		block discarded – undo
27	27	use OCP\Constants;
28	28	use OCP\Files\InvalidPathException;
29	29
30		-abstract class AbstractNode implements NodeInterface
31		-{
	30	+abstract class AbstractNode implements NodeInterface {
32	31	/**
33	32	* {@inheritDoc}
34	33	*/

		@@ -30,8 +30,7 @@
		block discarded – undo
30	30	use OCA\CMSPico\Files\FolderInterface;
31	31	use OCP\Files\NotFoundException;
32	32
33		-class ThemesService
34		-{
	33	+class ThemesService {
35	34	/** @var ConfigService */
36	35	private $configService;
37	36

		@@ -31,8 +31,7 @@
		block discarded – undo
31	31	use OCP\Files\InvalidPathException;
32	32	use OCP\Files\NotFoundException;
33	33
34		-class PluginsService
35		-{
	34	+class PluginsService {
36	35	/** @var ConfigService */
37	36	private $configService;
38	37

nextcloud / cms_pico

Pull Request — master (#77)

Status

Category

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch