View GitHub Repository cms_pico

Schedule Inspection
Subscribe
Passed
Pull Request — master (#77)
by Daniel
03:10 queued 01:28
created
Status
Category
Toggle Patches
appinfo/routes.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch 
@@ -23,7 +23,7 @@  discard block
 
 block discarded – undo
23 23
24 24 
 return [
25 25 
 	'routes' => [
26 
-		[ 'name' => 'Pico#getRoot', 'url' => '/pico/{site}/', 'verb' => 'GET' ],
26 
+		['name' => 'Pico#getRoot', 'url' => '/pico/{site}/', 'verb' => 'GET'],
27 27 
 		[
28 28 
 			'name' => 'Pico#getPage',
29 29 
 			'url' => '/pico/{site}/{page}',
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
 			'requirements' => array('page' => '.+')
32 32 
 		],
33 33
34 
-		[ 'name' => 'Pico#getRootProxy', 'url' => '/pico_proxy/{site}/', 'verb' => 'GET' ],
34 
+		['name' => 'Pico#getRootProxy', 'url' => '/pico_proxy/{site}/', 'verb' => 'GET'],
35 35 
 		[
36 36 
 			'name' => 'Pico#getPageProxy',
37 37 
 			'url' => '/pico_proxy/{site}/{page}',
 
@@ -39,26 +39,26 @@  discard block
 
 block discarded – undo
39 39 
 			'requirements' => array('page' => '.+')
40 40 
 		],
41 41
42 
-		[ 'name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET' ],
43 
-		[ 'name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST' ],
44 
-		[ 'name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST' ],
45 
-		[ 'name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE' ],
42 
+		['name' => 'Settings#getPersonalWebsites', 'url' => '/personal/websites', 'verb' => 'GET'],
43 
+		['name' => 'Settings#createPersonalWebsite', 'url' => '/personal/websites', 'verb' => 'POST'],
44 
+		['name' => 'Settings#updatePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'POST'],
45 
+		['name' => 'Settings#removePersonalWebsite', 'url' => '/personal/websites/{siteId}', 'verb' => 'DELETE'],
46 46
47 
-		[ 'name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET' ],
48 
-		[ 'name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST' ],
49 
-		[ 'name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE' ],
47 
+		['name' => 'Settings#getTemplates', 'url' => '/admin/templates', 'verb' => 'GET'],
48 
+		['name' => 'Settings#addCustomTemplate', 'url' => '/admin/templates', 'verb' => 'POST'],
49 
+		['name' => 'Settings#removeCustomTemplate', 'url' => '/admin/templates/{item}', 'verb' => 'DELETE'],
50 50
51 
-		[ 'name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET' ],
52 
-		[ 'name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST' ],
53 
-		[ 'name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST' ],
54 
-		[ 'name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE' ],
51 
+		['name' => 'Settings#getThemes', 'url' => '/admin/themes', 'verb' => 'GET'],
52 
+		['name' => 'Settings#addCustomTheme', 'url' => '/admin/themes', 'verb' => 'POST'],
53 
+		['name' => 'Settings#updateCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'POST'],
54 
+		['name' => 'Settings#removeCustomTheme', 'url' => '/admin/themes/{item}', 'verb' => 'DELETE'],
55 55
56 
-		[ 'name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET' ],
57 
-		[ 'name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST' ],
58 
-		[ 'name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST' ],
59 
-		[ 'name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE' ],
56 
+		['name' => 'Settings#getPlugins', 'url' => '/admin/plugins', 'verb' => 'GET'],
57 
+		['name' => 'Settings#addCustomPlugin', 'url' => '/admin/plugins', 'verb' => 'POST'],
58 
+		['name' => 'Settings#updateCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'POST'],
59 
+		['name' => 'Settings#removeCustomPlugin', 'url' => '/admin/plugins/{item}', 'verb' => 'DELETE'],
60 60
61 
-		[ 'name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST' ],
61 
+		['name' => 'Settings#setLinkMode', 'url' => '/admin/link_mode', 'verb' => 'POST'],
62 62 
 	]
63 63 
 ];
64 64
Please login to merge, or discard this patch.
lib/Files/NodeInterface.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -29,8 +29,7 @@
 
 block discarded – undo
29 29 
 use OCP\Files\InvalidPathException;
30 30 
 use OCP\Files\NotPermittedException;
31 31
32 
-interface NodeInterface
33 
-{
32 
+interface NodeInterface {
34 33 
 	/**
35 34 
 	 * @param string $name
36 35 
 	 *
Please login to merge, or discard this patch.
lib/Files/AbstractNode.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -115,7 +115,7 @@  discard block
 
 block discarded – undo
115 115 
 	 */
116 116 
 	public function isReadable(): bool
117 117 
 	{
118 
-		return ($this->getPermissions() & Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
118 
+		return ($this->getPermissions()&Constants::PERMISSION_READ) === Constants::PERMISSION_READ;
119 119 
 	}
120 120
121 121 
 	/**
 
@@ -123,7 +123,7 @@  discard block
 
 block discarded – undo
123 123 
 	 */
124 124 
 	public function isUpdateable(): bool
125 125 
 	{
126 
-		return ($this->getPermissions() & Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
126 
+		return ($this->getPermissions()&Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE;
127 127 
 	}
128 128
129 129 
 	/**
 
@@ -131,7 +131,7 @@  discard block
 
 block discarded – undo
131 131 
 	 */
132 132 
 	public function isDeletable(): bool
133 133 
 	{
134 
-		return ($this->getPermissions() & Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
134 
+		return ($this->getPermissions()&Constants::PERMISSION_DELETE) === Constants::PERMISSION_DELETE;
135 135 
 	}
136 136
137 137 
 	/**
 
@@ -141,7 +141,7 @@  discard block
 
 block discarded – undo
141 141 
 	 */
142 142 
 	protected function assertValidFileName(string $name)
143 143 
 	{
144 
-		if (in_array($name, [ '', '.', '..' ], true)) {
144 
+		if (in_array($name, ['', '.', '..'], true)) {
145 145 
 			throw new InvalidPathException();
146 146 
 		}
147 147 
 		if ((strpos($name, '/') !== false) || (strpos($name, '\\') !== false)) {
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -27,8 +27,7 @@
 
 block discarded – undo
27 27 
 use OCP\Constants;
28 28 
 use OCP\Files\InvalidPathException;
29 29
30 
-abstract class AbstractNode implements NodeInterface
31 
-{
30 
+abstract class AbstractNode implements NodeInterface {
32 31 
 	/**
33 32 
 	 * {@inheritDoc}
34 33 
 	 */
Please login to merge, or discard this patch.
lib/Files/AbstractStorageNode.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -29,8 +29,7 @@
 
 block discarded – undo
29 29 
 use OCP\Files\InvalidPathException;
30 30 
 use OCP\Files\Node as OCNode;
31 31
32 
-abstract class AbstractStorageNode extends AbstractNode implements NodeInterface
33 
-{
32 
+abstract class AbstractStorageNode extends AbstractNode implements NodeInterface {
34 33 
 	/** @var OCNode */
35 34 
 	protected $node;
36 35
Please login to merge, or discard this patch.
lib/Service/ThemesService.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -30,8 +30,7 @@
 
 block discarded – undo
30 30 
 use OCA\CMSPico\Files\FolderInterface;
31 31 
 use OCP\Files\NotFoundException;
32 32
33 
-class ThemesService
34 
-{
33 
+class ThemesService {
35 34 
 	/** @var ConfigService */
36 35 
 	private $configService;
37 36
Please login to merge, or discard this patch.
lib/Service/PluginsService.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -31,8 +31,7 @@
 
 block discarded – undo
31 31 
 use OCP\Files\InvalidPathException;
32 32 
 use OCP\Files\NotFoundException;
33 33
34 
-class PluginsService
35 
-{
34 
+class PluginsService {
36 35 
 	/** @var ConfigService */
37 36 
 	private $configService;
38 37
Please login to merge, or discard this patch.