OCA\CMSPico\Files\StorageScanner

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

76.92%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	scan()	0	6	2
A	__construct()	0	16	2

<?php
/**
 * CMS Pico - Create websites using Pico CMS for Nextcloud.
 *
 * @copyright Copyright (c) 2022, Daniel Rudolf (<picocms.org@daniel-rudolf.de>)
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace OCA\CMSPico\Files;

use OC\Files\Utils\Scanner;
use OC\ForbiddenException;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Files\NotFoundException;
use OCP\Files\NotPermittedException;
use OCP\IDBConnection;
use OCP\ILogger;
use Psr\Log\LoggerInterface;

class StorageScanner
{
	/** @var Scanner */
	private $scanner;

	/**
	 * @param IDBConnection    $connection
	 * @param IEventDispatcher $eventDispatcher
	 */
	public function __construct(IDBConnection $connection, IEventDispatcher $eventDispatcher)
	{
		$this->connection = \OC::$server->query(IDBConnection::class);

The function OC\ServerContainer::query() has been deprecated: 20.0.0 use \Psr\Container\ContainerInterface::get

The property connection does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->eventDispatcher = \OC::$server->query(IEventDispatcher::class);

The property eventDispatcher does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

The function OC\ServerContainer::query() has been deprecated: 20.0.0 use \Psr\Container\ContainerInterface::get

		// TODO >= NC 24: Remove version switch
		[ $majorVersion ] = \OC_Util::getVersion();
		if ($majorVersion >= 24) {
			/** @var LoggerInterface $logger */
			$logger = \OC::$server->query(LoggerInterface::class);

The function OC\ServerContainer::query() has been deprecated: 20.0.0 use \Psr\Container\ContainerInterface::get

		} else {
			/** @var ILogger $logger */
			$logger = \OC::$server->query(ILogger::class);

The function OC\ServerContainer::query() has been deprecated: 20.0.0 use \Psr\Container\ContainerInterface::get

		}

		$this->scanner = new Scanner(null, $connection, $eventDispatcher, $logger);

It seems like $logger can also be of type Psr\Log\LoggerInterface; however, parameter $logger of OC\Files\Utils\Scanner::__construct() does only seem to accept OCP\ILogger, maybe add an additional type check?

	}

	/**
	 * @param string $path
	 * @param bool   $recursive
	 *
	 * @throws NotPermittedException
	 * @throws NotFoundException
	 */
	public function scan(string $path, bool $recursive = FolderInterface::SYNC_RECURSIVE): void
	{
		try {
			$this->scanner->scan($path, $recursive);
		} catch (ForbiddenException $e) {
			throw new NotPermittedException();
		}
	}
}