Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 42 | class TokensRequest extends TokensRequestBuilder { |
||
| 43 | |||
| 44 | |||
| 45 | /** |
||
| 46 | * @param string $token |
||
| 47 | * |
||
| 48 | * @return SharesToken |
||
| 49 | * @throws TokenDoesNotExistException |
||
| 50 | */ |
||
| 51 | View Code Duplication | public function getByToken(string $token) { |
|
| 64 | |||
| 65 | |||
| 66 | /** |
||
| 67 | * @param string $shareId |
||
| 68 | * @param string $circleId |
||
| 69 | * @param string $email |
||
| 70 | * |
||
| 71 | * @return SharesToken |
||
| 72 | * @throws TokenDoesNotExistException |
||
| 73 | */ |
||
| 74 | public function getTokenFromMember(string $shareId, string $circleId, string $email) { |
||
| 75 | $qb = $this->getTokensSelectSql(); |
||
| 76 | $this->limitToShareId($qb, $shareId); |
||
| 77 | $this->limitToUserId($qb, $email); |
||
| 78 | $this->limitToCircleId($qb, $circleId); |
||
| 79 | |||
| 80 | $cursor = $qb->execute(); |
||
| 81 | $data = $cursor->fetch(); |
||
| 82 | $cursor->closeCursor(); |
||
| 83 | if ($data === false) { |
||
| 84 | throw new TokenDoesNotExistException('Unknown share token'); |
||
| 85 | } |
||
| 86 | |||
| 87 | return $this->parseTokensSelectSql($data); |
||
| 88 | } |
||
| 89 | |||
| 90 | |||
| 91 | /** |
||
| 92 | * @param Member $member |
||
| 93 | * |
||
| 94 | * @return SharesToken[] |
||
| 95 | */ |
||
| 96 | View Code Duplication | public function getTokensFromMember(Member $member) { |
|
| 110 | |||
| 111 | |||
| 112 | /** |
||
| 113 | * @param Member $member |
||
| 114 | * @param int $shareId |
||
| 115 | * @param string $password |
||
| 116 | * |
||
| 117 | * @return SharesToken |
||
| 118 | * @throws TokenDoesNotExistException |
||
| 119 | */ |
||
| 120 | public function generateTokenForMember(Member $member, int $shareId, string $password = ''): SharesToken { |
||
| 121 | try { |
||
| 122 | $token = $this->miscService->token(15); |
||
| 123 | |||
| 124 | if ($password !== '') { |
||
| 125 | $hasher = \OC::$server->getHasher(); |
||
| 126 | $password = $hasher->hash($password); |
||
| 127 | } |
||
| 128 | |||
| 129 | $qb = $this->getTokensInsertSql(); |
||
| 130 | $qb->setValue('circle_id', $qb->createNamedParameter($member->getCircleId())) |
||
| 131 | ->setValue('user_id', $qb->createNamedParameter($member->getUserId())) |
||
| 132 | ->setValue('share_id', $qb->createNamedParameter($shareId)) |
||
| 133 | ->setValue('member_id', $qb->createNamedParameter($member->getMemberId())) |
||
| 134 | ->setValue('token', $qb->createNamedParameter($token)) |
||
| 135 | ->setValue('password', $qb->createNamedParameter($password)); |
||
| 136 | |||
| 137 | $qb->execute(); |
||
| 138 | } catch (UniqueConstraintViolationException $e) { |
||
| 139 | } |
||
| 140 | |||
| 141 | return $this->getTokenFromMember($shareId, $member->getCircleId(), $member->getUserId()); |
||
| 142 | } |
||
| 143 | |||
| 144 | |||
| 145 | /** |
||
| 146 | * @param int $shareId |
||
| 147 | */ |
||
| 148 | public function removeTokenByShareId(int $shareId) { |
||
| 154 | |||
| 155 | |||
| 156 | /** |
||
| 157 | * @param Member $member |
||
| 158 | */ |
||
| 159 | public function removeTokensFromMember(Member $member) { |
||
| 166 | |||
| 167 | |||
| 168 | public function updateSinglePassword(string $circleId, string $password) { |
||
| 181 | |||
| 182 | } |
||
| 183 | |||
| 184 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.