Completed
Pull Request — master (#135)
by Blizzz
01:59
created
lib/Service/EventsService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	 * generateEvent()
283 283
 	 * Create an Activity Event with the basic settings for the app.
284 284
 	 *
285
-	 * @param $type
285
+	 * @param string $type
286 286
 	 *
287 287
 	 * @return \OCP\Activity\IEvent
288 288
 	 */
Please login to merge, or discard this patch.
lib/ShareByCircleProvider.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -432,6 +432,13 @@
 block discarded – undo
432 432
 	}
433 433
 
434 434
 
435
+	/**
436
+	 * @param string $userId
437
+	 * @param integer $shareType
438
+	 * @param Node|null $node
439
+	 * @param integer $limit
440
+	 * @param integer $offset
441
+	 */
435 442
 	private function getSharedWithCircleMembers($userId, $shareType, $node, $limit, $offset) {
436 443
 
437 444
 		$qb = $this->getCompleteSelectSql();
Please login to merge, or discard this patch.
lib/Db/CircleProviderRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
 	 * limit the request to the children of a share
108 108
 	 *
109 109
 	 * @param IQueryBuilder $qb
110
-	 * @param $userId
110
+	 * @param string $userId
111 111
 	 * @param int $parentId
112 112
 	 */
113 113
 	protected function limitToShareChildren(IQueryBuilder &$qb, $userId, $parentId = -1) {
Please login to merge, or discard this patch.
lib/Db/MembersRequest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 * returns the index of a specific UserID in a Members List
193 193
 	 *
194 194
 	 * @param array $members
195
-	 * @param $userId
195
+	 * @param string $userId
196 196
 	 *
197 197
 	 * @return int
198 198
 	 */
@@ -415,6 +415,9 @@  discard block
 block discarded – undo
415 415
 	}
416 416
 
417 417
 
418
+	/**
419
+	 * @param string $groupId
420
+	 */
418 421
 	public function unlinkAllFromGroup($groupId) {
419 422
 		$qb = $this->getGroupsDeleteSql($groupId);
420 423
 		$qb->execute();
Please login to merge, or discard this patch.
lib/Service/GroupsService.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	 * @param string $circleUniqueId
87 87
 	 * @param string $groupId
88 88
 	 *
89
-	 * @return array
89
+	 * @return Member[]
90 90
 	 * @throws \Exception
91 91
 	 */
92 92
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	/**
113 113
 	 * Check if a fresh member can be generated (by linkGroup)
114 114
 	 *
115
-	 * @param $circleId
116
-	 * @param $groupId
115
+	 * @param string $circleId
116
+	 * @param string $groupId
117 117
 	 *
118 118
 	 * @return null|Member
119 119
 	 * @throws MemberAlreadyExistsException
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 	 * @param string $groupId
149 149
 	 * @param int $level
150 150
 	 *
151
-	 * @return array
151
+	 * @return Member[]
152 152
 	 * @throws \Exception
153 153
 	 */
154 154
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 	/**
187 187
 	 * @param Circle $circle
188 188
 	 * @param Member $group
189
-	 * @param $level
189
+	 * @param integer $level
190 190
 	 *
191 191
 	 * @throws \Exception
192 192
 	 */
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 	 * @param string $circleUniqueId
214 214
 	 * @param string $groupId
215 215
 	 *
216
-	 * @return array
216
+	 * @return Member[]
217 217
 	 * @throws \Exception
218 218
 	 */
219 219
 	public function unlinkGroup($circleUniqueId, $groupId) {
Please login to merge, or discard this patch.
lib/Model/BaseMember.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -149,6 +149,9 @@
 block discarded – undo
149 149
 	}
150 150
 
151 151
 
152
+	/**
153
+	 * @param string $display
154
+	 */
152 155
 	public function setDisplayName($display) {
153 156
 		$this->displayName = $display;
154 157
 
Please login to merge, or discard this patch.
lib/Service/SharingFrameService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
 	 *
130 130
 	 * @param SharingFrame $frame
131 131
 	 * @param Circle $circle
132
-	 * @param $broadcast
132
+	 * @param string|null $broadcast
133 133
 	 */
134 134
 	private function generateHeaders(SharingFrame $frame, Circle $circle, $broadcast) {
135 135
 
Please login to merge, or discard this patch.
lib/Service/FederatedLinkCreationService.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
189 189
 
190 190
 
191 191
 	/**
192
-	 * @param $circleUniqueId
193
-	 * @param $remote
192
+	 * @param string $circleUniqueId
193
+	 * @param string $remote
194 194
 	 *
195 195
 	 * @return FederatedLink
196 196
 	 */
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 	 *
282 282
 	 * Will parse the error reason returned by requestLink() and throw an Exception
283 283
 	 *
284
-	 * @param $reason
284
+	 * @param string $reason
285 285
 	 *
286 286
 	 * @throws Exception
287 287
 	 * @throws FederatedRemoteDoesNotAllowException
Please login to merge, or discard this patch.
lib/Service/MembersService.php 1 patch
Doc Comments   +12 added lines, -9 removed lines patch added patch discarded remove patch
@@ -101,9 +101,9 @@  discard block
 block discarded – undo
101 101
 	 *
102 102
 	 * @param string $circleUniqueId
103 103
 	 * @param $ident
104
-	 * @param $type
104
+	 * @param integer $type
105 105
 	 *
106
-	 * @return array
106
+	 * @return Member[]
107 107
 	 * @throws \Exception
108 108
 	 */
109 109
 	public function addMember($circleUniqueId, $ident, $type) {
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
 	/**
245 245
 	 * Verify if a local account is valid.
246 246
 	 *
247
-	 * @param $ident
248
-	 * @param $type
247
+	 * @param string $ident
248
+	 * @param integer $type
249 249
 	 *
250 250
 	 * @throws NoUserException
251 251
 	 */
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 * Verify if a mail have a valid format.
267 267
 	 *
268 268
 	 * @param $ident
269
-	 * @param $type
269
+	 * @param integer $type
270 270
 	 *
271 271
 	 * @throws EmailAccountInvalidFormatException
272 272
 	 */
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 	 * Verify if a contact exist in current user address books.
288 288
 	 *
289 289
 	 * @param $ident
290
-	 * @param $type
290
+	 * @param integer $type
291 291
 	 *
292 292
 	 * @throws NoUserException
293 293
 	 */
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 	 * @param int $type
372 372
 	 * @param int $level
373 373
 	 *
374
-	 * @return array
374
+	 * @return Member[]
375 375
 	 * @throws \Exception
376 376
 	 */
377 377
 	public function levelMember($circleUniqueId, $name, $type, $level) {
@@ -397,6 +397,9 @@  discard block
 block discarded – undo
397 397
 	}
398 398
 
399 399
 
400
+	/**
401
+	 * @param integer $level
402
+	 */
400 403
 	private function updateMemberLevel(Circle $circle, Member $member, $level) {
401 404
 		if ($member->getLevel() === $level) {
402 405
 			return;
@@ -466,9 +469,9 @@  discard block
 block discarded – undo
466 469
 	/**
467 470
 	 * @param string $circleUniqueId
468 471
 	 * @param string $name
469
-	 * @param $type
472
+	 * @param integer $type
470 473
 	 *
471
-	 * @return array
474
+	 * @return Member[]
472 475
 	 * @throws \Exception
473 476
 	 */
474 477
 	public function removeMember($circleUniqueId, $name, $type) {
Please login to merge, or discard this patch.