Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
39 | class CirclesMapper extends Mapper { |
||
40 | |||
41 | const TABLENAME = 'circles_circles'; |
||
42 | |||
43 | private $miscService; |
||
44 | |||
45 | public function __construct(IDBConnection $db, $miscService) { |
||
50 | |||
51 | |||
52 | /** |
||
53 | * Returns all circle from a user point-of-view |
||
54 | * |
||
55 | * @param $userId |
||
56 | * @param $type |
||
57 | * @param string $name |
||
58 | * @param int $level |
||
59 | * @param int $circleId |
||
60 | * |
||
61 | * @return Circle[] |
||
62 | * @throws ConfigNoCircleAvailable |
||
63 | */ |
||
64 | public function findCirclesByUser($userId, $type, $name = '', $level = 0, $circleId = -1) { |
||
83 | |||
84 | |||
85 | /** |
||
86 | * Returns SQL for findCirclesByUser |
||
87 | * |
||
88 | * @param $userId |
||
89 | * @param $type |
||
90 | * @param $name |
||
91 | * @param $level |
||
92 | * @param $circleId |
||
93 | * |
||
94 | * @return IQueryBuilder |
||
95 | * @throws ConfigNoCircleAvailable |
||
96 | */ |
||
97 | private function findCirclesByUserSql($userId, $type, $name, $level, $circleId) { |
||
130 | |||
131 | |||
132 | private function buildWithOrXTypes(&$qb, $userId, $type, $name, $circleId) { |
||
157 | |||
158 | /** |
||
159 | * @param IQueryBuilder $qb |
||
160 | * @param string $field |
||
161 | * @param int $circleId |
||
162 | */ |
||
163 | private function buildWithCircleId(IQueryBuilder & $qb, string $field, int $circleId) { |
||
171 | |||
172 | |||
173 | /** |
||
174 | * @param IQueryBuilder $qb |
||
175 | * @param string $field |
||
176 | * @param int $level |
||
177 | */ |
||
178 | private function buildWithMemberLevel(IQueryBuilder & $qb, string $field, int $level) { |
||
186 | |||
187 | |||
188 | /** |
||
189 | * @param IQueryBuilder $qb |
||
190 | * @param int $type |
||
191 | * @param int|string $userId |
||
192 | * |
||
193 | * @return \OCP\DB\QueryBuilder\ICompositeExpression |
||
194 | */ |
||
195 | private function generateTypeEntryForCirclePersonal(IQueryBuilder $qb, int $type, string $userId |
||
212 | |||
213 | /** |
||
214 | * @param IQueryBuilder $qb |
||
215 | * @param int $type |
||
216 | * @param int $circleId |
||
217 | * @param string $name |
||
218 | * |
||
219 | * @return string |
||
220 | */ |
||
221 | private function generateTypeEntryForCircleHidden( |
||
243 | |||
244 | |||
245 | /** |
||
246 | * @param IQueryBuilder $qb |
||
247 | * @param int $type |
||
248 | * |
||
249 | * @return string |
||
250 | */ |
||
251 | View Code Duplication | private function generateTypeEntryForCirclePrivate(IQueryBuilder $qb, int $type) { |
|
262 | |||
263 | |||
264 | /** |
||
265 | * @param IQueryBuilder $qb |
||
266 | * @param int $type |
||
267 | * |
||
268 | * @return string |
||
269 | */ |
||
270 | View Code Duplication | private function generateTypeEntryForCirclePublic(IQueryBuilder $qb, int $type) { |
|
281 | |||
282 | /** |
||
283 | * Returns details about a circle. |
||
284 | * |
||
285 | * @param string $userId |
||
286 | * @param int $circleId |
||
287 | * |
||
288 | * @return Circle |
||
289 | * @throws CircleDoesNotExistException |
||
290 | * @throws ConfigNoCircleAvailable |
||
291 | */ |
||
292 | public function getDetailsFromCircle($userId, $circleId) { |
||
308 | |||
309 | |||
310 | /** |
||
311 | * @param Circle $circle |
||
312 | * @param Member $owner |
||
313 | * |
||
314 | * @return bool |
||
315 | * @throws CircleAlreadyExistsException |
||
316 | */ |
||
317 | public function create(Circle & $circle, Member & $owner) { |
||
338 | |||
339 | |||
340 | /** |
||
341 | * remove a circle |
||
342 | * |
||
343 | * @param Circle $circle |
||
344 | */ |
||
345 | View Code Duplication | public function destroy(Circle $circle) { |
|
357 | |||
358 | |||
359 | /** |
||
360 | * returns if the circle is already in database |
||
361 | * |
||
362 | * @param Circle $circle |
||
363 | * @param Member $owner |
||
364 | * |
||
365 | * @return bool |
||
366 | */ |
||
367 | public function isCircleUnique(Circle $circle, Member $owner) { |
||
385 | |||
386 | |||
387 | /** |
||
388 | * Return SQL for isCircleUnique(); |
||
389 | * |
||
390 | * @return IQueryBuilder |
||
391 | */ |
||
392 | private function isCircleUniqueSql() { |
||
407 | |||
408 | |||
409 | /** |
||
410 | * return if the personal circle is unique |
||
411 | * |
||
412 | * @param Circle $circle |
||
413 | * @param Member $owner |
||
414 | * |
||
415 | * @return bool |
||
416 | */ |
||
417 | private function isPersonalCircleUnique(Circle $circle, Member $owner) { |
||
432 | } |
||
433 | |||
434 |