Completed
Pull Request — master (#551)
by Maxence
02:49
created
lib/Search/GlobalScaleUsers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 		RequestResultNotJsonException $e
96 96
 		) {
97 97
 			$this->miscService->log(
98
-				'Issue while search users from lookup: ' . get_class($e) . ' ' . $e->getMessage()
98
+				'Issue while search users from lookup: '.get_class($e).' '.$e->getMessage()
99 99
 			);
100 100
 
101 101
 			return [];
Please login to merge, or discard this patch.
lib/Activity/ProviderParser.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 				continue;
138 138
 			}
139 139
 
140
-			$replace['{' . $k . '}'] = $data[$k]['_parsed'];
140
+			$replace['{'.$k.'}'] = $data[$k]['_parsed'];
141 141
 		}
142 142
 
143 143
 		$line = strtr($line, $replace);
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 		return [
302 302
 			'type'    => $member->getTypeName(),
303 303
 			'id'      => $member->getUserId(),
304
-			'name'    => $member->getCachedName() . ' (' . $member->getTypeString() . ')',
304
+			'name'    => $member->getCachedName().' ('.$member->getTypeString().')',
305 305
 			'_parsed' => $member->getCachedName()
306 306
 		];
307 307
 	}
@@ -337,8 +337,8 @@  discard block
 block discarded – undo
337 337
 		return [
338 338
 			'type'    => 'circle',
339 339
 			'id'      => $link->getUniqueId(),
340
-			'name'    => $link->getToken() . '@' . $link->getAddress(),
341
-			'_parsed' => $link->getToken() . '@' . $link->getAddress()
340
+			'name'    => $link->getToken().'@'.$link->getAddress(),
341
+			'_parsed' => $link->getToken().'@'.$link->getAddress()
342 342
 		];
343 343
 	}
344 344
 
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 use Throwable;
60 60
 
61 61
 
62
-require_once __DIR__ . '/../../vendor/autoload.php';
62
+require_once __DIR__.'/../../vendor/autoload.php';
63 63
 
64 64
 
65 65
 /**
Please login to merge, or discard this patch.
lib/Db/SharesRequest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 		$expr = $qb->expr();
106 106
 
107 107
 		$this->limitToShareType($qb, self::SHARE_TYPE);
108
-		$qb->andWhere($expr->isNull($this->default_select_alias . '.parent'));
108
+		$qb->andWhere($expr->isNull($this->default_select_alias.'.parent'));
109 109
 
110 110
 		$shares = [];
111 111
 		$cursor = $qb->execute();
Please login to merge, or discard this patch.
lib/Command/CirclesTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -141,9 +141,9 @@  discard block
 block discarded – undo
141 141
 		$test->setAsync(true);
142 142
 		$token = $this->gsUpstreamService->newEvent($test);
143 143
 
144
-		$output->writeln('- Async request is sent, now waiting ' . $this->delay . ' seconds');
144
+		$output->writeln('- Async request is sent, now waiting '.$this->delay.' seconds');
145 145
 		sleep($this->delay);
146
-		$output->writeln('- Pause is over, checking results for ' . $token);
146
+		$output->writeln('- Pause is over, checking results for '.$token);
147 147
 
148 148
 		$wrappers = $this->gsUpstreamService->getEventsByToken($token);
149 149
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 
156 156
 		$localLooksGood = false;
157 157
 		foreach ($instances as $instance) {
158
-			$output->write($instance . ' ');
158
+			$output->write($instance.' ');
159 159
 			if (array_key_exists($instance, $result)
160 160
 				&& $result[$instance]->getResult()
161 161
 									 ->gInt('status') === 1) {
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 		$this->configService->configureRequest($request, $route, $args);
193 193
 		$request->setFollowLocation(false);
194 194
 
195
-		$o->write('- ' . $type . ' request on ' . $request->getCompleteUrl() . ': ');
195
+		$o->write('- '.$type.' request on '.$request->getCompleteUrl().': ');
196 196
 		$this->doRequest($request);
197 197
 
198 198
 		$color = 'error';
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 			$color = 'info';
202 202
 		}
203 203
 
204
-		$o->writeln('<' . $color . '>' . $result->getStatusCode() . '</' . $color . '>');
204
+		$o->writeln('<'.$color.'>'.$result->getStatusCode().'</'.$color.'>');
205 205
 
206 206
 		if ($result->getStatusCode() === 200) {
207 207
 			return true;
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 
224 224
 		$output->writeln('');
225 225
 		$output->writeln(
226
-			'The address <info>' . $address . '</info> seems to reach your local Nextcloud.'
226
+			'The address <info>'.$address.'</info> seems to reach your local Nextcloud.'
227 227
 		);
228 228
 
229 229
 		$helper = $this->getHelper('question');
@@ -240,8 +240,8 @@  discard block
 block discarded – undo
240 240
 
241 241
 		$this->configService->setAppValue(ConfigService::FORCE_NC_BASE, $address);
242 242
 		$output->writeln(
243
-			'New configuration <info>' . Application::APP_ID . '.' . ConfigService::FORCE_NC_BASE . '=\''
244
-			. $address . '\'</info> stored in database'
243
+			'New configuration <info>'.Application::APP_ID.'.'.ConfigService::FORCE_NC_BASE.'=\''
244
+			. $address.'\'</info> stored in database'
245 245
 		);
246 246
 	}
247 247
 
Please login to merge, or discard this patch.
lib/Command/Groups.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@
 block discarded – undo
93 93
 	 */
94 94
 	private function listLinkedGroups(InputInterface $input, OutputInterface $output) {
95 95
 		if ($input->getOption('list') !== true) {
96
-			return ;
96
+			return;
97 97
 		}
98 98
 
99 99
 		throw new FakeException();
Please login to merge, or discard this patch.
lib/Service/CirclesService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -569,24 +569,24 @@
 block discarded – undo
569 569
 		switch ($type) {
570 570
 			case DeprecatedCircle::CIRCLES_PERSONAL:
571 571
 				return $urlGen->getAbsoluteURL(
572
-					$urlGen->imagePath(Application::APP_ID, 'personal' . $ext)
572
+					$urlGen->imagePath(Application::APP_ID, 'personal'.$ext)
573 573
 				);
574 574
 			case DeprecatedCircle::CIRCLES_CLOSED:
575 575
 				return $urlGen->getAbsoluteURL(
576
-					$urlGen->imagePath(Application::APP_ID, 'closed' . $ext)
576
+					$urlGen->imagePath(Application::APP_ID, 'closed'.$ext)
577 577
 				);
578 578
 			case DeprecatedCircle::CIRCLES_SECRET:
579 579
 				return $urlGen->getAbsoluteURL(
580
-					$urlGen->imagePath(Application::APP_ID, 'secret' . $ext)
580
+					$urlGen->imagePath(Application::APP_ID, 'secret'.$ext)
581 581
 				);
582 582
 			case DeprecatedCircle::CIRCLES_PUBLIC:
583 583
 				return $urlGen->getAbsoluteURL(
584
-					$urlGen->imagePath(Application::APP_ID, 'black_circle' . $ext)
584
+					$urlGen->imagePath(Application::APP_ID, 'black_circle'.$ext)
585 585
 				);
586 586
 		}
587 587
 
588 588
 		return $urlGen->getAbsoluteURL(
589
-			$urlGen->imagePath(Application::APP_ID, 'black_circle' . $ext)
589
+			$urlGen->imagePath(Application::APP_ID, 'black_circle'.$ext)
590 590
 		);
591 591
 	}
592 592
 
Please login to merge, or discard this patch.
lib/Db/DeprecatedMembersRequest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 * returns the index of a specific UserID in a Members List
317 317
 	 *
318 318
 	 * @param array $members
319
-	 * @param $userId
319
+	 * @param string $userId
320 320
 	 *
321 321
 	 * @return int
322 322
 	 */
@@ -656,6 +656,9 @@  discard block
 block discarded – undo
656 656
 	}
657 657
 
658 658
 
659
+	/**
660
+	 * @param string $groupId
661
+	 */
659 662
 	public function unlinkAllFromGroup($groupId) {
660 663
 		$qb = $this->getMembersDeleteSql();
661 664
 
Please login to merge, or discard this patch.
lib/Model/BaseCircle.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 	}
468 468
 
469 469
 	/**
470
-	 * @return string
470
+	 * @return integer
471 471
 	 */
472 472
 	public function getType() {
473 473
 		return $this->type;
@@ -521,7 +521,7 @@  discard block
 block discarded – undo
521 521
 	}
522 522
 
523 523
 	/**
524
-	 * @return array
524
+	 * @return DeprecatedMember[]
525 525
 	 */
526 526
 	public function getGroups() {
527 527
 		return $this->groups;
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 	}
540 540
 
541 541
 	/**
542
-	 * @return array
542
+	 * @return FederatedLink[]
543 543
 	 */
544 544
 	public function getLinks() {
545 545
 		return $this->links;
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
 //	}
576 576
 
577 577
 	/**
578
-	 * @param integer|string $type
578
+	 * @param string $type
579 579
 	 *
580 580
 	 * @return integer
581 581
 	 */
Please login to merge, or discard this patch.