MembersList::execute() - Code Metrics - Inspection of "manage circles and members from occ" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#379)

by Maxence

created 2020-03-16 12:27 UTC

MembersList::execute() A

↳ Parent: MembersList

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	35
rs	9.36
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php declare(strict_types=1);


/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2017
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Circles\Command;

use OC\Core\Command\Base;
use OCA\Circles\Db\CirclesRequest;
use OCA\Circles\Db\MembersRequest;
use OCA\Circles\Exceptions\CircleDoesNotExistException;
use OCP\IL10N;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\ConsoleOutput;
use Symfony\Component\Console\Output\OutputInterface;


/**
 * Class MembersList
 *
 * @package OCA\Circles\Command
 */
class MembersList extends Base {


	/** @var IL10N */
	private $l10n;

	/** @var CirclesRequest */
	private $circlesRequest;

	/** @var MembersRequest */
	private $membersRequest;


	/**
	 * MembersList constructor.
	 *
	 * @param IL10N $l10n
	 * @param CirclesRequest $circlesRequest
	 * @param MembersRequest $membersRequest
	 */
	public function __construct(IL10N $l10n, CirclesRequest $circlesRequest, MembersRequest $membersRequest) {
		parent::__construct();
		$this->l10n = $l10n;
		$this->circlesRequest = $circlesRequest;
		$this->membersRequest = $membersRequest;
	}


	protected function configure() {
		parent::configure();
		$this->setName('circles:members:list')
			 ->setDescription('listing members')
			 ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle')
			 ->addOption('json', '', InputOption::VALUE_NONE, 'returns result as JSON');
	}


	/**
	 * @param InputInterface $input
	 * @param OutputInterface $output
	 *
	 * @return int
	 * @throws CircleDoesNotExistException
	 */
	protected function execute(InputInterface $input, OutputInterface $output): int {
		$circleId = $input->getArgument('circle_id');
		$json = $input->getOption('json');

		$this->circlesRequest->forceGetCircle($circleId);

		$members = $this->membersRequest->forceGetMembers($circleId);

		if ($json) {
			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";

			return 0;
		}

		$output = new ConsoleOutput();
		$output = $output->section();

		$table = new Table($output);
		$table->setHeaders(['ID', 'Name', 'Level']);
		$table->render();
		$output->writeln('');

		$c = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		foreach ($members as $member) {
			$table->appendRow(
				[
					$member->getMemberId(),
					$member->getUserId(),
					$member->getLevelString(),
				]
			);
		}

		return 0;
	}

}



1			<?php declare(strict_types=1);
2
3
4			/**
5			* Circles - Bring cloud-users closer together.
6			*
7			* This file is licensed under the Affero General Public License version 3 or
8			* later. See the COPYING file.
9			*
10			* @author Maxence Lange <[email protected]>
11			* @copyright 2017
12			* @license GNU AGPL version 3 or any later version
13			*
14			* This program is free software: you can redistribute it and/or modify
15			* it under the terms of the GNU Affero General Public License as
16			* published by the Free Software Foundation, either version 3 of the
17			* License, or (at your option) any later version.
18			*
19			* This program is distributed in the hope that it will be useful,
20			* but WITHOUT ANY WARRANTY; without even the implied warranty of
21			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
22			* GNU Affero General Public License for more details.
23			*
24			* You should have received a copy of the GNU Affero General Public License
25			* along with this program. If not, see <http://www.gnu.org/licenses/>.
26			*
27			*/
28
29
30			namespace OCA\Circles\Command;
31
32			use OC\Core\Command\Base;
33			use OCA\Circles\Db\CirclesRequest;
34			use OCA\Circles\Db\MembersRequest;
35			use OCA\Circles\Exceptions\CircleDoesNotExistException;
36			use OCP\IL10N;
37			use Symfony\Component\Console\Helper\Table;
38			use Symfony\Component\Console\Input\InputArgument;
39			use Symfony\Component\Console\Input\InputInterface;
40			use Symfony\Component\Console\Input\InputOption;
41			use Symfony\Component\Console\Output\ConsoleOutput;
42			use Symfony\Component\Console\Output\OutputInterface;
43
44
45			/**
46			* Class MembersList
47			*
48			* @package OCA\Circles\Command
49			*/
50			class MembersList extends Base {
51
52
53			/** @var IL10N */
54			private $l10n;
55
56			/** @var CirclesRequest */
57			private $circlesRequest;
58
59			/** @var MembersRequest */
60			private $membersRequest;
61
62
63			/**
64			* MembersList constructor.
65			*
66			* @param IL10N $l10n
67			* @param CirclesRequest $circlesRequest
68			* @param MembersRequest $membersRequest
69			*/
70			public function __construct(IL10N $l10n, CirclesRequest $circlesRequest, MembersRequest $membersRequest) {
71			parent::__construct();
72			$this->l10n = $l10n;
73			$this->circlesRequest = $circlesRequest;
74			$this->membersRequest = $membersRequest;
75			}
76
77
78			protected function configure() {
79			parent::configure();
80			$this->setName('circles:members:list')
81			->setDescription('listing members')
82			->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle')
83			->addOption('json', '', InputOption::VALUE_NONE, 'returns result as JSON');
84			}
85
86
87			/**
88			* @param InputInterface $input
89			* @param OutputInterface $output
90			*
91			* @return int
92			* @throws CircleDoesNotExistException
93			*/
94			protected function execute(InputInterface $input, OutputInterface $output): int {
95			$circleId = $input->getArgument('circle_id');
96			$json = $input->getOption('json');
97
98			$this->circlesRequest->forceGetCircle($circleId);
99
100			$members = $this->membersRequest->forceGetMembers($circleId);
101
102			if ($json) {
103			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";
104
105			return 0;
106			}
107
108			$output = new ConsoleOutput();
109			$output = $output->section();
110
111			$table = new Table($output);
112			$table->setHeaders(['ID', 'Name', 'Level']);
113			$table->render();
114			$output->writeln('');
115
116			$c = 0;
			0 ignored issues – show Unused Code introduced 2020-03-16 12:28 UTC by Report Bug Copy Issue Report `$c` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
117			foreach ($members as $member) {
118			$table->appendRow(
119			[
120			$member->getMemberId(),
121			$member->getUserId(),
122			$member->getLevelString(),
123			]
124			);
125			}
126
127			return 0;
128			}
129
130			}
131
132

nextcloud / circles

Pull Request — master (#379)

MembersList::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like