nextcloud / circles

lib/Db/MembersRequest.php

Doc Comments +4 added lines, -1 removed lines

@@ -192,7 +192,7 @@ 
 	 * returns the index of a specific UserID in a Members List
 	 *
 	 * @param array $members
-	 * @param $userId
+	 * @param string $userId
 	 *
 	 * @return int
 	 */
@@ -415,6 +415,9 @@ 
 	}
 
 
+	/**
+	 * @param string $groupId
+	 */
 	public function unlinkAllFromGroup($groupId) {
 		$qb = $this->getGroupsDeleteSql($groupId);
 		$qb->execute();

lib/Model/FederatedLink.php

Doc Comments +3 added lines

@@ -301,6 +301,9 @@
 	}
 
 
+	/**
+	 * @param integer $status
+	 */
 	public function hasToBeValidStatusUpdate($status) {
 		if ($this->getStatus() === self::STATUS_LINK_DOWN && $status === self::STATUS_LINK_REMOVE) {
 			return true;

lib/Activity/BaseProvider.php

Spacing +9 added lines, -9 removed lines

@@ -74,7 +74,7 @@ 
 	 * @return IEvent
 	 */
 	protected function parseCircleEvent(
-		IEvent &$event, Circle $circle, $remote, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, $remote, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'author' => $this->generateViewerParameter($circle),
@@ -102,7 +102,7 @@ 
 	 * @return IEvent
 	 */
 	protected function parseMemberEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'circle' => $this->generateCircleParameter($circle),
@@ -128,7 +128,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	protected function parseLinkEvent(IEvent &$event, Circle $circle, FederatedLink $remote, $line
+	protected function parseLinkEvent(IEvent & $event, Circle $circle, FederatedLink $remote, $line
 	) {
 		$data = [
 			'circle' => $this->generateCircleParameter($circle),
@@ -151,7 +151,7 @@ 
 	 * @return IEvent
 	 */
 	protected function parseCircleMemberEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'author' => $this->generateViewerParameter($circle),
@@ -182,7 +182,7 @@ 
 	 * @return IEvent
 	 */
 	protected function parseCircleMemberAdvancedEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $targetEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $targetEvent, $othersEvent
 	) {
 		$data = [
 			'author' => $this->generateViewerParameter($circle),
@@ -205,13 +205,13 @@ 
 	/**
 	 * @param IEvent $event
 	 */
-	protected function generateParsedSubject(IEvent &$event) {
+	protected function generateParsedSubject(IEvent & $event) {
 		$subject = $event->getRichSubject();
 		$params = $event->getRichSubjectParameters();
 		$ak = array_keys($params);
 		foreach ($ak as $k) {
 			if (is_array($params[$k])) {
-				$subject = str_replace('{' . $k . '}', $params[$k]['parsed'], $subject);
+				$subject = str_replace('{'.$k.'}', $params[$k]['parsed'], $subject);
 			}
 		}
 
@@ -278,8 +278,8 @@ 
 		return [
 			'type'   => 'circle',
 			'id'     => $link->getUniqueId(),
-			'name'   => $link->getToken() . '@' . $link->getAddress(),
-			'parsed' => $link->getToken() . '@' . $link->getAddress()
+			'name'   => $link->getToken().'@'.$link->getAddress(),
+			'parsed' => $link->getToken().'@'.$link->getAddress()
 		];
 	}
 

lib/Activity/Provider.php

Spacing +13 added lines, -13 removed lines

@@ -70,7 +70,7 @@ 
 	}
 
 
-	private function setIcon(IEvent &$event, Circle $circle) {
+	private function setIcon(IEvent & $event, Circle $circle) {
 		$event->setIcon(
 			CirclesService::getCircleIcon(
 				$circle->getType(),
@@ -87,7 +87,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseAsMember(IEvent &$event, Circle $circle, $params) {
+	private function parseAsMember(IEvent & $event, Circle $circle, $params) {
 		if ($event->getType() !== 'circles_as_member') {
 			return $event;
 		}
@@ -124,7 +124,7 @@ 
 	 * @return IEvent
 	 * @throws Exception
 	 */
-	private function parseAsModerator(IEvent &$event, Circle $circle, $params) {
+	private function parseAsModerator(IEvent & $event, Circle $circle, $params) {
 		if ($event->getType() !== 'circles_as_moderator') {
 			return $event;
 		}
@@ -155,7 +155,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseMemberAsMember(IEvent &$event, Circle $circle) {
+	private function parseMemberAsMember(IEvent & $event, Circle $circle) {
 		$params = $event->getSubjectParameters();
 		$member = Member::fromJSON($params['member']);
 
@@ -187,7 +187,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseSubjectMemberJoin(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberJoin(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() === Circle::CIRCLES_CLOSED) {
 			return $this->parseCircleMemberEvent(
 				$event, $circle, $member,
@@ -214,7 +214,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseSubjectMemberAdd(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberAdd(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() === Circle::CIRCLES_CLOSED) {
 			return $this->parseCircleMemberAdvancedEvent(
 				$event, $circle, $member,
@@ -244,7 +244,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseSubjectMemberLeft(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberLeft(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() === Circle::CIRCLES_CLOSED
 			&& $member->getLevel() === Member::LEVEL_NONE) {
 			return $this->parseSubjectNonMemberLeftClosedCircle($event, $circle, $member);
@@ -270,7 +270,7 @@ 
 	 * @return IEvent
 	 */
 	private function parseSubjectNonMemberLeftClosedCircle(
-		IEvent &$event, Circle $circle, Member $member
+		IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($member->getStatus() === Member::STATUS_INVITED) {
 			return $this->parseCircleMemberEvent(
@@ -299,7 +299,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseSubjectMemberRemove(IEvent &$event, Circle $circle, Member $member) {
+	private function parseSubjectMemberRemove(IEvent & $event, Circle $circle, Member $member) {
 		if ($circle->getType() === Circle::CIRCLES_CLOSED
 			&& $member->getLevel() === Member::LEVEL_NONE) {
 			return $this->parseSubjectNonMemberRemoveClosedCircle($event, $circle, $member);
@@ -327,7 +327,7 @@ 
 	 * @return IEvent
 	 */
 	private function parseSubjectNonMemberRemoveClosedCircle(
-		IEvent &$event, Circle $circle, Member $member
+		IEvent & $event, Circle $circle, Member $member
 	) {
 		if ($member->getStatus() === Member::STATUS_REQUEST) {
 			return $this->parseCircleMemberAdvancedEvent(
@@ -353,7 +353,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseGroupAsModerator(IEvent &$event, Circle $circle) {
+	private function parseGroupAsModerator(IEvent & $event, Circle $circle) {
 
 		$params = $event->getSubjectParameters();
 		$group = Member::fromJSON($params['group']);
@@ -400,7 +400,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseMemberAsModerator(IEvent &$event, Circle $circle) {
+	private function parseMemberAsModerator(IEvent & $event, Circle $circle) {
 
 		$params = $event->getSubjectParameters();
 		$member = Member::fromJSON($params['member']);
@@ -449,7 +449,7 @@ 
 	 *
 	 * @return IEvent
 	 */
-	private function parseLinkAsModerator(IEvent &$event, Circle $circle) {
+	private function parseLinkAsModerator(IEvent & $event, Circle $circle) {
 
 		$params = $event->getSubjectParameters();
 		$remote = FederatedLink::fromJSON($params['link']);

lib/Db/CoreRequestBuilder.php

Spacing +30 added lines, -30 removed lines

@@ -71,7 +71,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $id
 	 */
-	protected function limitToId(IQueryBuilder &$qb, $id) {
+	protected function limitToId(IQueryBuilder & $qb, $id) {
 		$this->limitToDBField($qb, 'id', $id);
 	}
 
@@ -82,7 +82,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $uniqueId
 	 */
-	protected function limitToUniqueId(IQueryBuilder &$qb, $uniqueId) {
+	protected function limitToUniqueId(IQueryBuilder & $qb, $uniqueId) {
 		$this->limitToDBField($qb, 'unique_id', $uniqueId);
 	}
 
@@ -93,7 +93,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $token
 	 */
-	protected function limitToToken(IQueryBuilder &$qb, $token) {
+	protected function limitToToken(IQueryBuilder & $qb, $token) {
 		$this->limitToDBField($qb, 'token', $token);
 	}
 
@@ -106,7 +106,7 @@ 
 	 *
 	 * @internal param int $circleId
 	 */
-	protected function limitToUserId(IQueryBuilder &$qb, $userId) {
+	protected function limitToUserId(IQueryBuilder & $qb, $userId) {
 		$this->limitToDBField($qb, 'user_id', $userId);
 	}
 
@@ -120,7 +120,7 @@ 
 	 *
 	 * @internal param int $circleId
 	 */
-	protected function limitToUserType(IQueryBuilder &$qb, $type) {
+	protected function limitToUserType(IQueryBuilder & $qb, $type) {
 		$this->limitToDBField($qb, 'user_type', $type);
 	}
 
@@ -132,7 +132,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $circleUniqueId
 	 */
-	protected function limitToCircleId(IQueryBuilder &$qb, $circleUniqueId) {
+	protected function limitToCircleId(IQueryBuilder & $qb, $circleUniqueId) {
 		$this->limitToDBField($qb, 'circle_id', $circleUniqueId);
 	}
 
@@ -143,15 +143,15 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $circleUniqueId
 	 */
-	protected function limitToShortenUniqueId(IQueryBuilder &$qb, $circleUniqueId) {
+	protected function limitToShortenUniqueId(IQueryBuilder & $qb, $circleUniqueId) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? '`' . $this->default_select_alias . '`.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? '`'.$this->default_select_alias.'`.' : '';
 
 		$qb->andWhere(
 			$expr->eq(
 				$qb->createNamedParameter($circleUniqueId),
 				$qb->createFunction(
-					'SUBSTR(' . $pf . '`unique_id`' . ', 1, ' . Circle::UNIQUEID_SHORT_LENGTH . ')'
+					'SUBSTR('.$pf.'`unique_id`'.', 1, '.Circle::UNIQUEID_SHORT_LENGTH.')'
 				)
 			)
 		);
@@ -165,7 +165,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $groupId
 	 */
-	protected function limitToGroupId(IQueryBuilder &$qb, $groupId) {
+	protected function limitToGroupId(IQueryBuilder & $qb, $groupId) {
 		$this->limitToDBField($qb, 'group_id', $groupId);
 	}
 
@@ -176,7 +176,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $name
 	 */
-	protected function limitToName(IQueryBuilder &$qb, $name) {
+	protected function limitToName(IQueryBuilder & $qb, $name) {
 		$this->limitToDBField($qb, 'name', $name);
 	}
 
@@ -188,12 +188,12 @@ 
 	 * @param int $level
 	 * @param string|array $pf
 	 */
-	protected function limitToLevel(IQueryBuilder &$qb, $level, $pf = '') {
+	protected function limitToLevel(IQueryBuilder & $qb, $level, $pf = '') {
 		$expr = $qb->expr();
 
 		if ($pf === '') {
-			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
-			$qb->andWhere($expr->gte($p . 'level', $qb->createNamedParameter($level)));
+			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
+			$qb->andWhere($expr->gte($p.'level', $qb->createNamedParameter($level)));
 
 			return;
 		}
@@ -208,7 +208,7 @@ 
 			if ($p === 'g' && !$this->leftJoinedNCGroupAndUser) {
 				continue;
 			}
-			$orX->add($expr->gte($p . '.level', $qb->createNamedParameter($level)));
+			$orX->add($expr->gte($p.'.level', $qb->createNamedParameter($level)));
 		}
 
 		$qb->andWhere($orX);
@@ -220,15 +220,15 @@ 
 	 *
 	 * @param IQueryBuilder $qb
 	 */
-	protected function limitToMembersAndAlmost(IQueryBuilder &$qb) {
+	protected function limitToMembersAndAlmost(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
 		$orX = $expr->orX();
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
 
 		$qb->andWhere($orX);
 	}
@@ -239,10 +239,10 @@ 
 	 * @param string $field
 	 * @param string|integer $value
 	 */
-	private function limitToDBField(IQueryBuilder &$qb, $field, $value) {
+	private function limitToDBField(IQueryBuilder & $qb, $field, $value) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
-		$qb->andWhere($expr->eq($pf . $field, $qb->createNamedParameter($value)));
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
+		$qb->andWhere($expr->eq($pf.$field, $qb->createNamedParameter($value)));
 	}
 
 
@@ -257,9 +257,9 @@ 
 	protected function limitToNCGroupUser(IQueryBuilder $qb, $userId = '') {
 		$expr = $qb->expr();
 
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
-		$and = $expr->andX($expr->eq($pf . 'group_id', 'ncgu.gid'));
+		$and = $expr->andX($expr->eq($pf.'group_id', 'ncgu.gid'));
 		if ($userId !== '') {
 			$and->add($expr->eq('ncgu.uid', $qb->createNamedParameter($userId)));
 		} else {
@@ -278,15 +278,15 @@ 
 	 *
 	 * @deprecated not used (14/07/17)
 	 */
-	protected function rightJoinCircles(IQueryBuilder &$qb) {
+	protected function rightJoinCircles(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
 		$qb->from(self::TABLE_CIRCLES, 'c')
 		   ->andWhere(
 			   $expr->eq(
-				   $pf . 'circle_id',
-				   $qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::UNIQUEID_SHORT_LENGTH . ')')
+				   $pf.'circle_id',
+				   $qb->createFunction('SUBSTR(`c`.`unique_id`, 1, '.Circle::UNIQUEID_SHORT_LENGTH.')')
 			   )
 		   );
 	}
@@ -317,7 +317,7 @@ 
 				$expr->eq('ncgu.gid', 'g.group_id'),
 				$expr->eq(
 					'g.circle_id', $qb->createFunction(
-					'SUBSTR(' . $field . ', 1, ' . Circle::UNIQUEID_SHORT_LENGTH . ')'
+					'SUBSTR('.$field.', 1, '.Circle::UNIQUEID_SHORT_LENGTH.')'
 				)
 				)
 			)

lib/Circles/FileSharingBroadcaster.php

Doc Comments +2 added lines, -2 removed lines

@@ -175,7 +175,7 @@ 
 
 
 	/**
-	 * @param $circleName
+	 * @param string $circleName
 	 * @param IShare $share
 	 * @param string $email
 	 */
@@ -229,7 +229,7 @@ 
 	 * @param $subject
 	 * @param $text
 	 * @param $fileName
-	 * @param $link
+	 * @param string $link
 	 *
 	 * @return \OCP\Mail\IEMailTemplate
 	 */

Spacing +1 added lines, -1 removed lines

@@ -244,7 +244,7 @@
 		$emailTemplate->addHeader();
 		$emailTemplate->addHeading($subject, false);
 		$emailTemplate->addBodyText(
-			$text . "\n " . $this->l10n->t('Click the button below to open it.'), $text
+			$text."\n ".$this->l10n->t('Click the button below to open it.'), $text
 		);
 		$emailTemplate->addBodyButton($this->l10n->t('Open »%s«', [$fileName]), $link);
 

lib/Model/SharingFrame.php

Doc Comments +3 added lines

@@ -278,6 +278,9 @@
 		);
 	}
 
+	/**
+	 * @param string $json
+	 */
 	public static function fromJSON($json) {
 
 		$arr = json_decode($json, true);

lib/Controller/FederatedController.php

Spacing +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 	 * @return DataResponse
 	 */
 	private function federatedFail($reason) {
-		$this->miscService->log(2, 'federated fail: ' . $reason);
+		$this->miscService->log(2, 'federated fail: '.$reason);
 
 		return new DataResponse(
 			[

lib/Service/MiscService.php

Spacing +1 added lines, -1 removed lines

@@ -227,7 +227,7 @@
 		ob_start();
 		echo($result);
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 */