Completed
Pull Request — master (#2056)
by
unknown
29s
created
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
 	public function registerFilesNavigation() {
169 169
 		$appManager = FilesApp::getNavigationManager();
170 170
 		$appManager->add(
171
-			function () {
171
+			function() {
172 172
 				$l = OC::$server->getL10N('circles');
173 173
 
174 174
 				return [
Please login to merge, or discard this patch.
lib/Model/FileCacheWrapper.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 		}
457 457
 
458 458
 		$path = $this->getPath();
459
-		[$storageType,] = explode('::', $this->getStorage(), 2);
459
+		[$storageType, ] = explode('::', $this->getStorage(), 2);
460 460
 
461 461
 		if ($path === '') {
462 462
 			// we only accept empty path on external storage
@@ -508,29 +508,29 @@  discard block
 block discarded – undo
508 508
 	 * @throws FileCacheNotFoundException
509 509
 	 */
510 510
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
511
-		if ($this->getInt($prefix . 'fileid', $data) === 0) {
511
+		if ($this->getInt($prefix.'fileid', $data) === 0) {
512 512
 			throw new FileCacheNotFoundException();
513 513
 		}
514 514
 
515
-		$this->setId($this->getInt($prefix . 'fileid', $data));
516
-		$this->setPath($this->get($prefix . 'path', $data));
517
-		$this->setPermissions($this->getInt($prefix . 'permissions', $data));
518
-		$this->setStorageId($this->getInt($prefix . 'storage', $data));
519
-		$this->setPathHash($this->get($prefix . 'path_hash', $data));
520
-		$this->setParent($this->getInt($prefix . 'parent', $data));
521
-		$this->setName($this->get($prefix . 'name', $data));
522
-		$this->setMimeType($this->getInt($prefix . 'mimetype', $data));
523
-		$this->setMimePart($this->getInt($prefix . 'mimepart', $data));
524
-		$this->setSize($this->getInt($prefix . 'size', $data));
525
-		$this->setMTime($this->getInt($prefix . 'mtime', $data));
526
-		$this->setStorageMTime($this->getInt($prefix . 'storage_mtime', $data));
527
-		$this->setEncrypted($this->getBool($prefix . 'encrypted', $data));
528
-		$this->setUnencryptedSize($this->getInt($prefix . 'unencrypted_size', $data));
529
-		$this->setEtag($this->get($prefix . 'etag', $data));
530
-		$this->setChecksum($this->get($prefix . 'checksum', $data));
515
+		$this->setId($this->getInt($prefix.'fileid', $data));
516
+		$this->setPath($this->get($prefix.'path', $data));
517
+		$this->setPermissions($this->getInt($prefix.'permissions', $data));
518
+		$this->setStorageId($this->getInt($prefix.'storage', $data));
519
+		$this->setPathHash($this->get($prefix.'path_hash', $data));
520
+		$this->setParent($this->getInt($prefix.'parent', $data));
521
+		$this->setName($this->get($prefix.'name', $data));
522
+		$this->setMimeType($this->getInt($prefix.'mimetype', $data));
523
+		$this->setMimePart($this->getInt($prefix.'mimepart', $data));
524
+		$this->setSize($this->getInt($prefix.'size', $data));
525
+		$this->setMTime($this->getInt($prefix.'mtime', $data));
526
+		$this->setStorageMTime($this->getInt($prefix.'storage_mtime', $data));
527
+		$this->setEncrypted($this->getBool($prefix.'encrypted', $data));
528
+		$this->setUnencryptedSize($this->getInt($prefix.'unencrypted_size', $data));
529
+		$this->setEtag($this->get($prefix.'etag', $data));
530
+		$this->setChecksum($this->get($prefix.'checksum', $data));
531 531
 
532 532
 		// small hack as there is no reason to call a recursive method for a single entry from the table
533
-		$this->setStorage($this->get($prefix . CoreQueryBuilder::STORAGES . '_id', $data));
533
+		$this->setStorage($this->get($prefix.CoreQueryBuilder::STORAGES.'_id', $data));
534 534
 
535 535
 		return $this;
536 536
 	}
Please login to merge, or discard this patch.
lib/Service/ActivityService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 		$event->setSubject('circle_create', ['circle' => json_encode($circle)]);
76 76
 
77 77
 		$this->userManager->callForSeenUsers(
78
-			function ($user) use ($event) {
78
+			function($user) use ($event) {
79 79
 				/** @var IUser $user */
80 80
 				$this->publishEvent($event, [$user]);
81 81
 			}
Please login to merge, or discard this patch.
lib/Service/FederatedUserService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -528,7 +528,7 @@  discard block
 block discarded – undo
528 528
 		if ($check) {
529 529
 			$user = $this->userManager->get($userId);
530 530
 			if ($user === null) {
531
-				throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
531
+				throw new FederatedUserNotFoundException('user '.$userId.' not found');
532 532
 			}
533 533
 			$displayName = $this->userManager->getDisplayName($userId);
534 534
 		} else {
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
 			$prefix = ($federatedUser->getUserType() === Member::TYPE_APP) ? 'app'
1044 1044
 				: Member::$TYPE[$federatedUser->getUserType()];
1045 1045
 
1046
-			$circle->setName($prefix . ':' . $federatedUser->getUserId() . ':' . $id)
1046
+			$circle->setName($prefix.':'.$federatedUser->getUserId().':'.$id)
1047 1047
 				   ->setDisplayName($federatedUser->getDisplayName())
1048 1048
 				   ->setSingleId($id)
1049 1049
 				   ->setSource($source);
@@ -1247,7 +1247,7 @@  discard block
 block discarded – undo
1247 1247
 		$owner = $this->getCurrentApp();
1248 1248
 
1249 1249
 		$circle = new Circle();
1250
-		$circle->setName('group:' . $groupId)
1250
+		$circle->setName('group:'.$groupId)
1251 1251
 			   ->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
1252 1252
 			   ->setSingleId($this->token(ManagedModel::ID_LENGTH))
1253 1253
 			   ->setSource(Member::TYPE_GROUP);
@@ -1315,8 +1315,8 @@  discard block
 block discarded – undo
1315 1315
 	 * @return string
1316 1316
 	 */
1317 1317
 	private function generateCacheKey(FederatedUser $federatedUser): string {
1318
-		return $federatedUser->getInstance() . '#'
1319
-			   . $federatedUser->getUserType() . '#'
1318
+		return $federatedUser->getInstance().'#'
1319
+			   . $federatedUser->getUserType().'#'
1320 1320
 			   . $federatedUser->getUserId();
1321 1321
 	}
1322 1322
 }
Please login to merge, or discard this patch.
lib/Db/CircleRequest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -184,8 +184,8 @@
 block discarded – undo
184 184
 		$qb->filterCircles(CoreQueryBuilder::CIRCLE, $probe);
185 185
 		if (!is_null($initiator)) {
186 186
 			$qb->limitToInitiator(CoreQueryBuilder::CIRCLE, $initiator);
187
-			$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR) . '.level', 'desc');
188
-			$qb->addOrderBy(CoreQueryBuilder::CIRCLE . '.display_name', 'asc');
187
+			$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR).'.level', 'desc');
188
+			$qb->addOrderBy(CoreQueryBuilder::CIRCLE.'.display_name', 'asc');
189 189
 		}
190 190
 		if ($probe->hasFilterMember()) {
191 191
 			$qb->limitToDirectMembership(CoreQueryBuilder::CIRCLE, $probe->getFilterMember());
Please login to merge, or discard this patch.
lib/Model/Circle.php 1 patch
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -90,27 +90,27 @@  discard block
 block discarded – undo
90 90
 	public const FLAGS_LONG = 2;
91 91
 
92 92
 	// specific value
93
-	public const CFG_CIRCLE = 0;        // only for code readability. Circle is locked by default.
94
-	public const CFG_SINGLE = 1;        // Circle with only one single member.
95
-	public const CFG_PERSONAL = 2;      // Personal circle, only the owner can see it.
93
+	public const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default.
94
+	public const CFG_SINGLE = 1; // Circle with only one single member.
95
+	public const CFG_PERSONAL = 2; // Personal circle, only the owner can see it.
96 96
 
97 97
 	// bitwise
98
-	public const CFG_SYSTEM = 4;            // System Circle (not managed by the official front-end). Meaning some config are limited
99
-	public const CFG_VISIBLE = 8;           // Visible to everyone, if not visible, people have to know its name to be able to find it
100
-	public const CFG_OPEN = 16;             // Circle is open, people can join
101
-	public const CFG_INVITE = 32;           // Adding a member generate an invitation that needs to be accepted
102
-	public const CFG_REQUEST = 64;          // Request to join Circles needs to be confirmed by a moderator
103
-	public const CFG_FRIEND = 128;          // Members of the circle can invite their friends
104
-	public const CFG_PROTECTED = 256;       // Password protected to join/request
105
-	public const CFG_NO_OWNER = 512;        // no owner, only members
106
-	public const CFG_HIDDEN = 1024;         // hidden from listing, but available as a share entity
107
-	public const CFG_BACKEND = 2048;            // Fully hidden, only backend Circles
108
-	public const CFG_LOCAL = 4096;              // Local even on GlobalScale
109
-	public const CFG_ROOT = 8192;               // Circle cannot be inside another Circle
110
-	public const CFG_CIRCLE_INVITE = 16384;     // Circle must confirm when invited in another circle
111
-	public const CFG_FEDERATED = 32768;         // Federated
112
-	public const CFG_MOUNTPOINT = 65536;        // Generate a Files folder for this Circle
113
-	public const CFG_APP = 131072;          // Some features are not available to the OCS API (ie. destroying Circle)
98
+	public const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited
99
+	public const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it
100
+	public const CFG_OPEN = 16; // Circle is open, people can join
101
+	public const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted
102
+	public const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator
103
+	public const CFG_FRIEND = 128; // Members of the circle can invite their friends
104
+	public const CFG_PROTECTED = 256; // Password protected to join/request
105
+	public const CFG_NO_OWNER = 512; // no owner, only members
106
+	public const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity
107
+	public const CFG_BACKEND = 2048; // Fully hidden, only backend Circles
108
+	public const CFG_LOCAL = 4096; // Local even on GlobalScale
109
+	public const CFG_ROOT = 8192; // Circle cannot be inside another Circle
110
+	public const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle
111
+	public const CFG_FEDERATED = 32768; // Federated
112
+	public const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle
113
+	public const CFG_APP = 131072; // Some features are not available to the OCS API (ie. destroying Circle)
114 114
 	public static $DEF_CFG_MAX = 262143;
115 115
 
116 116
 
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 	 */
480 480
 	public function addInheritedMembers(array $members): self {
481 481
 		$knownIds = array_map(
482
-			function (Member $member): string {
482
+			function(Member $member): string {
483 483
 				return $member->getId();
484 484
 			}, $this->inheritedMembers
485 485
 		);
@@ -893,25 +893,25 @@  discard block
 block discarded – undo
893 893
 	 * @throws CircleNotFoundException
894 894
 	 */
895 895
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
896
-		if ($this->get($prefix . 'unique_id', $data) === '') {
896
+		if ($this->get($prefix.'unique_id', $data) === '') {
897 897
 			throw new CircleNotFoundException();
898 898
 		}
899 899
 
900
-		$this->setSingleId($this->get($prefix . 'unique_id', $data))
901
-			 ->setName($this->get($prefix . 'name', $data))
902
-			 ->setDisplayName($this->get($prefix . 'display_name', $data))
903
-			 ->setSanitizedName($this->get($prefix . 'sanitized_name', $data))
904
-			 ->setConfig($this->getInt($prefix . 'config', $data))
905
-			 ->setSource($this->getInt($prefix . 'source', $data))
906
-			 ->setInstance($this->get($prefix . 'instance', $data))
907
-			 ->setSettings($this->getArray($prefix . 'settings', $data))
908
-			 ->setContactAddressBook($this->getInt($prefix . 'contact_addressbook', $data))
909
-			 ->setContactGroupName($this->get($prefix . 'contact_groupname', $data))
910
-			 ->setDescription($this->get($prefix . 'description', $data));
911
-
912
-		$creation = $this->get($prefix . 'creation', $data);
900
+		$this->setSingleId($this->get($prefix.'unique_id', $data))
901
+			 ->setName($this->get($prefix.'name', $data))
902
+			 ->setDisplayName($this->get($prefix.'display_name', $data))
903
+			 ->setSanitizedName($this->get($prefix.'sanitized_name', $data))
904
+			 ->setConfig($this->getInt($prefix.'config', $data))
905
+			 ->setSource($this->getInt($prefix.'source', $data))
906
+			 ->setInstance($this->get($prefix.'instance', $data))
907
+			 ->setSettings($this->getArray($prefix.'settings', $data))
908
+			 ->setContactAddressBook($this->getInt($prefix.'contact_addressbook', $data))
909
+			 ->setContactGroupName($this->get($prefix.'contact_groupname', $data))
910
+			 ->setDescription($this->get($prefix.'description', $data));
911
+
912
+		$creation = $this->get($prefix.'creation', $data);
913 913
 		$dateTime = DateTime::createFromFormat('Y-m-d H:i:s', $creation);
914
-		$timestamp = $dateTime ? $dateTime->getTimestamp() : (int) strtotime($creation);
914
+		$timestamp = $dateTime ? $dateTime->getTimestamp() : (int)strtotime($creation);
915 915
 		$this->setCreation($timestamp);
916 916
 
917 917
 		$this->setPopulation($this->getInt('population', $this->getSettings()));
Please login to merge, or discard this patch.
lib/Command/MembersAdd.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 		} catch (FederatedItemException $e) {
130 130
 			if ($input->getOption('status-code')) {
131 131
 				throw new FederatedItemException(
132
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
132
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
133 133
 				);
134 134
 			}
135 135
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 				$instance = $host;
190 190
 			}
191 191
 
192
-			$result[] = $user['userid']['value'] . ' <info>@' . $host . '</info>';
192
+			$result[] = $user['userid']['value'].' <info>@'.$host.'</info>';
193 193
 		}
194 194
 
195 195
 		//		if ($userId === '') {
Please login to merge, or discard this patch.
lib/Command/CirclesMemberships.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -212,10 +212,10 @@  discard block
 block discarded – undo
212 212
 		//			return 0;
213 213
 		//		}
214 214
 
215
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
216
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
217
-		$output->writeln('Type: <info>' . Member::$TYPE[$federatedUser->getUserType()] . '</info>');
218
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
215
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
216
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
217
+		$output->writeln('Type: <info>'.Member::$TYPE[$federatedUser->getUserType()].'</info>');
218
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
219 219
 
220 220
 		$output->writeln('');
221 221
 		$output->writeln('Memberships:');
@@ -224,14 +224,14 @@  discard block
 block discarded – undo
224 224
 		if ($count === 0) {
225 225
 			$output->writeln('(database not updated)');
226 226
 		} else {
227
-			$output->writeln('(' . $count . ' entries generated/updated in the database)');
227
+			$output->writeln('('.$count.' entries generated/updated in the database)');
228 228
 		}
229 229
 
230 230
 		foreach ($federatedUser->getMemberships() as $membership) {
231 231
 			$this->memberships[$membership->getCircleId()] = $membership;
232 232
 			$output->writeln(
233
-				'- <info>' . $membership->getCircleId() . '</info> ('
234
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
233
+				'- <info>'.$membership->getCircleId().'</info> ('
234
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
235 235
 			);
236 236
 		}
237 237
 
@@ -305,9 +305,9 @@  discard block
 block discarded – undo
305 305
 				if ($lineNumber === 2) {
306 306
 					return '';
307 307
 				}
308
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
308
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
309 309
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
310
-					$line .= '@' . $federatedUser->getInstance();
310
+					$line .= '@'.$federatedUser->getInstance();
311 311
 				}
312 312
 
313 313
 				return $line;
@@ -319,28 +319,28 @@  discard block
 block discarded – undo
319 319
 				$circle = $member->getCircle();
320 320
 
321 321
 				if ($lineNumber === 1) {
322
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
322
+					$line .= '<info>'.$circle->getSingleId().'</info>';
323 323
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
324
-						$line .= '@' . $circle->getInstance();
324
+						$line .= '@'.$circle->getInstance();
325 325
 					}
326
-					$line .= ' (' . ($this->input->getOption('display-name') ?
327
-							$circle->getDisplayName() : $circle->getName()) . ')';
328
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
329
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
326
+					$line .= ' ('.($this->input->getOption('display-name') ?
327
+							$circle->getDisplayName() : $circle->getName()).')';
328
+					$line .= ' <info>MemberId</info>: '.$member->getId();
329
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
330 330
 
331 331
 					$knownMembership = $this->memberships[$member->getCircleId()];
332 332
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
333
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
333
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
334 334
 					}
335 335
 				}
336 336
 				if ($lineNumber === 2) {
337 337
 					$owner = $circle->getOwner();
338
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance() . ' ';
338
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance().' ';
339 339
 					if ($owner->hasBasedOn()) {
340
-						$line .= '(' . Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()] . ') ';
340
+						$line .= '('.Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()].') ';
341 341
 					}
342 342
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
343
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
343
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
344 344
 				}
345 345
 
346 346
 				return $line;
@@ -399,6 +399,6 @@  discard block
 block discarded – undo
399 399
 			);
400 400
 		}
401 401
 
402
-		$output->writeln($count . ' memberships updated');
402
+		$output->writeln($count.' memberships updated');
403 403
 	}
404 404
 }
Please login to merge, or discard this patch.
lib/Command/CirclesTest.php 1 patch
Spacing   +66 added lines, -66 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 
204 204
 		// get the singleId of a Group
205 205
 		$federatedUser = $circlesManager->getFederatedUser('testGroup', Member::TYPE_GROUP);
206
-		echo 'singleId: ' . $federatedUser->getSingleId() . "\n";
206
+		echo 'singleId: '.$federatedUser->getSingleId()."\n";
207 207
 
208 208
 		//		$federatedUser->getMemberships();
209 209
 
@@ -242,8 +242,8 @@  discard block
 block discarded – undo
242 242
 
243 243
 
244 244
 		$members = array_map(
245
-			function (Member $member): string {
246
-				return $member->getUserId() . ' ' . $member->getSingleId() . '   - ' . $member->getUserType();
245
+			function(Member $member): string {
246
+				return $member->getUserId().' '.$member->getSingleId().'   - '.$member->getUserType();
247 247
 			}, $circle->getInheritedMembers()
248 248
 		);
249 249
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 			} catch (Exception $e) {
330 330
 				if ($this->pOn) {
331 331
 					$message = ($e->getMessage() !== '') ? $e->getMessage() : get_class($e);
332
-					$this->output->writeln('<error>' . $message . '</error>');
332
+					$this->output->writeln('<error>'.$message.'</error>');
333 333
 				} else {
334 334
 					throw $e;
335 335
 				}
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
 	 */
414 414
 	private function loadConfiguration() {
415 415
 		$this->p('Loading configuration');
416
-		$configuration = file_get_contents(__DIR__ . '/../../testConfiguration.json');
416
+		$configuration = file_get_contents(__DIR__.'/../../testConfiguration.json');
417 417
 		$this->config = json_decode($configuration, true);
418 418
 		$this->r(true, 'testConfiguration.json');
419 419
 
@@ -446,22 +446,22 @@  discard block
 block discarded – undo
446 446
 		$this->r();
447 447
 
448 448
 		foreach ($this->getInstances() as $instance) {
449
-			$this->p('Creating users on ' . $instance);
449
+			$this->p('Creating users on '.$instance);
450 450
 			foreach ($this->getConfigArray($instance, 'users') as $userId) {
451 451
 				$this->pm($userId);
452 452
 				$this->occ(
453
-					$instance, 'user:add --password-from-env ' . $userId, false, false,
453
+					$instance, 'user:add --password-from-env '.$userId, false, false,
454 454
 					['OC_PASS' => 'testtest']
455 455
 				);
456 456
 			}
457 457
 			$this->r();
458 458
 
459 459
 			foreach ($this->getConfigArray($instance, 'groups') as $groupId => $users) {
460
-				$this->p('Creating group <info>' . $groupId . '</info> on <info>' . $instance . '</info>');
461
-				$this->occ($instance, 'group:add ' . $groupId, false, false);
460
+				$this->p('Creating group <info>'.$groupId.'</info> on <info>'.$instance.'</info>');
461
+				$this->occ($instance, 'group:add '.$groupId, false, false);
462 462
 				foreach ($users as $userId) {
463 463
 					$this->pm($userId);
464
-					$this->occ($instance, 'group:adduser ' . $groupId . ' ' . $userId, true, false);
464
+					$this->occ($instance, 'group:adduser '.$groupId.' '.$userId, true, false);
465 465
 				}
466 466
 				$this->r();
467 467
 			}
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 		foreach ($this->getInstances(true) as $instance) {
496 496
 			$this->pm($instance);
497 497
 			foreach ($this->getConfigArray($instance, 'config') as $k => $v) {
498
-				$this->occ($instance, 'config:app:set --value ' . $v . ' circles ' . $k, true, false);
498
+				$this->occ($instance, 'config:app:set --value '.$v.' circles '.$k, true, false);
499 499
 			}
500 500
 		}
501 501
 		$this->r();
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 	 */
509 509
 	private function confirmVersion() {
510 510
 		$version = $this->configService->getAppValue('installed_version');
511
-		$this->p('Confirming version <info>' . $version . '</info>');
511
+		$this->p('Confirming version <info>'.$version.'</info>');
512 512
 		foreach ($this->getInstances(false) as $instance) {
513 513
 			$this->pm($instance);
514 514
 			$capabilities = $this->occ($instance, 'circles:check --capabilities');
@@ -559,12 +559,12 @@  discard block
 block discarded – undo
559 559
 	 */
560 560
 	private function statusFreshInstances() {
561 561
 		foreach ($this->getInstances() as $instanceId) {
562
-			$this->p('Circles on ' . $instanceId);
562
+			$this->p('Circles on '.$instanceId);
563 563
 			$result = $this->occ($instanceId, 'circles:manage:list --all');
564 564
 			$expectedSize = sizeof($this->getConfigArray($instanceId, 'groups'))
565 565
 							+ sizeof($this->getConfigArray($instanceId, 'users'))
566 566
 							+ 1;
567
-			$this->r((sizeof($result) === $expectedSize), sizeof($result) . ' circles');
567
+			$this->r((sizeof($result) === $expectedSize), sizeof($result).' circles');
568 568
 
569 569
 			$membersList = $groupsList = [];
570 570
 			foreach ($result as $item) {
@@ -583,12 +583,12 @@  discard block
 block discarded – undo
583 583
 			$instance = $this->getConfig($instanceId, 'config.frontal_cloud_id');
584 584
 
585 585
 			foreach ($this->getConfigArray($instanceId, 'users') as $userId) {
586
-				$this->p('Checking Single Circle for <comment>' . $userId . '@' . $instance . '</comment>');
586
+				$this->p('Checking Single Circle for <comment>'.$userId.'@'.$instance.'</comment>');
587 587
 				$circle = $this->getSingleCircleForMember($membersList, $userId, $instance);
588 588
 
589 589
 				$compareToOwnerBasedOn = new Circle();
590 590
 				$compareToOwnerBasedOn->setConfig(Circle::CFG_SINGLE)
591
-									  ->setName('user:' . $userId . ':{CIRCLEID}')
591
+									  ->setName('user:'.$userId.':{CIRCLEID}')
592 592
 									  ->setDisplayName($userId);
593 593
 
594 594
 				$compareToOwner = new Member();
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
 				$compareTo = new Circle();
607 607
 				$compareTo->setOwner($compareToOwner)
608 608
 						  ->setConfig(Circle::CFG_SINGLE)
609
-						  ->setName('user:' . $userId . ':{CIRCLEID}')
609
+						  ->setName('user:'.$userId.':{CIRCLEID}')
610 610
 						  ->setDisplayName($userId);
611 611
 
612 612
 				$this->confirmCircleData($circle, $compareTo);
@@ -643,8 +643,8 @@  discard block
 block discarded – undo
643 643
 			$this->r(true, $circle->getSingleId());
644 644
 
645 645
 			foreach ($this->getConfigArray($instanceId, 'groups') as $groupId => $members) {
646
-				$this->p('Checking Circle for <comment>' . $groupId . '@' . $instance . '</comment>');
647
-				$circle = $this->getCircleFromList($groupsList, 'group:' . $groupId);
646
+				$this->p('Checking Circle for <comment>'.$groupId.'@'.$instance.'</comment>');
647
+				$circle = $this->getCircleFromList($groupsList, 'group:'.$groupId);
648 648
 
649 649
 				$appCircle = $this->getSingleCircleForMember($membersList, 'circles', $instance);
650 650
 				$appOwner = $appCircle->getOwner();
@@ -668,7 +668,7 @@  discard block
 block discarded – undo
668 668
 				$compareTo = new Circle();
669 669
 				$compareTo->setOwner($compareToOwner)
670 670
 						  ->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
671
-						  ->setName('group:' . $groupId)
671
+						  ->setName('group:'.$groupId)
672 672
 						  ->setDisplayName($groupId);
673 673
 
674 674
 				$this->confirmCircleData($circle, $compareTo);
@@ -685,12 +685,12 @@  discard block
 block discarded – undo
685 685
 	 */
686 686
 	private function createRemoteLink() {
687 687
 		foreach ($this->getInstances() as $instanceId) {
688
-			$this->p('Init remote link from ' . $instanceId);
688
+			$this->p('Init remote link from '.$instanceId);
689 689
 			$links = $this->getConfigArray($instanceId, 'remote');
690 690
 			foreach ($links as $link => $type) {
691 691
 				$remote = $this->getConfig($link, 'config.frontal_cloud_id');
692
-				$this->pm($remote . '(' . $type . ')');
693
-				$this->occ($instanceId, 'circles:remote ' . $remote . ' --type ' . $type . ' --yes');
692
+				$this->pm($remote.'('.$type.')');
693
+				$this->occ($instanceId, 'circles:remote '.$remote.' --type '.$type.' --yes');
694 694
 			}
695 695
 			$this->r();
696 696
 		}
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 	private function buildingLocalDatabase() {
705 705
 		$this->circles = $this->federatedUsers = [];
706 706
 		foreach ($this->getInstances() as $instanceId) {
707
-			$this->p('Retrieving Circles from ' . $instanceId);
707
+			$this->p('Retrieving Circles from '.$instanceId);
708 708
 			$circles = $this->occ($instanceId, 'circles:manage:list --all');
709 709
 			foreach ($circles as $item) {
710 710
 				/** @var Circle $circle */
@@ -739,7 +739,7 @@  discard block
 block discarded – undo
739 739
 		$name = self::$TEST_CIRCLES[0];
740 740
 		$owner = $this->getInstanceUsers($localInstanceId)[1];
741 741
 		$dataCreatedCircle001 =
742
-			$this->occ($localInstanceId, 'circles:manage:create --type user ' . $owner . ' ' . $name);
742
+			$this->occ($localInstanceId, 'circles:manage:create --type user '.$owner.' '.$name);
743 743
 		/** @var Circle $createdCircle */
744 744
 		$createdCircle = $this->deserialize($dataCreatedCircle001, Circle::class);
745 745
 		$this->circles[$localInstanceId][$createdCircle->getName()] = $createdCircle;
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
 
772 772
 
773 773
 		$this->p('Comparing local stored data');
774
-		$dataCircle = $this->occ($localInstanceId, 'circle:manage:details ' . $createdCircle->getSingleId());
774
+		$dataCircle = $this->occ($localInstanceId, 'circle:manage:details '.$createdCircle->getSingleId());
775 775
 
776 776
 		/** @var Circle $tmpCircle */
777 777
 		$tmpCircle = $this->deserialize($dataCircle, Circle::class);
@@ -780,9 +780,9 @@  discard block
 block discarded – undo
780 780
 
781 781
 		$links = $this->getConfigArray('global-scale-1', 'remote');
782 782
 		foreach ($this->getInstances(false) as $instanceId) {
783
-			$this->p('Comparing data stored on ' . $instanceId);
783
+			$this->p('Comparing data stored on '.$instanceId);
784 784
 			$dataCircle =
785
-				$this->occ($instanceId, 'circle:manage:details ' . $createdCircle->getSingleId(), false);
785
+				$this->occ($instanceId, 'circle:manage:details '.$createdCircle->getSingleId(), false);
786 786
 
787 787
 			if ($instanceId === $localInstanceId || $links[$instanceId] === 'GlobalScale') {
788 788
 				/** @var Circle $tmpCircle */
@@ -835,11 +835,11 @@  discard block
 block discarded – undo
835 835
 		$name = self::$TEST_CIRCLES[0];
836 836
 		$circle = $this->getCircleByName($localInstanceId, $name);
837 837
 		$userId = $this->getInstanceUsers($localInstanceId)[6];
838
-		$userCircle = $this->getCircleByName($localInstanceId, 'user:' . $userId);
838
+		$userCircle = $this->getCircleByName($localInstanceId, 'user:'.$userId);
839 839
 		$user = $userCircle->getOwner();
840 840
 		$dataAddedMember =
841 841
 			$this->occ(
842
-				$localInstanceId, 'circles:members:add ' . $circle->getSingleId() . ' ' . $user->getSingleId()
842
+				$localInstanceId, 'circles:members:add '.$circle->getSingleId().' '.$user->getSingleId()
843 843
 			);
844 844
 		/** @var Member $addedMember */
845 845
 		$addedMember = $this->deserialize($dataAddedMember, Member::class);
@@ -859,11 +859,11 @@  discard block
 block discarded – undo
859 859
 
860 860
 		$circle = $this->getCircleByName($localInstanceId, $circleName);
861 861
 		$userId = $this->getInstanceUsers($localInstanceId)[6];
862
-		$userCircle = $this->getCircleByName($localInstanceId, 'user:' . $userId);
862
+		$userCircle = $this->getCircleByName($localInstanceId, 'user:'.$userId);
863 863
 		$user = $userCircle->getOwner();
864 864
 		$dataAddedMember =
865 865
 			$this->occ(
866
-				$localInstanceId, 'circles:members:add ' . $circle->getSingleId() . ' ' . $user->getSingleId()
866
+				$localInstanceId, 'circles:members:add '.$circle->getSingleId().' '.$user->getSingleId()
867 867
 			);
868 868
 		/** @var Member $addedMember */
869 869
 		$addedMember = $this->deserialize($dataAddedMember, Member::class);
@@ -957,13 +957,13 @@  discard block
 block discarded – undo
957 957
 			];
958 958
 		}
959 959
 
960
-		$this->compare($compareTo->getSingleId(), $circle->getSingleId(), $prefix . '.id', $params);
961
-		$this->compare($compareTo->getName(), $circle->getName(), $prefix . '.name', $params);
960
+		$this->compare($compareTo->getSingleId(), $circle->getSingleId(), $prefix.'.id', $params);
961
+		$this->compare($compareTo->getName(), $circle->getName(), $prefix.'.name', $params);
962 962
 		$this->compare(
963
-			$compareTo->getDisplayName(), $circle->getDisplayName(), $prefix . '.displayName', $params
963
+			$compareTo->getDisplayName(), $circle->getDisplayName(), $prefix.'.displayName', $params
964 964
 		);
965
-		$this->compareInt($compareTo->getConfig(), $circle->getConfig(), $prefix . '.config', true);
966
-		$this->compareInt($compareTo->getSource(), $circle->getSource(), $prefix . '.source');
965
+		$this->compareInt($compareTo->getConfig(), $circle->getConfig(), $prefix.'.config', true);
966
+		$this->compareInt($compareTo->getSource(), $circle->getSource(), $prefix.'.source');
967 967
 
968 968
 		if ($compareTo->hasOwner()) {
969 969
 			$compareToOwner = $compareTo->getOwner();
@@ -973,7 +973,7 @@  discard block
 block discarded – undo
973 973
 					throw new Exception('empty owner');
974 974
 				}
975 975
 				if ($owner->getCircleId() !== $circle->getSingleId()) {
976
-					throw new Exception($prefix . '.owner.circleId is different than ' . $prefix . '.id');
976
+					throw new Exception($prefix.'.owner.circleId is different than '.$prefix.'.id');
977 977
 				}
978 978
 				$this->confirmMemberData($owner, $compareToOwner, 'owner', false, $params);
979 979
 			}
@@ -986,7 +986,7 @@  discard block
 block discarded – undo
986 986
 				}
987 987
 				$initiator = $circle->getInitiator();
988 988
 				if ($initiator->getCircleId() !== $circle->getSingleId()) {
989
-					throw new Exception($prefix . '.initiator.circleId is different than ' . $prefix . '.id');
989
+					throw new Exception($prefix.'.initiator.circleId is different than '.$prefix.'.id');
990 990
 				}
991 991
 				$this->confirmMemberData($initiator, $compareToInitiator, 'owner', false, $params);
992 992
 			}
@@ -1013,27 +1013,27 @@  discard block
 block discarded – undo
1013 1013
 		bool $versa = false,
1014 1014
 		array $params = []
1015 1015
 	) {
1016
-		$this->compare($compareTo->getId(), $member->getId(), $prefix . '.id', $params);
1017
-		$this->compare($compareTo->getCircleId(), $member->getCircleId(), $prefix . '.circleId', $params);
1018
-		$this->compare($compareTo->getSingleId(), $member->getSingleId(), $prefix . '.singleId', $params);
1019
-		$this->compare($compareTo->getUserId(), $member->getUserId(), $prefix . '.userId', $params);
1016
+		$this->compare($compareTo->getId(), $member->getId(), $prefix.'.id', $params);
1017
+		$this->compare($compareTo->getCircleId(), $member->getCircleId(), $prefix.'.circleId', $params);
1018
+		$this->compare($compareTo->getSingleId(), $member->getSingleId(), $prefix.'.singleId', $params);
1019
+		$this->compare($compareTo->getUserId(), $member->getUserId(), $prefix.'.userId', $params);
1020 1020
 		$this->compare(
1021
-			$compareTo->getDisplayName(), $member->getDisplayName(), $prefix . '.displayName', $params
1021
+			$compareTo->getDisplayName(), $member->getDisplayName(), $prefix.'.displayName', $params
1022 1022
 		);
1023
-		$this->compareInt($compareTo->getUserType(), $member->getUserType(), $prefix . '.userType');
1024
-		$this->compare($compareTo->getInstance(), $member->getInstance(), $prefix . '.instance', $params);
1025
-		$this->compareInt($compareTo->getLevel(), $member->getLevel(), $prefix . '.level', true);
1026
-		$this->compare($compareTo->getStatus(), $member->getStatus(), $prefix . '.status', $params);
1023
+		$this->compareInt($compareTo->getUserType(), $member->getUserType(), $prefix.'.userType');
1024
+		$this->compare($compareTo->getInstance(), $member->getInstance(), $prefix.'.instance', $params);
1025
+		$this->compareInt($compareTo->getLevel(), $member->getLevel(), $prefix.'.level', true);
1026
+		$this->compare($compareTo->getStatus(), $member->getStatus(), $prefix.'.status', $params);
1027 1027
 
1028 1028
 		if ($compareTo->hasBasedOn()) {
1029 1029
 			if (!$member->hasBasedOn()) {
1030
-				throw new Exception('empty ' . $prefix . '.basedOn');
1030
+				throw new Exception('empty '.$prefix.'.basedOn');
1031 1031
 			}
1032 1032
 			$basedOn = $member->getBasedOn();
1033 1033
 			$this->confirmCircleData(
1034 1034
 				$basedOn,
1035 1035
 				$compareTo->getBasedOn(),
1036
-				$prefix . '.basedOn',
1036
+				$prefix.'.basedOn',
1037 1037
 				false,
1038 1038
 				$params
1039 1039
 			);
@@ -1052,7 +1052,7 @@  discard block
 block discarded – undo
1052 1052
 	private function compare(string $expected, string $compare, string $def, array $params) {
1053 1053
 		if ($expected !== ''
1054 1054
 			&& $this->feedStringWithParams($expected, $params) !== $compare) {
1055
-			throw new Exception($def . ': ' . $compare . ' (' . $expected . ')');
1055
+			throw new Exception($def.': '.$compare.' ('.$expected.')');
1056 1056
 		}
1057 1057
 	}
1058 1058
 
@@ -1068,7 +1068,7 @@  discard block
 block discarded – undo
1068 1068
 	private function compareInt(int $expected, int $compare, string $def, bool $force = false) {
1069 1069
 		if (($expected > 0 || ($force && $expected >= 0))
1070 1070
 			&& $expected !== $compare) {
1071
-			throw new Exception('wrong ' . $def . ': ' . $compare . ' (' . $expected . ')');
1071
+			throw new Exception('wrong '.$def.': '.$compare.' ('.$expected.')');
1072 1072
 		}
1073 1073
 	}
1074 1074
 
@@ -1104,7 +1104,7 @@  discard block
 block discarded – undo
1104 1104
 			}
1105 1105
 		}
1106 1106
 
1107
-		throw new CircleNotFoundException('cannot find ' . $userId . ' in the list of Single Circle');
1107
+		throw new CircleNotFoundException('cannot find '.$userId.' in the list of Single Circle');
1108 1108
 	}
1109 1109
 
1110 1110
 
@@ -1122,7 +1122,7 @@  discard block
 block discarded – undo
1122 1122
 		}
1123 1123
 
1124 1124
 		throw new CircleNotFoundException(
1125
-			'cannot extract \'' . $name . '\' from the list of generated Circles'
1125
+			'cannot extract \''.$name.'\' from the list of generated Circles'
1126 1126
 		);
1127 1127
 	}
1128 1128
 
@@ -1142,7 +1142,7 @@  discard block
 block discarded – undo
1142 1142
 		}
1143 1143
 
1144 1144
 		throw new CircleNotFoundException(
1145
-			'cannot extract  \'' . $name . '\' from the list of provided Circles'
1145
+			'cannot extract  \''.$name.'\' from the list of provided Circles'
1146 1146
 		);
1147 1147
 	}
1148 1148
 
@@ -1187,7 +1187,7 @@  discard block
 block discarded – undo
1187 1187
 			}
1188 1188
 		}
1189 1189
 
1190
-		throw new ItemNotFoundException($instance . ' not found');
1190
+		throw new ItemNotFoundException($instance.' not found');
1191 1191
 	}
1192 1192
 
1193 1193
 
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
 	): ?array {
1223 1223
 		$configInstance = $this->getConfigInstance($instance);
1224 1224
 		$path = $this->get('path', $configInstance);
1225
-		$occ = rtrim($path, '/') . '/occ';
1225
+		$occ = rtrim($path, '/').'/occ';
1226 1226
 
1227 1227
 		$command = array_merge([$occ], explode(' ', $cmd));
1228 1228
 		if ($jsonAsOutput) {
@@ -1232,7 +1232,7 @@  discard block
 block discarded – undo
1232 1232
 		$process->run(null, $env);
1233 1233
 
1234 1234
 		if ($exceptionOnFail && !$process->isSuccessful()) {
1235
-			throw new Exception(implode(' ', $command) . ' failed');
1235
+			throw new Exception(implode(' ', $command).' failed');
1236 1236
 		}
1237 1237
 
1238 1238
 		$output = json_decode($process->getOutput(), true);
@@ -1255,7 +1255,7 @@  discard block
 block discarded – undo
1255 1255
 	 */
1256 1256
 	private function t(string $title): void {
1257 1257
 		$this->output->writeln('');
1258
-		$this->output->writeln('<comment>### ' . $title . '</comment>');
1258
+		$this->output->writeln('<comment>### '.$title.'</comment>');
1259 1259
 		$this->output->writeln('');
1260 1260
 	}
1261 1261
 
@@ -1264,14 +1264,14 @@  discard block
 block discarded – undo
1264 1264
 	 */
1265 1265
 	private function p(string $processing): void {
1266 1266
 		$this->pOn = true;
1267
-		$this->output->write('- ' . $processing . ': ');
1267
+		$this->output->write('- '.$processing.': ');
1268 1268
 	}
1269 1269
 
1270 1270
 	/**
1271 1271
 	 * @param string $more
1272 1272
 	 */
1273 1273
 	private function pm(string $more): void {
1274
-		$this->output->write($more . ' ');
1274
+		$this->output->write($more.' ');
1275 1275
 	}
1276 1276
 
1277 1277
 	/**
@@ -1281,9 +1281,9 @@  discard block
 block discarded – undo
1281 1281
 	private function r(bool $result = true, string $info = ''): void {
1282 1282
 		$this->pOn = false;
1283 1283
 		if ($result) {
1284
-			$this->output->writeln('<info>' . (($info !== '') ? $info : 'done') . '</info>');
1284
+			$this->output->writeln('<info>'.(($info !== '') ? $info : 'done').'</info>');
1285 1285
 		} else {
1286
-			$this->output->writeln('<error>' . (($info !== '') ? $info : 'done') . '</error>');
1286
+			$this->output->writeln('<error>'.(($info !== '') ? $info : 'done').'</error>');
1287 1287
 		}
1288 1288
 	}
1289 1289
 
@@ -1305,16 +1305,16 @@  discard block
 block discarded – undo
1305 1305
 		$dataAddedMember =
1306 1306
 			$this->occ(
1307 1307
 				$instanceId,
1308
-				'circles:members:add ' . $circle->getSingleId() . ' ' . $userId . ' --type ' . $type
1308
+				'circles:members:add '.$circle->getSingleId().' '.$userId.' --type '.$type
1309 1309
 			);
1310 1310
 		/** @var Member $addedMember */
1311 1311
 		$addedMember = $this->deserialize($dataAddedMember, Member::class);
1312 1312
 
1313 1313
 
1314
-		echo 'ADDEDMEMBER: ' . json_encode($addedMember, JSON_PRETTY_PRINT) . "\n";
1314
+		echo 'ADDEDMEMBER: '.json_encode($addedMember, JSON_PRETTY_PRINT)."\n";
1315 1315
 
1316 1316
 		$federatedUser = $this->federatedUsers[$instanceId][$userId];
1317
-		echo 'FEDERATEDUER: ' . json_encode($federatedUser, JSON_PRETTY_PRINT) . "\n";
1317
+		echo 'FEDERATEDUER: '.json_encode($federatedUser, JSON_PRETTY_PRINT)."\n";
1318 1318
 
1319 1319
 		return $addedMember;
1320 1320
 	}
Please login to merge, or discard this patch.