Completed
Pull Request — master (#2056)
by
unknown
29s
created
lib/Command/CirclesConfig.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 		} catch (FederatedItemException $e) {
156 156
 			if ($input->getOption('status-code')) {
157 157
 				throw new FederatedItemException(
158
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
158
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
159 159
 				);
160 160
 			}
161 161
 
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
189 189
 			$value = array_search(strtoupper($item), $valid);
190 190
 			if (!$value) {
191 191
 				throw new InvalidArgumentException(
192
-					'Invalid config \'' . $item . '\'. Available values: '
193
-					. implode(', ', array_values($valid)) . '. '
192
+					'Invalid config \''.$item.'\'. Available values: '
193
+					. implode(', ', array_values($valid)).'. '
194 194
 					. 'To disable a config, start the value with an underscore'
195 195
 				);
196 196
 			}
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 
220 220
 		array_walk(
221 221
 			$listing,
222
-			function (string &$v): void {
222
+			function(string &$v): void {
223 223
 				[, $long] = explode('|', $v);
224 224
 				$v = strtoupper(str_replace(' ', '', $long));
225 225
 			}
Please login to merge, or discard this patch.
lib/Service/FederatedEventService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -245,16 +245,16 @@  discard block
 block discarded – undo
245 245
 		try {
246 246
 			$test = new ReflectionClass($class);
247 247
 		} catch (ReflectionException $e) {
248
-			throw new FederatedEventException('ReflectionException with ' . $class . ': ' . $e->getMessage());
248
+			throw new FederatedEventException('ReflectionException with '.$class.': '.$e->getMessage());
249 249
 		}
250 250
 
251 251
 		if (!in_array(IFederatedItem::class, $test->getInterfaceNames())) {
252
-			throw new FederatedEventException($class . ' does not implements IFederatedItem');
252
+			throw new FederatedEventException($class.' does not implements IFederatedItem');
253 253
 		}
254 254
 
255 255
 		$item = OC::$server->get($class);
256 256
 		if (!($item instanceof IFederatedItem)) {
257
-			throw new FederatedEventException($class . ' not an IFederatedItem');
257
+			throw new FederatedEventException($class.' not an IFederatedItem');
258 258
 		}
259 259
 
260 260
 		if ($item instanceof IFederatedItemHighSeverity) {
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 			$knownInstances = $this->memberRequest->getMemberInstances($circle->getSingleId());
451 451
 			$instances = array_filter(
452 452
 				array_map(
453
-					function (RemoteInstance $instance) use ($knownInstances) {
453
+					function(RemoteInstance $instance) use ($knownInstances) {
454 454
 						if (!in_array($instance->getInstance(), $knownInstances)) {
455 455
 							return null;
456 456
 						}
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
 		if ($event->hasMember()
466 466
 			&& !$this->configService->isLocalInstance($event->getMember()->getInstance())) {
467 467
 			$currentInstances = array_map(
468
-				function (RemoteInstance $instance): string {
468
+				function(RemoteInstance $instance): string {
469 469
 					return $instance->getInstance();
470 470
 				}, $instances
471 471
 			);
Please login to merge, or discard this patch.
lib/Service/MemberService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@
 block discarded – undo
251 251
 		}
252 252
 
253 253
 		$members = array_map(
254
-			function (FederatedUser $federatedUser) use ($patron) {
254
+			function(FederatedUser $federatedUser) use ($patron) {
255 255
 				$member = new Member();
256 256
 				$member->importFromIFederatedUser($federatedUser);
257 257
 				$member->setInvitedBy($patron);
Please login to merge, or discard this patch.
lib/Service/EventWrapperService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
 	 */
175 175
 	private function getFailedEvents(array $retryRange): array {
176 176
 		$token = array_map(
177
-			function (EventWrapper $event): string {
177
+			function(EventWrapper $event): string {
178 178
 				return $event->getToken();
179 179
 			}, $this->eventWrapperRequest->getFailedEvents($retryRange)
180 180
 		);
Please login to merge, or discard this patch.
lib/Circles/FileSharingBroadcaster.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 			$this->miscService = OC::$server->query(MiscService::class);
137 137
 		} catch (QueryException $e) {
138 138
 			OC::$server->getLogger()
139
-					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - ' . $e->getMessage());
139
+					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - '.$e->getMessage());
140 140
 		}
141 141
 
142 142
 		try {
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 
282 282
 		$allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId());
283 283
 		$knownShares = array_map(
284
-			function (SharesToken $shareToken) {
284
+			function(SharesToken $shareToken) {
285 285
 				return $shareToken->getShareId();
286 286
 			},
287 287
 			$this->tokensRequest->getTokensFromMember($member)
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 	 * @throws IllegalIDChangeException
329 329
 	 */
330 330
 	private function generateShare($data): IShare {
331
-		$this->logger->log(0, 'Regenerate shares from payload: ' . json_encode($data));
331
+		$this->logger->log(0, 'Regenerate shares from payload: '.json_encode($data));
332 332
 
333 333
 		$share = new Share($this->rootFolder, $this->userManager);
334 334
 		$share->setId($data['id']);
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
 			$this->sendPasswordByMail($share, $displayName, $email, $password);
422 422
 		} catch (Exception $e) {
423 423
 			OC::$server->getLogger()
424
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
424
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
425 425
 		}
426 426
 	}
427 427
 
@@ -439,8 +439,8 @@  discard block
 block discarded – undo
439 439
 		$message = $this->mailer->createMessage();
440 440
 
441 441
 		$this->logger->log(
442
-			0, "Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
443
-			   . ' - link: ' . $link
442
+			0, "Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
443
+			   . ' - link: '.$link
444 444
 		);
445 445
 
446 446
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 
480 480
 		$message = $this->mailer->createMessage();
481 481
 
482
-		$this->logger->log(0, "Sending password mail to circle '" . $circleName . "': " . $email);
482
+		$this->logger->log(0, "Sending password mail to circle '".$circleName."': ".$email);
483 483
 
484 484
 		$filename = $share->getNode()
485 485
 						  ->getName();
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
535 535
 		if ($initiatorEmailAddress !== null) {
536 536
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
537
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
537
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
538 538
 		} else {
539 539
 			$emailTemplate->addFooter();
540 540
 		}
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 		$emailTemplate->addHeader();
570 570
 		$emailTemplate->addHeading($subject, false);
571 571
 		$emailTemplate->addBodyText(
572
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
572
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
573 573
 				$this->l10n->t('Click the button below to open it.')
574 574
 			), $text
575 575
 		);
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 			$this->sendMailExistingShares($template, $author->getCachedName(), $recipient);
616 616
 			$this->sendPasswordExistingShares($author, $recipient, $password);
617 617
 		} catch (Exception $e) {
618
-			$this->logger->log(2, 'Failed to send mail about existing share ' . $e->getMessage());
618
+			$this->logger->log(2, 'Failed to send mail about existing share '.$e->getMessage());
619 619
 		}
620 620
 	}
621 621
 
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
639 639
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
640 640
 
641
-		$this->logger->log(0, "Sending password mail about existing files to '" . $email . "'");
641
+		$this->logger->log(0, "Sending password mail about existing files to '".$email."'");
642 642
 
643 643
 		$plainBodyPart = $this->l10n->t(
644 644
 			"%1\$s shared multiple files with you.\nYou should have already received a separate email with a link to access them.\n",
@@ -680,7 +680,7 @@  discard block
 block discarded – undo
680 680
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
681 681
 		if ($authorEmail !== null) {
682 682
 			$message->setReplyTo([$authorEmail => $authorName]);
683
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
683
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
684 684
 		} else {
685 685
 			$emailTemplate->addFooter();
686 686
 		}
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
 	 */
726 726
 	protected function generateMailExitingShares($author, $circleName) {
727 727
 		$this->logger->log(
728
-			0, "Generating mail about existing share mail from '" . $author . "' in "
728
+			0, "Generating mail about existing share mail from '".$author."' in "
729 729
 			   . $circleName
730 730
 		);
731 731
 
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleAddingCircleMember.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -85,35 +85,35 @@
 block discarded – undo
85 85
 
86 86
 		$eventType = ($event->getType() === CircleGenericEvent::INVITED) ? 'invited' : 'joined';
87 87
 
88
-		$info = 'A new member have been added (' . $eventType . ') to a Circle. ';
88
+		$info = 'A new member have been added ('.$eventType.') to a Circle. ';
89 89
 
90
-		$info .= 'userId: ' . $member->getUserId() . '; userType: ' . Member::$TYPE[$member->getUserType()]
91
-				 . '; singleId: ' . $member->getSingleId() . '; memberId: ' . $member->getId()
92
-				 . '; isLocal: ' . json_encode($member->isLocal()) . '; level: '
93
-				 . Member::$DEF_LEVEL[$member->getLevel()] . '; ';
90
+		$info .= 'userId: '.$member->getUserId().'; userType: '.Member::$TYPE[$member->getUserType()]
91
+				 . '; singleId: '.$member->getSingleId().'; memberId: '.$member->getId()
92
+				 . '; isLocal: '.json_encode($member->isLocal()).'; level: '
93
+				 . Member::$DEF_LEVEL[$member->getLevel()].'; ';
94 94
 
95 95
 		$memberships = array_map(
96
-			function (Membership $membership) {
96
+			function(Membership $membership) {
97 97
 				return $membership->getCircleId();
98 98
 			}, $circle->getMemberships()
99 99
 		);
100 100
 
101 101
 		$listMemberships = (count($memberships) > 0) ? implode(', ', $memberships) : 'none';
102
-		$info .= 'circleName: ' . $circle->getDisplayName() . '; circleId: ' . $circle->getSingleId()
103
-				 . '; Circle memberships: ' . $listMemberships . '.';
102
+		$info .= 'circleName: '.$circle->getDisplayName().'; circleId: '.$circle->getSingleId()
103
+				 . '; Circle memberships: '.$listMemberships.'.';
104 104
 
105 105
 		if ($member->getUserType() === Member::TYPE_CIRCLE) {
106 106
 			$basedOn = $member->getBasedOn();
107 107
 			$members = array_map(
108
-				function (Member $member) {
109
-					return $member->getUserId() . ' (' . Member::$TYPE[$member->getUserType()] . ')';
108
+				function(Member $member) {
109
+					return $member->getUserId().' ('.Member::$TYPE[$member->getUserType()].')';
110 110
 				}, $basedOn->getInheritedMembers()
111 111
 			);
112 112
 
113
-			$info .= ' Member is a Circle (singleId: ' . $basedOn->getSingleId()
114
-					 . ') that contains those inherited members: ' . implode(', ', $members);
113
+			$info .= ' Member is a Circle (singleId: '.$basedOn->getSingleId()
114
+					 . ') that contains those inherited members: '.implode(', ', $members);
115 115
 		}
116 116
 
117
-		$this->log(3, $prefix . $info);
117
+		$this->log(3, $prefix.$info);
118 118
 	}
119 119
 }
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleMembershipsRemoved.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 		$prefix = '[Example Event] (ExampleMembershipsRemoved) ';
93 93
 
94 94
 		$memberships = array_map(
95
-			function (Membership $membership) {
95
+			function(Membership $membership) {
96 96
 				$inheritance = ($membership->getInheritanceDepth() > 1) ?
97 97
 					'an inherited member' : 'a direct member';
98 98
 				try {
@@ -100,15 +100,15 @@  discard block
 block discarded – undo
100 100
 				} catch (Exception $e) {
101 101
 					$this->e($e);
102 102
 
103
-					return $membership->getSingleId() . ' is not ' . $inheritance . ' of '
104
-						   . $membership->getCircleId() . ' anymore';
103
+					return $membership->getSingleId().' is not '.$inheritance.' of '
104
+						   . $membership->getCircleId().' anymore';
105 105
 				}
106 106
 
107
-				return $federatedUser->getUserId() . ' (' . Member::$TYPE[$federatedUser->getUserType()]
108
-					   . ') is not ' . $inheritance . ' of ' . $membership->getCircleId() . ' anymore';
107
+				return $federatedUser->getUserId().' ('.Member::$TYPE[$federatedUser->getUserType()]
108
+					   . ') is not '.$inheritance.' of '.$membership->getCircleId().' anymore';
109 109
 			}, $event->getMemberships()
110 110
 		);
111 111
 
112
-		$this->log(3, $prefix . implode('. ', $memberships));
112
+		$this->log(3, $prefix.implode('. ', $memberships));
113 113
 	}
114 114
 }
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleMembershipsCreated.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 		$prefix = '[Example Event] (ExampleMembershipsCreated) ';
93 93
 
94 94
 		$memberships = array_map(
95
-			function (Membership $membership) {
95
+			function(Membership $membership) {
96 96
 				$inheritance = ($membership->getInheritanceDepth() > 1) ?
97 97
 					'an inherited member' : 'a direct member';
98 98
 				try {
@@ -100,15 +100,15 @@  discard block
 block discarded – undo
100 100
 				} catch (Exception $e) {
101 101
 					$this->e($e);
102 102
 
103
-					return $membership->getSingleId() . ' is now ' . $inheritance . ' of '
103
+					return $membership->getSingleId().' is now '.$inheritance.' of '
104 104
 						   . $membership->getCircleId();
105 105
 				}
106 106
 
107
-				return $federatedUser->getUserId() . ' (' . Member::$TYPE[$federatedUser->getUserType()]
108
-					   . ') is now ' . $inheritance . ' of ' . $membership->getCircleId();
107
+				return $federatedUser->getUserId().' ('.Member::$TYPE[$federatedUser->getUserType()]
108
+					   . ') is now '.$inheritance.' of '.$membership->getCircleId();
109 109
 			}, $event->getMemberships()
110 110
 		);
111 111
 
112
-		$this->log(3, $prefix . implode('. ', $memberships));
112
+		$this->log(3, $prefix.implode('. ', $memberships));
113 113
 	}
114 114
 }
Please login to merge, or discard this patch.
lib/Model/GlobalScale/GSShare.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 			return $mountPoint;
153 153
 		}
154 154
 
155
-		return '/' . $userId . '/files/' . ltrim($mountPoint, '/');
155
+		return '/'.$userId.'/files/'.ltrim($mountPoint, '/');
156 156
 	}
157 157
 
158 158
 	/**
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 	public function toMount(string $userId, string $protocol = 'https'): array {
292 292
 		return [
293 293
 			'owner' => $this->getOwner(),
294
-			'remote' => $protocol . '://' . $this->getInstance(),
294
+			'remote' => $protocol.'://'.$this->getInstance(),
295 295
 			'token' => $this->getToken(),
296 296
 			'share_token' => $this->getToken(),
297 297
 			'password' => $this->getPassword(),
Please login to merge, or discard this patch.