Completed
Pull Request — master (#2042)
by
unknown
29s
created
lib/Command/CirclesConfig.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 		} catch (FederatedItemException $e) {
117 117
 			if ($input->getOption('status-code')) {
118 118
 				throw new FederatedItemException(
119
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
119
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
120 120
 				);
121 121
 			}
122 122
 
@@ -158,8 +158,8 @@  discard block
 block discarded – undo
158 158
 			$value = array_search(strtoupper($item), $valid);
159 159
 			if (!$value) {
160 160
 				throw new InvalidArgumentException(
161
-					'Invalid config \'' . $item . '\'. Available values: '
162
-					. implode(', ', array_values($valid)) . '. '
161
+					'Invalid config \''.$item.'\'. Available values: '
162
+					. implode(', ', array_values($valid)).'. '
163 163
 					. 'To disable a config, start the value with an underscore'
164 164
 				);
165 165
 			}
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 		array_walk(
195 195
 			$listing,
196
-			function (string &$v): void {
196
+			function(string &$v): void {
197 197
 				[, $long] = explode('|', $v);
198 198
 				$v = strtoupper(str_replace(' ', '', $long));
199 199
 			}
Please login to merge, or discard this patch.
lib/Command/CirclesCheck.php 1 patch
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 			throw new Exception('Please specify a --type for the test');
110 110
 		}
111 111
 		if ($test !== '' && !in_array($type, self::$checks)) {
112
-			throw new Exception('Unknown type: ' . implode(', ', self::$checks));
112
+			throw new Exception('Unknown type: '.implode(', ', self::$checks));
113 113
 		}
114 114
 
115 115
 		//		$this->configService->setAppValue(ConfigService::TEST_NC_BASE, $test);
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 		}
166 166
 
167 167
 		$output->writeln('');
168
-		$output->writeln('* testing current address: ' . $test);
168
+		$output->writeln('* testing current address: '.$test);
169 169
 
170 170
 		try {
171 171
 			$this->setupLoopback($input, $output, $test);
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
 				continue;
201 201
 			}
202 202
 
203
-			$loopback = rtrim($scheme . '://' . $cloudId . $path, '/');
204
-			$output->writeln('* testing address: ' . $loopback . ' ');
203
+			$loopback = rtrim($scheme.'://'.$cloudId.$path, '/');
204
+			$output->writeln('* testing address: '.$loopback.' ');
205 205
 
206 206
 			try {
207 207
 				$this->setupLoopback($input, $output, $loopback);
@@ -272,8 +272,8 @@  discard block
 block discarded – undo
272 272
 		$test = new FederatedEvent(LoopbackTest::class);
273 273
 		$this->federatedEventService->newEvent($test);
274 274
 		$output->writeln(
275
-			'<info>' . $test->getWrapperToken() . '</info> ' .
276
-			'(took ' . ((string)(round(microtime(true) * 1000.0) - $timer)) . 'ms)'
275
+			'<info>'.$test->getWrapperToken().'</info> '.
276
+			'(took '.((string)(round(microtime(true) * 1000.0) - $timer)).'ms)'
277 277
 		);
278 278
 
279 279
 		$output->writeln('- Waiting for async process to finish (5s)');
@@ -292,18 +292,18 @@  discard block
 block discarded – undo
292 292
 
293 293
 		$checkVerify = $wrapper->getEvent()->getData()->gInt('verify');
294 294
 		if ($checkVerify === LoopbackTest::VERIFY) {
295
-			$output->write('<info>verify=' . ((string)$checkVerify) . '</info> ');
295
+			$output->write('<info>verify='.((string)$checkVerify).'</info> ');
296 296
 		} else {
297
-			$output->writeln('<error>verify=' . ((string)$checkVerify) . '</error>');
297
+			$output->writeln('<error>verify='.((string)$checkVerify).'</error>');
298 298
 
299 299
 			return false;
300 300
 		}
301 301
 
302 302
 		$checkManage = $wrapper->getResult()->gInt('manage');
303 303
 		if ($checkManage === LoopbackTest::MANAGE) {
304
-			$output->write('<info>manage=' . ((string)$checkManage) . '</info> ');
304
+			$output->write('<info>manage='.((string)$checkManage).'</info> ');
305 305
 		} else {
306
-			$output->writeln('<error>manage=' . ((string)$checkManage) . '</error>');
306
+			$output->writeln('<error>manage='.((string)$checkManage).'</error>');
307 307
 
308 308
 			return false;
309 309
 		}
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 		$this->configService->setAppValue(ConfigService::LOOPBACK_CLOUD_ID, $cloudId);
343 343
 		$this->configService->setAppValue(ConfigService::LOOPBACK_CLOUD_PATH, $path);
344 344
 		$output->writeln(
345
-			'- Address <info>' . $loopback . '</info> is now used as <info>loopback</info>'
345
+			'- Address <info>'.$loopback.'</info> is now used as <info>loopback</info>'
346 346
 		);
347 347
 	}
348 348
 
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
 				continue;
396 396
 			}
397 397
 
398
-			$internal = rtrim($scheme . '://' . $cloudId, '/');
399
-			$fullInternal = rtrim($scheme . '://' . $cloudId . $path, '/');
398
+			$internal = rtrim($scheme.'://'.$cloudId, '/');
399
+			$fullInternal = rtrim($scheme.'://'.$cloudId.$path, '/');
400 400
 
401 401
 			$question = new ConfirmationQuestion(
402 402
 				'<comment>Do you want to check the validity of this internal address?</comment> (Y/n) ', true,
@@ -415,9 +415,9 @@  discard block
 block discarded – undo
415 415
 					'You will need to run this <info>curl</info> command from a terminal on your local network and paste its result: '
416 416
 				);
417 417
 				$output->writeln(
418
-					'     curl -L "' . $internal
418
+					'     curl -L "'.$internal
419 419
 					. '/.well-known/webfinger?resource=http://nextcloud.com/&test='
420
-					. $testToken . '"'
420
+					. $testToken.'"'
421 421
 				);
422 422
 
423 423
 				$output->writeln('paste the result here: ');
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 
452 452
 				if ($pastedHref !== $href) {
453 453
 					$output->writeln(
454
-						'<error>The returned data (' . $pastedHref . ') are not the one expected: </error>'
454
+						'<error>The returned data ('.$pastedHref.') are not the one expected: </error>'
455 455
 						. $href
456 456
 					);
457 457
 					continue;
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 					'Next step, please run this <info>curl</info> command from a terminal on your local network and paste its result: '
464 464
 				);
465 465
 				$output->writeln(
466
-					'     curl -L "' . $pastedHref . '?test=' . $testToken . '" -H "Accept: application/json"'
466
+					'     curl -L "'.$pastedHref.'?test='.$testToken.'" -H "Accept: application/json"'
467 467
 				);
468 468
 
469 469
 				$output->writeln('paste the result here: ');
@@ -479,9 +479,9 @@  discard block
 block discarded – undo
479 479
 					|| $appSignatory->getRoot() !== $pastedSignatory->g('root')) {
480 480
 					$output->writeln(
481 481
 						'<error>The returned data ('
482
-						. $pastedSignatory->g('uid') . '/' . $pastedSignatory->g('root')
482
+						. $pastedSignatory->g('uid').'/'.$pastedSignatory->g('root')
483 483
 						. ') are not the one expected: </error>'
484
-						. $appSignatory->getUid(true) . '/' . $appSignatory->getRoot()
484
+						. $appSignatory->getUid(true).'/'.$appSignatory->getRoot()
485 485
 					);
486 486
 					continue;
487 487
 				}
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
 
508 508
 		$output->writeln('');
509 509
 		$question = new ConfirmationQuestion(
510
-			'- Do you want to save <info>' . $internal
510
+			'- Do you want to save <info>'.$internal
511 511
 			. '</info> as your <info>internal</info> address ? (y/N) ',
512 512
 			false, '/^(y|Y)/i'
513 513
 		);
@@ -524,7 +524,7 @@  discard block
 block discarded – undo
524 524
 		$this->configService->setAppValue(ConfigService::INTERNAL_CLOUD_ID, $cloudId);
525 525
 		$this->configService->setAppValue(ConfigService::INTERNAL_CLOUD_PATH, $path);
526 526
 
527
-		$output->writeln('- Address <info>' . $internal . '</info> is now used as <info>internal</info>');
527
+		$output->writeln('- Address <info>'.$internal.'</info> is now used as <info>internal</info>');
528 528
 	}
529 529
 
530 530
 	/**
@@ -575,8 +575,8 @@  discard block
 block discarded – undo
575 575
 				continue;
576 576
 			}
577 577
 
578
-			$frontal = rtrim($scheme . '://' . $cloudId, '/');
579
-			$fullFrontal = rtrim($scheme . '://' . $cloudId . $path, '/');
578
+			$frontal = rtrim($scheme.'://'.$cloudId, '/');
579
+			$fullFrontal = rtrim($scheme.'://'.$cloudId.$path, '/');
580 580
 
581 581
 			$question = new ConfirmationQuestion(
582 582
 				'<comment>Do you want to check the validity of this frontal address?</comment> (y/N) ', false,
@@ -595,9 +595,9 @@  discard block
 block discarded – undo
595 595
 					'You will need to run this <info>curl</info> command from a remote terminal and paste its result: '
596 596
 				);
597 597
 				$output->writeln(
598
-					'     curl -L "' . $frontal
598
+					'     curl -L "'.$frontal
599 599
 					. '/.well-known/webfinger?resource=http://nextcloud.com/&test='
600
-					. $testToken . '"'
600
+					. $testToken.'"'
601 601
 				);
602 602
 
603 603
 				$output->writeln('paste the result here: ');
@@ -631,7 +631,7 @@  discard block
 block discarded – undo
631 631
 
632 632
 				if ($pastedHref !== $href) {
633 633
 					$output->writeln(
634
-						'<error>The returned data (' . $pastedHref . ') are not the one expected: </error>'
634
+						'<error>The returned data ('.$pastedHref.') are not the one expected: </error>'
635 635
 						. $href
636 636
 					);
637 637
 					continue;
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
 					'Next step, please run this <info>curl</info> command from a remote terminal and paste its result: '
644 644
 				);
645 645
 				$output->writeln(
646
-					'     curl -L "' . $pastedHref . '?test=' . $testToken . '" -H "Accept: application/json"'
646
+					'     curl -L "'.$pastedHref.'?test='.$testToken.'" -H "Accept: application/json"'
647 647
 				);
648 648
 
649 649
 				$output->writeln('paste the result here: ');
@@ -659,9 +659,9 @@  discard block
 block discarded – undo
659 659
 					|| $appSignatory->getRoot() !== $pastedSignatory->g('root')) {
660 660
 					$output->writeln(
661 661
 						'<error>The returned data ('
662
-						. $pastedSignatory->g('uid') . '/' . $pastedSignatory->g('root')
662
+						. $pastedSignatory->g('uid').'/'.$pastedSignatory->g('root')
663 663
 						. ') are not the one expected: </error>'
664
-						. $appSignatory->getUid(true) . '/' . $appSignatory->getRoot()
664
+						. $appSignatory->getUid(true).'/'.$appSignatory->getRoot()
665 665
 					);
666 666
 					continue;
667 667
 				}
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
 
688 688
 		$output->writeln('');
689 689
 		$question = new ConfirmationQuestion(
690
-			'- Do you want to save <info>' . $frontal
690
+			'- Do you want to save <info>'.$frontal
691 691
 			. '</info> as your <info>frontal</info> address ? (y/N) ',
692 692
 			false, '/^(y|Y)/i'
693 693
 		);
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 		$this->configService->setAppValue(ConfigService::FRONTAL_CLOUD_ID, $cloudId);
705 705
 		$this->configService->setAppValue(ConfigService::FRONTAL_CLOUD_PATH, $path);
706 706
 
707
-		$output->writeln('- Address <info>' . $frontal . '</info> is now used as <info>frontal</info>');
707
+		$output->writeln('- Address <info>'.$frontal.'</info> is now used as <info>frontal</info>');
708 708
 	}
709 709
 
710 710
 	/**
@@ -729,7 +729,7 @@  discard block
 block discarded – undo
729 729
 			$request->setDataSerialize(new SimpleDataStore(['empty' => 1]));
730 730
 		}
731 731
 
732
-		$output->write('- ' . $type . ' request on ' . $request->getCompleteUrl() . ': ');
732
+		$output->write('- '.$type.' request on '.$request->getCompleteUrl().': ');
733 733
 
734 734
 		try {
735 735
 			$this->doRequest($request);
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
 				$color = 'info';
741 741
 			}
742 742
 
743
-			$output->writeln('<' . $color . '>' . ((string)$result->getStatusCode()) . '</' . $color . '>');
743
+			$output->writeln('<'.$color.'>'.((string)$result->getStatusCode()).'</'.$color.'>');
744 744
 			if ($result->getStatusCode() === 200) {
745 745
 				return true;
746 746
 			}
@@ -763,7 +763,7 @@  discard block
 block discarded – undo
763 763
 
764 764
 		$output->writeln('');
765 765
 		$output->writeln(
766
-			'The address <info>' . $address . '</info> seems to reach your local Nextcloud.'
766
+			'The address <info>'.$address.'</info> seems to reach your local Nextcloud.'
767 767
 		);
768 768
 
769 769
 		/** @var QuestionHelper $helper */
@@ -781,8 +781,8 @@  discard block
 block discarded – undo
781 781
 
782 782
 		$this->configService->setAppValue(ConfigService::FORCE_NC_BASE, $address);
783 783
 		$output->writeln(
784
-			'New configuration <info>' . Application::APP_ID . '.' . ConfigService::FORCE_NC_BASE . '=\''
785
-			. $address . '\'</info> stored in database'
784
+			'New configuration <info>'.Application::APP_ID.'.'.ConfigService::FORCE_NC_BASE.'=\''
785
+			. $address.'\'</info> stored in database'
786 786
 		);
787 787
 	}
788 788
 
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
 		$path = rtrim($path, '/');
810 810
 
811 811
 		if (!is_null($cloudIdPort)) {
812
-			$cloudId = $cloudId . ':' . ((string)$cloudIdPort);
812
+			$cloudId = $cloudId.':'.((string)$cloudIdPort);
813 813
 		}
814 814
 
815 815
 		return [$scheme, $cloudId, $path];
Please login to merge, or discard this patch.
lib/Command/MembersAdd.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 		} catch (FederatedItemException $e) {
110 110
 			if ($input->getOption('status-code')) {
111 111
 				throw new FederatedItemException(
112
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
112
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
113 113
 				);
114 114
 			}
115 115
 
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
148 148
 		try {
149 149
 			$users = $this->retrieveJson($request);
150 150
 		} catch (
151
-			RequestContentException|
152
-			RequestNetworkException|
153
-			RequestResultSizeException|
154
-			RequestServerException|
151
+			RequestContentException |
152
+			RequestNetworkException |
153
+			RequestResultSizeException |
154
+			RequestServerException |
155 155
 			RequestResultNotJsonException $e
156 156
 		) {
157 157
 			return '';
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 				$instance = $host;
170 170
 			}
171 171
 
172
-			$result[] = $user['userid']['value'] . ' <info>@' . $host . '</info>';
172
+			$result[] = $user['userid']['value'].' <info>@'.$host.'</info>';
173 173
 		}
174 174
 
175 175
 		//		if ($userId === '') {
Please login to merge, or discard this patch.
lib/Command/CirclesJoin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.
lib/Command/CirclesLeave.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.
lib/Command/CirclesSetting.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.
lib/Command/CirclesEdit.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.
lib/Command/MembersLevel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.
lib/Command/CirclesDestroy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 		} catch (FederatedItemException $e) {
159 159
 			if ($input->getOption('status-code')) {
160 160
 				throw new FederatedItemException(
161
-					' [' . get_class($e) . ', ' . ((string)$e->getStatus()) . ']' . "\n" . $e->getMessage()
161
+					' ['.get_class($e).', '.((string)$e->getStatus()).']'."\n".$e->getMessage()
162 162
 				);
163 163
 			}
164 164
 
Please login to merge, or discard this patch.