Complex classes like MembershipService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MembershipService, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
55 | class MembershipService { |
||
56 | |||
57 | |||
58 | use TNC22Logger; |
||
59 | |||
60 | |||
61 | /** @var MembershipRequest */ |
||
62 | private $membershipRequest; |
||
63 | |||
64 | /** @var CircleRequest */ |
||
65 | private $circleRequest; |
||
66 | |||
67 | /** @var MemberRequest */ |
||
68 | private $memberRequest; |
||
69 | |||
70 | /** @var EventService */ |
||
71 | private $eventService; |
||
72 | |||
73 | /** @var OutputService */ |
||
74 | private $outputService; |
||
75 | |||
76 | |||
77 | /** |
||
78 | * MembershipService constructor. |
||
79 | * |
||
80 | * @param MembershipRequest $membershipRequest |
||
81 | * @param CircleRequest $circleRequest |
||
82 | * @param MemberRequest $memberRequest |
||
83 | * @param EventService $eventService |
||
84 | * @param OutputService $outputService |
||
85 | */ |
||
86 | public function __construct( |
||
87 | MembershipRequest $membershipRequest, |
||
88 | CircleRequest $circleRequest, |
||
89 | MemberRequest $memberRequest, |
||
90 | EventService $eventService, |
||
91 | OutputService $outputService |
||
92 | ) { |
||
93 | $this->membershipRequest = $membershipRequest; |
||
94 | $this->circleRequest = $circleRequest; |
||
95 | $this->memberRequest = $memberRequest; |
||
96 | $this->eventService = $eventService; |
||
97 | $this->outputService = $outputService; |
||
98 | } |
||
99 | |||
100 | |||
101 | /** |
||
102 | * @param string $singleId |
||
103 | * |
||
104 | * @throws RequestBuilderException |
||
105 | */ |
||
106 | public function onUpdate(string $singleId): void { |
||
107 | if ($singleId === '') { |
||
108 | return; |
||
109 | } |
||
110 | |||
111 | try { |
||
112 | $this->circleRequest->getFederatedUserBySingleId($singleId); |
||
113 | } catch (FederatedUserNotFoundException | OwnerNotFoundException $e) { |
||
114 | $this->membershipRequest->removeBySingleId($singleId); |
||
115 | } |
||
116 | |||
117 | $children = array_unique( |
||
118 | array_merge( |
||
119 | [$singleId], |
||
120 | $this->getChildrenMembers($singleId), |
||
121 | $this->getChildrenMemberships($singleId) |
||
122 | ) |
||
123 | ); |
||
124 | |||
125 | foreach ($children as $singleId) { |
||
126 | $this->manageMemberships($singleId); |
||
127 | } |
||
128 | } |
||
129 | |||
130 | |||
131 | /** |
||
132 | * |
||
133 | */ |
||
134 | public function manageAll(): void { |
||
135 | $params = new SimpleDataStore(['includeSystemCircles' => true]); |
||
136 | $circles = $this->circleRequest->getCircles( |
||
137 | null, |
||
138 | null, |
||
139 | null, |
||
140 | null, |
||
141 | $params |
||
142 | ); |
||
143 | |||
144 | $this->outputService->startMigrationProgress(sizeof($circles)); |
||
145 | |||
146 | foreach ($circles as $circle) { |
||
147 | $this->outputService->output( |
||
148 | 'Caching memberships for \'' . $circle->getDisplayName() . '\'', |
||
149 | true |
||
150 | ); |
||
151 | $this->manageMemberships($circle->getSingleId()); |
||
152 | } |
||
153 | |||
154 | $this->outputService->finishMigrationProgress(); |
||
155 | } |
||
156 | |||
157 | |||
158 | /** |
||
159 | * @param string $singleId |
||
160 | * |
||
161 | * @return int |
||
162 | */ |
||
163 | public function manageMemberships(string $singleId): int { |
||
164 | $memberships = $this->generateMemberships($singleId); |
||
165 | |||
166 | return $this->updateMembershipsDatabase($singleId, $memberships); |
||
167 | } |
||
168 | |||
169 | |||
170 | /** |
||
171 | * @param string $circleId |
||
172 | * @param string $singleId |
||
173 | * |
||
174 | * @return Membership |
||
175 | * @throws MembershipNotFoundException |
||
176 | * @throws RequestBuilderException |
||
177 | */ |
||
178 | public function getMembership(string $circleId, string $singleId): Membership { |
||
179 | $membership = $this->membershipRequest->getMembership($circleId, $singleId); |
||
180 | $details = $this->circleRequest->getCirclesByIds($membership->getInheritancePath()); |
||
181 | $membership->setInheritanceDetails($details); |
||
182 | |||
183 | return $membership; |
||
184 | } |
||
185 | |||
186 | |||
187 | /** |
||
188 | * @param string $singleId |
||
189 | * @param bool $all |
||
190 | */ |
||
191 | public function resetMemberships(string $singleId = '', bool $all = false) { |
||
192 | $this->membershipRequest->removeBySingleId($singleId, $all); |
||
193 | } |
||
194 | |||
195 | |||
196 | /** |
||
197 | * @param FederatedUser $federatedUser |
||
198 | */ |
||
199 | public function deleteFederatedUser(FederatedUser $federatedUser) { |
||
200 | $this->membershipRequest->deleteFederatedUser($federatedUser); |
||
201 | } |
||
202 | |||
203 | |||
204 | /** |
||
205 | * @param string $singleId |
||
206 | * @param string $circleId |
||
207 | * @param array $memberships |
||
208 | * @param array $knownIds |
||
209 | * @param array $path |
||
210 | * |
||
211 | * @return array |
||
212 | * @throws RequestBuilderException |
||
213 | */ |
||
214 | private function generateMemberships( |
||
215 | string $singleId, |
||
216 | string $circleId = '', |
||
217 | array &$memberships = [], |
||
218 | array $knownIds = [], |
||
219 | array $path = [] |
||
220 | ): array { |
||
221 | $circleId = ($circleId === '') ? $singleId : $circleId; |
||
222 | $path[] = $circleId; |
||
223 | $knownIds[] = $circleId; |
||
224 | |||
225 | $members = $this->memberRequest->getMembersBySingleId($circleId); |
||
226 | foreach ($members as $member) { |
||
227 | if ($member->getLevel() < Member::LEVEL_MEMBER) { |
||
228 | continue; |
||
229 | } |
||
230 | |||
231 | $membership = new Membership($singleId, count($path) > 1 ? $path[1] : '', $member); |
||
232 | $membership->setInheritancePath(array_reverse($path)) |
||
233 | ->setInheritanceDepth(sizeof($path)); |
||
234 | $this->fillMemberships($membership, $memberships); |
||
235 | if (!in_array($member->getCircleId(), $knownIds)) { |
||
236 | $this->generateMemberships( |
||
237 | $singleId, |
||
238 | $member->getCircleId(), |
||
239 | $memberships, |
||
240 | $knownIds, |
||
241 | $path |
||
242 | ); |
||
243 | } |
||
244 | } |
||
245 | |||
246 | return $memberships; |
||
247 | } |
||
248 | |||
249 | |||
250 | /** |
||
251 | * @param string $singleId |
||
252 | * @param Membership[] $memberships |
||
253 | * |
||
254 | * @return int |
||
255 | */ |
||
256 | private function updateMembershipsDatabase(string $singleId, array $memberships): int { |
||
271 | |||
272 | |||
273 | /** |
||
274 | * @param string $id |
||
275 | * @param array $knownIds |
||
276 | * |
||
277 | * @return array |
||
278 | * @throws RequestBuilderException |
||
279 | */ |
||
280 | private function getChildrenMembers(string $id, array &$knownIds = []): array { |
||
296 | |||
297 | |||
298 | /** |
||
299 | * @param string $id |
||
300 | * @param array $knownIds |
||
301 | * |
||
302 | * @return array |
||
303 | */ |
||
304 | private function getChildrenMemberships(string $id, array &$knownIds = []): array { |
||
320 | |||
321 | |||
322 | /** |
||
323 | * @param Membership $membership |
||
324 | * @param Membership[] $memberships |
||
325 | */ |
||
326 | private function fillMemberships(Membership $membership, array &$memberships) { |
||
342 | |||
343 | |||
344 | /** |
||
345 | * @param Membership[] $memberships |
||
346 | * @param Membership[] $known |
||
347 | * |
||
348 | * @return Membership[] |
||
349 | */ |
||
350 | private function removeDeprecatedMemberships(array $memberships, array $known): array { |
||
367 | |||
368 | |||
369 | /** |
||
370 | * @param Membership[] $memberships |
||
371 | * @param Membership[] $known |
||
372 | * |
||
373 | * @return Membership[] |
||
374 | */ |
||
375 | private function createNewMemberships(array $memberships, array $known): array { |
||
392 | |||
393 | |||
394 | /** |
||
395 | * @param Membership[] $list |
||
396 | * @param string $circleId |
||
397 | * |
||
398 | * @return Membership |
||
399 | * @throws ItemNotFoundException |
||
400 | */ |
||
401 | private function getMembershipsFromList(array $list, string $circleId): Membership { |
||
410 | |||
411 | } |
||
412 | |||
413 |