nextcloud / circles

lib/Model/Federated/RemoteInstance.php

Spacing +13 added lines, -13 removed lines

@@ -50,11 +50,11 @@ 
 
 	use TArrayTools;
 
-	const TYPE_UNKNOWN = 'Unknown';    // not trusted
-	const TYPE_PASSIVE = 'Passive';    // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
-	const TYPE_EXTERNAL = 'External';  // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
-	const TYPE_TRUSTED = 'Trusted';    // everything about Federated Circles are broadcasted.
-	const TYPE_GLOBAL_SCALE = 'GlobalScale';  // every Circle is broadcasted,
+	const TYPE_UNKNOWN = 'Unknown'; // not trusted
+	const TYPE_PASSIVE = 'Passive'; // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
+	const TYPE_EXTERNAL = 'External'; // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
+	const TYPE_TRUSTED = 'Trusted'; // everything about Federated Circles are broadcasted.
+	const TYPE_GLOBAL_SCALE = 'GlobalScale'; // every Circle is broadcasted,
 
 	public static $LIST_TYPE = [
 		self::TYPE_UNKNOWN,
@@ -432,7 +432,7 @@ 
 		];
 
 		if ($this->getAuthSigned() !== '') {
-			$data['auth-signed'] = $this->getAlgorithm() . ':' . $this->getAuthSigned();
+			$data['auth-signed'] = $this->getAlgorithm().':'.$this->getAuthSigned();
 		}
 
 		return array_filter(array_merge($data, parent::jsonSerialize()));
@@ -447,16 +447,16 @@ 
 	 * @throws RemoteNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->getInt($prefix . 'id', $data) === 0) {
+		if ($this->getInt($prefix.'id', $data) === 0) {
 			throw new RemoteNotFoundException();
 		}
 
-		$this->setDbId($this->getInt($prefix . 'id', $data));
-		$this->import($this->getArray($prefix . 'item', $data));
-		$this->setOrigData($this->getArray($prefix . 'item', $data));
-		$this->setType($this->get($prefix . 'type', $data));
-		$this->setInstance($this->get($prefix . 'instance', $data));
-		$this->setId($this->get($prefix . 'href', $data));
+		$this->setDbId($this->getInt($prefix.'id', $data));
+		$this->import($this->getArray($prefix.'item', $data));
+		$this->setOrigData($this->getArray($prefix.'item', $data));
+		$this->setType($this->get($prefix.'type', $data));
+		$this->setInstance($this->get($prefix.'instance', $data));
+		$this->setId($this->get($prefix.'href', $data));
 
 		return $this;
 	}

lib/Model/Mount.php

Spacing +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
 			return $this->mountPoint;
 		}
 
-		return '/' . $this->getInitiator()->getUserId() . '/files/' . ltrim($this->mountPoint, '/');
+		return '/'.$this->getInitiator()->getUserId().'/files/'.ltrim($this->mountPoint, '/');
 	}
 
 	/**

lib/Model/Circle.php

Spacing +31 added lines, -31 removed lines

@@ -84,26 +84,26 @@ 
 
 
 	// specific value
-	const CFG_CIRCLE = 0;        // only for code readability. Circle is locked by default.
-	const CFG_SINGLE = 1;        // Circle with only one single member.
-	const CFG_PERSONAL = 2;      // Personal circle, only the owner can see it.
+	const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default.
+	const CFG_SINGLE = 1; // Circle with only one single member.
+	const CFG_PERSONAL = 2; // Personal circle, only the owner can see it.
 
 	// bitwise
-	const CFG_SYSTEM = 4;            // System Circle (not managed by the official front-end). Meaning some config are limited
-	const CFG_VISIBLE = 8;           // Visible to everyone, if not visible, people have to know its name to be able to find it
-	const CFG_OPEN = 16;             // Circle is open, people can join
-	const CFG_INVITE = 32;           // Adding a member generate an invitation that needs to be accepted
-	const CFG_REQUEST = 64;          // Request to join Circles needs to be confirmed by a moderator
-	const CFG_FRIEND = 128;          // Members of the circle can invite their friends
-	const CFG_PROTECTED = 256;       // Password protected to join/request
-	const CFG_NO_OWNER = 512;        // no owner, only members
-	const CFG_HIDDEN = 1024;         // hidden from listing, but available as a share entity
-	const CFG_BACKEND = 2048;        // Fully hidden, only backend Circles
-	const CFG_LOCAL = 4096;         // Local even on GlobalScale
-	const CFG_ROOT = 8192;           // Circle cannot be inside another Circle
-	const CFG_CIRCLE_INVITE = 16384;  // Circle must confirm when invited in another circle
-	const CFG_FEDERATED = 32768;     // Federated
-	const CFG_MOUNTPOINT = 65536;         // Generate a Files folder for this Circle
+	const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited
+	const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it
+	const CFG_OPEN = 16; // Circle is open, people can join
+	const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted
+	const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator
+	const CFG_FRIEND = 128; // Members of the circle can invite their friends
+	const CFG_PROTECTED = 256; // Password protected to join/request
+	const CFG_NO_OWNER = 512; // no owner, only members
+	const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity
+	const CFG_BACKEND = 2048; // Fully hidden, only backend Circles
+	const CFG_LOCAL = 4096; // Local even on GlobalScale
+	const CFG_ROOT = 8192; // Circle cannot be inside another Circle
+	const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle
+	const CFG_FEDERATED = 32768; // Federated
+	const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle
 
 	public static $DEF_CFG_MAX = 131071;
 
@@ -717,22 +717,22 @@ 
 	 * @throws CircleNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->get($prefix . 'unique_id', $data) === '') {
+		if ($this->get($prefix.'unique_id', $data) === '') {
 			throw new CircleNotFoundException();
 		}
 
-		$this->setSingleId($this->get($prefix . 'unique_id', $data))
-			 ->setName($this->get($prefix . 'name', $data))
-			 ->setDisplayName($this->get($prefix . 'display_name', $data))
-			 ->setConfig($this->getInt($prefix . 'config', $data))
-			 ->setSource($this->getInt($prefix . 'source', $data))
-			 ->setInstance($this->get($prefix . 'instance', $data))
-			 ->setSettings($this->getArray($prefix . 'settings', $data))
-			 ->setContactAddressBook($this->getInt($prefix . 'contact_addressbook', $data))
-			 ->setContactGroupName($this->get($prefix . 'contact_groupname', $data))
-			 ->setDescription($this->get($prefix . 'description', $data));
-
-		$creation = $this->get($prefix . 'creation', $data);
+		$this->setSingleId($this->get($prefix.'unique_id', $data))
+			 ->setName($this->get($prefix.'name', $data))
+			 ->setDisplayName($this->get($prefix.'display_name', $data))
+			 ->setConfig($this->getInt($prefix.'config', $data))
+			 ->setSource($this->getInt($prefix.'source', $data))
+			 ->setInstance($this->get($prefix.'instance', $data))
+			 ->setSettings($this->getArray($prefix.'settings', $data))
+			 ->setContactAddressBook($this->getInt($prefix.'contact_addressbook', $data))
+			 ->setContactGroupName($this->get($prefix.'contact_groupname', $data))
+			 ->setDescription($this->get($prefix.'description', $data));
+
+		$creation = $this->get($prefix.'creation', $data);
 		$this->setCreation(DateTime::createFromFormat('Y-m-d H:i:s', $creation)->getTimestamp());
 
 		$this->getManager()->manageImportFromDatabase($this, $data, $prefix);

Doc Comments +2 added lines, -2 removed lines

@@ -358,7 +358,7 @@ 
 
 
 	/**
-	 * @param ?Member $owner
+	 * @param Member $owner
 	 *
 	 * @return self
 	 */
@@ -414,7 +414,7 @@ 
 
 
 	/**
-	 * @param array $members
+	 * @param Member[] $members
 	 * @param bool $detailed
 	 *
 	 * @return self

lib/Model/FileCacheWrapper.php

Spacing +18 added lines, -18 removed lines

@@ -504,29 +504,29 @@
 	 * @throws FileCacheNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->getInt($prefix . 'fileid', $data) === 0) {
+		if ($this->getInt($prefix.'fileid', $data) === 0) {
 			throw new FileCacheNotFoundException();
 		}
 
-		$this->setId($this->getInt($prefix . 'fileid', $data));
-		$this->setPath($this->get($prefix . 'path', $data));
-		$this->setPermissions($this->getInt($prefix . 'permissions', $data));
-		$this->setStorageId($this->getInt($prefix . 'storage', $data));
-		$this->setPathHash($this->get($prefix . 'path_hash', $data));
-		$this->setParent($this->getInt($prefix . 'parent', $data));
-		$this->setName($this->get($prefix . 'name', $data));
-		$this->setMimeType($this->getInt($prefix . 'mimetype', $data));
-		$this->setMimePart($this->getInt($prefix . 'mimepart', $data));
-		$this->setSize($this->getInt($prefix . 'size', $data));
-		$this->setMTime($this->getInt($prefix . 'mtime', $data));
-		$this->setStorageMTime($this->getInt($prefix . 'storage_mtime', $data));
-		$this->setEncrypted($this->getBool($prefix . 'encrypted', $data));
-		$this->setUnencryptedSize($this->getInt($prefix . 'unencrypted_size', $data));
-		$this->setEtag($this->get($prefix . 'etag', $data));
-		$this->setChecksum($this->get($prefix . 'checksum', $data));
+		$this->setId($this->getInt($prefix.'fileid', $data));
+		$this->setPath($this->get($prefix.'path', $data));
+		$this->setPermissions($this->getInt($prefix.'permissions', $data));
+		$this->setStorageId($this->getInt($prefix.'storage', $data));
+		$this->setPathHash($this->get($prefix.'path_hash', $data));
+		$this->setParent($this->getInt($prefix.'parent', $data));
+		$this->setName($this->get($prefix.'name', $data));
+		$this->setMimeType($this->getInt($prefix.'mimetype', $data));
+		$this->setMimePart($this->getInt($prefix.'mimepart', $data));
+		$this->setSize($this->getInt($prefix.'size', $data));
+		$this->setMTime($this->getInt($prefix.'mtime', $data));
+		$this->setStorageMTime($this->getInt($prefix.'storage_mtime', $data));
+		$this->setEncrypted($this->getBool($prefix.'encrypted', $data));
+		$this->setUnencryptedSize($this->getInt($prefix.'unencrypted_size', $data));
+		$this->setEtag($this->get($prefix.'etag', $data));
+		$this->setChecksum($this->get($prefix.'checksum', $data));
 
 		// small hack as there is no reason to call a recursive method for a single entry from the table
-		$this->setStorage($this->get($prefix . CoreQueryBuilder::STORAGES . '_id', $data));
+		$this->setStorage($this->get($prefix.CoreQueryBuilder::STORAGES.'_id', $data));
 
 		return $this;
 	}

lib/Model/Member.php

Spacing +19 added lines, -19 removed lines

@@ -794,29 +794,29 @@ 
 	 * @throws MemberNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->get($prefix . 'single_id', $data) === '') {
+		if ($this->get($prefix.'single_id', $data) === '') {
 			throw new MemberNotFoundException();
 		}
 
-		$this->setId($this->get($prefix . 'member_id', $data));
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
-		$this->setUserId($this->get($prefix . 'user_id', $data));
-		$this->setUserType($this->getInt($prefix . 'user_type', $data));
-		$this->setInstance($this->get($prefix . 'instance', $data));
-		$this->setLevel($this->getInt($prefix . 'level', $data));
-		$this->setStatus($this->get($prefix . 'status', $data));
-		$this->setDisplayName($this->get($prefix . 'cached_name', $data));
-		$this->setNote($this->get($prefix . 'note', $data));
-		$this->setContactId($this->get($prefix . 'contact_id', $data));
-		$this->setContactMeta($this->get($prefix . 'contact_meta', $data));
-
-		$cachedUpdate = $this->get($prefix . 'cached_update', $data);
+		$this->setId($this->get($prefix.'member_id', $data));
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
+		$this->setSingleId($this->get($prefix.'single_id', $data));
+		$this->setUserId($this->get($prefix.'user_id', $data));
+		$this->setUserType($this->getInt($prefix.'user_type', $data));
+		$this->setInstance($this->get($prefix.'instance', $data));
+		$this->setLevel($this->getInt($prefix.'level', $data));
+		$this->setStatus($this->get($prefix.'status', $data));
+		$this->setDisplayName($this->get($prefix.'cached_name', $data));
+		$this->setNote($this->get($prefix.'note', $data));
+		$this->setContactId($this->get($prefix.'contact_id', $data));
+		$this->setContactMeta($this->get($prefix.'contact_meta', $data));
+
+		$cachedUpdate = $this->get($prefix.'cached_update', $data);
 		if ($cachedUpdate !== '') {
 			$this->setDisplayUpdate(DateTime::createFromFormat('Y-m-d H:i:s', $cachedUpdate)->getTimestamp());
 		}
 
-		$joined = $this->get($prefix . 'joined', $data);
+		$joined = $this->get($prefix.'joined', $data);
 		if ($joined !== '') {
 			$this->setJoined(DateTime::createFromFormat('Y-m-d H:i:s', $joined)->getTimestamp());
 		}
@@ -896,7 +896,7 @@ 
 	public static function parseLevelInt(int $level): int {
 		if (!array_key_exists($level, self::$DEF_LEVEL)) {
 			$all = implode(', ', array_keys(self::$DEF_LEVEL));
-			throw new ParseMemberLevelException('Available levels: ' . $all, 121);
+			throw new ParseMemberLevelException('Available levels: '.$all, 121);
 		}
 
 		return $level;
@@ -915,7 +915,7 @@ 
 
 		if (!$level) {
 			$all = implode(', ', array_values(self::$DEF_LEVEL));
-			throw new ParseMemberLevelException('Available levels: ' . $all, 121);
+			throw new ParseMemberLevelException('Available levels: '.$all, 121);
 		}
 
 		return (int)$level;
@@ -933,7 +933,7 @@ 
 
 		if ($type === false) {
 			$all = implode(', ', array_values(self::$TYPE));
-			throw new UserTypeNotFoundException('Available types: ' . $all);
+			throw new UserTypeNotFoundException('Available types: '.$all);
 		}
 
 		return (int)$type;

lib/Model/Helpers/MemberHelper.php

Spacing +3 added lines, -3 removed lines

@@ -104,7 +104,7 @@ 
 		try {
 			$level = Member::parseLevelString($levelString);
 		} catch (ParseMemberLevelException $e) {
-			throw new MemberHelperException('method ' . $levelString . ' not found');
+			throw new MemberHelperException('method '.$levelString.' not found');
 		}
 
 		$this->mustHaveLevelEqualOrAbove($level);
@@ -122,11 +122,11 @@ 
 		try {
 			$level = Member::parseLevelString($levelString);
 		} catch (ParseMemberLevelException $e) {
-			throw new MemberHelperException('method ' . $levelString . ' not found');
+			throw new MemberHelperException('method '.$levelString.' not found');
 		}
 
 		if ($this->member->getLevel() >= $level) {
-			throw new MemberLevelException('Member cannot be ' . $levelString);
+			throw new MemberLevelException('Member cannot be '.$levelString);
 		}
 	}
 

lib/Model/Membership.php

Spacing +8 added lines, -8 removed lines

@@ -259,17 +259,17 @@
 	 * @throws MembershipNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->get($prefix . 'single_id', $data) === '') {
+		if ($this->get($prefix.'single_id', $data) === '') {
 			throw new MembershipNotFoundException();
 		}
 
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
-		$this->setLevel($this->getInt($prefix . 'level', $data));
-		$this->setInheritanceFirst($this->get($prefix . 'inheritance_first', $data));
-		$this->setInheritanceLast($this->get($prefix . 'inheritance_last', $data));
-		$this->setInheritancePath($this->getArray($prefix . 'inheritance_path', $data));
-		$this->setInheritanceDepth($this->getInt($prefix . 'inheritance_depth', $data));
+		$this->setSingleId($this->get($prefix.'single_id', $data));
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
+		$this->setLevel($this->getInt($prefix.'level', $data));
+		$this->setInheritanceFirst($this->get($prefix.'inheritance_first', $data));
+		$this->setInheritanceLast($this->get($prefix.'inheritance_last', $data));
+		$this->setInheritancePath($this->getArray($prefix.'inheritance_path', $data));
+		$this->setInheritanceDepth($this->getInt($prefix.'inheritance_depth', $data));
 
 		return $this;
 	}

lib/Command/MembersLevel.php

Spacing +1 added lines, -1 removed lines

@@ -125,7 +125,7 @@
 		} catch (FederatedItemException $e) {
 			if ($input->getOption('status-code')) {
 				throw new FederatedItemException(
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
 				);
 			}
 

lib/Command/CirclesLeave.php

Spacing +1 added lines, -1 removed lines

@@ -125,7 +125,7 @@
 		} catch (FederatedItemException $e) {
 			if ($input->getOption('status-code')) {
 				throw new FederatedItemException(
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
 				);
 			}