Completed
Pull Request — master (#551)
by Maxence
02:47
created
lib/Model/Federated/RemoteInstance.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
 
50 50
 	use TArrayTools;
51 51
 
52
-	const TYPE_UNKNOWN = 'Unknown';    // not trusted
53
-	const TYPE_PASSIVE = 'Passive';    // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
54
-	const TYPE_EXTERNAL = 'External';  // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
55
-	const TYPE_TRUSTED = 'Trusted';    // everything about Federated Circles are broadcasted.
56
-	const TYPE_GLOBAL_SCALE = 'GlobalScale';  // every Circle is broadcasted,
52
+	const TYPE_UNKNOWN = 'Unknown'; // not trusted
53
+	const TYPE_PASSIVE = 'Passive'; // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
54
+	const TYPE_EXTERNAL = 'External'; // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
55
+	const TYPE_TRUSTED = 'Trusted'; // everything about Federated Circles are broadcasted.
56
+	const TYPE_GLOBAL_SCALE = 'GlobalScale'; // every Circle is broadcasted,
57 57
 
58 58
 	const TEST = 'test';
59 59
 	const INCOMING = 'incoming';
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
 		];
400 400
 
401 401
 		if ($this->getAuthSigned() !== '') {
402
-			$data['auth-signed'] = $this->getAlgorithm() . ':' . $this->getAuthSigned();
402
+			$data['auth-signed'] = $this->getAlgorithm().':'.$this->getAuthSigned();
403 403
 		}
404 404
 
405 405
 		return array_filter(array_merge($data, parent::jsonSerialize()));
Please login to merge, or discard this patch.
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -161,16 +161,16 @@  discard block
 block discarded – undo
161 161
 		$this->generateMemberSelectAlias($alias, self::PREFIX_MEMBER)
162 162
 			 ->leftJoin(
163 163
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
164
-				 $expr->eq($alias . '.circle_id', $this->getDefaultSelectAlias() . '.unique_id')
164
+				 $expr->eq($alias.'.circle_id', $this->getDefaultSelectAlias().'.unique_id')
165 165
 			 );
166 166
 
167 167
 		// TODO: Check in big table if it is better to put condition in andWhere() or in LeftJoin()
168 168
 		$this->andWhere(
169 169
 			$expr->andX(
170
-				$expr->eq($alias . '.user_id', $this->createNamedParameter($member->getUserId())),
171
-				$expr->eq($alias . '.user_type', $this->createNamedParameter($member->getUserType())),
172
-				$expr->eq($alias . '.instance', $this->createNamedParameter($this->getInstance($member))),
173
-				$expr->gte($alias . '.level', $this->createNamedParameter($level))
170
+				$expr->eq($alias.'.user_id', $this->createNamedParameter($member->getUserId())),
171
+				$expr->eq($alias.'.user_type', $this->createNamedParameter($member->getUserType())),
172
+				$expr->eq($alias.'.instance', $this->createNamedParameter($this->getInstance($member))),
173
+				$expr->gte($alias.'.level', $this->createNamedParameter($level))
174 174
 			)
175 175
 		);
176 176
 	}
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 			 ->leftJoin(
192 192
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_CIRCLE, $alias,
193 193
 				 $expr->andX(
194
-					 $expr->eq($alias . '.unique_id', $this->getDefaultSelectAlias() . '.circle_id')
194
+					 $expr->eq($alias.'.unique_id', $this->getDefaultSelectAlias().'.circle_id')
195 195
 				 )
196 196
 			 );
197 197
 
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
 			 ->leftJoin(
222 222
 				 $circleTableAlias, CoreRequestBuilder::TABLE_MEMBER, $alias,
223 223
 				 $expr->andX(
224
-					 $expr->eq($alias . '.circle_id', $circleTableAlias . '.unique_id'),
225
-					 $expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
224
+					 $expr->eq($alias.'.circle_id', $circleTableAlias.'.unique_id'),
225
+					 $expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
226 226
 				 )
227 227
 			 );
228 228
 	}
@@ -248,11 +248,11 @@  discard block
 block discarded – undo
248 248
 			 ->leftJoin(
249 249
 				 $aliasCircle, CoreRequestBuilder::TABLE_MEMBER, $alias,
250 250
 				 $expr->andX(
251
-					 $expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
252
-					 $expr->eq($alias . '.user_id', $this->createNamedParameter($initiator->getUserId())),
253
-					 $expr->eq($alias . '.user_type', $this->createNamedParameter($initiator->getUserType())),
251
+					 $expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
252
+					 $expr->eq($alias.'.user_id', $this->createNamedParameter($initiator->getUserId())),
253
+					 $expr->eq($alias.'.user_type', $this->createNamedParameter($initiator->getUserType())),
254 254
 					 $expr->eq(
255
-						 $alias . '.instance', $this->createNamedParameter($this->getInstance($initiator))
255
+						 $alias.'.instance', $this->createNamedParameter($this->getInstance($initiator))
256 256
 					 )
257 257
 				 )
258 258
 			 );
@@ -278,9 +278,9 @@  discard block
 block discarded – undo
278 278
 		$this->leftJoin(
279 279
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
280 280
 			$expr->andX(
281
-				$expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
282
-				$expr->eq($alias . '.instance', $this->createNamedParameter($instance)),
283
-				$expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
281
+				$expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
282
+				$expr->eq($alias.'.instance', $this->createNamedParameter($instance)),
283
+				$expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
284 284
 			)
285 285
 		);
286 286
 	}
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 		$expr = $this->expr();
301 301
 		$this->leftJoin(
302 302
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $alias,
303
-			$expr->eq($alias . '.instance', $this->createNamedParameter($instance))
303
+			$expr->eq($alias.'.instance', $this->createNamedParameter($instance))
304 304
 		);
305 305
 	}
306 306
 
@@ -319,15 +319,15 @@  discard block
 block discarded – undo
319 319
 		// - 4 (Visible to everyone)
320 320
 		$orX = $expr->orX();
321 321
 		$orX->add(
322
-			$expr->andX($expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
322
+			$expr->andX($expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
323 323
 		);
324 324
 		$orX->add(
325 325
 			$expr->andX(
326
-				$expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_PERSONAL),
327
-				$expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
326
+				$expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_PERSONAL),
327
+				$expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
328 328
 			)
329 329
 		);
330
-		$orX->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_VISIBLE));
330
+		$orX->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_VISIBLE));
331 331
 		$this->andWhere($orX);
332 332
 
333 333
 
@@ -362,10 +362,10 @@  discard block
 block discarded – undo
362 362
 		$expr = $this->expr();
363 363
 
364 364
 		$orHidden = $expr->orX();
365
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_SINGLE));
366
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_HIDDEN));
367
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_BACKEND));
368
-		$this->andWhere($this->createFunction('NOT') . $orHidden);
365
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_SINGLE));
366
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_HIDDEN));
367
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_BACKEND));
368
+		$this->andWhere($this->createFunction('NOT').$orHidden);
369 369
 	}
370 370
 
371 371
 
@@ -394,30 +394,30 @@  discard block
 block discarded – undo
394 394
 
395 395
 		$orX = $expr->orX();
396 396
 		$orX->add(
397
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
397
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
398 398
 		);
399 399
 
400 400
 		$orExtOrPassive = $expr->orX();
401 401
 		$orExtOrPassive->add(
402
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
402
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
403 403
 		);
404 404
 		if (!$sensitive) {
405 405
 			$orExtOrPassive->add(
406
-				$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
406
+				$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
407 407
 			);
408 408
 		} else {
409 409
 			if ($this->getDefaultSelectAlias() === 'm') {
410 410
 				$andPassive = $expr->andX();
411 411
 				$andPassive->add(
412
-					$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
412
+					$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
413 413
 				);
414 414
 				$orMemberOrLevel = $expr->orX();
415 415
 				$orMemberOrLevel->add(
416
-					$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
416
+					$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
417 417
 				);
418 418
 				$orMemberOrLevel->add(
419 419
 					$expr->eq(
420
-						$this->getDefaultSelectAlias() . '.level',
420
+						$this->getDefaultSelectAlias().'.level',
421 421
 						$this->createNamedParameter(Member::LEVEL_OWNER)
422 422
 					)
423 423
 				);
@@ -428,18 +428,18 @@  discard block
 block discarded – undo
428 428
 
429 429
 		$andExternal = $expr->andX();
430 430
 		$andExternal->add($orExtOrPassive);
431
-		$andExternal->add($expr->isNotNull($aliasMembers . '.instance'));
431
+		$andExternal->add($expr->isNotNull($aliasMembers.'.instance'));
432 432
 
433 433
 		$orExtOrTrusted = $expr->orX();
434 434
 		$orExtOrTrusted->add($andExternal);
435 435
 		$orExtOrTrusted->add(
436
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
436
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
437 437
 		);
438 438
 
439 439
 		$andTrusted = $expr->andX();
440 440
 		$andTrusted->add($orExtOrTrusted);
441
-		$andTrusted->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_FEDERATED));
442
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
441
+		$andTrusted->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_FEDERATED));
442
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
443 443
 		$orX->add($andTrusted);
444 444
 
445 445
 		$this->andWhere($orX);
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 	 * @param int $flag
451 451
 	 */
452 452
 	public function filterConfig(int $flag): void {
453
-		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias() . '.config', $flag));
453
+		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias().'.config', $flag));
454 454
 	}
455 455
 
456 456
 
@@ -461,15 +461,15 @@  discard block
 block discarded – undo
461 461
 	 * @return $this
462 462
 	 */
463 463
 	private function generateCircleSelectAlias(string $alias, string $prefix): self {
464
-		$this->selectAlias($alias . '.unique_id', $prefix . 'unique_id')
465
-			 ->selectAlias($alias . '.name', $prefix . 'name')
466
-			 ->selectAlias($alias . '.alt_name', $prefix . 'alt_name')
467
-			 ->selectAlias($alias . '.description', $prefix . 'description')
468
-			 ->selectAlias($alias . '.settings', $prefix . 'settings')
469
-			 ->selectAlias($alias . '.config', $prefix . 'config')
470
-			 ->selectAlias($alias . '.contact_addressbook', $prefix . 'contact_addressbook')
471
-			 ->selectAlias($alias . '.contact_groupname', $prefix . 'contact_groupname')
472
-			 ->selectAlias($alias . '.creation', $prefix . 'creation');
464
+		$this->selectAlias($alias.'.unique_id', $prefix.'unique_id')
465
+			 ->selectAlias($alias.'.name', $prefix.'name')
466
+			 ->selectAlias($alias.'.alt_name', $prefix.'alt_name')
467
+			 ->selectAlias($alias.'.description', $prefix.'description')
468
+			 ->selectAlias($alias.'.settings', $prefix.'settings')
469
+			 ->selectAlias($alias.'.config', $prefix.'config')
470
+			 ->selectAlias($alias.'.contact_addressbook', $prefix.'contact_addressbook')
471
+			 ->selectAlias($alias.'.contact_groupname', $prefix.'contact_groupname')
472
+			 ->selectAlias($alias.'.creation', $prefix.'creation');
473 473
 
474 474
 		return $this;
475 475
 	}
@@ -481,20 +481,20 @@  discard block
 block discarded – undo
481 481
 	 * @return $this
482 482
 	 */
483 483
 	private function generateMemberSelectAlias(string $alias, string $prefix): self {
484
-		$this->selectAlias($alias . '.circle_id', $prefix . 'circle_id')
485
-			 ->selectAlias($alias . '.single_id', $prefix . 'single_id')
486
-			 ->selectAlias($alias . '.user_id', $prefix . 'user_id')
487
-			 ->selectAlias($alias . '.user_type', $prefix . 'user_type')
488
-			 ->selectAlias($alias . '.member_id', $prefix . 'member_id')
489
-			 ->selectAlias($alias . '.instance', $prefix . 'instance')
490
-			 ->selectAlias($alias . '.cached_name', $prefix . 'cached_name')
491
-			 ->selectAlias($alias . '.cached_update', $prefix . 'cached_update')
492
-			 ->selectAlias($alias . '.status', $prefix . 'status')
493
-			 ->selectAlias($alias . '.level', $prefix . 'level')
494
-			 ->selectAlias($alias . '.note', $prefix . 'note')
495
-			 ->selectAlias($alias . '.contact_id', $prefix . 'contact_id')
496
-			 ->selectAlias($alias . '.contact_meta', $prefix . 'contact_meta')
497
-			 ->selectAlias($alias . '.joined', $prefix . 'joined');
484
+		$this->selectAlias($alias.'.circle_id', $prefix.'circle_id')
485
+			 ->selectAlias($alias.'.single_id', $prefix.'single_id')
486
+			 ->selectAlias($alias.'.user_id', $prefix.'user_id')
487
+			 ->selectAlias($alias.'.user_type', $prefix.'user_type')
488
+			 ->selectAlias($alias.'.member_id', $prefix.'member_id')
489
+			 ->selectAlias($alias.'.instance', $prefix.'instance')
490
+			 ->selectAlias($alias.'.cached_name', $prefix.'cached_name')
491
+			 ->selectAlias($alias.'.cached_update', $prefix.'cached_update')
492
+			 ->selectAlias($alias.'.status', $prefix.'status')
493
+			 ->selectAlias($alias.'.level', $prefix.'level')
494
+			 ->selectAlias($alias.'.note', $prefix.'note')
495
+			 ->selectAlias($alias.'.contact_id', $prefix.'contact_id')
496
+			 ->selectAlias($alias.'.contact_meta', $prefix.'contact_meta')
497
+			 ->selectAlias($alias.'.joined', $prefix.'joined');
498 498
 
499 499
 		return $this;
500 500
 	}
Please login to merge, or discard this patch.
lib/Service/CircleService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
 	 * @param string $name
122 122
 	 * @param FederatedUser|null $owner
123 123
 	 *
124
-	 * @return Circle
124
+	 * @return SimpleDataStore
125 125
 	 * @throws FederatedEventException
126 126
 	 * @throws InitiatorNotConfirmedException
127 127
 	 * @throws InitiatorNotFoundException
Please login to merge, or discard this patch.
lib/Model/Member.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -549,29 +549,29 @@  discard block
 block discarded – undo
549 549
 	 * @throws MemberNotFoundException
550 550
 	 */
551 551
 	public function importFromDatabase(array $data, string $prefix = ''): INC21QueryRow {
552
-		if (!array_key_exists($prefix . 'member_id', $data)) {
552
+		if (!array_key_exists($prefix.'member_id', $data)) {
553 553
 			throw new MemberNotFoundException();
554 554
 		}
555 555
 
556
-		$this->setId($this->get($prefix . 'member_id', $data));
557
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
558
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
559
-		$this->setUserId($this->get($prefix . 'user_id', $data));
560
-		$this->setUserType($this->getInt($prefix . 'user_type', $data));
561
-		$this->setInstance($this->get($prefix . 'instance', $data));
562
-		$this->setLevel($this->getInt($prefix . 'level', $data));
563
-		$this->setStatus($this->get($prefix . 'status', $data));
564
-		$this->setCachedName($this->get($prefix . 'cached_name', $data));
565
-		$this->setNote($this->get($prefix . 'note', $data));
566
-		$this->setContactId($this->get($prefix . 'contact_id', $data));
567
-		$this->setContactMeta($this->get($prefix . 'contact_meta', $data));
568
-
569
-		$cachedUpdate = $this->get($prefix . 'cached_update', $data);
556
+		$this->setId($this->get($prefix.'member_id', $data));
557
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
558
+		$this->setSingleId($this->get($prefix.'single_id', $data));
559
+		$this->setUserId($this->get($prefix.'user_id', $data));
560
+		$this->setUserType($this->getInt($prefix.'user_type', $data));
561
+		$this->setInstance($this->get($prefix.'instance', $data));
562
+		$this->setLevel($this->getInt($prefix.'level', $data));
563
+		$this->setStatus($this->get($prefix.'status', $data));
564
+		$this->setCachedName($this->get($prefix.'cached_name', $data));
565
+		$this->setNote($this->get($prefix.'note', $data));
566
+		$this->setContactId($this->get($prefix.'contact_id', $data));
567
+		$this->setContactMeta($this->get($prefix.'contact_meta', $data));
568
+
569
+		$cachedUpdate = $this->get($prefix.'cached_update', $data);
570 570
 		if ($cachedUpdate !== '') {
571 571
 			$this->setCachedUpdate(DateTime::createFromFormat('Y-m-d H:i:s', $cachedUpdate)->getTimestamp());
572 572
 		}
573 573
 
574
-		$joined = $this->get($prefix . 'joined', $data);
574
+		$joined = $this->get($prefix.'joined', $data);
575 575
 		if ($joined !== '') {
576 576
 			$this->setJoined(DateTime::createFromFormat('Y-m-d H:i:s', $joined)->getTimestamp());
577 577
 		}
@@ -600,7 +600,7 @@  discard block
 block discarded – undo
600 600
 
601 601
 		if (!$level) {
602 602
 			$all = implode(', ', array_values(self::$DEF_LEVEL));
603
-			throw new MemberLevelException('Available levels: ' . $all);
603
+			throw new MemberLevelException('Available levels: '.$all);
604 604
 		}
605 605
 
606 606
 		return (int)$level;
@@ -618,7 +618,7 @@  discard block
 block discarded – undo
618 618
 
619 619
 		if (!$type) {
620 620
 			$all = implode(', ', array_values(self::$DEF_TYPE));
621
-			throw new UserTypeNotFoundException('Available types: ' . $all);
621
+			throw new UserTypeNotFoundException('Available types: '.$all);
622 622
 		}
623 623
 
624 624
 		return (int)$type;
Please login to merge, or discard this patch.
lib/Command/CirclesCreate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
 		$owner = $this->federatedUserService->getLocalFederatedUser($ownerId);
118 118
 		$outcome = $this->circleService->create($name, $owner);
119 119
 
120
-		echo json_encode($outcome, JSON_PRETTY_PRINT) . "\n";
120
+		echo json_encode($outcome, JSON_PRETTY_PRINT)."\n";
121 121
 
122 122
 		return 0;
123 123
 	}
Please login to merge, or discard this patch.
lib/Command/MembersAdd.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 		$federatedUser = $this->federatedUserService->generateFederatedUser($userId, (int)$type);
128 128
 		$outcome = $this->memberService->addMember($circleId, $federatedUser);
129 129
 
130
-		echo json_encode($outcome, JSON_PRETTY_PRINT) . "\n";
130
+		echo json_encode($outcome, JSON_PRETTY_PRINT)."\n";
131 131
 
132 132
 		return 0;
133 133
 	}
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 				$instance = $host;
179 179
 			}
180 180
 
181
-			$result[] = $user['userid']['value'] . ' <info>@' . $host . '</info>';
181
+			$result[] = $user['userid']['value'].' <info>@'.$host.'</info>';
182 182
 		}
183 183
 
184 184
 //		if ($userId === '') {
Please login to merge, or discard this patch.
lib/Service/FederatedUserService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	public function getLocalFederatedUser(string $userId): FederatedUser {
231 231
 		$user = $this->userManager->get($userId);
232 232
 		if ($user === null) {
233
-			throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
233
+			throw new FederatedUserNotFoundException('user '.$userId.' not found');
234 234
 		}
235 235
 
236 236
 		$federatedUser = new FederatedUser();
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 			$circle = new Circle();
514 514
 			$id = $this->token(ManagedModel::ID_LENGTH);
515 515
 
516
-			$circle->setName('single:' . $federatedUser->getUserId() . ':' . $id)
516
+			$circle->setName('single:'.$federatedUser->getUserId().':'.$id)
517 517
 				   ->setId($id)
518 518
 				   ->setConfig(Circle::CFG_SINGLE);
519 519
 			$this->circleRequest->save($circle);
Please login to merge, or discard this patch.
lib/FederatedItems/MemberAdd.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 		$initiatorHelper = new MemberHelper($initiator);
161 161
 		$initiatorHelper->mustBeModerator();
162 162
 
163
-		$federatedId = $member->getUserId() . '@' . $member->getInstance();
163
+		$federatedId = $member->getUserId().'@'.$member->getInstance();
164 164
 		try {
165 165
 			$federatedUser =
166 166
 				$this->federatedUserService->getFederatedUser($federatedId, $member->getUserType());
167 167
 		} catch (MemberNotFoundException $e) {
168 168
 			throw new MemberNotFoundException(
169
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s not found',
170
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
169
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s not found',
170
+				['member' => $member->getUserId().'@'.$member->getInstance()]
171 171
 			);
172 172
 		}
173 173
 		$member->importFromIFederatedUser($federatedUser);
@@ -176,8 +176,8 @@  discard block
 block discarded – undo
176 176
 			$knownMember = $this->memberRequest->searchMember($member);
177 177
 			// TODO: maybe member is requesting access
178 178
 			throw new MemberAlreadyExistsException(
179
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s is already a member',
180
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
179
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s is already a member',
180
+				['member' => $member->getUserId().'@'.$member->getInstance()]
181 181
 			);
182 182
 		} catch (MemberNotFoundException $e) {
183 183
 		}
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 			$this->sendMailExistingShares($template, $author, $recipient);
491 491
 			$this->sendPasswordExistingShares($author, $recipient, $password);
492 492
 		} catch (Exception $e) {
493
-			$this->miscService->log('Failed to send mail about existing share ' . $e->getMessage());
493
+			$this->miscService->log('Failed to send mail about existing share '.$e->getMessage());
494 494
 		}
495 495
 	}
496 496
 
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
643 643
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
644 644
 
645
-		$this->miscService->log("Sending password mail about existing files to '" . $email . "'", 0);
645
+		$this->miscService->log("Sending password mail about existing files to '".$email."'", 0);
646 646
 
647 647
 		$plainBodyPart = $this->l10n->t(
648 648
 			"%1\$s shared multiple files with you.\nYou should have already received a separate mail with a link to access them.\n",
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
685 685
 		if ($authorEmail !== null) {
686 686
 			$message->setReplyTo([$authorEmail => $authorName]);
687
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
687
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
688 688
 		} else {
689 689
 			$emailTemplate->addFooter();
690 690
 		}
Please login to merge, or discard this patch.
lib/Command/CirclesMemberships.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -179,10 +179,10 @@  discard block
 block discarded – undo
179 179
 		$type = Member::parseTypeString($input->getOption('type'));
180 180
 		$federatedUser = $this->federatedUserService->getFederatedUser($userId, (int)$type);
181 181
 
182
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
183
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
184
-		$output->writeln('Type: <info>' . Member::$DEF_TYPE[$federatedUser->getUserType()] . '</info>');
185
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
182
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
183
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
184
+		$output->writeln('Type: <info>'.Member::$DEF_TYPE[$federatedUser->getUserType()].'</info>');
185
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
186 186
 
187 187
 		$this->singleId = $federatedUser->getSingleId();
188 188
 		$tree = new NC21TreeNode(null, new SimpleDataStore(['federatedUser' => $federatedUser]));
@@ -192,8 +192,8 @@  discard block
 block discarded – undo
192 192
 		$output->writeln('Memberships:');
193 193
 		foreach ($federatedUser->getMemberships() as $membership) {
194 194
 			$output->writeln(
195
-				'- <info>' . $membership->getCircleId() . '</info> ('
196
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
195
+				'- <info>'.$membership->getCircleId().'</info> ('
196
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
197 197
 			);
198 198
 		}
199 199
 		$output->writeln('');
@@ -262,9 +262,9 @@  discard block
 block discarded – undo
262 262
 				if ($lineNumber === 2) {
263 263
 					return '';
264 264
 				}
265
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
265
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
266 266
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
267
-					$line .= '@' . $federatedUser->getInstance();
267
+					$line .= '@'.$federatedUser->getInstance();
268 268
 				}
269 269
 
270 270
 				return $line;
@@ -276,25 +276,25 @@  discard block
 block discarded – undo
276 276
 				$circle = $member->getCircle();
277 277
 
278 278
 				if ($lineNumber === 1) {
279
-					$line .= '<info>' . $circle->getId() . '</info>';
279
+					$line .= '<info>'.$circle->getId().'</info>';
280 280
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
281
-						$line .= '@' . $circle->getInstance();
281
+						$line .= '@'.$circle->getInstance();
282 282
 					}
283
-					$line .= ' (' . $circle->getName() . ')';
284
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
283
+					$line .= ' ('.$circle->getName().')';
284
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
285 285
 
286 286
 					$knownMembership = $this->memberships[$member->getCircleId()];
287 287
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
288
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
288
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
289 289
 					}
290 290
 				}
291 291
 
292 292
 				if ($lineNumber === 2) {
293 293
 					$owner = $circle->getOwner();
294
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance() . ' ';
294
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance().' ';
295 295
 					$type =
296 296
 						implode(", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG));
297
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
297
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
298 298
 				}
299 299
 
300 300
 				return $line;
Please login to merge, or discard this patch.