Completed
Pull Request — master (#551)
by Maxence
02:47
created
lib/Command/MembersAdd.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 		$federatedUser = $this->federatedUserService->generateFederatedUser($userId, (int)$type);
128 128
 		$outcome = $this->memberService->addMember($circleId, $federatedUser);
129 129
 
130
-		echo json_encode($outcome, JSON_PRETTY_PRINT) . "\n";
130
+		echo json_encode($outcome, JSON_PRETTY_PRINT)."\n";
131 131
 
132 132
 		return 0;
133 133
 	}
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 				$instance = $host;
179 179
 			}
180 180
 
181
-			$result[] = $user['userid']['value'] . ' <info>@' . $host . '</info>';
181
+			$result[] = $user['userid']['value'].' <info>@'.$host.'</info>';
182 182
 		}
183 183
 
184 184
 //		if ($userId === '') {
Please login to merge, or discard this patch.
lib/Service/FederatedUserService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	public function getLocalFederatedUser(string $userId): FederatedUser {
231 231
 		$user = $this->userManager->get($userId);
232 232
 		if ($user === null) {
233
-			throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
233
+			throw new FederatedUserNotFoundException('user '.$userId.' not found');
234 234
 		}
235 235
 
236 236
 		$federatedUser = new FederatedUser();
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 			$circle = new Circle();
514 514
 			$id = $this->token(ManagedModel::ID_LENGTH);
515 515
 
516
-			$circle->setName('single:' . $federatedUser->getUserId() . ':' . $id)
516
+			$circle->setName('single:'.$federatedUser->getUserId().':'.$id)
517 517
 				   ->setId($id)
518 518
 				   ->setConfig(Circle::CFG_SINGLE);
519 519
 			$this->circleRequest->save($circle);
Please login to merge, or discard this patch.
lib/FederatedItems/MemberAdd.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 		$initiatorHelper = new MemberHelper($initiator);
161 161
 		$initiatorHelper->mustBeModerator();
162 162
 
163
-		$federatedId = $member->getUserId() . '@' . $member->getInstance();
163
+		$federatedId = $member->getUserId().'@'.$member->getInstance();
164 164
 		try {
165 165
 			$federatedUser =
166 166
 				$this->federatedUserService->getFederatedUser($federatedId, $member->getUserType());
167 167
 		} catch (MemberNotFoundException $e) {
168 168
 			throw new MemberNotFoundException(
169
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s not found',
170
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
169
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s not found',
170
+				['member' => $member->getUserId().'@'.$member->getInstance()]
171 171
 			);
172 172
 		}
173 173
 		$member->importFromIFederatedUser($federatedUser);
@@ -176,8 +176,8 @@  discard block
 block discarded – undo
176 176
 			$knownMember = $this->memberRequest->searchMember($member);
177 177
 			// TODO: maybe member is requesting access
178 178
 			throw new MemberAlreadyExistsException(
179
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s is already a member',
180
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
179
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s is already a member',
180
+				['member' => $member->getUserId().'@'.$member->getInstance()]
181 181
 			);
182 182
 		} catch (MemberNotFoundException $e) {
183 183
 		}
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 			$this->sendMailExistingShares($template, $author, $recipient);
491 491
 			$this->sendPasswordExistingShares($author, $recipient, $password);
492 492
 		} catch (Exception $e) {
493
-			$this->miscService->log('Failed to send mail about existing share ' . $e->getMessage());
493
+			$this->miscService->log('Failed to send mail about existing share '.$e->getMessage());
494 494
 		}
495 495
 	}
496 496
 
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
643 643
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
644 644
 
645
-		$this->miscService->log("Sending password mail about existing files to '" . $email . "'", 0);
645
+		$this->miscService->log("Sending password mail about existing files to '".$email."'", 0);
646 646
 
647 647
 		$plainBodyPart = $this->l10n->t(
648 648
 			"%1\$s shared multiple files with you.\nYou should have already received a separate mail with a link to access them.\n",
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
685 685
 		if ($authorEmail !== null) {
686 686
 			$message->setReplyTo([$authorEmail => $authorName]);
687
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
687
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
688 688
 		} else {
689 689
 			$emailTemplate->addFooter();
690 690
 		}
Please login to merge, or discard this patch.
lib/Command/CirclesMemberships.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -179,10 +179,10 @@  discard block
 block discarded – undo
179 179
 		$type = Member::parseTypeString($input->getOption('type'));
180 180
 		$federatedUser = $this->federatedUserService->getFederatedUser($userId, (int)$type);
181 181
 
182
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
183
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
184
-		$output->writeln('Type: <info>' . Member::$DEF_TYPE[$federatedUser->getUserType()] . '</info>');
185
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
182
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
183
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
184
+		$output->writeln('Type: <info>'.Member::$DEF_TYPE[$federatedUser->getUserType()].'</info>');
185
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
186 186
 
187 187
 		$this->singleId = $federatedUser->getSingleId();
188 188
 		$tree = new NC21TreeNode(null, new SimpleDataStore(['federatedUser' => $federatedUser]));
@@ -192,8 +192,8 @@  discard block
 block discarded – undo
192 192
 		$output->writeln('Memberships:');
193 193
 		foreach ($federatedUser->getMemberships() as $membership) {
194 194
 			$output->writeln(
195
-				'- <info>' . $membership->getCircleId() . '</info> ('
196
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
195
+				'- <info>'.$membership->getCircleId().'</info> ('
196
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
197 197
 			);
198 198
 		}
199 199
 		$output->writeln('');
@@ -262,9 +262,9 @@  discard block
 block discarded – undo
262 262
 				if ($lineNumber === 2) {
263 263
 					return '';
264 264
 				}
265
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
265
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
266 266
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
267
-					$line .= '@' . $federatedUser->getInstance();
267
+					$line .= '@'.$federatedUser->getInstance();
268 268
 				}
269 269
 
270 270
 				return $line;
@@ -276,25 +276,25 @@  discard block
 block discarded – undo
276 276
 				$circle = $member->getCircle();
277 277
 
278 278
 				if ($lineNumber === 1) {
279
-					$line .= '<info>' . $circle->getId() . '</info>';
279
+					$line .= '<info>'.$circle->getId().'</info>';
280 280
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
281
-						$line .= '@' . $circle->getInstance();
281
+						$line .= '@'.$circle->getInstance();
282 282
 					}
283
-					$line .= ' (' . $circle->getName() . ')';
284
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
283
+					$line .= ' ('.$circle->getName().')';
284
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
285 285
 
286 286
 					$knownMembership = $this->memberships[$member->getCircleId()];
287 287
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
288
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
288
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
289 289
 					}
290 290
 				}
291 291
 
292 292
 				if ($lineNumber === 2) {
293 293
 					$owner = $circle->getOwner();
294
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance() . ' ';
294
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance().' ';
295 295
 					$type =
296 296
 						implode(", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG));
297
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
297
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
298 298
 				}
299 299
 
300 300
 				return $line;
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -164,14 +164,14 @@  discard block
 block discarded – undo
164 164
 		if ($input->getOption('tree')) {
165 165
 			$this->federatedUserService->commandLineInitiator($initiator, $circleId, true);
166 166
 			$circle = $this->circleService->getCircle($circleId);
167
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
167
+			$output->writeln('<info>Name</info>: '.$circle->getName());
168 168
 			$owner = $circle->getOwner();
169
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
169
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
170 170
 			$type =
171 171
 				implode(
172 172
 					", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG)
173 173
 				);
174
-			$output->writeln('<info>Config</info>: ' . $type);
174
+			$output->writeln('<info>Config</info>: '.$type);
175 175
 			$output->writeln(' ');
176 176
 
177 177
 			$tree = new NC21TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 		}
194 194
 
195 195
 		if ($input->getOption('json')) {
196
-			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";
196
+			echo json_encode($members, JSON_PRETTY_PRINT)."\n";
197 197
 
198 198
 			return 0;
199 199
 		}
@@ -344,32 +344,32 @@  discard block
 block discarded – undo
344 344
 				$member = $data->gObj('member', Member::class);
345 345
 
346 346
 				if ($lineNumber === 1) {
347
-					$line .= '<info>' . $member->getUserId() . '</info>';
347
+					$line .= '<info>'.$member->getUserId().'</info>';
348 348
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
349
-						$line .= '@' . $member->getInstance();
349
+						$line .= '@'.$member->getInstance();
350 350
 					}
351
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
351
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
352 352
 
353 353
 					if (!is_null($circle)) {
354
-						$line .= ' <info>Name</info>: ' . $circle->getName();
354
+						$line .= ' <info>Name</info>: '.$circle->getName();
355 355
 					}
356 356
 				}
357 357
 
358 358
 				if ($lineNumber === 2 && !is_null($circle)) {
359 359
 					$owner = $circle->getOwner();
360
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
360
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
361 361
 					$type =
362 362
 						implode(
363 363
 							", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG)
364 364
 						);
365
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
365
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
366 366
 				}
367 367
 
368 368
 			} else {
369 369
 				if ($lineNumber === 1 && !is_null($circle)) {
370
-					$line .= '<info>' . $circle->getId() . '</info>';
370
+					$line .= '<info>'.$circle->getId().'</info>';
371 371
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
372
-						$line .= '@' . $circle->getInstance();
372
+						$line .= '@'.$circle->getInstance();
373 373
 					}
374 374
 				}
375 375
 			}
Please login to merge, or discard this patch.