Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 38 | class MembersMapper extends Mapper { |
||
| 39 | |||
| 40 | const TABLENAME = 'circles_members'; |
||
| 41 | |||
| 42 | private $miscService; |
||
| 43 | |||
| 44 | public function __construct(IDBConnection $db, $miscService) { |
||
| 48 | |||
| 49 | |||
| 50 | /** |
||
| 51 | * @param $circleId |
||
| 52 | * @param $userId |
||
| 53 | * @param bool $moderator |
||
| 54 | * |
||
| 55 | * @return null|Member |
||
| 56 | * @throws MemberDoesNotExistException |
||
| 57 | */ |
||
| 58 | public function getMemberFromCircle($circleId, $userId, $moderator = false) { |
||
| 80 | |||
| 81 | |||
| 82 | /** |
||
| 83 | * get members list from a circle. If moderator, returns also notes about each member. |
||
| 84 | * |
||
| 85 | * @param $circleId |
||
| 86 | * @param Member $user |
||
| 87 | * |
||
| 88 | * @return array |
||
| 89 | * @internal param Member $member |
||
| 90 | * @internal param bool $moderator |
||
| 91 | * |
||
| 92 | */ |
||
| 93 | public function getMembersFromCircle($circleId, Member $user) { |
||
| 117 | |||
| 118 | |||
| 119 | /** |
||
| 120 | * Generate SQL Request for getMemberFromCircle() |
||
| 121 | * |
||
| 122 | * @param $circleId |
||
| 123 | * @param $userId |
||
| 124 | * |
||
| 125 | * @return \OCP\DB\QueryBuilder\IQueryBuilder |
||
| 126 | */ |
||
| 127 | private function getMemberFromCircleSql($circleId, $userId) { |
||
| 137 | |||
| 138 | |||
| 139 | /** |
||
| 140 | * Return SQL for getMembersFromCircle. |
||
| 141 | * |
||
| 142 | * @param $circleId |
||
| 143 | * |
||
| 144 | * @return \OCP\DB\QueryBuilder\IQueryBuilder |
||
| 145 | */ |
||
| 146 | private function getMembersFromCircleSql($circleId) { |
||
| 157 | |||
| 158 | |||
| 159 | /** |
||
| 160 | * |
||
| 161 | * Return the base select request for both |
||
| 162 | * getMembersFromCircleSql() |
||
| 163 | * getMemberFromCircleSql() |
||
| 164 | * |
||
| 165 | * @param $circleId |
||
| 166 | * |
||
| 167 | * @return \OCP\DB\QueryBuilder\IQueryBuilder |
||
| 168 | */ |
||
| 169 | private function getMembersFromCircleSqlBase($circleId) { |
||
| 184 | |||
| 185 | |||
| 186 | /** |
||
| 187 | * update database entry for a specific Member. |
||
| 188 | * |
||
| 189 | * @param Member $member |
||
| 190 | * |
||
| 191 | * @return bool |
||
| 192 | */ |
||
| 193 | public function editMember(Member $member) { |
||
| 215 | |||
| 216 | |||
| 217 | /** |
||
| 218 | * Insert Member into database. |
||
| 219 | * |
||
| 220 | * @param Member $member |
||
| 221 | * |
||
| 222 | * @throws MemberAlreadyExistsException |
||
| 223 | */ |
||
| 224 | public function add(Member $member) { |
||
| 239 | |||
| 240 | |||
| 241 | /** |
||
| 242 | * Remove a member from a circle. |
||
| 243 | * |
||
| 244 | * @param Member $member |
||
| 245 | * |
||
| 246 | * @return bool |
||
| 247 | */ |
||
| 248 | public function remove(Member $member) { |
||
| 265 | |||
| 266 | /** |
||
| 267 | * remove all members/owner from a circle |
||
| 268 | * |
||
| 269 | * @param Circle $circle |
||
| 270 | * |
||
| 271 | * @return bool |
||
| 272 | */ |
||
| 273 | View Code Duplication | public function removeAllFromCircle(Circle $circle) { |
|
| 286 | } |
||
| 287 | |||
| 288 |
Scrutinizer analyzes your
composer.json/composer.lockfile if available to determine the classes, and functions that are defined by your dependencies.It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.