nextcloud / circles

lib/Db/GSSharesRequest.php

Spacing +2 added lines, -2 removed lines

@@ -97,11 +97,11 @@
 
 	private function leftJoinMountPoint(IQueryBuilder $qb, string $userId) {
 		$expr = $qb->expr();
-		$pf = '' . $this->default_select_alias . '.';
+		$pf = ''.$this->default_select_alias.'.';
 
 		$on = $expr->andX(
 			$expr->eq('mp.user_id', $qb->createNamedParameter($userId)),
-			$expr->eq('mp.share_id', $pf . 'id'),
+			$expr->eq('mp.share_id', $pf.'id'),
 		);
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */

lib/Db/CoreQueryBuilder.php

Spacing +84 added lines, -84 removed lines

@@ -377,8 +377,8 @@ 
 			$andX = [];
 			foreach (explode(' ', $circle->getDisplayName()) as $word) {
 				$andX[] = $expr->iLike(
-					$this->getDefaultSelectAlias() . '.' . 'display_name',
-					$this->createNamedParameter('%' . $word . '%')
+					$this->getDefaultSelectAlias().'.'.'display_name',
+					$this->createNamedParameter('%'.$word.'%')
 				);
 			}
 		}
@@ -407,7 +407,7 @@ 
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
 				->leftJoin(
 					$alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
-					$expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
+					$expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
 				);
 		} catch (RequestBuilderException $e) {
 		}
@@ -459,7 +459,7 @@ 
 		$expr = $this->expr();
 		$this->leftJoin(
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
 		);
 	}
 
@@ -487,12 +487,12 @@ 
 		$this->leftJoin(
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
 			$expr->andX(
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
 				$expr->eq(
-					$aliasRemoteMember . '.instance',
+					$aliasRemoteMember.'.instance',
 					$this->createNamedParameter($remoteInstance->getInstance())
 				),
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
 			)
 		);
 	}
@@ -524,21 +524,21 @@ 
 		$this->leftJoin(
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
 			$expr->andX(
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
 			)
 		);
 		$this->leftJoin(
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
 			$expr->andX(
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
 				$expr->eq(
-					$aliasRemoteCircleOwner . '.instance',
+					$aliasRemoteCircleOwner.'.instance',
 					$this->createNamedParameter($remoteInstance->getInstance())
 				),
 				$expr->eq(
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
 				)
 			)
 		);
@@ -569,11 +569,11 @@ 
 		$aliasRemoteCircleOwner = $this->generateAlias($aliasRemoteCircle, self::OWNER);
 
 		$expr = $this->expr();
-		$orX = [$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))];
+		$orX = [$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))];
 
-		$orExtOrPassive = [$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))];
+		$orExtOrPassive = [$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))];
 		if (!$sensitive) {
-			$orExtOrPassive[] = $expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE));
+			$orExtOrPassive[] = $expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE));
 		} else {
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
 				$orExtOrPassive[] = $this->limitRemoteVisibility_Sensitive_Members($aliasRemote);
@@ -581,8 +581,8 @@ 
 		}
 
 		$orInstance = $expr->orX(
-			$expr->isNotNull($aliasRemoteMember . '.instance'),
-			$expr->isNotNull($aliasRemoteCircleOwner . '.instance'),
+			$expr->isNotNull($aliasRemoteMember.'.instance'),
+			$expr->isNotNull($aliasRemoteCircleOwner.'.instance'),
 		);
 
 		$andExternal = $expr->andX(
@@ -592,13 +592,13 @@ 
 
 		$orExtOrTrusted = $expr->orX(
 			$andExternal,
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED)),
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED)),
 		);
 
 		$orX[] = $expr->andX(
 			$orExtOrTrusted,
 			$this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle),
-			$expr->emptyString($aliasOwner . '.instance'),
+			$expr->emptyString($aliasOwner.'.instance'),
 		);
 
 		$this->andWhere($expr->orX(...$orX));
@@ -625,7 +625,7 @@ 
 		}
 		$this->innerJoin(
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
 		);
 
 		$this->filterDirectMembership($aliasMember, $member);
@@ -650,12 +650,12 @@ 
 			$aliasCircle,
 			'circles_membership',
 			$aliasMembership,
-			$this->expr()->eq($aliasCircle . '.unique_id', $aliasMembership . '.circle_id')
+			$this->expr()->eq($aliasCircle.'.unique_id', $aliasMembership.'.circle_id')
 		);
 
 		$this->andWhere(
 			$this->expr()->eq(
-				$aliasMembership . '.single_id',
+				$aliasMembership.'.single_id',
 				$this->createNamedParameter($federatedUser->getSingleId())
 			)
 		);
@@ -675,22 +675,22 @@ 
 		$andX = [];
 
 		if ($member->getUserId() !== '') {
-			$andX[] = $expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()));
+			$andX[] = $expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()));
 		}
 
 		if ($member->getSingleId() !== '') {
-			$andX[] = $expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()));
+			$andX[] = $expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()));
 		}
 
 		if ($member->getUserType() > 0) {
-			$andX[] = $expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()));
+			$andX[] = $expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()));
 		}
 
 		$this->limitToInstance($this->getInstance($member));
 
 		if ($member->getLevel() > 0) {
 			$andX[] = $expr->gte(
-				$aliasMember . '.level',
+				$aliasMember.'.level',
 				$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
 			);
 		}
@@ -730,7 +730,7 @@ 
 			$helperAlias,
 			CoreRequestBuilder::TABLE_CIRCLE,
 			$aliasCircle,
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
 		);
 
 		if (!is_null($initiator)) {
@@ -761,7 +761,7 @@ 
 		$this->generateCircleSelectAlias($aliasInvitedBy)
 			->leftJoin(
 				$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
-				$expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
+				$expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
 			);
 
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -792,7 +792,7 @@ 
 		$this->generateCircleSelectAlias($aliasBasedOn)
 			->leftJoin(
 				$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
-				$expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
+				$expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
 			);
 
 		if (!is_null($initiator)) {
@@ -825,9 +825,9 @@ 
 			->leftJoin(
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
 				$expr->andX(
-					$expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
+					$expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
 					$expr->eq(
-						$aliasMember . '.level',
+						$aliasMember.'.level',
 						$this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
 					)
 				)
@@ -859,7 +859,7 @@ 
 
 		$expr = $this->expr();
 
-		$on = $expr->andX($expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field));
+		$on = $expr->andX($expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field));
 
 		// limit on membership level if requested
 		$minLevel = $probe->getMinimumLevel();
@@ -900,8 +900,8 @@ 
 			->leftJoin(
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
 				$expr->andX(
-					$expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
-					$expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
+					$expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
+					$expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
 					$this->exprGt('level', Member::LEVEL_MEMBER, true, $aliasMember)
 				)
 			);
@@ -933,7 +933,7 @@ 
 
 		$this->leftJoin(
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
 		);
 
 		//		if (!$this->getBool('getData', $options, false)) {
@@ -947,8 +947,8 @@ 
 			->leftJoin(
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
 				$expr->andX(
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
 				)
 			);
 
@@ -965,12 +965,12 @@ 
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
 		$this->leftJoin(
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
 		);
 
 		$orX = $expr->orX(
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
 		);
 
 		$this->andWhere($orX);
@@ -991,11 +991,11 @@ 
 
 		$expr = $this->expr();
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
 		if ($level > 1) {
 			$this->andWhere(
 				$expr->gte(
-					$aliasMembership . '.level',
+					$aliasMembership.'.level',
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
 				)
 			);
@@ -1023,8 +1023,8 @@ 
 		$this->leftJoin(
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
 			$expr->andX(
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
 			)
 		);
 
@@ -1037,8 +1037,8 @@ 
 			->leftJoin(
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
 				$expr->andX(
-					$expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
+					$expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
 				)
 			);
 	}
@@ -1078,7 +1078,7 @@ 
 
 		$this->leftJoin(
 			$alias, CoreRequestBuilder::TABLE_TOKEN, $aliasShareToken,
-			$expr->eq($aliasShareToken . '.share_id', $alias . '.' . $field)
+			$expr->eq($aliasShareToken.'.share_id', $alias.'.'.$field)
 		);
 	}
 
@@ -1120,14 +1120,14 @@ 
 		try {
 			$aliasConfig = $this->generateAlias($alias, self::CONFIG, $options);
 			$this->selectAlias(
-				$aliasConfig . '.config',
-				(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'circle_config'
+				$aliasConfig.'.config',
+				(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'circle_config'
 			);
 			$this->leftJoin(
 				$alias,
 				CoreRequestBuilder::TABLE_CIRCLE,
 				$aliasConfig,
-				$expr->eq($alias . '.circle_id', $aliasConfig . '.unique_id')
+				$expr->eq($alias.'.circle_id', $aliasConfig.'.unique_id')
 			);
 		} catch (RequestBuilderException $e) {
 		}
@@ -1165,7 +1165,7 @@ 
 			$aliasMembership,
 			$expr->andX(
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
 			)
 		);
 
@@ -1183,10 +1183,10 @@ 
 		try {
 			$aliasMembershipCircle = $this->generateAlias($aliasMembership, self::CONFIG, $options);
 			$orXMembershipCircle = $expr->orX(...array_map(
-				function (string $alias) use ($aliasMembershipCircle) {
+				function(string $alias) use ($aliasMembershipCircle) {
 					return $this->expr()->eq(
-						$alias . '.circle_id',
-						$aliasMembershipCircle . '.unique_id'
+						$alias.'.circle_id',
+						$aliasMembershipCircle.'.unique_id'
 					);
 				},
 				$listMembershipCircleAlias
@@ -1217,7 +1217,7 @@ 
 						$aliasDirectInitiator,
 						$expr->andX(
 							$this->exprLimit('single_id', $initiator->getSingleId(), $aliasDirectInitiator),
-							$expr->eq($aliasDirectInitiator . '.circle_id', $helperAlias . '.' . $field)
+							$expr->eq($aliasDirectInitiator.'.circle_id', $helperAlias.'.'.$field)
 						)
 					);
 			} catch (RequestBuilderException $e) {
@@ -1231,8 +1231,8 @@ 
 			$this->leftJoin(
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
 				$expr->andX(
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
 				)
 			);
 
@@ -1240,8 +1240,8 @@ 
 			$this->leftJoin(
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
 				$expr->andX(
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
 				)
 			);
 
@@ -1286,8 +1286,8 @@ 
 			->leftJoin(
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
 				$expr->andX(
-					$expr->eq($aliasInitiator . '.circle_id', $alias . '.unique_id'),
-					$expr->eq($aliasInitiator . '.' . $field, $helperAlias . '.inheritance_first'),
+					$expr->eq($aliasInitiator.'.circle_id', $alias.'.unique_id'),
+					$expr->eq($aliasInitiator.'.'.$field, $helperAlias.'.inheritance_first'),
 				)
 			);
 		//
@@ -1323,15 +1323,15 @@ 
 		if (!$this->getBool('filterPersonalCircles', $options, false)) {
 			$orX[] = $expr->andX(
 				$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $aliasMembershipCircle),
-				$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
+				$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
 			);
 		}
 
 		$minimumLevel = $this->getInt('minimumLevel', $options);
 		$orXLevelCheck = $expr->orX(...array_map(
-			function (string $alias) use ($minimumLevel) {
+			function(string $alias) use ($minimumLevel) {
 				return $this->expr()->gte(
-					$alias . '.level',
+					$alias.'.level',
 					$this->createNamedParameter($minimumLevel, self::PARAM_INT)
 				);
 			},
@@ -1411,13 +1411,13 @@ 
 	private function limitRemoteVisibility_Sensitive_Members(string $alias): ICompositeExpression {
 		$expr = $this->expr();
 		return $expr->andX(
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE)),
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE)),
 			$expr->orX(
-				$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance'),
+				$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance'),
 				// TODO: do we need this ? (display members from the local instance)
-				$expr->emptyString($this->getDefaultSelectAlias() . '.instance'),
+				$expr->emptyString($this->getDefaultSelectAlias().'.instance'),
 				$expr->eq(
-					$this->getDefaultSelectAlias() . '.level',
+					$this->getDefaultSelectAlias().'.level',
 					$this->createNamedParameter(Member::LEVEL_OWNER)
 				),
 			),
@@ -1452,11 +1452,11 @@ 
 			)
 			->leftJoin(
 				$aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
-				$expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
+				$expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
 			)
 			->leftJoin(
 				$aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
-				$expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
+				$expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
 			);
 	}
 
@@ -1478,8 +1478,8 @@ 
 		$this->leftJoin(
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
 			$expr->andX(
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
 			)
 		);
 
@@ -1537,13 +1537,13 @@ 
 		$this->leftJoin(
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
 			$expr->andX(
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
-				$expr->eq($aliasMountpoint . '.single_id', $this->createNamedParameter($federatedUser->getSingleId()))
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
+				$expr->eq($aliasMountpoint.'.single_id', $this->createNamedParameter($federatedUser->getSingleId()))
 			)
 		);
 
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
 	}
 
 
@@ -1651,10 +1651,10 @@ 
 	 */
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
 		$search = str_replace('_', '.', $base);
-		$path = $search . '.' . $extension;
+		$path = $search.'.'.$extension;
 		if (!$this->validKey($path, $this->getSqlPath())
 			&& !in_array($extension, $this->getArray($search, $this->getSqlPath()))) {
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
+			throw new RequestBuilderException($extension.' not found in '.$search);
 		}
 
 		if (!is_array($options)) {
@@ -1663,15 +1663,15 @@ 
 
 		$optionPath = '';
 		foreach (explode('.', $path) as $p) {
-			$optionPath = trim($optionPath . '.' . $p, '.');
+			$optionPath = trim($optionPath.'.'.$p, '.');
 			$options = array_merge(
 				$options,
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->getSqlPath()),
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->getSqlPath()),
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
 			);
 		}
 
-		return $base . '_' . $extension;
+		return $base.'_'.$extension;
 	}
 
 
@@ -1691,7 +1691,7 @@ 
 			} else {
 				$k = $arr;
 			}
-			$path[$k] = $prefix . '_' . $k . '_';
+			$path[$k] = $prefix.'_'.$k.'_';
 		}
 
 		return $path;

lib/Listeners/GroupChanged.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 		$groupId = $event->getGroup()->getGID();
 
 		$circle = new Circle();
-		$circle->setName('group:' . $groupId)
+		$circle->setName('group:'.$groupId)
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
 			->setSource(Member::TYPE_GROUP);
 

lib/Tools/Db/ExtendedQueryBuilder.php

Spacing +30 added lines, -30 removed lines

@@ -195,7 +195,7 @@ 
 	 */
 	public function limitToCreation(int $delay = 0): self {
 		$date = new DateTime('now');
-		$date->sub(new DateInterval('PT' . ((string)$delay) . 'M'));
+		$date->sub(new DateInterval('PT'.((string)$delay).'M'));
 
 		$this->limitToDBFieldDateTime('creation', $date, true);
 
@@ -212,7 +212,7 @@ 
 		$expr = $this->expr();
 		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias()
 																. '.' : '';
-		$field = $pf . $field;
+		$field = $pf.$field;
 
 		$orX = [$expr->lte($field, $this->createNamedParameter($date, IQueryBuilder::PARAM_DATE))];
 
@@ -239,8 +239,8 @@ 
 		}
 
 		$expr = $this->expr();
-		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias() . '.' : '';
-		$field = $pf . $field;
+		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias().'.' : '';
+		$field = $pf.$field;
 
 		$this->andWhere($expr->gte($field, $this->createNamedParameter($dTime, IQueryBuilder::PARAM_DATE)));
 	}
@@ -253,8 +253,8 @@ 
 	public function searchInDBField(string $field, string $value): void {
 		$expr = $this->expr();
 
-		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias() . '.' : '';
-		$field = $pf . $field;
+		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias().'.' : '';
+		$field = $pf.$field;
 
 		$this->andWhere($expr->iLike($field, $this->createNamedParameter($value)));
 	}
@@ -377,7 +377,7 @@ 
 	 */
 	public function exprLike(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -390,7 +390,7 @@ 
 
 	public function exprLimit(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -408,7 +408,7 @@ 
 
 	public function exprLimitInt(string $field, int $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -426,7 +426,7 @@ 
 	 */
 	public function exprLimitBool(string $field, bool $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -447,7 +447,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -472,7 +472,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -526,7 +526,7 @@ 
 		int $type = IQueryBuilder::PARAM_STR_ARRAY,
 	): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -543,7 +543,7 @@ 
 	 */
 	public function exprLimitBitwise(string $field, int $flag, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -565,7 +565,7 @@ 
 	 */
 	public function exprLt(string $field, int $value, bool $lte = false, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -587,7 +587,7 @@ 
 	 */
 	public function exprGt(string $field, int $value, bool $gte = false, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -696,7 +696,7 @@ 
 	 */
 	public function exprUnlike(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -720,7 +720,7 @@ 
 	 */
 	public function exprFilter(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -746,7 +746,7 @@ 
 	 */
 	public function exprFilterInt(string $field, int $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -764,7 +764,7 @@ 
 	 */
 	public function exprFilterBool(string $field, bool $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -785,7 +785,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -810,7 +810,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -838,7 +838,7 @@ 
 		bool $cs = true,
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$orX = [];
@@ -863,7 +863,7 @@ 
 	 */
 	public function exprFilterInArray(string $field, array $values, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -881,7 +881,7 @@ 
 	 */
 	public function exprFilterBitwise(string $field, int $flag, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -1042,12 +1042,12 @@ 
 		string $alias = '',
 	): self {
 		$selectFields = array_map(
-			function (string $item) use ($alias) {
+			function(string $item) use ($alias) {
 				if ($alias === '') {
 					return $item;
 				}
 
-				return $alias . '.' . $item;
+				return $alias.'.'.$item;
 			}, $fields
 		);
 
@@ -1073,13 +1073,13 @@ 
 		string $prefix,
 		array $default = [],
 	): self {
-		$prefix = trim($prefix) . '_';
+		$prefix = trim($prefix).'_';
 		foreach ($default as $k => $v) {
-			$this->addDefaultValue($prefix . $k, (string)$v);
+			$this->addDefaultValue($prefix.$k, (string)$v);
 		}
 
 		foreach ($fields as $field) {
-			$this->selectAlias($alias . '.' . $field, $prefix . $field);
+			$this->selectAlias($alias.'.'.$field, $prefix.$field);
 		}
 
 		return $this;

lib/Service/SyncService.php

Spacing +4 added lines, -4 removed lines

@@ -226,7 +226,7 @@ 
 	 * @throws SingleCircleNotFoundException
 	 */
 	public function syncNextcloudUser(string $userId): FederatedUser {
-		$this->outputService->output('Syncing Nextcloud Account \'' . $userId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud Account \''.$userId.'\'', true);
 
 		return $this->federatedUserService->getLocalFederatedUser($userId, false, true);
 	}
@@ -270,12 +270,12 @@ 
 	 * @throws RequestBuilderException
 	 */
 	public function syncNextcloudGroup(string $groupId): Circle {
-		$this->outputService->output('Syncing Nextcloud Group \'' . $groupId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud Group \''.$groupId.'\'', true);
 
 		$circle = $this->federatedUserService->getGroupCircle($groupId);
 		$this->circleService->updateDisplayName($circle->getSingleId(), $this->groupManager->getDisplayName($groupId));
 
-		$members = array_map(function (Member $member): string {
+		$members = array_map(function(Member $member): string {
 			return $member->getSingleId();
 		}, $this->memberRequest->getMembers($circle->getSingleId()));
 
@@ -353,7 +353,7 @@ 
 	 */
 	public function groupDeleted(string $groupId): void {
 		$circle = new Circle();
-		$circle->setName('group:' . $groupId)
+		$circle->setName('group:'.$groupId)
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
 			->setSource(Member::TYPE_GROUP);
 

lib/Command/CirclesMaintenance.php

Spacing +6 added lines, -6 removed lines

@@ -91,7 +91,7 @@ 
 				'<error>WARNING! You are about to delete all data related to the Circles App!</error>'
 			);
 			$question = new ConfirmationQuestion(
-				'<comment>Do you really want to ' . $action . ' Circles ?</comment> (y/N) ', false,
+				'<comment>Do you really want to '.$action.' Circles ?</comment> (y/N) ', false,
 				'/^(y|Y)/i'
 			);
 
@@ -107,7 +107,7 @@ 
 			$output->writeln('<error>WARNING! This operation is not reversible.</error>');
 
 			$question = new Question(
-				'<comment>Please confirm this destructive operation by typing \'' . $action
+				'<comment>Please confirm this destructive operation by typing \''.$action
 				. '\'</comment>: ', ''
 			);
 
@@ -125,7 +125,7 @@ 
 				$this->coreRequestBuilder->uninstall();
 			}
 
-			$output->writeln('<info>' . $action . ' done</info>');
+			$output->writeln('<info>'.$action.' done</info>');
 
 			return 0;
 		}
@@ -138,7 +138,7 @@ 
 				$this->maintenanceService->runMaintenance($i, $input->getOption('force-refresh'));
 			} catch (MaintenanceException $e) {
 				$this->logger->warning('issue while performing maintenance', ['level' => $i, ['exception' => $e]]);
-				$output->writeln('- <error>issue while performing maintenance</error> ' . $e->getMessage() . ' (more details in logs)');
+				$output->writeln('- <error>issue while performing maintenance</error> '.$e->getMessage().' (more details in logs)');
 			}
 		}
 
@@ -158,7 +158,7 @@ 
 		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);
 		$displayName = $this->maintenanceService->updateDisplayName($federatedUser);
 		if ($displayName !== '') {
-			$output->writeln('Display name of ' . $federatedUser->getSingleId() . ' updated to ' . $displayName);
+			$output->writeln('Display name of '.$federatedUser->getSingleId().' updated to '.$displayName);
 		}
 
 		return 0;
@@ -173,7 +173,7 @@ 
 			try {
 				$this->refreshSingleDisplayName($row['uid'], $output);
 			} catch (Exception $e) {
-				$output->writeln(get_class($e) . ' while trying to update display name of ' . $row['uid']);
+				$output->writeln(get_class($e).' while trying to update display name of '.$row['uid']);
 			}
 		}
 	}