Completed
Pull Request — master (#692)
by John
37s
created
lib/Service/MemberService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@
 block discarded – undo
251 251
 		}
252 252
 
253 253
 		$members = array_map(
254
-			function (FederatedUser $federatedUser) use ($patron) {
254
+			function(FederatedUser $federatedUser) use ($patron) {
255 255
 				$member = new Member();
256 256
 				$member->importFromIFederatedUser($federatedUser);
257 257
 				$member->setInvitedBy($patron);
Please login to merge, or discard this patch.
lib/Service/GSDownstreamService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@
 block discarded – undo
153 153
 			$gs = $this->globalScaleService->getGlobalScaleEvent($event);
154 154
 			$gs->manage($event);
155 155
 		} catch (Exception $e) {
156
-			$this->miscService->log('issue onNewEvent: ' . json_encode($event) . ' - ' . $e->getMessage());
156
+			$this->miscService->log('issue onNewEvent: '.json_encode($event).' - '.$e->getMessage());
157 157
 		}
158 158
 	}
159 159
 }
Please login to merge, or discard this patch.
lib/Service/MaintenanceService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 		$this->federatedUserService->bypassCurrentUserCondition(true);
142 142
 
143 143
 		$this->lockMaintenanceRun();
144
-		$this->debug('running maintenance (' . $level . ')');
144
+		$this->debug('running maintenance ('.$level.')');
145 145
 
146 146
 		switch ($level) {
147 147
 			case 1:
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 	 */
336 336
 	private function output(string $message): void {
337 337
 		if (!is_null($this->output)) {
338
-			$this->output->writeln('- ' . $message);
338
+			$this->output->writeln('- '.$message);
339 339
 		}
340 340
 	}
341 341
 }
Please login to merge, or discard this patch.
lib/Service/EventsService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 			$event->setSubject('circle_create', ['circle' => json_encode($circle)]);
144 144
 
145 145
 			$this->userManager->callForSeenUsers(
146
-				function ($user) use ($event) {
146
+				function($user) use ($event) {
147 147
 					/** @var IUser $user */
148 148
 					$this->publishEvent($event, [$user]);
149 149
 				}
Please login to merge, or discard this patch.
lib/Service/EventWrapperService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
 	 */
175 175
 	private function getFailedEvents(array $retryRange): array {
176 176
 		$token = array_map(
177
-			function (EventWrapper $event): string {
177
+			function(EventWrapper $event): string {
178 178
 				return $event->getToken();
179 179
 			}, $this->eventWrapperRequest->getFailedEvents($retryRange)
180 180
 		);
Please login to merge, or discard this patch.
lib/Service/MembershipService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 
142 142
 		foreach ($circles as $circle) {
143 143
 			$this->outputService->output(
144
-				'Caching memberships for \'' . $circle->getDisplayName() . '\'',
144
+				'Caching memberships for \''.$circle->getDisplayName().'\'',
145 145
 				true
146 146
 			);
147 147
 			$this->manageMemberships($circle->getSingleId());
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
 	 */
277 277
 	private function getChildrenMembers(string $id, array &$knownIds = []): array {
278 278
 		$singleIds = array_map(
279
-			function (Member $item): string {
279
+			function(Member $item): string {
280 280
 				return $item->getSingleId();
281 281
 			}, $this->memberRequest->getMembers($id)
282 282
 		);
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 */
301 301
 	private function getChildrenMemberships(string $id, array &$knownIds = []): array {
302 302
 		$singleIds = array_map(
303
-			function (Membership $item): string {
303
+			function(Membership $item): string {
304 304
 				return $item->getSingleId();
305 305
 			}, $this->membershipRequest->getInherited($id)
306 306
 		);
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	 */
347 347
 	private function removeDeprecatedMemberships(array $memberships, array $known): array {
348 348
 		$circleIds = array_map(
349
-			function (Membership $membership): string {
349
+			function(Membership $membership): string {
350 350
 				return $membership->getCircleId();
351 351
 			}, $memberships
352 352
 		);
Please login to merge, or discard this patch.
lib/Circles/FileSharingBroadcaster.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 			$this->miscService = OC::$server->query(MiscService::class);
137 137
 		} catch (QueryException $e) {
138 138
 			OC::$server->getLogger()
139
-					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - ' . $e->getMessage());
139
+					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - '.$e->getMessage());
140 140
 		}
141 141
 
142 142
 		try {
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 
282 282
 		$allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId());
283 283
 		$knownShares = array_map(
284
-			function (SharesToken $shareToken) {
284
+			function(SharesToken $shareToken) {
285 285
 				return $shareToken->getShareId();
286 286
 			},
287 287
 			$this->tokensRequest->getTokensFromMember($member)
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 	 * @throws IllegalIDChangeException
329 329
 	 */
330 330
 	private function generateShare($data): IShare {
331
-		$this->logger->log(0, 'Regenerate shares from payload: ' . json_encode($data));
331
+		$this->logger->log(0, 'Regenerate shares from payload: '.json_encode($data));
332 332
 
333 333
 		$share = new Share($this->rootFolder, $this->userManager);
334 334
 		$share->setId($data['id']);
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
 			$this->sendPasswordByMail($share, $displayName, $email, $password);
422 422
 		} catch (Exception $e) {
423 423
 			OC::$server->getLogger()
424
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
424
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
425 425
 		}
426 426
 	}
427 427
 
@@ -439,8 +439,8 @@  discard block
 block discarded – undo
439 439
 		$message = $this->mailer->createMessage();
440 440
 
441 441
 		$this->logger->log(
442
-			0, "Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
443
-			   . ' - link: ' . $link
442
+			0, "Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
443
+			   . ' - link: '.$link
444 444
 		);
445 445
 
446 446
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 
480 480
 		$message = $this->mailer->createMessage();
481 481
 
482
-		$this->logger->log(0, "Sending password mail to circle '" . $circleName . "': " . $email);
482
+		$this->logger->log(0, "Sending password mail to circle '".$circleName."': ".$email);
483 483
 
484 484
 		$filename = $share->getNode()
485 485
 						  ->getName();
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
535 535
 		if ($initiatorEmailAddress !== null) {
536 536
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
537
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
537
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
538 538
 		} else {
539 539
 			$emailTemplate->addFooter();
540 540
 		}
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 		$emailTemplate->addHeader();
570 570
 		$emailTemplate->addHeading($subject, false);
571 571
 		$emailTemplate->addBodyText(
572
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
572
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
573 573
 				$this->l10n->t('Click the button below to open it.')
574 574
 			), $text
575 575
 		);
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 			$this->sendMailExistingShares($template, $author->getCachedName(), $recipient);
616 616
 			$this->sendPasswordExistingShares($author, $recipient, $password);
617 617
 		} catch (Exception $e) {
618
-			$this->logger->log(2, 'Failed to send mail about existing share ' . $e->getMessage());
618
+			$this->logger->log(2, 'Failed to send mail about existing share '.$e->getMessage());
619 619
 		}
620 620
 	}
621 621
 
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
639 639
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
640 640
 
641
-		$this->logger->log(0, "Sending password mail about existing files to '" . $email . "'");
641
+		$this->logger->log(0, "Sending password mail about existing files to '".$email."'");
642 642
 
643 643
 		$plainBodyPart = $this->l10n->t(
644 644
 			"%1\$s shared multiple files with you.\nYou should have already received a separate email with a link to access them.\n",
@@ -680,7 +680,7 @@  discard block
 block discarded – undo
680 680
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
681 681
 		if ($authorEmail !== null) {
682 682
 			$message->setReplyTo([$authorEmail => $authorName]);
683
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
683
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
684 684
 		} else {
685 685
 			$emailTemplate->addFooter();
686 686
 		}
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
 	 */
726 726
 	protected function generateMailExitingShares($author, $circleName) {
727 727
 		$this->logger->log(
728
-			0, "Generating mail about existing share mail from '" . $author . "' in "
728
+			0, "Generating mail about existing share mail from '".$author."' in "
729 729
 			   . $circleName
730 730
 		);
731 731
 
Please login to merge, or discard this patch.
lib/FederatedItems/SingleMemberAdd.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -351,10 +351,10 @@  discard block
 block discarded – undo
351 351
 	protected function generateMember(FederatedEvent $event, Circle $circle, Member $member): Member {
352 352
 		try {
353 353
 			if ($member->getSingleId() !== '') {
354
-				$userId = $member->getSingleId() . '@' . $member->getInstance();
354
+				$userId = $member->getSingleId().'@'.$member->getInstance();
355 355
 				$federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_SINGLE);
356 356
 			} else {
357
-				$userId = $member->getUserId() . '@' . $member->getInstance();
357
+				$userId = $member->getUserId().'@'.$member->getInstance();
358 358
 				$federatedUser = $this->federatedUserService->getFederatedUser(
359 359
 					$userId,
360 360
 					$member->getUserType()
@@ -632,7 +632,7 @@  discard block
 block discarded – undo
632 632
 			$this->sendMailExistingShares($template, $author, $recipient);
633 633
 			$this->sendPasswordExistingShares($author, $recipient, $password);
634 634
 		} catch (Exception $e) {
635
-			$this->miscService->log('Failed to send mail about existing share ' . $e->getMessage());
635
+			$this->miscService->log('Failed to send mail about existing share '.$e->getMessage());
636 636
 		}
637 637
 	}
638 638
 
@@ -669,7 +669,7 @@  discard block
 block discarded – undo
669 669
 	private function getUnknownShares(DeprecatedMember $member): array {
670 670
 		$allShares = $this->fileSharesRequest->getSharesForCircle($member->getCircleId());
671 671
 		$knownShares = array_map(
672
-			function (SharesToken $shareToken) {
672
+			function(SharesToken $shareToken) {
673 673
 				return $shareToken->getShareId();
674 674
 			},
675 675
 			$this->tokensRequest->getTokensFromMember($member)
@@ -784,7 +784,7 @@  discard block
 block discarded – undo
784 784
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
785 785
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
786 786
 
787
-		$this->miscService->log("Sending password mail about existing files to '" . $email . "'", 0);
787
+		$this->miscService->log("Sending password mail about existing files to '".$email."'", 0);
788 788
 
789 789
 		$plainBodyPart = $this->l10n->t(
790 790
 			"%1\$s shared multiple files with you.\nYou should have already received a separate email with a link to access them.\n",
@@ -826,7 +826,7 @@  discard block
 block discarded – undo
826 826
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
827 827
 		if ($authorEmail !== null) {
828 828
 			$message->setReplyTo([$authorEmail => $authorName]);
829
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
829
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
830 830
 		} else {
831 831
 			$emailTemplate->addFooter();
832 832
 		}
Please login to merge, or discard this patch.
lib/GlobalScale/FileShare.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -85,14 +85,14 @@  discard block
 block discarded – undo
85 85
 			$node = $share->getNode();
86 86
 			$filename = $node->getName();
87 87
 		} catch (NotFoundException $e) {
88
-			$this->miscService->log('issue while FileShare: ' . $e->getMessage());
88
+			$this->miscService->log('issue while FileShare: '.$e->getMessage());
89 89
 
90 90
 			return;
91 91
 		}
92 92
 
93 93
 		$event->getData()
94 94
 			  ->s('gs_federated', $share->getToken())
95
-			  ->s('gs_filename', '/' . $filename);
95
+			  ->s('gs_filename', '/'.$filename);
96 96
 	}
97 97
 
98 98
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 			);
259 259
 		} catch (Exception $e) {
260 260
 			OC::$server->getLogger()
261
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
261
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
262 262
 		}
263 263
 	}
264 264
 
@@ -276,8 +276,8 @@  discard block
 block discarded – undo
276 276
 		$message = $this->mailer->createMessage();
277 277
 
278 278
 		$this->miscService->log(
279
-			"Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
280
-			. ' - link: ' . $link, 0
279
+			"Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
280
+			. ' - link: '.$link, 0
281 281
 		);
282 282
 
283 283
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 
317 317
 		$message = $this->mailer->createMessage();
318 318
 
319
-		$this->miscService->log("Sending password mail to circle '" . $circleName . "': " . $email, 0);
319
+		$this->miscService->log("Sending password mail to circle '".$circleName."': ".$email, 0);
320 320
 
321 321
 		$filename = $share->getNode()
322 322
 						  ->getName();
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
372 372
 		if ($initiatorEmailAddress !== null) {
373 373
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
374
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
374
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
375 375
 		} else {
376 376
 			$emailTemplate->addFooter();
377 377
 		}
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 		$emailTemplate->addHeader();
407 407
 		$emailTemplate->addHeading($subject, false);
408 408
 		$emailTemplate->addBodyText(
409
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
409
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
410 410
 				$this->l10n->t('Click the button below to open it.')
411 411
 			), $text
412 412
 		);
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
 		);
430 430
 
431 431
 		return array_map(
432
-			function (DeprecatedMember $member) {
432
+			function(DeprecatedMember $member) {
433 433
 				return $member->getUserId();
434 434
 			}, $members
435 435
 		);
Please login to merge, or discard this patch.