Completed
Pull Request — master (#692)
by John
37s
created
lib/Cron/Maintenance.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -54,9 +54,9 @@
 block discarded – undo
54 54
 
55 55
 	static $DELAY =
56 56
 		[
57
-			1 => 60,    // every minute
58
-			2 => 300,   // every 5 minutes
59
-			3 => 3600,  // every hour
57
+			1 => 60, // every minute
58
+			2 => 300, // every 5 minutes
59
+			3 => 3600, // every hour
60 60
 			4 => 75400, // every day
61 61
 			5 => 432000 // evey week
62 62
 		];
Please login to merge, or discard this patch.
lib/Model/ShareWrapper.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -648,9 +648,9 @@  discard block
 block discarded – undo
648 648
 
649 649
 		$display = $circle->getDisplayName();
650 650
 		if ($circle->getSource() === Member::TYPE_CIRCLE) {
651
-			$display .= ' (Circle owned by ' . $circle->getOwner()->getDisplayName() . ')';
651
+			$display .= ' (Circle owned by '.$circle->getOwner()->getDisplayName().')';
652 652
 		} else {
653
-			$display .= ' (' . Circle::$DEF_SOURCE[$circle->getSource()] . ')';
653
+			$display .= ' ('.Circle::$DEF_SOURCE[$circle->getSource()].')';
654 654
 		}
655 655
 
656 656
 		$share->setSharedWithDisplayName($display);
@@ -740,20 +740,20 @@  discard block
 block discarded – undo
740 740
 	 */
741 741
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
742 742
 		$shareTime = new DateTime();
743
-		$shareTime->setTimestamp($this->getInt($prefix . 'stime', $data));
744
-
745
-		$this->setId($this->get($prefix . 'id', $data))
746
-			 ->setShareType($this->getInt($prefix . 'share_type', $data))
747
-			 ->setPermissions($this->getInt($prefix . 'permissions', $data))
748
-			 ->setItemType($this->get($prefix . 'item_type', $data))
749
-			 ->setItemSource($this->getInt($prefix . 'item_source', $data))
750
-			 ->setItemTarget($this->get($prefix . 'item_target', $data))
751
-			 ->setFileSource($this->getInt($prefix . 'file_source', $data))
752
-			 ->setFileTarget($this->get($prefix . 'file_target', $data))
753
-			 ->setSharedWith($this->get($prefix . 'share_with', $data))
754
-			 ->setSharedBy($this->get($prefix . 'uid_initiator', $data))
755
-			 ->setShareOwner($this->get($prefix . 'uid_owner', $data))
756
-			 ->setToken($this->get($prefix . 'token', $data))
743
+		$shareTime->setTimestamp($this->getInt($prefix.'stime', $data));
744
+
745
+		$this->setId($this->get($prefix.'id', $data))
746
+			 ->setShareType($this->getInt($prefix.'share_type', $data))
747
+			 ->setPermissions($this->getInt($prefix.'permissions', $data))
748
+			 ->setItemType($this->get($prefix.'item_type', $data))
749
+			 ->setItemSource($this->getInt($prefix.'item_source', $data))
750
+			 ->setItemTarget($this->get($prefix.'item_target', $data))
751
+			 ->setFileSource($this->getInt($prefix.'file_source', $data))
752
+			 ->setFileTarget($this->get($prefix.'file_target', $data))
753
+			 ->setSharedWith($this->get($prefix.'share_with', $data))
754
+			 ->setSharedBy($this->get($prefix.'uid_initiator', $data))
755
+			 ->setShareOwner($this->get($prefix.'uid_owner', $data))
756
+			 ->setToken($this->get($prefix.'token', $data))
757 757
 			 ->setShareTime($shareTime);
758 758
 
759 759
 //		if (($password = $this->get('personal_password', $data, '')) !== '') {
@@ -762,9 +762,9 @@  discard block
 block discarded – undo
762 762
 //			$share->setPassword($this->get('password', $data, ''));
763 763
 //		}
764 764
 
765
-		$this->setChildId($this->getInt($prefix . 'child_id', $data))
766
-			 ->setChildFileTarget($this->get($prefix . 'child_file_target', $data))
767
-			 ->setChildPermissions($this->getInt($prefix . 'child_permissions', $data))
765
+		$this->setChildId($this->getInt($prefix.'child_id', $data))
766
+			 ->setChildFileTarget($this->get($prefix.'child_file_target', $data))
767
+			 ->setChildPermissions($this->getInt($prefix.'child_permissions', $data))
768 768
 			 ->setProviderId(ShareByCircleProvider::IDENTIFIER)
769 769
 			 ->setStatus(Ishare::STATUS_ACCEPTED);
770 770
 
Please login to merge, or discard this patch.
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +80 added lines, -80 removed lines patch added patch discarded remove patch
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
 		}
398 398
 
399 399
 		if ($circle->getDisplayName() !== '') {
400
-			$this->searchInDBField('display_name', '%' . $circle->getDisplayName() . '%');
400
+			$this->searchInDBField('display_name', '%'.$circle->getDisplayName().'%');
401 401
 		}
402 402
 		if ($circle->getConfig() > 0) {
403 403
 			$this->limitBitwise('config', $circle->getConfig());
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
417 417
 				 ->leftJoin(
418 418
 					 $alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
419
-					 $expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
419
+					 $expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
420 420
 				 );
421 421
 		} catch (RequestBuilderException $e) {
422 422
 		}
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
 		$expr = $this->expr();
470 470
 		$this->leftJoin(
471 471
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
472
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
472
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
473 473
 		);
474 474
 	}
475 475
 
@@ -497,12 +497,12 @@  discard block
 block discarded – undo
497 497
 		$this->leftJoin(
498 498
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
499 499
 			$expr->andX(
500
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
500
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
501 501
 				$expr->eq(
502
-					$aliasRemoteMember . '.instance',
502
+					$aliasRemoteMember.'.instance',
503 503
 					$this->createNamedParameter($remoteInstance->getInstance())
504 504
 				),
505
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
505
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
506 506
 			)
507 507
 		);
508 508
 	}
@@ -534,21 +534,21 @@  discard block
 block discarded – undo
534 534
 		$this->leftJoin(
535 535
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
536 536
 			$expr->andX(
537
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
538
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
539
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
537
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
538
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
539
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
540 540
 			)
541 541
 		);
542 542
 		$this->leftJoin(
543 543
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
544 544
 			$expr->andX(
545
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
545
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
546 546
 				$expr->eq(
547
-					$aliasRemoteCircleOwner . '.instance',
547
+					$aliasRemoteCircleOwner.'.instance',
548 548
 					$this->createNamedParameter($remoteInstance->getInstance())
549 549
 				),
550 550
 				$expr->eq(
551
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
551
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
552 552
 				)
553 553
 			)
554 554
 		);
@@ -581,16 +581,16 @@  discard block
 block discarded – undo
581 581
 		$expr = $this->expr();
582 582
 		$orX = $expr->orX();
583 583
 		$orX->add(
584
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
584
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
585 585
 		);
586 586
 
587 587
 		$orExtOrPassive = $expr->orX();
588 588
 		$orExtOrPassive->add(
589
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
589
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
590 590
 		);
591 591
 		if (!$sensitive) {
592 592
 			$orExtOrPassive->add(
593
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
593
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
594 594
 			);
595 595
 		} else {
596 596
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -599,8 +599,8 @@  discard block
 block discarded – undo
599 599
 		}
600 600
 
601 601
 		$orInstance = $expr->orX();
602
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
603
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
602
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
603
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
604 604
 
605 605
 		$andExternal = $expr->andX();
606 606
 		$andExternal->add($orExtOrPassive);
@@ -609,13 +609,13 @@  discard block
 block discarded – undo
609 609
 		$orExtOrTrusted = $expr->orX();
610 610
 		$orExtOrTrusted->add($andExternal);
611 611
 		$orExtOrTrusted->add(
612
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
612
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
613 613
 		);
614 614
 
615 615
 		$andTrusted = $expr->andX();
616 616
 		$andTrusted->add($orExtOrTrusted);
617 617
 		$andTrusted->add($this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle));
618
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
618
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
619 619
 		$orX->add($andTrusted);
620 620
 
621 621
 		$this->andWhere($orX);
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
 		}
643 643
 		$this->leftJoin(
644 644
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
645
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
645
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
646 646
 		);
647 647
 
648 648
 		$this->filterDirectMembership($aliasMember, $member);
@@ -663,30 +663,30 @@  discard block
 block discarded – undo
663 663
 
664 664
 		if ($member->getUserId() !== '') {
665 665
 			$andX->add(
666
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
666
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
667 667
 			);
668 668
 		}
669 669
 
670 670
 		if ($member->getSingleId() !== '') {
671 671
 			$andX->add(
672
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
672
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
673 673
 			);
674 674
 		}
675 675
 
676 676
 		if ($member->getUserType() > 0) {
677 677
 			$andX->add(
678
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
678
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
679 679
 			);
680 680
 		}
681 681
 
682 682
 		$andX->add(
683
-			$expr->eq($aliasMember . '.instance', $this->createNamedParameter($this->getInstance($member)))
683
+			$expr->eq($aliasMember.'.instance', $this->createNamedParameter($this->getInstance($member)))
684 684
 		);
685 685
 
686 686
 		if ($member->getLevel() > 0) {
687 687
 			$andX->add(
688 688
 				$expr->gte(
689
-					$aliasMember . '.level',
689
+					$aliasMember.'.level',
690 690
 					$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
691 691
 				)
692 692
 			);
@@ -717,12 +717,12 @@  discard block
 block discarded – undo
717 717
 
718 718
 		$expr = $this->expr();
719 719
 		$this->selectAlias(
720
-			$this->createFunction('COUNT(`' . $aliasMemberCount . '`.`member_id`)'),
721
-			(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'population'
720
+			$this->createFunction('COUNT(`'.$aliasMemberCount.'`.`member_id`)'),
721
+			(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'population'
722 722
 		);
723 723
 		$this->leftJoin(
724 724
 			$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMemberCount,
725
-			$expr->eq($alias . '.unique_id', $aliasMemberCount . '.circle_id')
725
+			$expr->eq($alias.'.unique_id', $aliasMemberCount.'.circle_id')
726 726
 		);
727 727
 	}
728 728
 
@@ -758,7 +758,7 @@  discard block
 block discarded – undo
758 758
 			$helperAlias,
759 759
 			CoreRequestBuilder::TABLE_CIRCLE,
760 760
 			$aliasCircle,
761
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
761
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
762 762
 		);
763 763
 
764 764
 		if (!is_null($initiator)) {
@@ -789,7 +789,7 @@  discard block
 block discarded – undo
789 789
 		$this->generateCircleSelectAlias($aliasInvitedBy)
790 790
 			 ->leftJoin(
791 791
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
792
-				 $expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
792
+				 $expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
793 793
 			 );
794 794
 
795 795
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -820,7 +820,7 @@  discard block
 block discarded – undo
820 820
 		$this->generateCircleSelectAlias($aliasBasedOn)
821 821
 			 ->leftJoin(
822 822
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
823
-				 $expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
823
+				 $expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
824 824
 			 );
825 825
 
826 826
 		if (!is_null($initiator)) {
@@ -853,9 +853,9 @@  discard block
 block discarded – undo
853 853
 			 ->leftJoin(
854 854
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
855 855
 				 $expr->andX(
856
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
856
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
857 857
 					 $expr->eq(
858
-						 $aliasMember . '.level',
858
+						 $aliasMember.'.level',
859 859
 						 $this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
860 860
 					 )
861 861
 				 )
@@ -893,10 +893,10 @@  discard block
 block discarded – undo
893 893
 			 ->leftJoin(
894 894
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
895 895
 				 $expr->andX(
896
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
897
-					 $expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
896
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
897
+					 $expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
898 898
 					 $expr->gte(
899
-						 $aliasMember . '.level',
899
+						 $aliasMember.'.level',
900 900
 						 $this->createNamedParameter(Member::LEVEL_MEMBER, self::PARAM_INT)
901 901
 					 )
902 902
 				 )
@@ -929,7 +929,7 @@  discard block
 block discarded – undo
929 929
 
930 930
 		$this->leftJoin(
931 931
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
932
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
932
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
933 933
 		);
934 934
 
935 935
 //		if (!$this->getBool('getData', $options, false)) {
@@ -943,8 +943,8 @@  discard block
 block discarded – undo
943 943
 			 ->leftJoin(
944 944
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
945 945
 				 $expr->andX(
946
-					 $expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
947
-					 $expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
946
+					 $expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
947
+					 $expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
948 948
 				 )
949 949
 			 );
950 950
 
@@ -961,12 +961,12 @@  discard block
 block discarded – undo
961 961
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
962 962
 		$this->leftJoin(
963 963
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
964
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
964
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
965 965
 		);
966 966
 
967 967
 		$orX = $expr->orX(
968
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
969
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
968
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
969
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
970 970
 		);
971 971
 
972 972
 		$this->andWhere($orX);
@@ -987,11 +987,11 @@  discard block
 block discarded – undo
987 987
 
988 988
 		$expr = $this->expr();
989 989
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
990
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
990
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
991 991
 		if ($level > 1) {
992 992
 			$this->andWhere(
993 993
 				$expr->gte(
994
-					$aliasMembership . '.level',
994
+					$aliasMembership.'.level',
995 995
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
996 996
 				)
997 997
 			);
@@ -1019,8 +1019,8 @@  discard block
 block discarded – undo
1019 1019
 		$this->leftJoin(
1020 1020
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
1021 1021
 			$expr->andX(
1022
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
1023
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
1022
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
1023
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
1024 1024
 			)
1025 1025
 		);
1026 1026
 
@@ -1033,8 +1033,8 @@  discard block
 block discarded – undo
1033 1033
 			 ->leftJoin(
1034 1034
 				 $aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
1035 1035
 				 $expr->andX(
1036
-					 $expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
1037
-					 $expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
1036
+					 $expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
1037
+					 $expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
1038 1038
 				 )
1039 1039
 			 );
1040 1040
 	}
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 
1068 1068
 		$this->leftJoin(
1069 1069
 			$alias, CoreRequestBuilder::TABLE_TOKEN, $aliasShareToken,
1070
-			$expr->eq($aliasShareToken . '.share_id', $alias . '.' . $field)
1070
+			$expr->eq($aliasShareToken.'.share_id', $alias.'.'.$field)
1071 1071
 		);
1072 1072
 	}
1073 1073
 
@@ -1109,14 +1109,14 @@  discard block
 block discarded – undo
1109 1109
 		try {
1110 1110
 			$aliasConfig = $this->generateAlias($alias, self::CONFIG, $options);
1111 1111
 			$this->selectAlias(
1112
-				$aliasConfig . '.config',
1113
-				(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'circle_config'
1112
+				$aliasConfig.'.config',
1113
+				(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'circle_config'
1114 1114
 			);
1115 1115
 			$this->leftJoin(
1116 1116
 				$alias,
1117 1117
 				CoreRequestBuilder::TABLE_CIRCLE,
1118 1118
 				$aliasConfig,
1119
-				$expr->eq($alias . '.circle_id', $aliasConfig . '.unique_id')
1119
+				$expr->eq($alias.'.circle_id', $aliasConfig.'.unique_id')
1120 1120
 			);
1121 1121
 		} catch (RequestBuilderException $e) {
1122 1122
 		}
@@ -1154,7 +1154,7 @@  discard block
 block discarded – undo
1154 1154
 			$aliasMembership,
1155 1155
 			$expr->andX(
1156 1156
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1157
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1157
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1158 1158
 			)
1159 1159
 		);
1160 1160
 
@@ -1164,7 +1164,7 @@  discard block
 block discarded – undo
1164 1164
 				$aliasMembership,
1165 1165
 				CoreRequestBuilder::TABLE_CIRCLE,
1166 1166
 				$aliasMembershipCircle,
1167
-				$expr->eq($aliasMembership . '.circle_id', $aliasMembershipCircle . '.unique_id')
1167
+				$expr->eq($aliasMembership.'.circle_id', $aliasMembershipCircle.'.unique_id')
1168 1168
 			);
1169 1169
 		} catch (RequestBuilderException $e) {
1170 1170
 		}
@@ -1185,7 +1185,7 @@  discard block
 block discarded – undo
1185 1185
 						 $aliasDirectInitiator,
1186 1186
 						 $expr->andX(
1187 1187
 							 $this->exprLimit('single_id', $initiator->getSingleId(), $aliasDirectInitiator),
1188
-							 $expr->eq($aliasDirectInitiator . '.circle_id', $helperAlias . '.' . $field)
1188
+							 $expr->eq($aliasDirectInitiator.'.circle_id', $helperAlias.'.'.$field)
1189 1189
 						 )
1190 1190
 					 );
1191 1191
 			} catch (RequestBuilderException $e) {
@@ -1198,8 +1198,8 @@  discard block
 block discarded – undo
1198 1198
 			$this->leftJoin(
1199 1199
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1200 1200
 				$expr->andX(
1201
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1202
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1201
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1202
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1203 1203
 				)
1204 1204
 			);
1205 1205
 
@@ -1207,8 +1207,8 @@  discard block
 block discarded – undo
1207 1207
 			$this->leftJoin(
1208 1208
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1209 1209
 				$expr->andX(
1210
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1211
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1210
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1211
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1212 1212
 				)
1213 1213
 			);
1214 1214
 
@@ -1260,7 +1260,7 @@  discard block
 block discarded – undo
1260 1260
 			$orX->add(
1261 1261
 				$expr->andX(
1262 1262
 					$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $aliasMembershipCircle),
1263
-					$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1263
+					$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1264 1264
 				)
1265 1265
 			);
1266 1266
 		}
@@ -1349,21 +1349,21 @@  discard block
 block discarded – undo
1349 1349
 		$expr = $this->expr();
1350 1350
 		$andPassive = $expr->andX();
1351 1351
 		$andPassive->add(
1352
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1352
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1353 1353
 		);
1354 1354
 
1355 1355
 		$orMemberOrLevel = $expr->orX();
1356 1356
 		$orMemberOrLevel->add(
1357
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1357
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1358 1358
 		);
1359 1359
 		// TODO: do we need this ? (display members from the local instance)
1360 1360
 		$orMemberOrLevel->add(
1361
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1361
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1362 1362
 		);
1363 1363
 
1364 1364
 		$orMemberOrLevel->add(
1365 1365
 			$expr->eq(
1366
-				$this->getDefaultSelectAlias() . '.level',
1366
+				$this->getDefaultSelectAlias().'.level',
1367 1367
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1368 1368
 			)
1369 1369
 		);
@@ -1400,11 +1400,11 @@  discard block
 block discarded – undo
1400 1400
 			 )
1401 1401
 			 ->leftJoin(
1402 1402
 				 $aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1403
-				 $expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1403
+				 $expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1404 1404
 			 )
1405 1405
 			 ->leftJoin(
1406 1406
 				 $aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1407
-				 $expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1407
+				 $expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1408 1408
 			 );
1409 1409
 	}
1410 1410
 
@@ -1426,8 +1426,8 @@  discard block
 block discarded – undo
1426 1426
 		$this->leftJoin(
1427 1427
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1428 1428
 			$expr->andX(
1429
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1430
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1429
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1430
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1431 1431
 			)
1432 1432
 		);
1433 1433
 
@@ -1477,13 +1477,13 @@  discard block
 block discarded – undo
1477 1477
 		$this->leftJoin(
1478 1478
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1479 1479
 			$expr->andX(
1480
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1481
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1480
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1481
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1482 1482
 			)
1483 1483
 		);
1484 1484
 
1485
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1486
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1485
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1486
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1487 1487
 	}
1488 1488
 
1489 1489
 
@@ -1587,10 +1587,10 @@  discard block
 block discarded – undo
1587 1587
 	 */
1588 1588
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1589 1589
 		$search = str_replace('_', '.', $base);
1590
-		$path = $search . '.' . $extension;
1590
+		$path = $search.'.'.$extension;
1591 1591
 		if (!$this->validKey($path, self::$SQL_PATH)
1592 1592
 			&& !in_array($extension, $this->getArray($search, self::$SQL_PATH))) {
1593
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1593
+			throw new RequestBuilderException($extension.' not found in '.$search);
1594 1594
 		}
1595 1595
 
1596 1596
 		if (!is_array($options)) {
@@ -1599,15 +1599,15 @@  discard block
 block discarded – undo
1599 1599
 
1600 1600
 		$optionPath = '';
1601 1601
 		foreach (explode('.', $path) as $p) {
1602
-			$optionPath = trim($optionPath . '.' . $p, '.');
1602
+			$optionPath = trim($optionPath.'.'.$p, '.');
1603 1603
 			$options = array_merge(
1604 1604
 				$options,
1605
-				$this->getArray($optionPath . '.' . self::OPTIONS, self::$SQL_PATH),
1606
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1605
+				$this->getArray($optionPath.'.'.self::OPTIONS, self::$SQL_PATH),
1606
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1607 1607
 			);
1608 1608
 		}
1609 1609
 
1610
-		return $base . '_' . $extension;
1610
+		return $base.'_'.$extension;
1611 1611
 	}
1612 1612
 
1613 1613
 
@@ -1627,7 +1627,7 @@  discard block
 block discarded – undo
1627 1627
 			} else {
1628 1628
 				$k = $arr;
1629 1629
 			}
1630
-			$path[$k] = $prefix . '_' . $k . '_';
1630
+			$path[$k] = $prefix.'_'.$k.'_';
1631 1631
 		}
1632 1632
 
1633 1633
 		return $path;
@@ -1644,7 +1644,7 @@  discard block
 block discarded – undo
1644 1644
 		$expr = $this->expr();
1645 1645
 		$orX = $expr->orX();
1646 1646
 		foreach ($aliases as $alias) {
1647
-			$orX->add($expr->gte($alias . '.level', $this->createNamedParameter($level)));
1647
+			$orX->add($expr->gte($alias.'.level', $this->createNamedParameter($level)));
1648 1648
 		}
1649 1649
 
1650 1650
 		return $orX;
Please login to merge, or discard this patch.
lib/Model/ShareToken.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -254,13 +254,13 @@
 block discarded – undo
254 254
 	 * @return INC22QueryRow
255 255
 	 */
256 256
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
257
-		$this->setShareId($this->getInt($prefix . 'share_id', $data));
258
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
259
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
260
-		$this->setMemberId($this->get($prefix . 'member_id', $data));
261
-		$this->setToken($this->get($prefix . 'token', $data));
262
-		$this->setPassword($this->get($prefix . 'password', $data));
263
-		$this->setAccepted($this->getInt($prefix . 'accepted', $data, IShare::STATUS_PENDING));
257
+		$this->setShareId($this->getInt($prefix.'share_id', $data));
258
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
259
+		$this->setSingleId($this->get($prefix.'single_id', $data));
260
+		$this->setMemberId($this->get($prefix.'member_id', $data));
261
+		$this->setToken($this->get($prefix.'token', $data));
262
+		$this->setPassword($this->get($prefix.'password', $data));
263
+		$this->setAccepted($this->getInt($prefix.'accepted', $data, IShare::STATUS_PENDING));
264 264
 
265 265
 		return $this;
266 266
 	}
Please login to merge, or discard this patch.
lib/Service/MigrationService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
 				try {
239 239
 					$data = new SimpleDataStore($row);
240 240
 					$this->outputService->output(
241
-						'Migrating Circle \'' . $data->g('name') . '\' (' . $data->g('unique_id') . ')',
241
+						'Migrating Circle \''.$data->g('name').'\' ('.$data->g('unique_id').')',
242 242
 						true
243 243
 					);
244 244
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 				try {
343 343
 					$data = new SimpleDataStore($row);
344 344
 					$this->outputService->output(
345
-						'Migrating Member \'' . $data->g('user_id') . '\' from \'' . $data->g('circle_id')
345
+						'Migrating Member \''.$data->g('user_id').'\' from \''.$data->g('circle_id')
346 346
 						. '\'',
347 347
 						true
348 348
 					);
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 			$addressBook =
461 461
 				$this->contactService->getAddressBoxById($cm, $this->get('addressbook-key', $entry));
462 462
 
463
-			$member->setUserId($userId . '/' . $addressBook->getUri() . '/' . $contactId);
463
+			$member->setUserId($userId.'/'.$addressBook->getUri().'/'.$contactId);
464 464
 		}
465 465
 	}
466 466
 
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 				try {
496 496
 					$data = new SimpleDataStore($row);
497 497
 					$this->outputService->output(
498
-						'Migrating ShareToken \'' . $data->g('token') . '\' for \'' . $data->g('user_id')
498
+						'Migrating ShareToken \''.$data->g('token').'\' for \''.$data->g('user_id')
499 499
 						. '\'',
500 500
 						true
501 501
 					);
Please login to merge, or discard this patch.
lib/Command/CirclesMemberships.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -214,10 +214,10 @@  discard block
 block discarded – undo
214 214
 //			return 0;
215 215
 //		}
216 216
 
217
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
218
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
219
-		$output->writeln('Type: <info>' . Member::$TYPE[$federatedUser->getUserType()] . '</info>');
220
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
217
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
218
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
219
+		$output->writeln('Type: <info>'.Member::$TYPE[$federatedUser->getUserType()].'</info>');
220
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
221 221
 
222 222
 		$output->writeln('');
223 223
 		$output->writeln('Memberships:');
@@ -226,14 +226,14 @@  discard block
 block discarded – undo
226 226
 		if ($count === 0) {
227 227
 			$output->writeln('(database not updated)');
228 228
 		} else {
229
-			$output->writeln('(' . $count . ' entries generated/updated in the database)');
229
+			$output->writeln('('.$count.' entries generated/updated in the database)');
230 230
 		}
231 231
 
232 232
 		foreach ($federatedUser->getMemberships() as $membership) {
233 233
 			$this->memberships[$membership->getCircleId()] = $membership;
234 234
 			$output->writeln(
235
-				'- <info>' . $membership->getCircleId() . '</info> ('
236
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
235
+				'- <info>'.$membership->getCircleId().'</info> ('
236
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
237 237
 			);
238 238
 		}
239 239
 
@@ -307,9 +307,9 @@  discard block
 block discarded – undo
307 307
 				if ($lineNumber === 2) {
308 308
 					return '';
309 309
 				}
310
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
310
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
311 311
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
312
-					$line .= '@' . $federatedUser->getInstance();
312
+					$line .= '@'.$federatedUser->getInstance();
313 313
 				}
314 314
 
315 315
 				return $line;
@@ -321,28 +321,28 @@  discard block
 block discarded – undo
321 321
 				$circle = $member->getCircle();
322 322
 
323 323
 				if ($lineNumber === 1) {
324
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
324
+					$line .= '<info>'.$circle->getSingleId().'</info>';
325 325
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
326
-						$line .= '@' . $circle->getInstance();
326
+						$line .= '@'.$circle->getInstance();
327 327
 					}
328
-					$line .= ' (' . ($this->input->getOption('display-name') ?
329
-							$circle->getDisplayName() : $circle->getName()) . ')';
330
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
331
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
328
+					$line .= ' ('.($this->input->getOption('display-name') ?
329
+							$circle->getDisplayName() : $circle->getName()).')';
330
+					$line .= ' <info>MemberId</info>: '.$member->getId();
331
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
332 332
 
333 333
 					$knownMembership = $this->memberships[$member->getCircleId()];
334 334
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
335
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
335
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
336 336
 					}
337 337
 				}
338 338
 				if ($lineNumber === 2) {
339 339
 					$owner = $circle->getOwner();
340
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
340
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
341 341
 					if ($owner->hasBasedOn()) {
342
-						$line .= ' (' . Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()] . ') ';
342
+						$line .= ' ('.Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()].') ';
343 343
 					}
344 344
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
345
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
345
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
346 346
 				}
347 347
 
348 348
 				return $line;
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 			);
399 399
 		}
400 400
 
401
-		$output->writeln($count . ' memberships updated');
401
+		$output->writeln($count.' memberships updated');
402 402
 	}
403 403
 
404 404
 }
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
 //use OCA\Files\App as FilesApp;
84 84
 
85 85
 
86
-require_once __DIR__ . '/../../vendor/autoload.php';
86
+require_once __DIR__.'/../../vendor/autoload.php';
87 87
 
88 88
 
89 89
 /**
Please login to merge, or discard this patch.
lib/Service/CirclesService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -577,24 +577,24 @@
 block discarded – undo
577 577
 		switch ($type) {
578 578
 			case DeprecatedCircle::CIRCLES_PERSONAL:
579 579
 				return $urlGen->getAbsoluteURL(
580
-					$urlGen->imagePath(Application::APP_ID, 'personal' . $ext)
580
+					$urlGen->imagePath(Application::APP_ID, 'personal'.$ext)
581 581
 				);
582 582
 			case DeprecatedCircle::CIRCLES_CLOSED:
583 583
 				return $urlGen->getAbsoluteURL(
584
-					$urlGen->imagePath(Application::APP_ID, 'closed' . $ext)
584
+					$urlGen->imagePath(Application::APP_ID, 'closed'.$ext)
585 585
 				);
586 586
 			case DeprecatedCircle::CIRCLES_SECRET:
587 587
 				return $urlGen->getAbsoluteURL(
588
-					$urlGen->imagePath(Application::APP_ID, 'secret' . $ext)
588
+					$urlGen->imagePath(Application::APP_ID, 'secret'.$ext)
589 589
 				);
590 590
 			case DeprecatedCircle::CIRCLES_PUBLIC:
591 591
 				return $urlGen->getAbsoluteURL(
592
-					$urlGen->imagePath(Application::APP_ID, 'circles' . $ext)
592
+					$urlGen->imagePath(Application::APP_ID, 'circles'.$ext)
593 593
 				);
594 594
 		}
595 595
 
596 596
 		return $urlGen->getAbsoluteURL(
597
-			$urlGen->imagePath(Application::APP_ID, 'circles' . $ext)
597
+			$urlGen->imagePath(Application::APP_ID, 'circles'.$ext)
598 598
 		);
599 599
 	}
600 600
 
Please login to merge, or discard this patch.
lib/Service/MaintenanceService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 		$this->federatedUserService->bypassCurrentUserCondition(true);
146 146
 
147 147
 		$this->lockMaintenanceRun();
148
-		$this->debug('running maintenance (' . $level . ')');
148
+		$this->debug('running maintenance ('.$level.')');
149 149
 
150 150
 		switch ($level) {
151 151
 			case 1:
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 	 */
341 341
 	private function output(string $message): void {
342 342
 		if (!is_null($this->output)) {
343
-			$this->output->writeln('- ' . $message);
343
+			$this->output->writeln('- '.$message);
344 344
 		}
345 345
 	}
346 346
 
Please login to merge, or discard this patch.