nextcloud / circles

lib/Model/Membership.php

Spacing +9 added lines, -9 removed lines

@@ -305,18 +305,18 @@
 	 * @throws MembershipNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		if ($this->get($prefix . 'single_id', $data) === '') {
+		if ($this->get($prefix.'single_id', $data) === '') {
 			throw new MembershipNotFoundException();
 		}
 
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
-		$this->setLevel($this->getInt($prefix . 'level', $data));
-		$this->setCircleConfig($this->getInt($prefix . 'circle_config', $data));
-		$this->setInheritanceFirst($this->get($prefix . 'inheritance_first', $data));
-		$this->setInheritanceLast($this->get($prefix . 'inheritance_last', $data));
-		$this->setInheritancePath($this->getArray($prefix . 'inheritance_path', $data));
-		$this->setInheritanceDepth($this->getInt($prefix . 'inheritance_depth', $data));
+		$this->setSingleId($this->get($prefix.'single_id', $data));
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
+		$this->setLevel($this->getInt($prefix.'level', $data));
+		$this->setCircleConfig($this->getInt($prefix.'circle_config', $data));
+		$this->setInheritanceFirst($this->get($prefix.'inheritance_first', $data));
+		$this->setInheritanceLast($this->get($prefix.'inheritance_last', $data));
+		$this->setInheritancePath($this->getArray($prefix.'inheritance_path', $data));
+		$this->setInheritanceDepth($this->getInt($prefix.'inheritance_depth', $data));
 
 		return $this;
 	}

lib/Controller/AdminController.php

Spacing +1 added lines, -1 removed lines

@@ -194,7 +194,7 @@
 					throw new OCSException('works only from local instance', 404);
 				}
 
-				$userId = $currentUser->getUserId() . '/' . $userId;
+				$userId = $currentUser->getUserId().'/'.$userId;
 			}
 
 			$federatedUser = $this->federatedUserService->generateFederatedUser($userId, $type);

lib/Model/ShareWrapper.php

Spacing +19 added lines, -19 removed lines

@@ -648,9 +648,9 @@ 
 
 		$display = $circle->getDisplayName();
 		if ($circle->getSource() === Member::TYPE_CIRCLE) {
-			$display .= ' (Circle owned by ' . $circle->getOwner()->getDisplayName() . ')';
+			$display .= ' (Circle owned by '.$circle->getOwner()->getDisplayName().')';
 		} else {
-			$display .= ' (' . Circle::$DEF_SOURCE[$circle->getSource()] . ')';
+			$display .= ' ('.Circle::$DEF_SOURCE[$circle->getSource()].')';
 		}
 
 		$share->setSharedWithDisplayName($display);
@@ -740,20 +740,20 @@ 
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
 		$shareTime = new DateTime();
-		$shareTime->setTimestamp($this->getInt($prefix . 'stime', $data));
-
-		$this->setId($this->get($prefix . 'id', $data))
-			 ->setShareType($this->getInt($prefix . 'share_type', $data))
-			 ->setPermissions($this->getInt($prefix . 'permissions', $data))
-			 ->setItemType($this->get($prefix . 'item_type', $data))
-			 ->setItemSource($this->getInt($prefix . 'item_source', $data))
-			 ->setItemTarget($this->get($prefix . 'item_target', $data))
-			 ->setFileSource($this->getInt($prefix . 'file_source', $data))
-			 ->setFileTarget($this->get($prefix . 'file_target', $data))
-			 ->setSharedWith($this->get($prefix . 'share_with', $data))
-			 ->setSharedBy($this->get($prefix . 'uid_initiator', $data))
-			 ->setShareOwner($this->get($prefix . 'uid_owner', $data))
-			 ->setToken($this->get($prefix . 'token', $data))
+		$shareTime->setTimestamp($this->getInt($prefix.'stime', $data));
+
+		$this->setId($this->get($prefix.'id', $data))
+			 ->setShareType($this->getInt($prefix.'share_type', $data))
+			 ->setPermissions($this->getInt($prefix.'permissions', $data))
+			 ->setItemType($this->get($prefix.'item_type', $data))
+			 ->setItemSource($this->getInt($prefix.'item_source', $data))
+			 ->setItemTarget($this->get($prefix.'item_target', $data))
+			 ->setFileSource($this->getInt($prefix.'file_source', $data))
+			 ->setFileTarget($this->get($prefix.'file_target', $data))
+			 ->setSharedWith($this->get($prefix.'share_with', $data))
+			 ->setSharedBy($this->get($prefix.'uid_initiator', $data))
+			 ->setShareOwner($this->get($prefix.'uid_owner', $data))
+			 ->setToken($this->get($prefix.'token', $data))
 			 ->setShareTime($shareTime);
 
 //		if (($password = $this->get('personal_password', $data, '')) !== '') {
@@ -762,9 +762,9 @@ 
 //			$share->setPassword($this->get('password', $data, ''));
 //		}
 
-		$this->setChildId($this->getInt($prefix . 'child_id', $data))
-			 ->setChildFileTarget($this->get($prefix . 'child_file_target', $data))
-			 ->setChildPermissions($this->getInt($prefix . 'child_permissions', $data))
+		$this->setChildId($this->getInt($prefix.'child_id', $data))
+			 ->setChildFileTarget($this->get($prefix.'child_file_target', $data))
+			 ->setChildPermissions($this->getInt($prefix.'child_permissions', $data))
 			 ->setProviderId(ShareByCircleProvider::IDENTIFIER)
 			 ->setStatus(Ishare::STATUS_ACCEPTED);
 

lib/Model/ShareToken.php

Spacing +7 added lines, -7 removed lines

@@ -254,13 +254,13 @@
 	 * @return INC22QueryRow
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
-		$this->setShareId($this->getInt($prefix . 'share_id', $data));
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
-		$this->setMemberId($this->get($prefix . 'member_id', $data));
-		$this->setToken($this->get($prefix . 'token', $data));
-		$this->setPassword($this->get($prefix . 'password', $data));
-		$this->setAccepted($this->getInt($prefix . 'accepted', $data, IShare::STATUS_PENDING));
+		$this->setShareId($this->getInt($prefix.'share_id', $data));
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
+		$this->setSingleId($this->get($prefix.'single_id', $data));
+		$this->setMemberId($this->get($prefix.'member_id', $data));
+		$this->setToken($this->get($prefix.'token', $data));
+		$this->setPassword($this->get($prefix.'password', $data));
+		$this->setAccepted($this->getInt($prefix.'accepted', $data, IShare::STATUS_PENDING));
 
 		return $this;
 	}

lib/Service/MigrationService.php

Spacing +4 added lines, -4 removed lines

@@ -238,7 +238,7 @@ 
 				try {
 					$data = new SimpleDataStore($row);
 					$this->outputService->output(
-						'Migrating Circle \'' . $data->g('name') . '\' (' . $data->g('unique_id') . ')',
+						'Migrating Circle \''.$data->g('name').'\' ('.$data->g('unique_id').')',
 						true
 					);
 
@@ -342,7 +342,7 @@ 
 				try {
 					$data = new SimpleDataStore($row);
 					$this->outputService->output(
-						'Migrating Member \'' . $data->g('user_id') . '\' from \'' . $data->g('circle_id')
+						'Migrating Member \''.$data->g('user_id').'\' from \''.$data->g('circle_id')
 						. '\'',
 						true
 					);
@@ -460,7 +460,7 @@ 
 			$addressBook =
 				$this->contactService->getAddressBoxById($cm, $this->get('addressbook-key', $entry));
 
-			$member->setUserId($userId . '/' . $addressBook->getUri() . '/' . $contactId);
+			$member->setUserId($userId.'/'.$addressBook->getUri().'/'.$contactId);
 		}
 	}
 
@@ -495,7 +495,7 @@ 
 				try {
 					$data = new SimpleDataStore($row);
 					$this->outputService->output(
-						'Migrating ShareToken \'' . $data->g('token') . '\' for \'' . $data->g('user_id')
+						'Migrating ShareToken \''.$data->g('token').'\' for \''.$data->g('user_id')
 						. '\'',
 						true
 					);

lib/Command/CirclesMemberships.php

Spacing +20 added lines, -20 removed lines

@@ -214,10 +214,10 @@ 
 //			return 0;
 //		}
 
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
-		$output->writeln('Type: <info>' . Member::$TYPE[$federatedUser->getUserType()] . '</info>');
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
+		$output->writeln('Type: <info>'.Member::$TYPE[$federatedUser->getUserType()].'</info>');
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
 
 		$output->writeln('');
 		$output->writeln('Memberships:');
@@ -226,14 +226,14 @@ 
 		if ($count === 0) {
 			$output->writeln('(database not updated)');
 		} else {
-			$output->writeln('(' . $count . ' entries generated/updated in the database)');
+			$output->writeln('('.$count.' entries generated/updated in the database)');
 		}
 
 		foreach ($federatedUser->getMemberships() as $membership) {
 			$this->memberships[$membership->getCircleId()] = $membership;
 			$output->writeln(
-				'- <info>' . $membership->getCircleId() . '</info> ('
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
+				'- <info>'.$membership->getCircleId().'</info> ('
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
 			);
 		}
 
@@ -307,9 +307,9 @@ 
 				if ($lineNumber === 2) {
 					return '';
 				}
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
-					$line .= '@' . $federatedUser->getInstance();
+					$line .= '@'.$federatedUser->getInstance();
 				}
 
 				return $line;
@@ -321,28 +321,28 @@ 
 				$circle = $member->getCircle();
 
 				if ($lineNumber === 1) {
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
+					$line .= '<info>'.$circle->getSingleId().'</info>';
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
-						$line .= '@' . $circle->getInstance();
+						$line .= '@'.$circle->getInstance();
 					}
-					$line .= ' (' . ($this->input->getOption('display-name') ?
-							$circle->getDisplayName() : $circle->getName()) . ')';
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
+					$line .= ' ('.($this->input->getOption('display-name') ?
+							$circle->getDisplayName() : $circle->getName()).')';
+					$line .= ' <info>MemberId</info>: '.$member->getId();
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
 
 					$knownMembership = $this->memberships[$member->getCircleId()];
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
 					}
 				}
 				if ($lineNumber === 2) {
 					$owner = $circle->getOwner();
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
 					if ($owner->hasBasedOn()) {
-						$line .= ' (' . Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()] . ') ';
+						$line .= ' ('.Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()].') ';
 					}
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
 				}
 
 				return $line;
@@ -398,7 +398,7 @@ 
 			);
 		}
 
-		$output->writeln($count . ' memberships updated');
+		$output->writeln($count.' memberships updated');
 	}
 
 }

lib/Service/CirclesService.php

Spacing +5 added lines, -5 removed lines

@@ -577,24 +577,24 @@
 		switch ($type) {
 			case DeprecatedCircle::CIRCLES_PERSONAL:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'personal' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'personal'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_CLOSED:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'closed' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'closed'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_SECRET:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'secret' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'secret'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_PUBLIC:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'circles' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'circles'.$ext)
 				);
 		}
 
 		return $urlGen->getAbsoluteURL(
-			$urlGen->imagePath(Application::APP_ID, 'circles' . $ext)
+			$urlGen->imagePath(Application::APP_ID, 'circles'.$ext)
 		);
 	}
 

tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -5,5 +5,5 @@
 require_once __DIR__.'/../../../lib/base.php';
 require_once __DIR__.'/../vendor/autoload.php';
 
-\OC::$loader->addValidRoot(OC::$SERVERROOT . '/tests');
+\OC::$loader->addValidRoot(OC::$SERVERROOT.'/tests');
 \OC_App::loadApp('circles');

tests/unit/lib/Api/CirclesTest.php

Spacing +2 added lines, -2 removed lines

@@ -327,7 +327,7 @@ 
 			} catch (Exception $e) {
 				$this->assertSame(
 					true, false,
-					'should have returned a MemberIsNotModeratorException - ' . $e->getMessage()
+					'should have returned a MemberIsNotModeratorException - '.$e->getMessage()
 				);
 			}
 
@@ -341,7 +341,7 @@ 
 			} catch (Exception $e) {
 				$this->assertSame(
 					true, false,
-					'should have returned a MemberIsNotModeratorException - ' . $e->getMessage()
+					'should have returned a MemberIsNotModeratorException - '.$e->getMessage()
 				);
 			}
 		}