Completed
Pull Request — master (#602)
by Maxence
02:45
created
lib/Command/CirclesCheck.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 			throw new Exception('Please specify a --type for the test');
174 174
 		}
175 175
 		if ($test !== '' && !in_array($type, self::$checks)) {
176
-			throw new Exception('Unknown type: ' . implode(', ', self::$checks));
176
+			throw new Exception('Unknown type: '.implode(', ', self::$checks));
177 177
 		}
178 178
 
179 179
 //		$this->configService->setAppValue(ConfigService::TEST_NC_BASE, $test);
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 		}
279 279
 
280 280
 		$output->writeln('');
281
-		$output->writeln('* testing current address: ' . $test);
281
+		$output->writeln('* testing current address: '.$test);
282 282
 
283 283
 		try {
284 284
 			$this->setupLoopback($input, $output, $test);
@@ -314,8 +314,8 @@  discard block
 block discarded – undo
314 314
 				continue;
315 315
 			}
316 316
 
317
-			$loopback = $scheme . '://' . $cloudId;
318
-			$output->write('* testing address: ' . $loopback . ' ');
317
+			$loopback = $scheme.'://'.$cloudId;
318
+			$output->write('* testing address: '.$loopback.' ');
319 319
 
320 320
 			if ($this->testLoopback($input, $output, $loopback)) {
321 321
 				$output->writeln('* <info>Loopback</info> address looks good');
@@ -385,9 +385,9 @@  discard block
 block discarded – undo
385 385
 		$test = new FederatedEvent(LoopbackTest::class);
386 386
 		$this->federatedEventService->newEvent($test);
387 387
 
388
-		$output->writeln('<info>' . $test->getWrapperToken() . '</info>');
388
+		$output->writeln('<info>'.$test->getWrapperToken().'</info>');
389 389
 
390
-		$output->writeln('- Waiting for async process to finish (' . $this->delay . 's)');
390
+		$output->writeln('- Waiting for async process to finish ('.$this->delay.'s)');
391 391
 		sleep($this->delay);
392 392
 
393 393
 		$output->write('- Checking status on FederatedEvent ');
@@ -401,18 +401,18 @@  discard block
 block discarded – undo
401 401
 
402 402
 		$checkVerify = $wrapper->getEvent()->getData()->gInt('verify');
403 403
 		if ($checkVerify === LoopbackTest::VERIFY) {
404
-			$output->write('<info>verify=' . $checkVerify . '</info> ');
404
+			$output->write('<info>verify='.$checkVerify.'</info> ');
405 405
 		} else {
406
-			$output->writeln('<error>verify=' . $checkVerify . '</error>');
406
+			$output->writeln('<error>verify='.$checkVerify.'</error>');
407 407
 
408 408
 			return false;
409 409
 		}
410 410
 
411 411
 		$checkManage = $wrapper->getResult()->gInt('manage');
412 412
 		if ($checkManage === LoopbackTest::MANAGE) {
413
-			$output->write('<info>manage=' . $checkManage . '</info> ');
413
+			$output->write('<info>manage='.$checkManage.'</info> ');
414 414
 		} else {
415
-			$output->writeln('<error>manage=' . $checkManage . '</error>');
415
+			$output->writeln('<error>manage='.$checkManage.'</error>');
416 416
 
417 417
 			return false;
418 418
 		}
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 		[$scheme, $cloudId] = $this->parseAddress($loopback);
435 435
 
436 436
 		$question = new ConfirmationQuestion(
437
-			'- Do you want to save <info>'. $loopback . '</info> as your <info>loopback</info> address ? (y/N) ', false, '/^(y|Y)/i'
437
+			'- Do you want to save <info>'.$loopback.'</info> as your <info>loopback</info> address ? (y/N) ', false, '/^(y|Y)/i'
438 438
 		);
439 439
 
440 440
 		$helper = $this->getHelper('question');
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
 		$this->configService->setAppValue(ConfigService::LOOPBACK_CLOUD_SCHEME, $scheme);
448 448
 		$this->configService->setAppValue(ConfigService::LOOPBACK_CLOUD_ID, $cloudId);
449 449
 		$output->writeln(
450
-			'- Address <info>' . $loopback . '</info> is now used as <info>loopback</info>'
450
+			'- Address <info>'.$loopback.'</info> is now used as <info>loopback</info>'
451 451
 		);
452 452
 
453 453
 	}
@@ -518,7 +518,7 @@  discard block
 block discarded – undo
518 518
 				continue;
519 519
 			}
520 520
 
521
-			$frontal = $scheme . '://' . $cloudId;
521
+			$frontal = $scheme.'://'.$cloudId;
522 522
 			break;
523 523
 		}
524 524
 
@@ -532,13 +532,13 @@  discard block
 block discarded – undo
532 532
 				'You will need to run this <info>curl</info> command from a remote terminal and paste its result: '
533 533
 			);
534 534
 			$output->writeln(
535
-				'     curl ' . $frontal . '/.well-known/webfinger?resource=http://nextcloud.com/'
535
+				'     curl '.$frontal.'/.well-known/webfinger?resource=http://nextcloud.com/'
536 536
 			);
537 537
 
538 538
 			$question = new Question('result: ', '');
539 539
 			$pasteWebfinger = $helper->ask($input, $output, $question);
540 540
 
541
-			echo '__ ' . $pasteWebfinger;
541
+			echo '__ '.$pasteWebfinger;
542 542
 
543 543
 			$output->writeln('TESTING !!');
544 544
 			$output->writeln('TESTING !!');
@@ -661,7 +661,7 @@  discard block
 block discarded – undo
661 661
 		$this->configService->configureLoopbackRequest($request, $route, $args);
662 662
 		$request->setFollowLocation(false);
663 663
 
664
-		$output->write('- ' . $type . ' request on ' . $request->getCompleteUrl() . ': ');
664
+		$output->write('- '.$type.' request on '.$request->getCompleteUrl().': ');
665 665
 
666 666
 		try {
667 667
 			$this->doRequest($request);
@@ -672,7 +672,7 @@  discard block
 block discarded – undo
672 672
 				$color = 'info';
673 673
 			}
674 674
 
675
-			$output->writeln('<' . $color . '>' . $result->getStatusCode() . '</' . $color . '>');
675
+			$output->writeln('<'.$color.'>'.$result->getStatusCode().'</'.$color.'>');
676 676
 			if ($result->getStatusCode() === 200) {
677 677
 				return true;
678 678
 			}
@@ -696,7 +696,7 @@  discard block
 block discarded – undo
696 696
 
697 697
 		$output->writeln('');
698 698
 		$output->writeln(
699
-			'The address <info>' . $address . '</info> seems to reach your local Nextcloud.'
699
+			'The address <info>'.$address.'</info> seems to reach your local Nextcloud.'
700 700
 		);
701 701
 
702 702
 		$helper = $this->getHelper('question');
@@ -713,8 +713,8 @@  discard block
 block discarded – undo
713 713
 
714 714
 		$this->configService->setAppValue(ConfigService::FORCE_NC_BASE, $address);
715 715
 		$output->writeln(
716
-			'New configuration <info>' . Application::APP_ID . '.' . ConfigService::FORCE_NC_BASE . '=\''
717
-			. $address . '\'</info> stored in database'
716
+			'New configuration <info>'.Application::APP_ID.'.'.ConfigService::FORCE_NC_BASE.'=\''
717
+			. $address.'\'</info> stored in database'
718 718
 		);
719 719
 	}
720 720
 
@@ -735,7 +735,7 @@  discard block
 block discarded – undo
735 735
 		}
736 736
 
737 737
 		if (!is_null($cloudIdPort)) {
738
-			$cloudId = $cloudId . ':' . $cloudIdPort;
738
+			$cloudId = $cloudId.':'.$cloudIdPort;
739 739
 		}
740 740
 
741 741
 		return [$scheme, $cloudId];
Please login to merge, or discard this patch.
lib/Migration/Version0022Date20220526111723.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
 		$tables = $schema->getTables();
79 79
 		foreach ($tables as $table) {
80 80
 			$tableName = $table->getName();
81
-			if (substr($tableName, 0, 8 + strlen($prefix)) === $prefix . 'circles_') {
81
+			if (substr($tableName, 0, 8 + strlen($prefix)) === $prefix.'circles_') {
82 82
 				$tableName = substr($tableName, strlen($prefix));
83 83
 				$schema->dropTable($tableName);
84 84
 			}
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleMembershipsRemoved.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -104,16 +104,16 @@
 block discarded – undo
104 104
 				} catch (Exception $e) {
105 105
 					$this->e($e);
106 106
 
107
-					return $membership->getSingleId() . ' is not ' . $inheritance . ' of '
108
-						   . $membership->getCircleId() . ' anymore';
107
+					return $membership->getSingleId().' is not '.$inheritance.' of '
108
+						   . $membership->getCircleId().' anymore';
109 109
 				}
110 110
 
111
-				return $federatedUser->getUserId() . ' (' . Member::$TYPE[$federatedUser->getUserType()]
112
-					   . ') is not ' . $inheritance . ' of ' . $membership->getCircleId() . ' anymore';
111
+				return $federatedUser->getUserId().' ('.Member::$TYPE[$federatedUser->getUserType()]
112
+					   . ') is not '.$inheritance.' of '.$membership->getCircleId().' anymore';
113 113
 			}, $event->getMemberships()
114 114
 		);
115 115
 
116
-		$this->log(3, $prefix . implode('. ', $memberships));
116
+		$this->log(3, $prefix.implode('. ', $memberships));
117 117
 	}
118 118
 
119 119
 }
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleMembershipsCreated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -104,16 +104,16 @@
 block discarded – undo
104 104
 				} catch (Exception $e) {
105 105
 					$this->e($e);
106 106
 
107
-					return $membership->getSingleId() . ' is now ' . $inheritance . ' of '
107
+					return $membership->getSingleId().' is now '.$inheritance.' of '
108 108
 						   . $membership->getCircleId();
109 109
 				}
110 110
 
111
-				return $federatedUser->getUserId() . ' (' . Member::$TYPE[$federatedUser->getUserType()]
112
-					   . ') is now ' . $inheritance . ' of ' . $membership->getCircleId();
111
+				return $federatedUser->getUserId().' ('.Member::$TYPE[$federatedUser->getUserType()]
112
+					   . ') is now '.$inheritance.' of '.$membership->getCircleId();
113 113
 			}, $event->getMemberships()
114 114
 		);
115 115
 
116
-		$this->log(3, $prefix . implode('. ', $memberships));
116
+		$this->log(3, $prefix.implode('. ', $memberships));
117 117
 	}
118 118
 
119 119
 }
Please login to merge, or discard this patch.
lib/Listeners/Examples/ExampleCircleMemberAdded.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 			$circle = $event->getCircle();
97 97
 			$eventType = ($event->getType() === CircleGenericEvent::INVITED) ? 'invited' : 'joined';
98 98
 
99
-			$info = 'A new member have been added (' . $eventType . ') to a Circle. ';
99
+			$info = 'A new member have been added ('.$eventType.') to a Circle. ';
100 100
 
101
-			$info .= 'userId: ' . $member->getUserId() . '; userType: ' . Member::$TYPE[$member->getUserType(
101
+			$info .= 'userId: '.$member->getUserId().'; userType: '.Member::$TYPE[$member->getUserType(
102 102
 				)]
103
-					 . '; singleId: ' . $member->getSingleId() . '; memberId: ' . $member->getId()
104
-					 . '; isLocal: ' . json_encode($member->isLocal()) . '; level: '
105
-					 . Member::$DEF_LEVEL[$member->getLevel()] . '; ';
103
+					 . '; singleId: '.$member->getSingleId().'; memberId: '.$member->getId()
104
+					 . '; isLocal: '.json_encode($member->isLocal()).'; level: '
105
+					 . Member::$DEF_LEVEL[$member->getLevel()].'; ';
106 106
 
107 107
 			$memberships = array_map(
108 108
 				function(Membership $membership) {
@@ -111,22 +111,22 @@  discard block
 block discarded – undo
111 111
 			);
112 112
 
113 113
 			$listMemberships = (count($memberships) > 0) ? implode(', ', $memberships) : 'none';
114
-			$info .= 'circleName: ' . $circle->getDisplayName() . '; circleId: ' . $circle->getSingleId()
115
-					 . '; Circle memberships: ' . $listMemberships . '.';
114
+			$info .= 'circleName: '.$circle->getDisplayName().'; circleId: '.$circle->getSingleId()
115
+					 . '; Circle memberships: '.$listMemberships.'.';
116 116
 
117 117
 			if ($member->getUserType() === Member::TYPE_CIRCLE) {
118 118
 				$basedOn = $member->getBasedOn();
119 119
 				$members = array_map(
120 120
 					function(Member $member) {
121
-						return $member->getUserId() . ' (' . Member::$TYPE[$member->getUserType()] . ')';
121
+						return $member->getUserId().' ('.Member::$TYPE[$member->getUserType()].')';
122 122
 					}, $basedOn->getInheritedMembers()
123 123
 				);
124 124
 
125
-				$info .= ' Member is a Circle (singleId: ' . $basedOn->getSingleId()
126
-						 . ') that contains those inherited members: ' . implode(', ', $members);
125
+				$info .= ' Member is a Circle (singleId: '.$basedOn->getSingleId()
126
+						 . ') that contains those inherited members: '.implode(', ', $members);
127 127
 			}
128 128
 
129
-			$this->log(3, $prefix . $info);
129
+			$this->log(3, $prefix.$info);
130 130
 		}
131 131
 	}
132 132
 
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -186,11 +186,11 @@  discard block
 block discarded – undo
186 186
 			$this->federatedUserService->commandLineInitiator($initiator, $initiatorType, $circleId, true);
187 187
 			$circle = $this->circleService->getCircle($circleId);
188 188
 
189
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
189
+			$output->writeln('<info>Name</info>: '.$circle->getName());
190 190
 			$owner = $circle->getOwner();
191
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
191
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
192 192
 			$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
193
-			$output->writeln('<info>Config</info>: ' . $type);
193
+			$output->writeln('<info>Config</info>: '.$type);
194 194
 			$output->writeln(' ');
195 195
 
196 196
 			$tree = new NC22TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -254,8 +254,7 @@  discard block
 block discarded – undo
254 254
 					($this->input->getOption('display-name')) ?
255 255
 						$member->getBasedOn()->getDisplayName() : $member->getUserId(),
256 256
 					$this->configService->displayInstance($member->getInstance()),
257
-					($level > 0) ? Member::$DEF_LEVEL[$level] :
258
-						'(' . strtolower($member->getStatus()) . ')'
257
+					($level > 0) ? Member::$DEF_LEVEL[$level] : '('.strtolower($member->getStatus()).')'
259 258
 				]
260 259
 			);
261 260
 		}
@@ -414,18 +413,18 @@  discard block
 block discarded – undo
414 413
 				$member = $data->gObj('member', Member::class);
415 414
 
416 415
 				if ($lineNumber === 1) {
417
-					$line .= '<info>' . $member->getSingleId() . '</info>';
416
+					$line .= '<info>'.$member->getSingleId().'</info>';
418 417
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
419
-						$line .= '@' . $member->getInstance();
418
+						$line .= '@'.$member->getInstance();
420 419
 					}
421
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
420
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
422 421
 
423
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
422
+					$line .= ' <info>MemberId</info>: '.$member->getId();
424 423
 					$name = ($this->input->getOption('display-name')) ?
425 424
 						$member->getBasedOn()->getDisplayName() : $member->getUserId();
426
-					$line .= ' <info>Name</info>: ' . $name;
425
+					$line .= ' <info>Name</info>: '.$name;
427 426
 					$source = ($member->hasBasedOn()) ? $member->getBasedOn()->getSource() : '';
428
-					$line .= ' <info>Source</info>: ' . Circle::$DEF_SOURCE[$source];
427
+					$line .= ' <info>Source</info>: '.Circle::$DEF_SOURCE[$source];
429 428
 				}
430 429
 
431 430
 				if ($lineNumber === 2) {
@@ -437,16 +436,16 @@  discard block
 block discarded – undo
437 436
 						return $line;
438 437
 					}
439 438
 					$owner = $circle->getOwner();
440
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
439
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
441 440
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
442
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
441
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
443 442
 				}
444 443
 
445 444
 			} else {
446 445
 				if ($lineNumber === 1 && !is_null($circle)) {
447
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
446
+					$line .= '<info>'.$circle->getSingleId().'</info>';
448 447
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
449
-						$line .= '@' . $circle->getInstance();
448
+						$line .= '@'.$circle->getInstance();
450 449
 					}
451 450
 				}
452 451
 			}
Please login to merge, or discard this patch.
lib/Model/Member.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -717,29 +717,29 @@  discard block
 block discarded – undo
717 717
 	 * @throws MemberNotFoundException
718 718
 	 */
719 719
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
720
-		if ($this->get($prefix . 'single_id', $data) === '') {
720
+		if ($this->get($prefix.'single_id', $data) === '') {
721 721
 			throw new MemberNotFoundException();
722 722
 		}
723 723
 
724
-		$this->setId($this->get($prefix . 'member_id', $data));
725
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
726
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
727
-		$this->setUserId($this->get($prefix . 'user_id', $data));
728
-		$this->setUserType($this->getInt($prefix . 'user_type', $data));
729
-		$this->setInstance($this->get($prefix . 'instance', $data));
730
-		$this->setLevel($this->getInt($prefix . 'level', $data));
731
-		$this->setStatus($this->get($prefix . 'status', $data));
732
-		$this->setDisplayName($this->get($prefix . 'cached_name', $data));
733
-		$this->setNote($this->get($prefix . 'note', $data));
734
-		$this->setContactId($this->get($prefix . 'contact_id', $data));
735
-		$this->setContactMeta($this->get($prefix . 'contact_meta', $data));
736
-
737
-		$cachedUpdate = $this->get($prefix . 'cached_update', $data);
724
+		$this->setId($this->get($prefix.'member_id', $data));
725
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
726
+		$this->setSingleId($this->get($prefix.'single_id', $data));
727
+		$this->setUserId($this->get($prefix.'user_id', $data));
728
+		$this->setUserType($this->getInt($prefix.'user_type', $data));
729
+		$this->setInstance($this->get($prefix.'instance', $data));
730
+		$this->setLevel($this->getInt($prefix.'level', $data));
731
+		$this->setStatus($this->get($prefix.'status', $data));
732
+		$this->setDisplayName($this->get($prefix.'cached_name', $data));
733
+		$this->setNote($this->get($prefix.'note', $data));
734
+		$this->setContactId($this->get($prefix.'contact_id', $data));
735
+		$this->setContactMeta($this->get($prefix.'contact_meta', $data));
736
+
737
+		$cachedUpdate = $this->get($prefix.'cached_update', $data);
738 738
 		if ($cachedUpdate !== '') {
739 739
 			$this->setDisplayUpdate(DateTime::createFromFormat('Y-m-d H:i:s', $cachedUpdate)->getTimestamp());
740 740
 		}
741 741
 
742
-		$joined = $this->get($prefix . 'joined', $data);
742
+		$joined = $this->get($prefix.'joined', $data);
743 743
 		if ($joined !== '') {
744 744
 			$this->setJoined(DateTime::createFromFormat('Y-m-d H:i:s', $joined)->getTimestamp());
745 745
 		}
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
813 813
 	public static function parseLevelInt(int $level): int {
814 814
 		if (!array_key_exists($level, self::$DEF_LEVEL)) {
815 815
 			$all = implode(', ', array_keys(self::$DEF_LEVEL));
816
-			throw new ParseMemberLevelException('Available levels: ' . $all, 121);
816
+			throw new ParseMemberLevelException('Available levels: '.$all, 121);
817 817
 		}
818 818
 
819 819
 		return $level;
@@ -832,7 +832,7 @@  discard block
 block discarded – undo
832 832
 
833 833
 		if (!$level) {
834 834
 			$all = implode(', ', array_values(self::$DEF_LEVEL));
835
-			throw new ParseMemberLevelException('Available levels: ' . $all, 121);
835
+			throw new ParseMemberLevelException('Available levels: '.$all, 121);
836 836
 		}
837 837
 
838 838
 		return (int)$level;
@@ -853,7 +853,7 @@  discard block
 block discarded – undo
853 853
 		$type = array_search($typeString, Member::$TYPE);
854 854
 		if ($type === false) {
855 855
 			$all = implode(', ', array_values(self::$TYPE));
856
-			throw new UserTypeNotFoundException('Available types: ' . $all);
856
+			throw new UserTypeNotFoundException('Available types: '.$all);
857 857
 		}
858 858
 
859 859
 		return (int)$type;
Please login to merge, or discard this patch.
lib/Db/MemberRequest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
 			$qb->filterDirectMembership(CoreQueryBuilder::MEMBER, $filter);
222 222
 		}
223 223
 
224
-		$qb->orderBy($qb->getDefaultSelectAlias() . '.level', 'desc');
225
-		$qb->addOrderBy($qb->getDefaultSelectAlias() . '.cached_name', 'asc');
224
+		$qb->orderBy($qb->getDefaultSelectAlias().'.level', 'desc');
225
+		$qb->addOrderBy($qb->getDefaultSelectAlias().'.cached_name', 'asc');
226 226
 
227 227
 		return $this->getItemsFromRequest($qb);
228 228
 	}
@@ -246,8 +246,8 @@  discard block
 block discarded – undo
246 246
 		$qb->limitToMembersByInheritance(CoreQueryBuilder::MEMBER, $singleId);
247 247
 
248 248
 		$aliasMembership = $qb->generateAlias(CoreQueryBuilder::MEMBER, CoreQueryBuilder::MEMBERSHIPS);
249
-		$qb->orderBy($aliasMembership . '.inheritance_depth', 'asc')
250
-		   ->addGroupBy($aliasMembership . '.inheritance_depth');
249
+		$qb->orderBy($aliasMembership.'.inheritance_depth', 'asc')
250
+		   ->addGroupBy($aliasMembership.'.inheritance_depth');
251 251
 
252 252
 //		$qb->groupBy(CoreQueryBuilder::MEMBER . '.single_id');
253 253
 
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 		$qb = $this->getMemberSelectSql();
286 286
 		$qb->limitToCircleId($circleId);
287 287
 
288
-		$qb->andwhere($qb->expr()->nonEmptyString(CoreQueryBuilder::MEMBER . '.instance'));
288
+		$qb->andwhere($qb->expr()->nonEmptyString(CoreQueryBuilder::MEMBER.'.instance'));
289 289
 
290 290
 		return array_map(
291 291
 			function(Member $member): string {
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
 	 */
342 342
 	public function searchFederatedUsers(string $needle): array {
343 343
 		$qb = $this->getMemberSelectSql();
344
-		$qb->searchInDBField('user_id', '%' . $needle . '%');
344
+		$qb->searchInDBField('user_id', '%'.$needle.'%');
345 345
 
346 346
 		return $this->getItemsFromRequest($qb, true);
347 347
 	}
Please login to merge, or discard this patch.
lib/CirclesQueryHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
 		$circle = new Circle();
145 145
 		$circle->importFromDatabase(
146 146
 			$data,
147
-			CoreQueryBuilder::HELPER . '_' . CoreQueryBuilder::CIRCLE . '_'
147
+			CoreQueryBuilder::HELPER.'_'.CoreQueryBuilder::CIRCLE.'_'
148 148
 		);
149 149
 
150 150
 		return $circle;
Please login to merge, or discard this patch.