nextcloud / circles

lib/Service/ConfigService.php

Spacing +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
 		if ((!$this->isNonSSLLinksAllowed() || strpos($remote, 'http://') !== 0)
 			&& strpos($remote, 'https://') !== 0
 		) {
-			$remote = 'https://' . $remote;
+			$remote = 'https://'.$remote;
 		}
 
 		return rtrim($remote, '/');

lib/Service/FederatedLinkCreationService.php

Doc Comments +3 added lines, -3 removed lines

@@ -189,8 +189,8 @@ 
 
 
 	/**
-	 * @param $circleUniqueId
-	 * @param $remote
+	 * @param string $circleUniqueId
+	 * @param string $remote
 	 *
 	 * @return FederatedLink
 	 */
@@ -281,7 +281,7 @@ 
 	 *
 	 * Will parse the error reason returned by requestLink() and throw an Exception
 	 *
-	 * @param $reason
+	 * @param string $reason
 	 *
 	 * @throws Exception
 	 * @throws FederatedRemoteDoesNotAllowException

lib/Service/MembersService.php

Doc Comments +12 added lines, -9 removed lines

@@ -101,9 +101,9 @@ 
 	 *
 	 * @param string $circleUniqueId
 	 * @param $ident
-	 * @param $type
+	 * @param integer $type
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function addMember($circleUniqueId, $ident, $type) {
@@ -244,8 +244,8 @@ 
 	/**
 	 * Verify if a local account is valid.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 */
@@ -266,7 +266,7 @@ 
 	 * Verify if a mail have a valid format.
 	 *
 	 * @param $ident
-	 * @param $type
+	 * @param integer $type
 	 *
 	 * @throws EmailAccountInvalidFormatException
 	 */
@@ -287,7 +287,7 @@ 
 	 * Verify if a contact exist in current user address books.
 	 *
 	 * @param $ident
-	 * @param $type
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 */
@@ -371,7 +371,7 @@ 
 	 * @param int $type
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function levelMember($circleUniqueId, $name, $type, $level) {
@@ -397,6 +397,9 @@ 
 	}
 
 
+	/**
+	 * @param integer $level
+	 */
 	private function updateMemberLevel(Circle $circle, Member $member, $level) {
 		if ($member->getLevel() === $level) {
 			return;
@@ -466,9 +469,9 @@ 
 	/**
 	 * @param string $circleUniqueId
 	 * @param string $name
-	 * @param $type
+	 * @param integer $type
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function removeMember($circleUniqueId, $name, $type) {

Spacing +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
 			return;
 		}
 
-		$tmpContact = $this->userId . ':' . $ident;
+		$tmpContact = $this->userId.':'.$ident;
 		try {
 			MiscService::getContactData($tmpContact);
 		} catch (Exception $e) {

lib/Model/FederatedLink.php

Doc Comments +3 added lines

@@ -303,6 +303,9 @@
 	}
 
 
+	/**
+	 * @param integer $status
+	 */
 	public function hasToBeValidStatusUpdate($status) {
 		try {
 			$this->hasToBeValidStatusUpdateWhileLinkDown($status);

lib/Service/MiscService.php

Doc Comments +5 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -79,6 +79,9 @@ 
 	}
 
 
+	/**
+	 * @param string[] $arr
+	 */
 	public static function mustContains($data, $arr) {
 		if (!is_array($arr)) {
 			$arr = [$arr];
@@ -188,7 +191,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 */

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		ob_start();
 		echo(json_encode($result));
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}

lib/Controller/TestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 
 
 	/**
-	 * @return DataResponse
+	 * @return string
 	 */
 	public function testAsyncStatus() {
 		return $this->miscService->success(

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 * @return string
 	 */
 	private function generateTestAsyncURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . Application::TEST_URL_ASYNC;
+		return $this->configService->generateRemoteHost($remote).Application::TEST_URL_ASYNC;
 	}
 
 

lib/Circles/FileSharingBroadcaster.php

Doc Comments +2 added lines, -2 removed lines

@@ -178,7 +178,7 @@ 
 
 
 	/**
-	 * @param $circleName
+	 * @param string $circleName
 	 * @param IShare $share
 	 * @param string $email
 	 */
@@ -233,7 +233,7 @@ 
 	 * @param $subject
 	 * @param $text
 	 * @param $fileName
-	 * @param $link
+	 * @param string $link
 	 * @param string $author
 	 * @param string $circleName
 	 *

Spacing +1 added lines, -1 removed lines

@@ -248,7 +248,7 @@
 		$emailTemplate->addHeader();
 		$emailTemplate->addHeading($subject, false);
 		$emailTemplate->addBodyText(
-			htmlspecialchars($text) . '<br>' . htmlspecialchars($this->l10n->t('Click the button below to open it.')), $text
+			htmlspecialchars($text).'<br>'.htmlspecialchars($this->l10n->t('Click the button below to open it.')), $text
 		);
 		$emailTemplate->addBodyButton($this->l10n->t('Open »%s«', [htmlspecialchars($fileName)]), $link);
 

lib/Service/CirclesService.php

Doc Comments +1 added lines

@@ -403,6 +403,7 @@
 	 * switchOlderAdminToOwner();
 	 *
 	 * @param Member[] $members
+	 * @param Circle $circle
 	 */
 	private function switchOlderAdminToOwner($circle, $members) {
 

Spacing +5 added lines, -5 removed lines

@@ -481,23 +481,23 @@
 		switch ($type) {
 			case Circle::CIRCLES_PERSONAL:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'personal' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'personal'.$ext)
 				);
 			case Circle::CIRCLES_CLOSED:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'closed' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'closed'.$ext)
 				);
 			case Circle::CIRCLES_SECRET:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'secret' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'secret'.$ext)
 				);
 			case Circle::CIRCLES_PUBLIC:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'public' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'public'.$ext)
 				);
 		}
 
-		return $urlGen->getAbsoluteURL($urlGen->imagePath(Application::APP_NAME, 'black_circle' . $ext));
+		return $urlGen->getAbsoluteURL($urlGen->imagePath(Application::APP_NAME, 'black_circle'.$ext));
 	}
 
 

lib/Service/SharingFrameService.php

Doc Comments +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
 	 *
 	 * @param SharingFrame $frame
 	 * @param Circle $circle
-	 * @param $broadcast
+	 * @param string|null $broadcast
 	 */
 	private function generateHeaders(SharingFrame $frame, Circle $circle, $broadcast) {
 
@@ -189,7 +189,7 @@ 
 	 * Please use getFrameFromCircle();
 	 *
 	 * @param string $circleUniqueId
-	 * @param $viewerId
+	 * @param string $viewerId
 	 *
 	 * @return SharingFrame[]
 	 */

Spacing +3 added lines, -3 removed lines

@@ -279,7 +279,7 @@ 
 		try {
 			$client->post(
 				$this->generatePayloadDeliveryURL(
-					$this->configService->getLocalAddress() . \OC::$WEBROOT
+					$this->configService->getLocalAddress().\OC::$WEBROOT
 				), [
 					'body'            => $args,
 					'timeout'         => Application::CLIENT_TIMEOUT,
@@ -300,7 +300,7 @@ 
 	 * @return string
 	 */
 	private function generatePayloadDeliveryURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . Application::REMOTE_URL_PAYLOAD;
+		return $this->configService->generateRemoteHost($remote).Application::REMOTE_URL_PAYLOAD;
 	}
 
 
@@ -374,7 +374,7 @@ 
 
 		} catch (Exception $e) {
 			$this->miscService->log(
-				'fail to send frame to ' . $link->getAddress() . ' - ' . $e->getMessage()
+				'fail to send frame to '.$link->getAddress().' - '.$e->getMessage()
 			);
 		}
 	}