Version0021Date20210105123456::changeSchema() - Code Metrics - Inspection of "Circles 22" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#551)

by Maxence

created 2021-02-25 14:19 UTC

Version0021Date20210105123456::changeSchema() F

↳ Parent: Version0021Date20210105123456

Complexity

Conditions	9
Paths	600

Size

Total Lines

157

Duplication

Lines	31
Ratio	19.75 %

Importance

Changes

Metric	Value
dl	31
loc	157
rs	3.5555
c	0
b	0
f	0
cc	9
nc	600
nop	3

How to fix Long Method

<?php

declare(strict_types=1);

/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2021
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Circles\Migration;

use Closure;
use Doctrine\DBAL\Schema\SchemaException;
use OCP\DB\ISchemaWrapper;
use OCP\IDBConnection;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;


/**
 * Class Version0021Date20210105123456
 *
 * @package OCA\Circles\Migration
 */
class Version0021Date20210105123456 extends SimpleMigrationStep {


	/** @var IDBConnection */
	private $connection;


	/**
	 * @param IDBConnection $connection
	 */
	public function __construct(IDBConnection $connection) {
		$this->connection = $connection;
	}


	/**
	 * @param IOutput $output
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	 * @param array $options
	 *
	 * @return null|ISchemaWrapper
	 */
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
		/** @var ISchemaWrapper $schema */
		$schema = $schemaClosure();

		try {
			$circles = $schema->getTable('circle_circles');
			if (!$circles->hasColumn('config')) {
				$circles->addColumn(
					'config', 'integer', [
								'notnull'  => false,
								'length'   => 11,
								'unsigned' => true,
							]
				);
			}
			if (!$circles->hasColumn('instance')) {
				$circles->addColumn(
					'instance', 'string', [
								  'notnull' => true,
								  'default' => '',
								  'length'  => 255
							  ]
				);
			}
			$circles->addIndex(['config']);
		} catch (SchemaException $e) {

		}


		try {
			$circles = $schema->getTable('circle_members');
			if (!$circles->hasColumn('single_id')) {
				$circles->addColumn(
					'single_id', 'string', [
								   'notnull' => false,
								   'length'  => 15
							   ]
				);
			}
		} catch (SchemaException $e) {

		}


		if (!$schema->hasTable('circle_remotes')) {
			$table = $schema->createTable('circle_remotes');
			$table->addColumn(
				'id', 'integer', [
						'autoincrement' => true,
						'notnull'       => true,
						'length'        => 4,
						'unsigned'      => true,
					]
			);
			$table->addColumn(
				'type', 'string', [
						  'notnull' => true,
						  'length'  => 15,
						  'default' => 'Unknown'
					  ]
			);
			$table->addColumn(
				'uid', 'string', [
						 'notnull' => false,
						 'length'  => 20,
					 ]
			);
			$table->addColumn(
				'instance', 'string', [
							  'notnull' => false,
							  'length'  => 127,
						  ]
			);
			$table->addColumn(
				'href', 'string', [
						  'notnull' => false,
						  'length'  => 254,
					  ]
			);
			$table->addColumn(
				'item', 'text', [
						  'notnull' => false,
					  ]
			);
			$table->addColumn(
				'creation', 'datetime', [
							  'notnull' => false,
						  ]
			);

			$table->setPrimaryKey(['id']);
			$table->addUniqueIndex(['instance']);
			$table->addIndex(['uid']);
			$table->addIndex(['href']);
		}

		if (!$schema->hasTable('circle_membership')) {

			$table = $schema->createTable('circle_membership');

			$table->addColumn(
				'id', 'string', [
						'notnull' => true,
						'length'  => 15,
					]
			);
			$table->addColumn(
				'circle_id', 'string', [
							   'notnull' => true,
							   'length'  => 15,
						   ]
			);
			$table->addColumn(
				'member_id', 'string', [
							   'notnull' => true,
							   'length'  => 15,
						   ]
			);
			$table->addColumn(
				'level', 'integer', [
						   'notnull'  => true,
						   'length'   => 1,
						   'unsigned' => true
					   ]
			);

			$table->addIndex(['id']);
		}


		if (!$schema->hasTable('circle_share_locks')) {
			$table = $schema->createTable('circle_share_locks');
			$table->addColumn(
				'id', 'integer', [
						'autoincrement' => true,
						'notnull'       => true,
						'length'        => 4,
						'unsigned'      => true,
					]
			);
			$table->addColumn(
				'item_id', 'string', [
							 'notnull' => true,
							 'length'  => 15
						 ]
			);
			$table->addColumn(
				'instance', 'string', [
							  'notnull' => true,
							  'length'  => 127,
						  ]
			);

			$table->setPrimaryKey(['id']);
			$table->addUniqueIndex(['item_id']);
		}

		return $schema;
	}


}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* Circles - Bring cloud-users closer together.
7		*
8		* This file is licensed under the Affero General Public License version 3 or
9		* later. See the COPYING file.
10		*
11		* @author Maxence Lange <[email protected]>
12		* @copyright 2021
13		* @license GNU AGPL version 3 or any later version
14		*
15		* This program is free software: you can redistribute it and/or modify
16		* it under the terms of the GNU Affero General Public License as
17		* published by the Free Software Foundation, either version 3 of the
18		* License, or (at your option) any later version.
19		*
20		* This program is distributed in the hope that it will be useful,
21		* but WITHOUT ANY WARRANTY; without even the implied warranty of
22		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23		* GNU Affero General Public License for more details.
24		*
25		* You should have received a copy of the GNU Affero General Public License
26		* along with this program. If not, see <http://www.gnu.org/licenses/>.
27		*
28		*/
29
30		namespace OCA\Circles\Migration;
31
32		use Closure;
33		use Doctrine\DBAL\Schema\SchemaException;
34		use OCP\DB\ISchemaWrapper;
35		use OCP\IDBConnection;
36		use OCP\Migration\IOutput;
37		use OCP\Migration\SimpleMigrationStep;
38
39
40		/**
41		* Class Version0021Date20210105123456
42		*
43		* @package OCA\Circles\Migration
44		*/
45		class Version0021Date20210105123456 extends SimpleMigrationStep {
46
47
48		/** @var IDBConnection */
49		private $connection;
50
51
52		/**
53		* @param IDBConnection $connection
54		*/
55		public function __construct(IDBConnection $connection) {
56		$this->connection = $connection;
57		}
58
59
60		/**
61		* @param IOutput $output
62		* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
63		* @param array $options
64		*
65		* @return null\|ISchemaWrapper
66		*/
67		public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
68		/** @var ISchemaWrapper $schema */
69		$schema = $schemaClosure();
70
71		try {
72		$circles = $schema->getTable('circle_circles');
73		if (!$circles->hasColumn('config')) {
74		$circles->addColumn(
75		'config', 'integer', [
76		'notnull' => false,
77		'length' => 11,
78		'unsigned' => true,
79		]
80		);
81		}
82		if (!$circles->hasColumn('instance')) {
83		$circles->addColumn(
84		'instance', 'string', [
85		'notnull' => true,
86		'default' => '',
87		'length' => 255
88		]
89		);
90		}
91		$circles->addIndex(['config']);
92		} catch (SchemaException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2021-02-03 13:57 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history... Bug introduced 2021-02-03 13:57 UTC by Report Bug Copy Issue Report The class `Doctrine\DBAL\Schema\SchemaException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
93		}
94
95
96		try {
97		$circles = $schema->getTable('circle_members');
98		if (!$circles->hasColumn('single_id')) {
99		$circles->addColumn(
100		'single_id', 'string', [
101		'notnull' => false,
102		'length' => 15
103		]
104		);
105		}
106		} catch (SchemaException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2021-02-03 13:57 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history... Bug introduced 2021-02-03 13:57 UTC by Report Bug Copy Issue Report The class `Doctrine\DBAL\Schema\SchemaException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
107		}
108
109
110		if (!$schema->hasTable('circle_remotes')) {
111		$table = $schema->createTable('circle_remotes');
112		$table->addColumn(
113		'id', 'integer', [
114		'autoincrement' => true,
115		'notnull' => true,
116		'length' => 4,
117		'unsigned' => true,
118		]
119		);
120		$table->addColumn(
121		'type', 'string', [
122		'notnull' => true,
123		'length' => 15,
124		'default' => 'Unknown'
125		]
126		);
127		$table->addColumn(
128		'uid', 'string', [
129		'notnull' => false,
130		'length' => 20,
131		]
132		);
133		$table->addColumn(
134		'instance', 'string', [
135		'notnull' => false,
136		'length' => 127,
137		]
138		);
139		$table->addColumn(
140		'href', 'string', [
141		'notnull' => false,
142		'length' => 254,
143		]
144		);
145		$table->addColumn(
146		'item', 'text', [
147		'notnull' => false,
148		]
149		);
150		$table->addColumn(
151		'creation', 'datetime', [
152		'notnull' => false,
153		]
154		);
155
156		$table->setPrimaryKey(['id']);
157		$table->addUniqueIndex(['instance']);
158		$table->addIndex(['uid']);
159		$table->addIndex(['href']);
160		}
161
162	View Code Duplication	if (!$schema->hasTable('circle_membership')) {
		0 ignored issues – show Duplication introduced 2019-12-05 15:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
163		$table = $schema->createTable('circle_membership');
164
165		$table->addColumn(
166		'id', 'string', [
167		'notnull' => true,
168		'length' => 15,
169		]
170		);
171		$table->addColumn(
172		'circle_id', 'string', [
173		'notnull' => true,
174		'length' => 15,
175		]
176		);
177		$table->addColumn(
178		'member_id', 'string', [
179		'notnull' => true,
180		'length' => 15,
181		]
182		);
183		$table->addColumn(
184		'level', 'integer', [
185		'notnull' => true,
186		'length' => 1,
187		'unsigned' => true
188		]
189		);
190
191		$table->addIndex(['id']);
192		}
193
194
195		if (!$schema->hasTable('circle_share_locks')) {
196		$table = $schema->createTable('circle_share_locks');
197		$table->addColumn(
198		'id', 'integer', [
199		'autoincrement' => true,
200		'notnull' => true,
201		'length' => 4,
202		'unsigned' => true,
203		]
204		);
205		$table->addColumn(
206		'item_id', 'string', [
207		'notnull' => true,
208		'length' => 15
209		]
210		);
211		$table->addColumn(
212		'instance', 'string', [
213		'notnull' => true,
214		'length' => 127,
215		]
216		);
217
218		$table->setPrimaryKey(['id']);
219		$table->addUniqueIndex(['item_id']);
220		}
221
222		return $schema;
223		}
224
225
226		}
227

nextcloud / circles

Pull Request — master (#551)

Version0021Date20210105123456::changeSchema() F

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like