Completed
Pull Request — master (#1378)
by Maxence
32s
created
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +83 added lines, -83 removed lines patch added patch discarded remove patch
@@ -398,8 +398,8 @@  discard block
 block discarded – undo
398 398
 			foreach (explode(' ', $circle->getDisplayName()) as $word) {
399 399
 				$andX->add(
400 400
 					$expr->iLike(
401
-						$this->getDefaultSelectAlias() . '.' . 'display_name',
402
-						$this->createNamedParameter('%' . $word . '%')
401
+						$this->getDefaultSelectAlias().'.'.'display_name',
402
+						$this->createNamedParameter('%'.$word.'%')
403 403
 					)
404 404
 				);
405 405
 			}
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
431 431
 				 ->leftJoin(
432 432
 				 	$alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
433
-				 	$expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
433
+				 	$expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
434 434
 				 );
435 435
 		} catch (RequestBuilderException $e) {
436 436
 		}
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 		$expr = $this->expr();
483 483
 		$this->leftJoin(
484 484
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
485
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
485
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
486 486
 		);
487 487
 	}
488 488
 
@@ -510,12 +510,12 @@  discard block
 block discarded – undo
510 510
 		$this->leftJoin(
511 511
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
512 512
 			$expr->andX(
513
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
513
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
514 514
 				$expr->eq(
515
-					$aliasRemoteMember . '.instance',
515
+					$aliasRemoteMember.'.instance',
516 516
 					$this->createNamedParameter($remoteInstance->getInstance())
517 517
 				),
518
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
518
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
519 519
 			)
520 520
 		);
521 521
 	}
@@ -547,21 +547,21 @@  discard block
 block discarded – undo
547 547
 		$this->leftJoin(
548 548
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
549 549
 			$expr->andX(
550
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
551
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
552
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
550
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
551
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
552
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
553 553
 			)
554 554
 		);
555 555
 		$this->leftJoin(
556 556
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
557 557
 			$expr->andX(
558
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
558
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
559 559
 				$expr->eq(
560
-					$aliasRemoteCircleOwner . '.instance',
560
+					$aliasRemoteCircleOwner.'.instance',
561 561
 					$this->createNamedParameter($remoteInstance->getInstance())
562 562
 				),
563 563
 				$expr->eq(
564
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
564
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
565 565
 				)
566 566
 			)
567 567
 		);
@@ -594,16 +594,16 @@  discard block
 block discarded – undo
594 594
 		$expr = $this->expr();
595 595
 		$orX = $expr->orX();
596 596
 		$orX->add(
597
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
597
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
598 598
 		);
599 599
 
600 600
 		$orExtOrPassive = $expr->orX();
601 601
 		$orExtOrPassive->add(
602
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
602
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
603 603
 		);
604 604
 		if (!$sensitive) {
605 605
 			$orExtOrPassive->add(
606
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
606
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
607 607
 			);
608 608
 		} else {
609 609
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -612,8 +612,8 @@  discard block
 block discarded – undo
612 612
 		}
613 613
 
614 614
 		$orInstance = $expr->orX();
615
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
616
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
615
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
616
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
617 617
 
618 618
 		$andExternal = $expr->andX();
619 619
 		$andExternal->add($orExtOrPassive);
@@ -622,13 +622,13 @@  discard block
 block discarded – undo
622 622
 		$orExtOrTrusted = $expr->orX();
623 623
 		$orExtOrTrusted->add($andExternal);
624 624
 		$orExtOrTrusted->add(
625
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
625
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
626 626
 		);
627 627
 
628 628
 		$andTrusted = $expr->andX();
629 629
 		$andTrusted->add($orExtOrTrusted);
630 630
 		$andTrusted->add($this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle));
631
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
631
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
632 632
 		$orX->add($andTrusted);
633 633
 
634 634
 		$this->andWhere($orX);
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 		}
656 656
 		$this->innerJoin(
657 657
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
658
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
658
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
659 659
 		);
660 660
 
661 661
 		$this->filterDirectMembership($aliasMember, $member);
@@ -680,12 +680,12 @@  discard block
 block discarded – undo
680 680
 			$aliasCircle,
681 681
 			'circles_membership',
682 682
 			$aliasMembership,
683
-			$this->expr()->eq($aliasCircle . '.unique_id', $aliasMembership . '.circle_id')
683
+			$this->expr()->eq($aliasCircle.'.unique_id', $aliasMembership.'.circle_id')
684 684
 		);
685 685
 
686 686
 		$this->andWhere(
687 687
 			$this->expr()->eq(
688
-				$aliasMembership . '.single_id',
688
+				$aliasMembership.'.single_id',
689 689
 				$this->createNamedParameter($federatedUser->getSingleId())
690 690
 			)
691 691
 		);
@@ -706,19 +706,19 @@  discard block
 block discarded – undo
706 706
 
707 707
 		if ($member->getUserId() !== '') {
708 708
 			$andX->add(
709
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
709
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
710 710
 			);
711 711
 		}
712 712
 
713 713
 		if ($member->getSingleId() !== '') {
714 714
 			$andX->add(
715
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
715
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
716 716
 			);
717 717
 		}
718 718
 
719 719
 		if ($member->getUserType() > 0) {
720 720
 			$andX->add(
721
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
721
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
722 722
 			);
723 723
 		}
724 724
 
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
 		if ($member->getLevel() > 0) {
728 728
 			$andX->add(
729 729
 				$expr->gte(
730
-					$aliasMember . '.level',
730
+					$aliasMember.'.level',
731 731
 					$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
732 732
 				)
733 733
 			);
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
 			$helperAlias,
769 769
 			CoreRequestBuilder::TABLE_CIRCLE,
770 770
 			$aliasCircle,
771
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
771
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
772 772
 		);
773 773
 
774 774
 		if (!is_null($initiator)) {
@@ -799,7 +799,7 @@  discard block
 block discarded – undo
799 799
 		$this->generateCircleSelectAlias($aliasInvitedBy)
800 800
 			 ->leftJoin(
801 801
 			 	$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
802
-			 	$expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
802
+			 	$expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
803 803
 			 );
804 804
 
805 805
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -830,7 +830,7 @@  discard block
 block discarded – undo
830 830
 		$this->generateCircleSelectAlias($aliasBasedOn)
831 831
 			 ->leftJoin(
832 832
 			 	$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
833
-			 	$expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
833
+			 	$expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
834 834
 			 );
835 835
 
836 836
 		if (!is_null($initiator)) {
@@ -863,9 +863,9 @@  discard block
 block discarded – undo
863 863
 			 ->leftJoin(
864 864
 			 	$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
865 865
 			 	$expr->andX(
866
-			 		$expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
866
+			 		$expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
867 867
 			 		$expr->eq(
868
-			 			$aliasMember . '.level',
868
+			 			$aliasMember.'.level',
869 869
 			 			$this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
870 870
 			 		)
871 871
 			 	)
@@ -897,7 +897,7 @@  discard block
 block discarded – undo
897 897
 
898 898
 		$expr = $this->expr();
899 899
 
900
-		$on = $expr->andX($expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field));
900
+		$on = $expr->andX($expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field));
901 901
 
902 902
 		// limit on membership level if requested
903 903
 		$minLevel = $probe->getMinimumLevel();
@@ -938,8 +938,8 @@  discard block
 block discarded – undo
938 938
 			 ->leftJoin(
939 939
 			 	$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
940 940
 			 	$expr->andX(
941
-			 		$expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
942
-			 		$expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
941
+			 		$expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
942
+			 		$expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
943 943
 			 		$this->exprGt('level', Member::LEVEL_MEMBER, true, $aliasMember)
944 944
 			 	)
945 945
 			 );
@@ -971,7 +971,7 @@  discard block
 block discarded – undo
971 971
 
972 972
 		$this->leftJoin(
973 973
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
974
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
974
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
975 975
 		);
976 976
 
977 977
 //		if (!$this->getBool('getData', $options, false)) {
@@ -985,8 +985,8 @@  discard block
 block discarded – undo
985 985
 			 ->leftJoin(
986 986
 			 	$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
987 987
 			 	$expr->andX(
988
-			 		$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
989
-			 		$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
988
+			 		$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
989
+			 		$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
990 990
 			 	)
991 991
 			 );
992 992
 
@@ -1003,12 +1003,12 @@  discard block
 block discarded – undo
1003 1003
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
1004 1004
 		$this->leftJoin(
1005 1005
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
1006
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
1006
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
1007 1007
 		);
1008 1008
 
1009 1009
 		$orX = $expr->orX(
1010
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
1011
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
1010
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
1011
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
1012 1012
 		);
1013 1013
 
1014 1014
 		$this->andWhere($orX);
@@ -1029,11 +1029,11 @@  discard block
 block discarded – undo
1029 1029
 
1030 1030
 		$expr = $this->expr();
1031 1031
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
1032
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
1032
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
1033 1033
 		if ($level > 1) {
1034 1034
 			$this->andWhere(
1035 1035
 				$expr->gte(
1036
-					$aliasMembership . '.level',
1036
+					$aliasMembership.'.level',
1037 1037
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
1038 1038
 				)
1039 1039
 			);
@@ -1061,8 +1061,8 @@  discard block
 block discarded – undo
1061 1061
 		$this->leftJoin(
1062 1062
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
1063 1063
 			$expr->andX(
1064
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
1065
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
1064
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
1065
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
1066 1066
 			)
1067 1067
 		);
1068 1068
 
@@ -1075,8 +1075,8 @@  discard block
 block discarded – undo
1075 1075
 			 ->leftJoin(
1076 1076
 			 	$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
1077 1077
 			 	$expr->andX(
1078
-			 		$expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
1079
-			 		$expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
1078
+			 		$expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
1079
+			 		$expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
1080 1080
 			 	)
1081 1081
 			 );
1082 1082
 	}
@@ -1116,7 +1116,7 @@  discard block
 block discarded – undo
1116 1116
 
1117 1117
 		$this->leftJoin(
1118 1118
 			$alias, CoreRequestBuilder::TABLE_TOKEN, $aliasShareToken,
1119
-			$expr->eq($aliasShareToken . '.share_id', $alias . '.' . $field)
1119
+			$expr->eq($aliasShareToken.'.share_id', $alias.'.'.$field)
1120 1120
 		);
1121 1121
 	}
1122 1122
 
@@ -1158,14 +1158,14 @@  discard block
 block discarded – undo
1158 1158
 		try {
1159 1159
 			$aliasConfig = $this->generateAlias($alias, self::CONFIG, $options);
1160 1160
 			$this->selectAlias(
1161
-				$aliasConfig . '.config',
1162
-				(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'circle_config'
1161
+				$aliasConfig.'.config',
1162
+				(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'circle_config'
1163 1163
 			);
1164 1164
 			$this->leftJoin(
1165 1165
 				$alias,
1166 1166
 				CoreRequestBuilder::TABLE_CIRCLE,
1167 1167
 				$aliasConfig,
1168
-				$expr->eq($alias . '.circle_id', $aliasConfig . '.unique_id')
1168
+				$expr->eq($alias.'.circle_id', $aliasConfig.'.unique_id')
1169 1169
 			);
1170 1170
 		} catch (RequestBuilderException $e) {
1171 1171
 		}
@@ -1203,7 +1203,7 @@  discard block
 block discarded – undo
1203 1203
 			$aliasMembership,
1204 1204
 			$expr->andX(
1205 1205
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1206
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1206
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1207 1207
 			)
1208 1208
 		);
1209 1209
 
@@ -1222,11 +1222,11 @@  discard block
 block discarded – undo
1222 1222
 			$aliasMembershipCircle = $this->generateAlias($aliasMembership, self::CONFIG, $options);
1223 1223
 			$orXMembershipCircle = $expr->orX();
1224 1224
 			array_map(
1225
-				function (string $alias) use ($orXMembershipCircle, $aliasMembershipCircle) {
1225
+				function(string $alias) use ($orXMembershipCircle, $aliasMembershipCircle) {
1226 1226
 					$orXMembershipCircle->add(
1227 1227
 						$this->expr()->eq(
1228
-							$alias . '.circle_id',
1229
-							$aliasMembershipCircle . '.unique_id'
1228
+							$alias.'.circle_id',
1229
+							$aliasMembershipCircle.'.unique_id'
1230 1230
 						)
1231 1231
 					);
1232 1232
 				},
@@ -1258,7 +1258,7 @@  discard block
 block discarded – undo
1258 1258
 					 	$aliasDirectInitiator,
1259 1259
 					 	$expr->andX(
1260 1260
 					 		$this->exprLimit('single_id', $initiator->getSingleId(), $aliasDirectInitiator),
1261
-					 		$expr->eq($aliasDirectInitiator . '.circle_id', $helperAlias . '.' . $field)
1261
+					 		$expr->eq($aliasDirectInitiator.'.circle_id', $helperAlias.'.'.$field)
1262 1262
 					 	)
1263 1263
 					 );
1264 1264
 			} catch (RequestBuilderException $e) {
@@ -1272,8 +1272,8 @@  discard block
 block discarded – undo
1272 1272
 			$this->leftJoin(
1273 1273
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1274 1274
 				$expr->andX(
1275
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1276
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1275
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1276
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1277 1277
 				)
1278 1278
 			);
1279 1279
 
@@ -1281,8 +1281,8 @@  discard block
 block discarded – undo
1281 1281
 			$this->leftJoin(
1282 1282
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1283 1283
 				$expr->andX(
1284
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1285
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1284
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1285
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1286 1286
 				)
1287 1287
 			);
1288 1288
 
@@ -1327,7 +1327,7 @@  discard block
 block discarded – undo
1327 1327
 			 ->leftJoin(
1328 1328
 			 	$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1329 1329
 			 	$expr->andX(
1330
-			 		$expr->eq($aliasInitiator . '.circle_id', $helperAlias . '.' . $field),
1330
+			 		$expr->eq($aliasInitiator.'.circle_id', $helperAlias.'.'.$field),
1331 1331
 			 		$this->exprLimitInt('level', Member::LEVEL_OWNER, $aliasInitiator)
1332 1332
 			 	)
1333 1333
 			 );
@@ -1363,7 +1363,7 @@  discard block
 block discarded – undo
1363 1363
 			$orX->add(
1364 1364
 				$expr->andX(
1365 1365
 					$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $aliasMembershipCircle),
1366
-					$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1366
+					$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1367 1367
 				)
1368 1368
 			);
1369 1369
 		}
@@ -1373,10 +1373,10 @@  discard block
 block discarded – undo
1373 1373
 		$orXLevelCheck = $expr->orX();
1374 1374
 
1375 1375
 		array_map(
1376
-			function (string $alias) use ($orXLevelCheck, $minimumLevel) {
1376
+			function(string $alias) use ($orXLevelCheck, $minimumLevel) {
1377 1377
 				$orXLevelCheck->add(
1378 1378
 					$this->expr()->gte(
1379
-						$alias . '.level',
1379
+						$alias.'.level',
1380 1380
 						$this->createNamedParameter($minimumLevel, self::PARAM_INT)
1381 1381
 					)
1382 1382
 				);
@@ -1466,21 +1466,21 @@  discard block
 block discarded – undo
1466 1466
 		$expr = $this->expr();
1467 1467
 		$andPassive = $expr->andX();
1468 1468
 		$andPassive->add(
1469
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1469
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1470 1470
 		);
1471 1471
 
1472 1472
 		$orMemberOrLevel = $expr->orX();
1473 1473
 		$orMemberOrLevel->add(
1474
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1474
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1475 1475
 		);
1476 1476
 		// TODO: do we need this ? (display members from the local instance)
1477 1477
 		$orMemberOrLevel->add(
1478
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1478
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1479 1479
 		);
1480 1480
 
1481 1481
 		$orMemberOrLevel->add(
1482 1482
 			$expr->eq(
1483
-				$this->getDefaultSelectAlias() . '.level',
1483
+				$this->getDefaultSelectAlias().'.level',
1484 1484
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1485 1485
 			)
1486 1486
 		);
@@ -1517,11 +1517,11 @@  discard block
 block discarded – undo
1517 1517
 			 )
1518 1518
 			 ->leftJoin(
1519 1519
 			 	$aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1520
-			 	$expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1520
+			 	$expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1521 1521
 			 )
1522 1522
 			 ->leftJoin(
1523 1523
 			 	$aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1524
-			 	$expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1524
+			 	$expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1525 1525
 			 );
1526 1526
 	}
1527 1527
 
@@ -1543,8 +1543,8 @@  discard block
 block discarded – undo
1543 1543
 		$this->leftJoin(
1544 1544
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1545 1545
 			$expr->andX(
1546
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1547
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1546
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1547
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1548 1548
 			)
1549 1549
 		);
1550 1550
 
@@ -1594,13 +1594,13 @@  discard block
 block discarded – undo
1594 1594
 		$this->leftJoin(
1595 1595
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1596 1596
 			$expr->andX(
1597
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1598
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1597
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1598
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1599 1599
 			)
1600 1600
 		);
1601 1601
 
1602
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1603
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1602
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1603
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1604 1604
 	}
1605 1605
 
1606 1606
 
@@ -1708,10 +1708,10 @@  discard block
 block discarded – undo
1708 1708
 	 */
1709 1709
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1710 1710
 		$search = str_replace('_', '.', $base);
1711
-		$path = $search . '.' . $extension;
1711
+		$path = $search.'.'.$extension;
1712 1712
 		if (!$this->validKey($path, $this->getSqlPath())
1713 1713
 			&& !in_array($extension, $this->getArray($search, $this->getSqlPath()))) {
1714
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1714
+			throw new RequestBuilderException($extension.' not found in '.$search);
1715 1715
 		}
1716 1716
 
1717 1717
 		if (!is_array($options)) {
@@ -1720,15 +1720,15 @@  discard block
 block discarded – undo
1720 1720
 
1721 1721
 		$optionPath = '';
1722 1722
 		foreach (explode('.', $path) as $p) {
1723
-			$optionPath = trim($optionPath . '.' . $p, '.');
1723
+			$optionPath = trim($optionPath.'.'.$p, '.');
1724 1724
 			$options = array_merge(
1725 1725
 				$options,
1726
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->getSqlPath()),
1727
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1726
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->getSqlPath()),
1727
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1728 1728
 			);
1729 1729
 		}
1730 1730
 
1731
-		return $base . '_' . $extension;
1731
+		return $base.'_'.$extension;
1732 1732
 	}
1733 1733
 
1734 1734
 
@@ -1748,7 +1748,7 @@  discard block
 block discarded – undo
1748 1748
 			} else {
1749 1749
 				$k = $arr;
1750 1750
 			}
1751
-			$path[$k] = $prefix . '_' . $k . '_';
1751
+			$path[$k] = $prefix.'_'.$k.'_';
1752 1752
 		}
1753 1753
 
1754 1754
 		return $path;
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
 	public function registerFilesNavigation() {
169 169
 		$appManager = FilesApp::getNavigationManager();
170 170
 		$appManager->add(
171
-			function () {
171
+			function() {
172 172
 				$l = OC::$server->getL10N('circles');
173 173
 
174 174
 				return [
Please login to merge, or discard this patch.
lib/Model/FileCacheWrapper.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 		}
457 457
 
458 458
 		$path = $this->getPath();
459
-		[$storageType,] = explode('::', $this->getStorage(), 2);
459
+		[$storageType, ] = explode('::', $this->getStorage(), 2);
460 460
 
461 461
 		if ($path === '') {
462 462
 			// we only accept empty path on external storage
@@ -508,29 +508,29 @@  discard block
 block discarded – undo
508 508
 	 * @throws FileCacheNotFoundException
509 509
 	 */
510 510
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
511
-		if ($this->getInt($prefix . 'fileid', $data) === 0) {
511
+		if ($this->getInt($prefix.'fileid', $data) === 0) {
512 512
 			throw new FileCacheNotFoundException();
513 513
 		}
514 514
 
515
-		$this->setId($this->getInt($prefix . 'fileid', $data));
516
-		$this->setPath($this->get($prefix . 'path', $data));
517
-		$this->setPermissions($this->getInt($prefix . 'permissions', $data));
518
-		$this->setStorageId($this->getInt($prefix . 'storage', $data));
519
-		$this->setPathHash($this->get($prefix . 'path_hash', $data));
520
-		$this->setParent($this->getInt($prefix . 'parent', $data));
521
-		$this->setName($this->get($prefix . 'name', $data));
522
-		$this->setMimeType($this->getInt($prefix . 'mimetype', $data));
523
-		$this->setMimePart($this->getInt($prefix . 'mimepart', $data));
524
-		$this->setSize($this->getInt($prefix . 'size', $data));
525
-		$this->setMTime($this->getInt($prefix . 'mtime', $data));
526
-		$this->setStorageMTime($this->getInt($prefix . 'storage_mtime', $data));
527
-		$this->setEncrypted($this->getBool($prefix . 'encrypted', $data));
528
-		$this->setUnencryptedSize($this->getInt($prefix . 'unencrypted_size', $data));
529
-		$this->setEtag($this->get($prefix . 'etag', $data));
530
-		$this->setChecksum($this->get($prefix . 'checksum', $data));
515
+		$this->setId($this->getInt($prefix.'fileid', $data));
516
+		$this->setPath($this->get($prefix.'path', $data));
517
+		$this->setPermissions($this->getInt($prefix.'permissions', $data));
518
+		$this->setStorageId($this->getInt($prefix.'storage', $data));
519
+		$this->setPathHash($this->get($prefix.'path_hash', $data));
520
+		$this->setParent($this->getInt($prefix.'parent', $data));
521
+		$this->setName($this->get($prefix.'name', $data));
522
+		$this->setMimeType($this->getInt($prefix.'mimetype', $data));
523
+		$this->setMimePart($this->getInt($prefix.'mimepart', $data));
524
+		$this->setSize($this->getInt($prefix.'size', $data));
525
+		$this->setMTime($this->getInt($prefix.'mtime', $data));
526
+		$this->setStorageMTime($this->getInt($prefix.'storage_mtime', $data));
527
+		$this->setEncrypted($this->getBool($prefix.'encrypted', $data));
528
+		$this->setUnencryptedSize($this->getInt($prefix.'unencrypted_size', $data));
529
+		$this->setEtag($this->get($prefix.'etag', $data));
530
+		$this->setChecksum($this->get($prefix.'checksum', $data));
531 531
 
532 532
 		// small hack as there is no reason to call a recursive method for a single entry from the table
533
-		$this->setStorage($this->get($prefix . CoreQueryBuilder::STORAGES . '_id', $data));
533
+		$this->setStorage($this->get($prefix.CoreQueryBuilder::STORAGES.'_id', $data));
534 534
 
535 535
 		return $this;
536 536
 	}
Please login to merge, or discard this patch.
lib/Activity/Provider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 			$this->parseAsNonMember($event, $circle);
69 69
 			$this->parseAsMember($event, $circle, $params);
70 70
 			$this->parseAsModerator($event, $circle, $params);
71
-		} catch (FakeException|InvalidItemException $e) {
71
+		} catch (FakeException | InvalidItemException $e) {
72 72
 			/** clean exit */
73 73
 		}
74 74
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	private function setIcon(IEvent $event): void {
96 96
 		$path = $this->urlGenerator->imagePath(
97 97
 			Application::APP_ID,
98
-			'circles.' . $this->activityManager->getRequirePNG() ? 'png' : 'svg'
98
+			'circles.'.$this->activityManager->getRequirePNG() ? 'png' : 'svg'
99 99
 		);
100 100
 		$event->setIcon($this->urlGenerator->getAbsoluteURL($path));
101 101
 	}
Please login to merge, or discard this patch.
lib/Activity/ProviderParser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 				continue;
127 127
 			}
128 128
 
129
-			$replace['{' . $k . '}'] = $data[$k]['_parsed'];
129
+			$replace['{'.$k.'}'] = $data[$k]['_parsed'];
130 130
 		}
131 131
 
132 132
 		$event->setParsedSubject(strtr($line, $replace));
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 		return [
271 271
 			'type' => Member::$TYPE[$member->getUserType()] ?? '',
272 272
 			'id' => $member->getUserId(),
273
-			'name' => $member->getDisplayName() . ' (' . (Member::$TYPE[$member->getUserType()] ?? '') . ')',
273
+			'name' => $member->getDisplayName().' ('.(Member::$TYPE[$member->getUserType()] ?? '').')',
274 274
 			'_parsed' => $member->getDisplayName()
275 275
 		];
276 276
 	}
Please login to merge, or discard this patch.
lib/Model/Circle.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -90,27 +90,27 @@  discard block
 block discarded – undo
90 90
 	public const FLAGS_LONG = 2;
91 91
 
92 92
 	// specific value
93
-	public const CFG_CIRCLE = 0;        // only for code readability. Circle is locked by default.
94
-	public const CFG_SINGLE = 1;        // Circle with only one single member.
95
-	public const CFG_PERSONAL = 2;      // Personal circle, only the owner can see it.
93
+	public const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default.
94
+	public const CFG_SINGLE = 1; // Circle with only one single member.
95
+	public const CFG_PERSONAL = 2; // Personal circle, only the owner can see it.
96 96
 
97 97
 	// bitwise
98
-	public const CFG_SYSTEM = 4;            // System Circle (not managed by the official front-end). Meaning some config are limited
99
-	public const CFG_VISIBLE = 8;           // Visible to everyone, if not visible, people have to know its name to be able to find it
100
-	public const CFG_OPEN = 16;             // Circle is open, people can join
101
-	public const CFG_INVITE = 32;           // Adding a member generate an invitation that needs to be accepted
102
-	public const CFG_REQUEST = 64;          // Request to join Circles needs to be confirmed by a moderator
103
-	public const CFG_FRIEND = 128;          // Members of the circle can invite their friends
104
-	public const CFG_PROTECTED = 256;       // Password protected to join/request
105
-	public const CFG_NO_OWNER = 512;        // no owner, only members
106
-	public const CFG_HIDDEN = 1024;         // hidden from listing, but available as a share entity
107
-	public const CFG_BACKEND = 2048;            // Fully hidden, only backend Circles
108
-	public const CFG_LOCAL = 4096;              // Local even on GlobalScale
109
-	public const CFG_ROOT = 8192;               // Circle cannot be inside another Circle
110
-	public const CFG_CIRCLE_INVITE = 16384;     // Circle must confirm when invited in another circle
111
-	public const CFG_FEDERATED = 32768;         // Federated
112
-	public const CFG_MOUNTPOINT = 65536;        // Generate a Files folder for this Circle
113
-	public const CFG_APP = 131072;          // Some features are not available to the OCS API (ie. destroying Circle)
98
+	public const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited
99
+	public const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it
100
+	public const CFG_OPEN = 16; // Circle is open, people can join
101
+	public const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted
102
+	public const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator
103
+	public const CFG_FRIEND = 128; // Members of the circle can invite their friends
104
+	public const CFG_PROTECTED = 256; // Password protected to join/request
105
+	public const CFG_NO_OWNER = 512; // no owner, only members
106
+	public const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity
107
+	public const CFG_BACKEND = 2048; // Fully hidden, only backend Circles
108
+	public const CFG_LOCAL = 4096; // Local even on GlobalScale
109
+	public const CFG_ROOT = 8192; // Circle cannot be inside another Circle
110
+	public const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle
111
+	public const CFG_FEDERATED = 32768; // Federated
112
+	public const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle
113
+	public const CFG_APP = 131072; // Some features are not available to the OCS API (ie. destroying Circle)
114 114
 	public static $DEF_CFG_MAX = 262143;
115 115
 
116 116
 
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 	 */
480 480
 	public function addInheritedMembers(array $members): self {
481 481
 		$knownIds = array_map(
482
-			function (Member $member): string {
482
+			function(Member $member): string {
483 483
 				return $member->getId();
484 484
 			}, $this->inheritedMembers
485 485
 		);
@@ -893,23 +893,23 @@  discard block
 block discarded – undo
893 893
 	 * @throws CircleNotFoundException
894 894
 	 */
895 895
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
896
-		if ($this->get($prefix . 'unique_id', $data) === '') {
896
+		if ($this->get($prefix.'unique_id', $data) === '') {
897 897
 			throw new CircleNotFoundException();
898 898
 		}
899 899
 
900
-		$this->setSingleId($this->get($prefix . 'unique_id', $data))
901
-			 ->setName($this->get($prefix . 'name', $data))
902
-			 ->setDisplayName($this->get($prefix . 'display_name', $data))
903
-			 ->setSanitizedName($this->get($prefix . 'sanitized_name', $data))
904
-			 ->setConfig($this->getInt($prefix . 'config', $data))
905
-			 ->setSource($this->getInt($prefix . 'source', $data))
906
-			 ->setInstance($this->get($prefix . 'instance', $data))
907
-			 ->setSettings($this->getArray($prefix . 'settings', $data))
908
-			 ->setContactAddressBook($this->getInt($prefix . 'contact_addressbook', $data))
909
-			 ->setContactGroupName($this->get($prefix . 'contact_groupname', $data))
910
-			 ->setDescription($this->get($prefix . 'description', $data));
911
-
912
-		$creation = $this->get($prefix . 'creation', $data);
900
+		$this->setSingleId($this->get($prefix.'unique_id', $data))
901
+			 ->setName($this->get($prefix.'name', $data))
902
+			 ->setDisplayName($this->get($prefix.'display_name', $data))
903
+			 ->setSanitizedName($this->get($prefix.'sanitized_name', $data))
904
+			 ->setConfig($this->getInt($prefix.'config', $data))
905
+			 ->setSource($this->getInt($prefix.'source', $data))
906
+			 ->setInstance($this->get($prefix.'instance', $data))
907
+			 ->setSettings($this->getArray($prefix.'settings', $data))
908
+			 ->setContactAddressBook($this->getInt($prefix.'contact_addressbook', $data))
909
+			 ->setContactGroupName($this->get($prefix.'contact_groupname', $data))
910
+			 ->setDescription($this->get($prefix.'description', $data));
911
+
912
+		$creation = $this->get($prefix.'creation', $data);
913 913
 		$this->setCreation(DateTime::createFromFormat('Y-m-d H:i:s', $creation)->getTimestamp());
914 914
 
915 915
 		$this->setPopulation($this->getInt('population', $this->getSettings()));
Please login to merge, or discard this patch.
lib/Service/ActivityService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 		$event->setSubject('circle_create', ['circle' => json_encode($circle)]);
76 76
 
77 77
 		$this->userManager->callForSeenUsers(
78
-			function ($user) use ($event) {
78
+			function($user) use ($event) {
79 79
 				/** @var IUser $user */
80 80
 				$this->publishEvent($event, [$user]);
81 81
 			}
Please login to merge, or discard this patch.
lib/FederatedItems/MemberLevel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
 	 * @param array $results
166 166
 	 */
167 167
 	public function result(FederatedEvent $event, array $results): void {
168
-		\OC::$server->getLogger()->log(3,' ____ result');
168
+		\OC::$server->getLogger()->log(3, ' ____ result');
169 169
 		$this->eventService->memberLevelEdited($event, $results);
170 170
 	}
171 171
 
Please login to merge, or discard this patch.
lib/FederatedItems/SingleMemberAdd.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 */
164 164
 	public function result(FederatedEvent $event, array $results): void {
165 165
 		$member = $event->getMember();
166
-		\OC::$server->getLogger()->log(3, '>> ' . $member->getStatus());
166
+		\OC::$server->getLogger()->log(3, '>> '.$member->getStatus());
167 167
 		if ($member->getStatus() === Member::STATUS_INVITED) {
168 168
 			$this->eventService->memberInvited($event, $results);
169 169
 		} else {
@@ -197,10 +197,10 @@  discard block
 block discarded – undo
197 197
 	protected function generateMember(FederatedEvent $event, Circle $circle, Member $member): Member {
198 198
 		try {
199 199
 			if ($member->getSingleId() !== '') {
200
-				$userId = $member->getSingleId() . '@' . $member->getInstance();
200
+				$userId = $member->getSingleId().'@'.$member->getInstance();
201 201
 				$federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_SINGLE);
202 202
 			} else {
203
-				$userId = $member->getUserId() . '@' . $member->getInstance();
203
+				$userId = $member->getUserId().'@'.$member->getInstance();
204 204
 				$federatedUser = $this->federatedUserService->getFederatedUser(
205 205
 					$userId,
206 206
 					$member->getUserType()
Please login to merge, or discard this patch.