Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 41 | class |
||
| 42 | TokensRequestBuilder extends CoreRequestBuilder { |
||
| 43 | |||
| 44 | |||
| 45 | /** |
||
| 46 | * Base of the Sql Insert request for Shares |
||
| 47 | * |
||
| 48 | * @return IQueryBuilder |
||
| 49 | */ |
||
| 50 | protected function getTokensInsertSql() { |
||
| 56 | |||
| 57 | |||
| 58 | /** |
||
| 59 | * Base of the Sql Update request for Groups |
||
| 60 | * |
||
| 61 | * @param int $circleId |
||
| 62 | * @param string $groupId |
||
| 63 | * |
||
| 64 | * @return IQueryBuilder |
||
| 65 | */ |
||
| 66 | protected function getTokensUpdateSql($circleId, $groupId) { |
||
| 72 | |||
| 73 | |||
| 74 | /** |
||
| 75 | * @return IQueryBuilder |
||
| 76 | */ |
||
| 77 | protected function getTokensSelectSql() { |
||
| 88 | |||
| 89 | |||
| 90 | /** |
||
| 91 | * Base of the Sql Delete request |
||
| 92 | * |
||
| 93 | * @return IQueryBuilder |
||
| 94 | */ |
||
| 95 | View Code Duplication | protected function getTokensDeleteSql() { |
|
| 105 | |||
| 106 | |||
| 107 | /** |
||
| 108 | * @param array $data |
||
| 109 | * |
||
| 110 | * @return SharesToken |
||
| 111 | */ |
||
| 112 | protected function parseTokensSelectSql($data) { |
||
| 118 | |||
| 119 | } |
||
| 120 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.