nextcloud / circles

lib/Service/CircleService.php

Doc Comments +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
 	 * @param string $name
 	 * @param FederatedUser|null $owner
 	 *
-	 * @return Circle
+	 * @return SimpleDataStore
 	 * @throws FederatedEventException
 	 * @throws InitiatorNotConfirmedException
 	 * @throws InitiatorNotFoundException

lib/Model/Member.php

Spacing +18 added lines, -18 removed lines

@@ -549,29 +549,29 @@ 
 	 * @throws MemberNotFoundException
 	 */
 	public function importFromDatabase(array $data, string $prefix = ''): INC21QueryRow {
-		if (!array_key_exists($prefix . 'member_id', $data)) {
+		if (!array_key_exists($prefix.'member_id', $data)) {
 			throw new MemberNotFoundException();
 		}
 
-		$this->setId($this->get($prefix . 'member_id', $data));
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
-		$this->setUserId($this->get($prefix . 'user_id', $data));
-		$this->setUserType($this->getInt($prefix . 'user_type', $data));
-		$this->setInstance($this->get($prefix . 'instance', $data));
-		$this->setLevel($this->getInt($prefix . 'level', $data));
-		$this->setStatus($this->get($prefix . 'status', $data));
-		$this->setCachedName($this->get($prefix . 'cached_name', $data));
-		$this->setNote($this->get($prefix . 'note', $data));
-		$this->setContactId($this->get($prefix . 'contact_id', $data));
-		$this->setContactMeta($this->get($prefix . 'contact_meta', $data));
-
-		$cachedUpdate = $this->get($prefix . 'cached_update', $data);
+		$this->setId($this->get($prefix.'member_id', $data));
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
+		$this->setSingleId($this->get($prefix.'single_id', $data));
+		$this->setUserId($this->get($prefix.'user_id', $data));
+		$this->setUserType($this->getInt($prefix.'user_type', $data));
+		$this->setInstance($this->get($prefix.'instance', $data));
+		$this->setLevel($this->getInt($prefix.'level', $data));
+		$this->setStatus($this->get($prefix.'status', $data));
+		$this->setCachedName($this->get($prefix.'cached_name', $data));
+		$this->setNote($this->get($prefix.'note', $data));
+		$this->setContactId($this->get($prefix.'contact_id', $data));
+		$this->setContactMeta($this->get($prefix.'contact_meta', $data));
+
+		$cachedUpdate = $this->get($prefix.'cached_update', $data);
 		if ($cachedUpdate !== '') {
 			$this->setCachedUpdate(DateTime::createFromFormat('Y-m-d H:i:s', $cachedUpdate)->getTimestamp());
 		}
 
-		$joined = $this->get($prefix . 'joined', $data);
+		$joined = $this->get($prefix.'joined', $data);
 		if ($joined !== '') {
 			$this->setJoined(DateTime::createFromFormat('Y-m-d H:i:s', $joined)->getTimestamp());
 		}
@@ -600,7 +600,7 @@ 
 
 		if (!$level) {
 			$all = implode(', ', array_values(self::$DEF_LEVEL));
-			throw new MemberLevelException('Available levels: ' . $all);
+			throw new MemberLevelException('Available levels: '.$all);
 		}
 
 		return (int)$level;
@@ -618,7 +618,7 @@ 
 
 		if (!$type) {
 			$all = implode(', ', array_values(self::$DEF_TYPE));
-			throw new UserTypeNotFoundException('Available types: ' . $all);
+			throw new UserTypeNotFoundException('Available types: '.$all);
 		}
 
 		return (int)$type;

lib/Command/CirclesCreate.php

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 		$owner = $this->federatedUserService->getLocalFederatedUser($ownerId);
 		$outcome = $this->circleService->create($name, $owner);
 
-		echo json_encode($outcome, JSON_PRETTY_PRINT) . "\n";
+		echo json_encode($outcome, JSON_PRETTY_PRINT)."\n";
 
 		return 0;
 	}

lib/Command/MembersAdd.php

Spacing +2 added lines, -2 removed lines

@@ -127,7 +127,7 @@ 
 		$federatedUser = $this->federatedUserService->generateFederatedUser($userId, (int)$type);
 		$outcome = $this->memberService->addMember($circleId, $federatedUser);
 
-		echo json_encode($outcome, JSON_PRETTY_PRINT) . "\n";
+		echo json_encode($outcome, JSON_PRETTY_PRINT)."\n";
 
 		return 0;
 	}
@@ -178,7 +178,7 @@ 
 				$instance = $host;
 			}
 
-			$result[] = $user['userid']['value'] . ' <info>@' . $host . '</info>';
+			$result[] = $user['userid']['value'].' <info>@'.$host.'</info>';
 		}
 
 //		if ($userId === '') {

lib/Service/FederatedUserService.php

Spacing +2 added lines, -2 removed lines

@@ -230,7 +230,7 @@ 
 	public function getLocalFederatedUser(string $userId): FederatedUser {
 		$user = $this->userManager->get($userId);
 		if ($user === null) {
-			throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
+			throw new FederatedUserNotFoundException('user '.$userId.' not found');
 		}
 
 		$federatedUser = new FederatedUser();
@@ -513,7 +513,7 @@ 
 			$circle = new Circle();
 			$id = $this->token(ManagedModel::ID_LENGTH);
 
-			$circle->setName('single:' . $federatedUser->getUserId() . ':' . $id)
+			$circle->setName('single:'.$federatedUser->getUserId().':'.$id)
 				   ->setId($id)
 				   ->setConfig(Circle::CFG_SINGLE);
 			$this->circleRequest->save($circle);

lib/FederatedItems/MemberAdd.php

Spacing +8 added lines, -8 removed lines

@@ -160,14 +160,14 @@ 
 		$initiatorHelper = new MemberHelper($initiator);
 		$initiatorHelper->mustBeModerator();
 
-		$federatedId = $member->getUserId() . '@' . $member->getInstance();
+		$federatedId = $member->getUserId().'@'.$member->getInstance();
 		try {
 			$federatedUser =
 				$this->federatedUserService->getFederatedUser($federatedId, $member->getUserType());
 		} catch (MemberNotFoundException $e) {
 			throw new MemberNotFoundException(
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s not found',
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s not found',
+				['member' => $member->getUserId().'@'.$member->getInstance()]
 			);
 		}
 		$member->importFromIFederatedUser($federatedUser);
@@ -176,8 +176,8 @@ 
 			$knownMember = $this->memberRequest->searchMember($member);
 			// TODO: maybe member is requesting access
 			throw new MemberAlreadyExistsException(
-				ucfirst(Member::$DEF_TYPE[$member->getUserType()]) . ' %s is already a member',
-				['member' => $member->getUserId() . '@' . $member->getInstance()]
+				ucfirst(Member::$DEF_TYPE[$member->getUserType()]).' %s is already a member',
+				['member' => $member->getUserId().'@'.$member->getInstance()]
 			);
 		} catch (MemberNotFoundException $e) {
 		}
@@ -490,7 +490,7 @@ 
 			$this->sendMailExistingShares($template, $author, $recipient);
 			$this->sendPasswordExistingShares($author, $recipient, $password);
 		} catch (Exception $e) {
-			$this->miscService->log('Failed to send mail about existing share ' . $e->getMessage());
+			$this->miscService->log('Failed to send mail about existing share '.$e->getMessage());
 		}
 	}
 
@@ -642,7 +642,7 @@ 
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
 
-		$this->miscService->log("Sending password mail about existing files to '" . $email . "'", 0);
+		$this->miscService->log("Sending password mail about existing files to '".$email."'", 0);
 
 		$plainBodyPart = $this->l10n->t(
 			"%1\$s shared multiple files with you.\nYou should have already received a separate mail with a link to access them.\n",
@@ -684,7 +684,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($authorEmail !== null) {
 			$message->setReplyTo([$authorEmail => $authorName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}

lib/Command/MembersList.php

Spacing +12 added lines, -12 removed lines

@@ -164,14 +164,14 @@ 
 		if ($input->getOption('tree')) {
 			$this->federatedUserService->commandLineInitiator($initiator, $circleId, true);
 			$circle = $this->circleService->getCircle($circleId);
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
+			$output->writeln('<info>Name</info>: '.$circle->getName());
 			$owner = $circle->getOwner();
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
 			$type =
 				implode(
 					", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG)
 				);
-			$output->writeln('<info>Config</info>: ' . $type);
+			$output->writeln('<info>Config</info>: '.$type);
 			$output->writeln(' ');
 
 			$tree = new NC21TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -193,7 +193,7 @@ 
 		}
 
 		if ($input->getOption('json')) {
-			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";
+			echo json_encode($members, JSON_PRETTY_PRINT)."\n";
 
 			return 0;
 		}
@@ -344,32 +344,32 @@ 
 				$member = $data->gObj('member', Member::class);
 
 				if ($lineNumber === 1) {
-					$line .= '<info>' . $member->getUserId() . '</info>';
+					$line .= '<info>'.$member->getUserId().'</info>';
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
-						$line .= '@' . $member->getInstance();
+						$line .= '@'.$member->getInstance();
 					}
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
 
 					if (!is_null($circle)) {
-						$line .= ' <info>Name</info>: ' . $circle->getName();
+						$line .= ' <info>Name</info>: '.$circle->getName();
 					}
 				}
 
 				if ($lineNumber === 2 && !is_null($circle)) {
 					$owner = $circle->getOwner();
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
 					$type =
 						implode(
 							", ", $this->modelManager->getCircleTypes($circle, ModelManager::TYPES_LONG)
 						);
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
 				}
 
 			} else {
 				if ($lineNumber === 1 && !is_null($circle)) {
-					$line .= '<info>' . $circle->getId() . '</info>';
+					$line .= '<info>'.$circle->getId().'</info>';
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
-						$line .= '@' . $circle->getInstance();
+						$line .= '@'.$circle->getInstance();
 					}
 				}
 			}

lib/Db/CoreRequestBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 
 
 	/**
-	 * @param array $ids
+	 * @param string[] $ids
 	 *
 	 * @throws InvalidIdException
 	 */

lib/Service/MembershipService.php

Doc Comments +4 added lines, -4 removed lines

@@ -173,8 +173,8 @@ 
 
 
 	/**
-	 * @param array $memberships
-	 * @param array $known
+	 * @param Membership[] $memberships
+	 * @param Membership[] $known
 	 *
 	 * @return int
 	 */
@@ -198,8 +198,8 @@ 
 
 
 	/**
-	 * @param array $memberships
-	 * @param array $known
+	 * @param Membership[] $memberships
+	 * @param Membership[] $known
 	 *
 	 * @return int
 	 */