Completed
Pull Request — master (#1845)
by Joas
40s
created
lib/Command/CirclesMemberships.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -192,10 +192,10 @@  discard block
 block discarded – undo
192 192
 		//			return 0;
193 193
 		//		}
194 194
 
195
-		$output->writeln('Id: <info>' . $federatedUser->getUserId() . '</info>');
196
-		$output->writeln('Instance: <info>' . $federatedUser->getInstance() . '</info>');
197
-		$output->writeln('Type: <info>' . Member::$TYPE[$federatedUser->getUserType()] . '</info>');
198
-		$output->writeln('SingleId: <info>' . $federatedUser->getSingleId() . '</info>');
195
+		$output->writeln('Id: <info>'.$federatedUser->getUserId().'</info>');
196
+		$output->writeln('Instance: <info>'.$federatedUser->getInstance().'</info>');
197
+		$output->writeln('Type: <info>'.Member::$TYPE[$federatedUser->getUserType()].'</info>');
198
+		$output->writeln('SingleId: <info>'.$federatedUser->getSingleId().'</info>');
199 199
 
200 200
 		$output->writeln('');
201 201
 		$output->writeln('Memberships:');
@@ -204,14 +204,14 @@  discard block
 block discarded – undo
204 204
 		if ($count === 0) {
205 205
 			$output->writeln('(database not updated)');
206 206
 		} else {
207
-			$output->writeln('(' . $count . ' entries generated/updated in the database)');
207
+			$output->writeln('('.$count.' entries generated/updated in the database)');
208 208
 		}
209 209
 
210 210
 		foreach ($federatedUser->getMemberships() as $membership) {
211 211
 			$this->memberships[$membership->getCircleId()] = $membership;
212 212
 			$output->writeln(
213
-				'- <info>' . $membership->getCircleId() . '</info> ('
214
-				. Member::$DEF_LEVEL[$membership->getLevel()] . ')'
213
+				'- <info>'.$membership->getCircleId().'</info> ('
214
+				. Member::$DEF_LEVEL[$membership->getLevel()].')'
215 215
 			);
216 216
 		}
217 217
 
@@ -285,9 +285,9 @@  discard block
 block discarded – undo
285 285
 				if ($lineNumber === 2) {
286 286
 					return '';
287 287
 				}
288
-				$line .= '<info>' . $federatedUser->getSingleId() . '</info>';
288
+				$line .= '<info>'.$federatedUser->getSingleId().'</info>';
289 289
 				if (!$this->configService->isLocalInstance($federatedUser->getInstance())) {
290
-					$line .= '@' . $federatedUser->getInstance();
290
+					$line .= '@'.$federatedUser->getInstance();
291 291
 				}
292 292
 
293 293
 				return $line;
@@ -299,33 +299,33 @@  discard block
 block discarded – undo
299 299
 				$circle = $member->getCircle();
300 300
 
301 301
 				if ($lineNumber === 1) {
302
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
302
+					$line .= '<info>'.$circle->getSingleId().'</info>';
303 303
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
304
-						$line .= '@' . $circle->getInstance();
304
+						$line .= '@'.$circle->getInstance();
305 305
 					}
306
-					$line .= ' (' . ($this->input->getOption('display-name') ?
307
-							$circle->getDisplayName() : $circle->getName()) . ')';
308
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
309
-					$line .= ' <info>Level</info>: ' . Member::$DEF_LEVEL[$member->getLevel()];
306
+					$line .= ' ('.($this->input->getOption('display-name') ?
307
+							$circle->getDisplayName() : $circle->getName()).')';
308
+					$line .= ' <info>MemberId</info>: '.$member->getId();
309
+					$line .= ' <info>Level</info>: '.Member::$DEF_LEVEL[$member->getLevel()];
310 310
 
311 311
 					$knownMembership = $this->memberships[$member->getCircleId()];
312 312
 					if ($member->getLevel() !== $knownMembership->getLevel()) {
313
-						$line .= ' (' . Member::$DEF_LEVEL[$knownMembership->getLevel()] . ')';
313
+						$line .= ' ('.Member::$DEF_LEVEL[$knownMembership->getLevel()].')';
314 314
 					}
315 315
 				}
316 316
 				if ($lineNumber === 2) {
317 317
 					$owner = $circle->getOwner();
318
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance() . ' ';
318
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance().' ';
319 319
 					if ($owner->hasBasedOn()) {
320
-						$line .= '(' . Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()] . ') ';
320
+						$line .= '('.Circle::$DEF_SOURCE[$owner->getBasedOn()->getSource()].') ';
321 321
 					}
322 322
 					$type = implode(', ', Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
323
-					$line .= ($type === '') ? '' : '<info>Config</info>: ' . $type;
323
+					$line .= ($type === '') ? '' : '<info>Config</info>: '.$type;
324 324
 				}
325 325
 
326 326
 				return $line;
327 327
 			}
328
-		} catch (InvalidItemException|ItemNotFoundException|UnknownTypeException $e) {
328
+		} catch (InvalidItemException | ItemNotFoundException | UnknownTypeException $e) {
329 329
 		}
330 330
 
331 331
 		return '';
@@ -379,6 +379,6 @@  discard block
 block discarded – undo
379 379
 			);
380 380
 		}
381 381
 
382
-		$output->writeln($count . ' memberships updated');
382
+		$output->writeln($count.' memberships updated');
383 383
 	}
384 384
 }
Please login to merge, or discard this patch.
lib/Service/FederatedUserService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 		if ($check) {
509 509
 			$user = $this->userManager->get($userId);
510 510
 			if ($user === null) {
511
-				throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
511
+				throw new FederatedUserNotFoundException('user '.$userId.' not found');
512 512
 			}
513 513
 			$displayName = $this->userManager->getDisplayName($userId);
514 514
 		} else {
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
 			$prefix = ($federatedUser->getUserType() === Member::TYPE_APP) ? 'app'
1024 1024
 				: Member::$TYPE[$federatedUser->getUserType()];
1025 1025
 
1026
-			$circle->setName($prefix . ':' . $federatedUser->getUserId() . ':' . $id)
1026
+			$circle->setName($prefix.':'.$federatedUser->getUserId().':'.$id)
1027 1027
 				->setDisplayName($federatedUser->getDisplayName())
1028 1028
 				->setSingleId($id)
1029 1029
 				->setSource($source);
@@ -1227,7 +1227,7 @@  discard block
 block discarded – undo
1227 1227
 		$owner = $this->getCurrentApp();
1228 1228
 
1229 1229
 		$circle = new Circle();
1230
-		$circle->setName('group:' . $groupId)
1230
+		$circle->setName('group:'.$groupId)
1231 1231
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
1232 1232
 			->setSingleId($this->token(ManagedModel::ID_LENGTH))
1233 1233
 			->setSource(Member::TYPE_GROUP);
@@ -1295,8 +1295,8 @@  discard block
 block discarded – undo
1295 1295
 	 * @return string
1296 1296
 	 */
1297 1297
 	private function generateCacheKey(FederatedUser $federatedUser): string {
1298
-		return $federatedUser->getInstance() . '#'
1299
-			   . $federatedUser->getUserType() . '#'
1298
+		return $federatedUser->getInstance().'#'
1299
+			   . $federatedUser->getUserType().'#'
1300 1300
 			   . $federatedUser->getUserId();
1301 1301
 	}
1302 1302
 }
Please login to merge, or discard this patch.
lib/Service/RemoteStreamService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 			//		$app->setAlgorithm(NCSignatory::SHA512);
267 267
 			$signedRequest = $this->signOutgoingRequest($request, $app);
268 268
 			$this->doRequest($signedRequest->getOutgoingRequest(), false);
269
-		} catch (RequestNetworkException|SignatoryException $e) {
269
+		} catch (RequestNetworkException | SignatoryException $e) {
270 270
 			throw new RemoteInstanceException($e->getMessage());
271 271
 		}
272 272
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
 	public function getCachedRemoteInstance(string $instance): RemoteInstance {
311 311
 		$remoteInstance = $this->remoteRequest->getFromInstance($instance);
312 312
 		if ($remoteInstance->getType() === RemoteInstance::TYPE_UNKNOWN) {
313
-			throw new UnknownRemoteException($instance . ' is set as \'unknown\' in database');
313
+			throw new UnknownRemoteException($instance.' is set as \'unknown\' in database');
314 314
 		}
315 315
 
316 316
 		return $remoteInstance;
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
499 499
 			$test = new ReflectionClass($class);
500 500
 			$this->confirmFederatedItemExceptionFromClass($test);
501 501
 			$e = $class;
502
-		} catch (ReflectionException|FederatedItemException $_e) {
502
+		} catch (ReflectionException | FederatedItemException $_e) {
503 503
 			$e = $this->getFederatedItemExceptionFromStatus($result->getStatusCode());
504 504
 		}
505 505
 
@@ -553,7 +553,7 @@  discard block
 block discarded – undo
553 553
 	 * @throws RemoteNotFoundException
554 554
 	 * @throws RemoteUidException
555 555
 	 */
556
-	public function confirmValidRemote(RemoteInstance $remote, ?RemoteInstance &$stored = null): void {
556
+	public function confirmValidRemote(RemoteInstance $remote, ?RemoteInstance & $stored = null): void {
557 557
 		try {
558 558
 			$stored = $this->remoteRequest->getFromHref($remote->getId());
559 559
 		} catch (RemoteNotFoundException $e) {
Please login to merge, or discard this patch.
lib/Service/ShareWrapperService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -324,8 +324,8 @@
 block discarded – undo
324 324
 		int $nodeId,
325 325
 		string $probeSum,
326 326
 	): string {
327
-		return $federatedUser->getSingleId() . '#'
328
-			   . $nodeId . '#'
327
+		return $federatedUser->getSingleId().'#'
328
+			   . $nodeId.'#'
329 329
 			   . $probeSum;
330 330
 	}
331 331
 }
Please login to merge, or discard this patch.
lib/Service/MembershipService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
 		try {
93 93
 			$this->circleRequest->getFederatedUserBySingleId($singleId);
94
-		} catch (FederatedUserNotFoundException|OwnerNotFoundException $e) {
94
+		} catch (FederatedUserNotFoundException | OwnerNotFoundException $e) {
95 95
 			$this->membershipRequest->removeBySingleId($singleId);
96 96
 		}
97 97
 
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 	 */
243 243
 	private function getChildrenMembers(string $id, array &$knownIds = []): array {
244 244
 		$singleIds = array_map(
245
-			function (Member $item): string {
245
+			function(Member $item): string {
246 246
 				return $item->getSingleId();
247 247
 			}, $this->memberRequest->getMembers($id)
248 248
 		);
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 */
267 267
 	private function getChildrenMemberships(string $id, array &$knownIds = []): array {
268 268
 		$singleIds = array_map(
269
-			function (Membership $item): string {
269
+			function(Membership $item): string {
270 270
 				return $item->getSingleId();
271 271
 			}, $this->membershipRequest->getInherited($id)
272 272
 		);
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
 	 */
321 321
 	private function removeDeprecatedMemberships(array $memberships, array $known): array {
322 322
 		$circleIds = array_map(
323
-			function (Membership $membership): string {
323
+			function(Membership $membership): string {
324 324
 				return $membership->getCircleId();
325 325
 			}, $memberships
326 326
 		);
Please login to merge, or discard this patch.
lib/Service/SyncService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 	 * @throws SingleCircleNotFoundException
227 227
 	 */
228 228
 	public function syncNextcloudUser(string $userId): FederatedUser {
229
-		$this->outputService->output('Syncing Nextcloud Account \'' . $userId . '\'', true);
229
+		$this->outputService->output('Syncing Nextcloud Account \''.$userId.'\'', true);
230 230
 
231 231
 		return $this->federatedUserService->getLocalFederatedUser($userId, false, true);
232 232
 	}
@@ -270,10 +270,10 @@  discard block
 block discarded – undo
270 270
 	 * @throws RequestBuilderException
271 271
 	 */
272 272
 	public function syncNextcloudGroup(string $groupId): Circle {
273
-		$this->outputService->output('Syncing Nextcloud Group \'' . $groupId . '\'', true);
273
+		$this->outputService->output('Syncing Nextcloud Group \''.$groupId.'\'', true);
274 274
 
275 275
 		$circle = $this->federatedUserService->getGroupCircle($groupId);
276
-		$members = array_map(function (Member $member): string {
276
+		$members = array_map(function(Member $member): string {
277 277
 			return $member->getSingleId();
278 278
 		}, $this->memberRequest->getMembers($circle->getSingleId()));
279 279
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 	 */
352 352
 	public function groupDeleted(string $groupId): void {
353 353
 		$circle = new Circle();
354
-		$circle->setName('group:' . $groupId)
354
+		$circle->setName('group:'.$groupId)
355 355
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
356 356
 			->setSource(Member::TYPE_GROUP);
357 357
 
Please login to merge, or discard this patch.
lib/Controller/RemoteController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -449,21 +449,21 @@
 block discarded – undo
449 449
 			/** @var FederatedUser $initiator */
450 450
 			$initiator = $store->gObj('initiator', FederatedUser::class);
451 451
 			$this->federatedUserService->setCurrentUser($initiator);
452
-		} catch (InvalidItemException|ItemNotFoundException $e) {
452
+		} catch (InvalidItemException | ItemNotFoundException $e) {
453 453
 		}
454 454
 
455 455
 		try {
456 456
 			/** @var FederatedUser $initiator */
457 457
 			$filterMember = $store->gObj('filterMember', Member::class);
458 458
 			$data->aObj('filterMember', $filterMember);
459
-		} catch (InvalidItemException|ItemNotFoundException $e) {
459
+		} catch (InvalidItemException | ItemNotFoundException $e) {
460 460
 		}
461 461
 
462 462
 		try {
463 463
 			/** @var FederatedUser $initiator */
464 464
 			$filterCircle = $store->gObj('filterCircle', Circle::class);
465 465
 			$data->aObj('filterCircle', $filterCircle);
466
-		} catch (InvalidItemException|ItemNotFoundException $e) {
466
+		} catch (InvalidItemException | ItemNotFoundException $e) {
467 467
 		}
468 468
 
469 469
 		return $data;
Please login to merge, or discard this patch.
lib/Db/MemberRequestBuilder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 			self::$tables[self::TABLE_MEMBER],
65 65
 			CoreQueryBuilder::MEMBER
66 66
 		)
67
-			->orderBy(CoreQueryBuilder::MEMBER . '.joined');
67
+			->orderBy(CoreQueryBuilder::MEMBER.'.joined');
68 68
 
69 69
 		if ($getBasedOn) {
70 70
 			$qb->leftJoinBasedOn(CoreQueryBuilder::MEMBER, $initiator);
Please login to merge, or discard this patch.
lib/Db/DeprecatedRequestBuilder.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -344,8 +344,8 @@  discard block
 block discarded – undo
344 344
 		$expr = $qb->expr();
345 345
 
346 346
 		if ($pf === '') {
347
-			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
348
-			$qb->andWhere($expr->gte($p . 'level', $qb->createNamedParameter($level)));
347
+			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
348
+			$qb->andWhere($expr->gte($p.'level', $qb->createNamedParameter($level)));
349 349
 
350 350
 			return;
351 351
 		}
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 			if ($p === 'g' && !$this->leftJoinedNCGroupAndUser) {
375 375
 				continue;
376 376
 			}
377
-			$orX->add($expr->gte($p . '.level', $qb->createNamedParameter($level)));
377
+			$orX->add($expr->gte($p.'.level', $qb->createNamedParameter($level)));
378 378
 		}
379 379
 
380 380
 		return $orX;
@@ -389,12 +389,12 @@  discard block
 block discarded – undo
389 389
 	protected function limitToMembersAndAlmost(IQueryBuilder $qb) {
390 390
 		$expr = $qb->expr();
391 391
 
392
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
392
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
393 393
 
394 394
 		$orX = $expr->orX();
395
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(DeprecatedMember::STATUS_MEMBER)));
396
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(DeprecatedMember::STATUS_INVITED)));
397
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(DeprecatedMember::STATUS_REQUEST)));
395
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(DeprecatedMember::STATUS_MEMBER)));
396
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(DeprecatedMember::STATUS_INVITED)));
397
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(DeprecatedMember::STATUS_REQUEST)));
398 398
 
399 399
 		$qb->andWhere($orX);
400 400
 	}
@@ -407,8 +407,8 @@  discard block
 block discarded – undo
407 407
 	 */
408 408
 	public function limitToDBField(IQueryBuilder $qb, $field, $value) {
409 409
 		$expr = $qb->expr();
410
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
411
-		$qb->andWhere($expr->eq($pf . $field, $qb->createNamedParameter($value)));
410
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
411
+		$qb->andWhere($expr->eq($pf.$field, $qb->createNamedParameter($value)));
412 412
 	}
413 413
 
414 414
 
@@ -419,8 +419,8 @@  discard block
 block discarded – undo
419 419
 	 */
420 420
 	private function limitToDBFieldOrGreater(IQueryBuilder $qb, $field, $value) {
421 421
 		$expr = $qb->expr();
422
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
423
-		$qb->andWhere($expr->gte($pf . $field, $qb->createNamedParameter($value)));
422
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
423
+		$qb->andWhere($expr->gte($pf.$field, $qb->createNamedParameter($value)));
424 424
 	}
425 425
 
426 426
 
@@ -435,9 +435,9 @@  discard block
 block discarded – undo
435 435
 	protected function limitToNCGroupUser(IQueryBuilder $qb, $userId = '') {
436 436
 		$expr = $qb->expr();
437 437
 
438
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
438
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
439 439
 
440
-		$and = $expr->andX($expr->eq($pf . 'user_id', 'ncgu.gid'));
440
+		$and = $expr->andX($expr->eq($pf.'user_id', 'ncgu.gid'));
441 441
 		if ($userId !== '') {
442 442
 			$and->add($expr->eq('ncgu.uid', $qb->createNamedParameter($userId)));
443 443
 		} else {
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 		}
461 461
 
462 462
 		$expr = $qb->expr();
463
-		$pf = $this->default_select_alias . '.';
463
+		$pf = $this->default_select_alias.'.';
464 464
 
465 465
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
466 466
 		$qb->selectAlias('lc.type', 'circle_type')
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
 			->selectAlias('lc.settings', 'circle_settings')
470 470
 			->leftJoin(
471 471
 				$this->default_select_alias, DeprecatedRequestBuilder::TABLE_CIRCLES, 'lc',
472
-				$expr->eq($pf . 'circle_id', 'lc.unique_id')
472
+				$expr->eq($pf.'circle_id', 'lc.unique_id')
473 473
 			);
474 474
 	}
475 475
 
Please login to merge, or discard this patch.